Add unit test for Scilab backend
ClosedPublic

Authored by shubham on Sun, Mar 22, 5:31 PM.

Details

Summary

Added unit test for Scilab backend.

Test Plan

ctest passes!

Diff Detail

Repository
R55 Cantor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
shubham created this revision.Sun, Mar 22, 5:31 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptSun, Mar 22, 5:31 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
shubham requested review of this revision.Sun, Mar 22, 5:31 PM
asemke added inline comments.Sun, Mar 22, 5:38 PM
src/backends/scilab/testscilab.cpp
25

where do you need this header file?

29

shouldn't be required here.

40

the usage of spaces is not consistent in Cantor's code. For new code we try to be more consistent and use spaces around operators. We don't use spaces next to the bracket. So, it should be

QVERIFY(e != nullptr);
shubham updated this revision to Diff 78243.Sun, Mar 22, 5:53 PM

Fix coding style

shubham updated this revision to Diff 78244.Sun, Mar 22, 6:21 PM
shubham marked an inline comment as done.

Add plot test

shubham marked 2 inline comments as done.Sun, Mar 22, 6:21 PM
shubham edited the test plan for this revision. (Show Details)
shubham updated this revision to Diff 78245.Sun, Mar 22, 6:26 PM

Remove unnecessary headers

shubham updated this revision to Diff 78247.Sun, Mar 22, 6:43 PM

Fix coding style

asemke accepted this revision.Sun, Mar 22, 6:44 PM
This revision is now accepted and ready to land.Sun, Mar 22, 6:44 PM
This revision was automatically updated to reflect the committed changes.