Add context menu entry to copy link text
Needs RevisionPublic

Authored by shubham on Feb 14 2019, 4:36 PM.

Details

Reviewers
drosca
ngraham
Summary

BUG: 388513

Diff Detail

Repository
R875 Falkon
Branch
link
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8297
Build 8315: arc lint + arc unit
shubham created this revision.Feb 14 2019, 4:36 PM
Restricted Application added a project: Falkon. · View Herald TranscriptFeb 14 2019, 4:36 PM
Restricted Application added a subscriber: falkon. · View Herald Transcript
shubham requested review of this revision.Feb 14 2019, 4:36 PM
drosca requested changes to this revision.Feb 15 2019, 2:12 PM

As with similar actions, this should be in plugin (preferably only script) and not in main code.

This revision now requires changes to proceed.Feb 15 2019, 2:12 PM

I did not get what you meant, can you please explain a bit?

I meant that I don't want this feature. Context menu on page is already very long, and if it contained every action that someone requested on bugzilla, it would not even fit on screen.

So, as with other similar features, I always say that it should go into plugin. It is now also possible to create script plugins (instead of C++ libraries), which is preferred for adding functionality such as this patch.

I meant that I don't want this feature. Context menu on page is already very long, and if it contained every action that someone requested on bugzilla, it would not even fit on screen.

So, as with other similar features, I always say that it should go into plugin. It is now also possible to create script plugins (instead of C++ libraries), which is preferred for adding functionality such as this patch.

Thanks for your comments, but what I really meant to ask was what is a plug in and how do I add this into that?

Take a look in src/plugins src/scripts

shubham added a comment.EditedFeb 25 2019, 1:45 AM

@drosca I had a look at those and found some python files doing something, still, I can't figure out what I have to do. Can you help a bit?

Is it required ?
Can't you just use <Win/Super>+<Alt> to select the text of the link ?

@drosca I had a look at those and found some python files doing something, still, I can't figure out what I have to do. Can you help a bit?

Any kind of help?