Add XSettingsd find module

In D27380#618545, @IlyaBizyaev wrote:

In D27380#618531, @ngraham wrote:

The problem being solved here is that starting with 5.18, style names were being localized, which GTK doesn't understand, causing it to fall back to the default font. This patch fixes that.

I see :)
I just thought maybe the pre-existing solution from the deleted KCM could be reused since it seemed to work well.

I have just tested a couple of fonts.

1. I've only tested Monospaced font with Russian locale, so I do not know it other ones work. Qt just ignores style string and any style of Monospaced is just Monospaced, 10 in the config.
2. Seems like GTK2 works fine with fonts and most of them works (Ubuntu Light for example).
3. GTK3 however have troubles with font styles and ignores what is after a comma. So that may be a GTK3 bug.

In D27380#617927, @ngraham wrote:

All fonts tested. :(

In D27380#617774, @ngraham wrote:

Thanks.

So if I set the general font to 9pt Ubuntu Italic, then in the config file I see gtk-font-name=Ubuntu, Italic 9 and Thunderbird respects the font, and the size, but not the style; it's not italic. :(

Or is that a separate issue?

In D27380#617677, @ngraham wrote:

Do you need to reload any daemon to get this to work?

Ping

Code style changes

Use big helper function for constructing font style. Please test, many fonts may break and not work.

Since we plan to move more GTK related code to kde-gtk-config repo (specifically coloration of GTK apps from krdb), isn't it more reasonable to put this module in kde-gtk-config repo?

In D27380#611204, @davidedmundson wrote:

Take this code

In D27380#611150, @ngraham wrote:

So maybe that's something we can fix in the Fonts KCM? Or Is it caused by the Qt bug ultimately causing https://bugs.kde.org/show_bug.cgi?id=378523?

In D27380#611132, @ngraham wrote:

Is the problem that the style name is already localized by the time we get it from the Fonts KCM?

Fair point.

Remove "Appearance" part, since settings applied by kded module is not only about appearance (e.g. scrollbar behavior)

Capitalize GNOME and remove KDE/Qt part

Rename files to provide ground for more kconf scripts in the future

Rollback the reparsings that are actually needed

In D27107#604878, @davidedmundson wrote:

You need to be careful here.

Some of this code is re-evaluated on receipt of other direct DBus signals. Not from kconfigwatcher.

In those cases, you will have to reparse.

The differences between gtkrc and gtkrc-2.0 at least is that the first one was used for GTK1 and the second for GTK2.

Rebase on master

In D26891#601329, @fvogt wrote:

Tested, confirmed to work.

I wonder what's up with the gtkrc files everywhere:

~/.config/gtkrc-2.0
~/.config/gtkrc
~/.gtkrc-2.0
./.config/gtk-3.0

It seems like the first two are created by krdb, does it read both still?

@meven wrote:

What if users have a different default theme set on first launch? I would suggest to read the current theme instead of hardcoding Breeze.

In D26928#601009, @davidedmundson wrote:

Can't style names have a space too?

Remove redundant theme update on startup

Provide kconf_script to upgrade themes from old ones. It is mostly the same as the one in breeze-gtk repo, but better.

@fvogt Do I understand correctly, that kconf_update script also run on Plasma update, if I add a new Id to one of .upd file (or add one with new Id)? For example from 5.17 to 5.18?

In D26891#600210, @fvogt wrote:

It should only do the migration once, like the kconf_update script.

In D26891#600210, @fvogt wrote:

If this is adjusted to include the migration code for older breeze-like GTK themes from https://cgit.kde.org/breeze-gtk.git/tree/kconf_update/main.cpp?id=b00e12ff39264fd8c2fb8af4168e998726766dfa, it should be possible to drop the kconf_update script there.
It might even cause conflicts otherwise.

This also should be changed in GTK Subpage in Application Style KCM (D26717)

Some typos, without them everything is OK.

Also i found out, that gtk apps on start throw this error:

(org.gnome.Nautilus:4278): Gdk-WARNING **: 21:08:58.246: Cannot transform xsetting gtk-enable-animations of type gchararray to type gboolean

This is because of xsettingd config. You need to add Gtk/EnableAnimations to exceptions in QStringList nonStringProperties var in replaceValueInXSettingsdContents method, but it's only a hotfix. It is better to do some parameterezing with QVariants or C++ templates for ConfigEditor functions.

Seems like dconf does not convert string to boolean.

(process:24285): GLib-GIO-CRITICAL **: 17:51:47.492: g_settings_set_value: key 'enable-animations' in 'org.gnome.desktop.interface' expects type 'b', but a GVariant of type 's' was given

In D26777#597167, @apol wrote:

Why don't you just export the interface you are using through qdbusxml2cpp and viceversa? This way you don't need to have the glue code.

Port dialogs to QtQuick

Ok, then.

In D26717#595664, @ngraham wrote:

Even better would be if we can use the new QML dialogs too. See D26544

In T10611#217854, @ngraham wrote:

window decoration button orders

Return accidentally removed empty lines in kcmstyle.h

Remove columnCount method and fix rowCount method