Switch to the old-style button text for the KNSQuick buttons
ClosedPublic

Authored by leinir on Fri, Jan 24, 10:43 AM.

Details

Summary

This fixes a series of localization issues as reported in
https://bugs.kde.org/show_bug.cgi?id=415541 based on the
minimum-impact method (hopefully these strings should even
still be in the pot files...)

BUG:415541

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
leinir created this revision.Fri, Jan 24, 10:43 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFri, Jan 24, 10:43 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
leinir requested review of this revision.Fri, Jan 24, 10:43 AM
gikari added a subscriber: gikari.Fri, Jan 24, 10:50 AM

This also should be changed in GTK Subpage in Application Style KCM (D26717)

davidedmundson accepted this revision.Fri, Jan 24, 11:02 AM

Which branch?

I don't have a strong opinion, that's something that needs @kde-i18n-doc to decide

This revision is now accepted and ready to land.Fri, Jan 24, 11:02 AM

No objections for porting into the stable branch from the Ukrainian team.

aacid added a subscriber: aacid.Sat, Jan 25, 12:23 AM

stable branch please :)

stable branch please :)

Ah! Missed this somehow - landing on the 5.18 branch momentarily! :)

This revision was automatically updated to reflect the committed changes.
victorr added a subscriber: victorr.EditedThu, Jan 30, 1:22 AM

This is probably a typo?
Now there are "Icons".

  • downloadNewWhat: i18n("Splash Screens")

+ text: i18n("Get New Icons...")

kcms/ksplash/package/contents/ui/main.qml

Please add this patch as well.

. downloadNewWhat: i18n("Wallpapers")
+ text: i18nd("plasma_wallpaper_org.kde.image","Get New Wallpapers...")

The window title is left with double text.
Image taken without a network connection,
therefore there are no thumbnails.