[App Style KCM] Port away from QDBusInterface
Needs ReviewPublic

Authored by gikari on Jan 19 2020, 11:07 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

Giving that the QDBusInterface introspects the DBus interface blockingly in its constructor.

Diff Detail

Repository
R119 Plasma Desktop
Branch
app-style-gtk-port-from-qdbus-interface
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21367
Build 21385: arc lint + arc unit
gikari created this revision.Jan 19 2020, 11:07 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 19 2020, 11:07 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gikari requested review of this revision.Jan 19 2020, 11:07 PM
apol added a subscriber: apol.Jan 19 2020, 11:40 PM

Why don't you just export the interface you are using through qdbusxml2cpp and viceversa? This way you don't need to have the glue code.

In D26777#597167, @apol wrote:

Why don't you just export the interface you are using through qdbusxml2cpp and viceversa? This way you don't need to have the glue code.

  1. This introduces build-time dependency on kde-gtk-config, which should be avoided (because it is also a dependency on GTK).
  2. The *Interface classes here are very similar to what qdbusxml2cpp generates, except that here they are extracting the value of reply (reply.value()), hiding the QDBus implementation details, and that they make synchronous calls where it is needed.

Ping! Do I sound reasonable? Any suggestions how can it be simplified without depending on kde-gtk-config?