Differential D27090

Replace config.h with target_compile_definitions
AbandonedPublic
Actions

Authored by gikari on Feb 1 2020, 5:16 PM.

Details

Reviewers
None
Summary

One line in CMakeLists.txt is simpler, than the whole generated file.

Test Plan

Relaunch kded5, open GTK Settings in Application style KCM and check if the previews are working.

Diff Detail

Repository
R99 KDE Gtk Configuration Tool
Branch
configh-to-compile-def
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21950
Build 21968: arc lint + arc unit
gikari created this revision.Feb 1 2020, 5:16 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 1 2020, 5:16 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gikari requested review of this revision.Feb 1 2020, 5:16 PM
apol added a subscriber: apol.Feb 3 2020, 5:15 PM

I wouldn't say it's simpler. If anything it's easier to inspect the value that is being passed from your editor.

gikari abandoned this revision.Feb 12 2020, 7:00 PM

Fair point.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)
DMconfig.h.cmake (1 line)
Mkded/CMakeLists.txt (5 lines)
Mkded/themepreviewer.cpp (5 lines)

Diff 74840

View Options

CMakeLists.txt

Loading...
View Options

config.h.cmake

Loading...
View Options

kded/CMakeLists.txt

Loading...
View Options

kded/themepreviewer.cpp

Loading...