[App Style KCM] Hide preview buttons, if previewers are not found
ClosedPublic

Authored by gikari on Jan 19 2020, 5:15 PM.

Details

Summary

BUG: 416343
FIXED-IN: 5.18.0

Test Plan
  1. Open GTK page of Application Style KCM, the preview buttons should be present
  2. Delete usr/lib/libexec/gtk_preview file or rename it to something else
  3. Reopen GTK page of KCM - the GTK2 preview button should disappear
  4. Delete usr/lib/libexec/gtk3_preview file or rename it to something else
  5. Reopen GTK page of KCM - the GTK3 preview button should disappear too
  6. Bring back the deleted/renamed files
  7. Reopen KCM, the buttons should be present

Example view:

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gikari created this revision.Jan 19 2020, 5:15 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 19 2020, 5:15 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gikari requested review of this revision.Jan 19 2020, 5:15 PM
gikari edited the test plan for this revision. (Show Details)Jan 19 2020, 5:17 PM
ngraham accepted this revision.Mon, Jan 20, 3:51 PM
ngraham added a subscriber: ngraham.

LGTM.

This revision is now accepted and ready to land.Mon, Jan 20, 3:51 PM
mart accepted this revision.Wed, Jan 22, 9:55 AM
This revision was automatically updated to reflect the committed changes.