• Activate orientation sensor only when used
• Query new libkscreen auto rotation and tablet mode API

Good find. Can subSurfaceTreeRect be recomputed in a less common call, not in the clientSize getter? For example when attached buffer size changes.

I move forward with this approach and revisit later to work on a better solution. Maybe with the libkscreen dbus process.

Good thing to tackle this. The separate kwayland-integration plugin always felt weird to me. I currently don't have an overview on KWindowSystem so I can't really comment on your analysis and proposed split but if you think it should be done like that let's move forward with it. What are the next steps?

In D24281#581188, @ngraham wrote:

I know it's the holiday season and we're all short on KDE time, but it rubs me the wrong way to revert a change pending further discussion only to then abandon the discussion. I feel that all the arguments against the Meta+Control+Arrow shortcuts have been refuted over and over again, and no alternative has been proposed that's considered superior.

I propose moving forward with this patch in its current form if no new arguments emerge by December 28th.

Hans' recent XWayland merge request: https://gitlab.freedesktop.org/xorg/xserver/merge_requests/270

Important for Hans' recent work on XWayland: https://gitlab.freedesktop.org/xorg/xserver/merge_requests/270

In D14949#580117, @alexde wrote:

Additional there could be a radiobutton

• Display none in full screen apps

Kai said that he wants to wait on @ervin's opinion since this patch would change the button order and maybe there is a way to solve the issue without doing that.

Fastest bug-to-fix process this year?

In D25921#579478, @apol wrote:

Just tested it, works okay.

Now the pen is broken. 😅

@ognarb: this was just pointed out by @hpereiradacosta as well. But you both are right that this is a technical issue one has to take into account. But I don't think it is much more than that. Still it complicates using such "letter-patterns" of course.

Looks good to me. Maybe someone besides me who worked more recently on the KCM wants to give his ok as well. If nothing comes in till tomorrow, push. Thanks.

In D26031#579232, @davidedmundson wrote:

Why do we need to compare names as well as ID?

With direct-apply having a revert window/overlay/inline message only shown when certain critical options were changed could be a good compromise. Though I would still like to see direct-apply land first in this case and then we can look into when and how the revert functionality should hook into.

In D25539#579054, @ngraham wrote:

I'm torn. In principle I agree that this is a great improvement to help people avoid blowing themselves up while testing settings. However I'm not convinced that the patch's current form strikes the right balance between achieving that goal and not annoying the user by reverting their intended changes when not needed.

In general I love InlineMeessages but I don't know if they're the right UI element here because they aren't modal. For this warning here I think we want a modal dialog because then the user can't miss it and get their settings reverted accidentally, which is possible with non-modal InlineMessages.

In D24281#578623, @thiagosueto wrote:

Sorry for being late to respond.
My two main concerns are whether the modifier keys are suitable *and* that we stay consistent on them.
What we have seen so far:

In general, apps don't use the Meta key for their shortcuts, while the shell does.

I verified that the first part of this is not true. Other DEs and distro implementations such as Xubuntu use the rule Meta+(first letter of application functionality).

Looks great!

In D25539#578624, @liushuyu wrote:

Any other suggestions for this patch?

Integrate into daemon.

Make sure we only set the file watcher once and connect output control file changes to config control file changes.