Differential D26175

[plasmashell] Update docs for panelTakesFocus to make it generic
ClosedPublic
Actions

Authored by davidedmundson on Dec 23 2019, 8:32 AM.

Details

Reviewers
romangg
Group Reviewers
KWin
Commits
R127:935e54ce1aad: [plasmashell] Update docs for panelTakesFocus to make it generic
Summary

We want surfaces with a notification role to be able to switch ability
to take focus or not on the fly. The semantics are identical as the
panel
taking focus, we may as well re-use what exists and remove the implicit
limitation than re-invent the wheel and complicate things.

Test Plan

Docs

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Dec 23 2019, 8:32 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 23 2019, 8:32 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Dec 23 2019, 8:32 AM
apol added a subscriber: apol.Dec 23 2019, 2:40 PM
apol added inline comments.
src/server/plasmashell_interface.h
178

How about we rename now and deprecate this one?

romangg accepted this revision.Dec 23 2019, 3:02 PM
romangg added a subscriber: romangg.
romangg added inline comments.
src/server/plasmashell_interface.h
178

Yea, could be better. David should decide on what he prefers. But the renaming should then anyway go into a separate patch.

This revision is now accepted and ready to land.Dec 23 2019, 3:02 PM
Closed by commit R127:935e54ce1aad: [plasmashell] Update docs for panelTakesFocus to make it generic (authored by davidedmundson). · Explain WhyDec 30 2019, 4:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 72398

View Options

src/client/plasmashell.h

Loading...
View Options

src/client/protocols/plasma-shell.xml

Loading...
View Options

src/server/plasmashell_interface.h

Loading...