• Using a bigger font size means less characters could be display.

The song name is always going to be elided, so it doesn't matter.

How about adding a little bit of a margin above the song name (Layout.topMargin 2, same as the left margin)
And why not keep the level of the track name at 4? It's more important than the artist name (subheading)

This is a really good idea. Nothing to lose and tons to gain, especially considering we get to use our existing code
+1

Right-sided elision isn't all that useful considering the filename that's being elided is usually pretty long already. This patch, however, would enable the user to always see the extension (which is a huge deal, especially if we're dealing with something malicious).

Oh one more thing - should we push the entire clock + stack a little bit further down to make it more (or entirely) vertically centered?

Use Math.max instead of OR (works with other distros now)

Sure thing

That commit truly is the gift that keeps on giving

Can you make it use Noto Sans by any chance?

Missed one

Simplify

Make Katie uppercase

Update preview to reflect latest theme version

Make the logout screen work too

Plasma Nano is really cute haha
But I have to say I admire the symmetry of Plasma Ion

Apply theme.conf approach to all modifications

Revert changes to UserDelegate.qml (empty line)

Use fixed font size for SDDM theme but not lock screen

Can confirm. theme.defaultFont.pointSize is indeed 9 pt.

In D19631#427916, @ngraham wrote:

In D19631#427911, @rooty wrote:

In D19631#427905, @ngraham wrote:

I don't think we should use hardcoded font sizes in either place. Maybe what we should do is have both of them use font.pointSize: theme.defaultFont.pointSize + 1 (etc.).

Yes that was the idea in D19547, but we can't because sddm doesn't recognize theme.defaultFont.pointSize.

Hmm, why not? Wouldn't the SDDM user just have its own value for that?

In D19631#427905, @ngraham wrote:

I don't think we should use hardcoded font sizes in either place. Maybe what we should do is have both of them use font.pointSize: theme.defaultFont.pointSize + 1 (etc.).

Rebase if needed

In D19036#427845, @cfeck wrote:

The status of this says 'Accepted', so developers might not check it.

If you want to wait for a developer's review, I suggest to keep the status 'Needs Review'.

Can anyone please help - how do I tell Main.qml to set the integer "nameFontSize" to 12 pt? My knowledge here is very limited and nothing I've tried has worked :/

(WIP) Switch back to the default theme font + 1 (or 2) for the lock screen

What hardcoding font sizes gives us are 2 places in Plasma losing their flexibility and not taking the user's preferences into consideration = SDDM-ing it.

In D19631#427726, @filipf wrote:

There has to be a better solution. We're dragging the quality of Plasma down simply because SDDM isn't on par with it. If there's no other way, hardcoded font sizes should only be present in SDDM.

@davidedmundson thoughts?

A quick google search (mpv, VLC, windows media player, etc.) reveals that the change you're proposing is actually more in keeping with the standard than what we've been using (Spotify/Winamp). So, +1 from me

I know it sounds strange but no value other than undefined causes the D19577 error... we could technically put "red" there because there's no outline to begin with and it'd look the same haha

Use less of a margin, rebase

Rebase

Refresh

There doesn't seem to be anything else to be done here

i vote for no 2 / current diff

Rebase

The last holdout :D

Thank you so much this particular landing has been a long time coming :D

Good things come to those who wait, thanks for the fix.
I can also confirm that this doesn't affect any other font adversely in any way.

Way prettier with these changes, +1
Ditto on the Status box, alignment with the left window border seems preferable.

Rebase; add Accessible.name

If I don't subtract 0.5 units.smallSpacing (two pixels), this happens:

In D19214#424074, @ngraham wrote:

Looks like https://bugs.kde.org/show_bug.cgi?id=399155 has revealed that the text field itself just isn't tall enough. Fixing that should fix both the bug mentioned above, as well as the hackaround to make the button shorter so they're the same height.

Let's either fix the issue in the PlasmaComponents text field before we land this, or else see if we can port this to use the Kirigami ActionTextField instead, which should be the correct height.

These screenshots might make this problem more appreciable.

In D19479#426474, @davidedmundson wrote:

Visual indication on mouseover is generally a good thing ++

A thumbnail

Perfect

A few concerns:

In T9041#178088, @konkinartem wrote:

I really hate to be a bore but without the switch to PropertyAnimation that annoying bug (that you might not be able to notice but I am) keeps rearing its ugly head.

How's that? It actually reminds me of the notification widget with these changes in place