Feed Advanced Search

Mar 28 2019

rooty resigned from D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background.
Mar 28 2019, 11:22 PM · Plasma
rooty resigned from D19471: Middle-elide file/folder labels so the extension is always visible.
Mar 28 2019, 11:22 PM · Dolphin
rooty resigned from D19613: Support NET_WM_STATE_FOCUSED.
Mar 28 2019, 11:22 PM · KWin
rooty abandoned D19209: [sddm-kcm] Adjust Background label and button.
Mar 28 2019, 11:20 PM · Plasma
rooty removed a member for VDG: rooty.
Mar 28 2019, 5:41 PM
rooty removed a watcher for VDG: rooty.
Mar 28 2019, 5:41 PM
rooty added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

In projects where maintenance is lacking you will notice a trend towards options sprawl for that reason.

Mar 28 2019, 12:26 PM · Plasma

Mar 27 2019

rooty added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

The suggestion about the hover effect though is a nice one +1

Mar 27 2019, 1:52 PM · Plasma
rooty added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.

No, it's not.

Mar 27 2019, 12:59 PM · Plasma
rooty added a comment to D19822: [Task Manager] Toggle mute when the audio indicator is clicked.
In D19822#439167, @hein wrote:

I'm not a fan of the checkbox, I think it's a little gratuitous. If you add a small feature and need to immediately add a checkbox to disable it, it's rather a red flag to me. It means either the feature or the checkbox should probably go.

Mar 27 2019, 8:02 AM · Plasma

Mar 20 2019

rooty added a comment to T10325: 5.16 Login screen improvements.

Congratulations everyone! Now let's never touch it again lol

Mar 20 2019, 7:29 PM · Plasma, VDG
rooty committed R120:94dcbf0500aa: [sddm-theme] Update login screen preview image (authored by rooty).
[sddm-theme] Update login screen preview image
Mar 20 2019, 5:15 PM
rooty closed D19469: [sddm-theme] Update login screen preview image.
Mar 20 2019, 5:15 PM · Plasma
rooty committed R120:154637e69119: [sddm-theme/lock screen] Move main stack to a more vertically centered position (authored by rooty).
[sddm-theme/lock screen] Move main stack to a more vertically centered position
Mar 20 2019, 4:51 PM
rooty closed D19916: [sddm-theme/lock screen] Move main stack to a more vertically centered position.
Mar 20 2019, 4:50 PM · Plasma
rooty updated the diff for D19469: [sddm-theme] Update login screen preview image.

Deselect password field

Mar 20 2019, 4:39 PM · Plasma
rooty updated the diff for D19469: [sddm-theme] Update login screen preview image.

Use correct Desktop Sesion setting and use Konqi and Katie mascot avatars

Mar 20 2019, 4:35 PM · Plasma
rooty added a comment to D19469: [sddm-theme] Update login screen preview image.

I'll be retaking this shortly - it says Openbox instead of Plasma (sorry) and yeah I'll be replacing the avatars
The blurry thing - don't look at me (or flipwise and me) because we're about as certain as a person can get that it's not sddm's (or the theme's) fault

Mar 20 2019, 4:18 PM · Plasma
rooty updated the diff for D19469: [sddm-theme] Update login screen preview image.

Use color avatars and 16:9 aspect ratio

Mar 20 2019, 4:15 PM · Plasma
rooty added a comment to D19469: [sddm-theme] Update login screen preview image.

This is the Konqi avatar I have available in SySe. It renders as fairly blurry / lower quality than the one I opted for originally - are you sure you want to use this?

Mar 20 2019, 4:04 PM · Plasma
rooty added a comment to D19469: [sddm-theme] Update login screen preview image.
In D19469#435215, @GB_2 wrote:

BTW, it's still not 1920x1080.

Mar 20 2019, 4:01 PM · Plasma
rooty added a comment to D19469: [sddm-theme] Update login screen preview image.
In D19469#435184, @GB_2 wrote:
In D19469#435175, @GB_2 wrote:

The file size is quite big (you can change the compression in Spectacle) and I think the resolution should be 1920x1080.
Please also change the user images to the colorful Konqi and Katie ones.

But they're uglier? :D

I think they look nice and we've been using them in other previews and release announcements too.

Mar 20 2019, 3:58 PM · Plasma
rooty added a comment to D19469: [sddm-theme] Update login screen preview image.
In D19469#435175, @GB_2 wrote:

The file size is quite big (you can change the compression in Spectacle) and I think the resolution should be 1920x1080.
Please also change the user images to the colorful Konqi and Katie ones.

Mar 20 2019, 3:56 PM · Plasma
rooty updated the diff for D19469: [sddm-theme] Update login screen preview image.

Compress image

Mar 20 2019, 3:51 PM · Plasma
rooty added a dependency for D19469: [sddm-theme] Update login screen preview image: D19916: [sddm-theme/lock screen] Move main stack to a more vertically centered position.
Mar 20 2019, 3:46 PM · Plasma
rooty added a dependent revision for D19916: [sddm-theme/lock screen] Move main stack to a more vertically centered position: D19469: [sddm-theme] Update login screen preview image.
Mar 20 2019, 3:46 PM · Plasma
rooty added a task to D19916: [sddm-theme/lock screen] Move main stack to a more vertically centered position: T10325: 5.16 Login screen improvements.
Mar 20 2019, 3:46 PM · Plasma
rooty added a revision to T10325: 5.16 Login screen improvements: D19916: [sddm-theme/lock screen] Move main stack to a more vertically centered position.
Mar 20 2019, 3:46 PM · Plasma, VDG
rooty added reviewers for D19916: [sddm-theme/lock screen] Move main stack to a more vertically centered position: VDG, ngraham, filipf, davidedmundson.
Mar 20 2019, 3:46 PM · Plasma
rooty requested review of D19916: [sddm-theme/lock screen] Move main stack to a more vertically centered position.
Mar 20 2019, 3:45 PM · Plasma
rooty added a comment to D19469: [sddm-theme] Update login screen preview image.

Okay so, scrot and xwd kinda drove me nuts, so I decided to open up sddm-greeter, cut off its titlebar, hide the panel and it looks identical to the login screen so :D Voila

Mar 20 2019, 3:42 PM · Plasma
rooty updated the diff for D19469: [sddm-theme] Update login screen preview image.

Update preview image

Mar 20 2019, 3:41 PM · Plasma
rooty added a comment to D19469: [sddm-theme] Update login screen preview image.

I actually tried that but it doesn't recognize theme.conf so there's no wallpaper (it's all white)
I'm trying to take a screenshot from outside X but seeing as I'm new to this it's not making it easy

Mar 20 2019, 3:26 PM · Plasma
rooty added a comment to D19469: [sddm-theme] Update login screen preview image.

Sure thing
Sorry it's been taking so long, I've been having the hardest time getting virtualbox to work...

Mar 20 2019, 6:22 AM · Plasma

Mar 19 2019

rooty added a comment to D19874: [Kickoff] Reduce the margins of KickoffItem, KickoffHighlight and use smallSpacing.

You should test this in all four orientations.
And if you retake the screenshots please arrange them as follows:

Mar 19 2019, 1:57 PM · Plasma
rooty added a comment to D19821: Fix breeze dialog background with Qt 5.12.2.

This wasn't supposed to land in Plasma 5.15 as well as master?

Plasma Framework is (in this case unfortunately) a Framework, so no stable branches.

Mar 19 2019, 1:57 PM · Frameworks
rooty added a comment to D19821: Fix breeze dialog background with Qt 5.12.2.

This wasn't supposed to land in Plasma 5.15 as well as master?

Mar 19 2019, 1:55 PM · Frameworks
rooty accepted D19821: Fix breeze dialog background with Qt 5.12.2.

If it works for you ship it, I'm nowhere near a computer right now

Mar 19 2019, 9:04 AM · Frameworks
rooty added a comment to D19874: [Kickoff] Reduce the margins of KickoffItem, KickoffHighlight and use smallSpacing.

Looks a lot better, +1.

Mar 19 2019, 7:10 AM · Plasma
rooty accepted D19872: [plasma-workspace-wallpapers] Add the Elarun wallpaper.
Mar 19 2019, 7:04 AM · Plasma

Mar 18 2019

rooty committed R122:22d725ca0361: [powerdevil] Touch up messages/prompts (authored by rooty).
[powerdevil] Touch up messages/prompts
Mar 18 2019, 8:14 PM
rooty closed D19838: [powerdevil] Touch up messages/prompts.
Mar 18 2019, 8:14 PM · Plasma
rooty added inline comments to D19838: [powerdevil] Touch up messages/prompts.
Mar 18 2019, 8:14 PM · Plasma
rooty updated the diff for D19838: [powerdevil] Touch up messages/prompts.

"or because"

Mar 18 2019, 8:14 PM · Plasma
rooty updated the diff for D19838: [powerdevil] Touch up messages/prompts.

Activity...

Mar 18 2019, 5:46 AM · Plasma
rooty updated the diff for D19838: [powerdevil] Touch up messages/prompts.

Remove unnecessary comment

Mar 18 2019, 5:44 AM · Plasma
rooty updated the diff for D19838: [powerdevil] Touch up messages/prompts.

Missed one

Mar 18 2019, 5:43 AM · Plasma
rooty updated the diff for D19838: [powerdevil] Touch up messages/prompts.

Implement inline comment suggestions

Mar 18 2019, 5:40 AM · Plasma
rooty added inline comments to D19838: [powerdevil] Touch up messages/prompts.
Mar 18 2019, 5:36 AM · Plasma

Mar 17 2019

rooty updated the diff for D19838: [powerdevil] Touch up messages/prompts.

Bring back the possessive pronouns

Mar 17 2019, 7:18 PM · Plasma
rooty updated the diff for D19838: [powerdevil] Touch up messages/prompts.

Drop unnecessary pronouns

Mar 17 2019, 7:05 PM · Plasma
rooty updated the diff for D19838: [powerdevil] Touch up messages/prompts.

Touch up some more

Mar 17 2019, 6:55 PM · Plasma
rooty updated the diff for D19838: [powerdevil] Touch up messages/prompts.

Add the verb run (because... why not)

Mar 17 2019, 6:38 PM · Plasma
rooty added a comment to D19838: [powerdevil] Touch up messages/prompts.

Looks good. I'd avoid using pronouns, I think it would sound better and whose else's is the battery if not yours?

Haha yeah.
Granted, even these pronouns are waaaay better than the prompt saying "I am going to sleep."
Outright creepy :D

Mar 17 2019, 6:08 PM · Plasma
rooty updated the diff for D19838: [powerdevil] Touch up messages/prompts.

Make sleep prompt more natural-sounding

Mar 17 2019, 6:05 PM · Plasma
rooty updated the diff for D19838: [powerdevil] Touch up messages/prompts.

Fix "be go"

Mar 17 2019, 6:02 PM · Plasma
rooty added a comment to D19838: [powerdevil] Touch up messages/prompts.

I'm not sold on the use of pronouns here, we could actually do without them
If we agree to keep the pronouns, I'm not going to object but... we can sound both non-technical and professional at the same time :D

Mar 17 2019, 6:00 PM · Plasma
rooty added reviewers for D19838: [powerdevil] Touch up messages/prompts: VDG, Plasma, broulik, ngraham, filipf.
Mar 17 2019, 5:56 PM · Plasma
rooty updated the diff for D19838: [powerdevil] Touch up messages/prompts.

Remove "as soon as possible" (less anxiety-inducing)

Mar 17 2019, 5:56 PM · Plasma
rooty requested review of D19838: [powerdevil] Touch up messages/prompts.
Mar 17 2019, 5:54 PM · Plasma
rooty added a comment to D19825: Improve update states' UI.

Hey I know this has landed already but how do you feel about the word Retrieving instead of Fetching?

Mar 17 2019, 5:41 PM · Plasma
rooty added a comment to D19821: Fix breeze dialog background with Qt 5.12.2.
In D19821#432780, @Zren wrote:

Another option I believe is to keep the <style> tag but add the id="current-color-scheme" type="text/css" attributes. I assume the only difference is plasma replaces the contents of the existing style tag instead of creating a new one, though I'm not sure where the code inserts it.

Mar 17 2019, 5:00 PM · Frameworks
rooty added a comment to D19613: Support NET_WM_STATE_FOCUSED.

We quite literally have nothing to lose by landing this.

Mar 17 2019, 9:38 AM · KWin
rooty added a comment to D19469: [sddm-theme] Update login screen preview image.

I'll post one

Mar 17 2019, 8:52 AM · Plasma
rooty added a comment to D19469: [sddm-theme] Update login screen preview image.

I do believe that this is the very last patch for T10325: 5.16 Login screen improvements. :)

Mar 17 2019, 7:51 AM · Plasma

Mar 16 2019

rooty accepted D17469: Give applications-games and input-gaming more contrast with Breeze Dark.

Much better than before

Mar 16 2019, 6:34 PM · Frameworks
rooty updated the summary of D19647: [sddm-theme/lock screen] Use QQC2 for the clock labels.
Mar 16 2019, 6:18 PM · Plasma
rooty updated the summary of D19647: [sddm-theme/lock screen] Use QQC2 for the clock labels.
Mar 16 2019, 6:13 PM · Plasma
rooty committed R120:d7654042677a: [sddm-theme/lock screen] Use QQC2 for the clock labels (authored by rooty).
[sddm-theme/lock screen] Use QQC2 for the clock labels
Mar 16 2019, 6:01 PM
rooty closed D19647: [sddm-theme/lock screen] Use QQC2 for the clock labels.
Mar 16 2019, 6:01 PM · Plasma
rooty added a comment to D19797: [fifteen-puzzle] Modernize settings window.

I'm not sure - the sections are so small the headings make it sound redundant (Numbers, Show numbers, Number color), I'd add spaces instead.

Mar 16 2019, 5:15 PM · Plasma
rooty committed R120:d3aa8b07c168: [sddm-theme/lock screen] Overhaul font sizes (authored by rooty).
[sddm-theme/lock screen] Overhaul font sizes
Mar 16 2019, 4:53 PM
rooty closed D19631: [sddm-theme/lock screen] Overhaul font sizes.
Mar 16 2019, 4:53 PM · Plasma
rooty updated the diff for D19631: [sddm-theme/lock screen] Overhaul font sizes.

Remove extra character

Mar 16 2019, 3:09 PM · Plasma
rooty updated the diff for D19631: [sddm-theme/lock screen] Overhaul font sizes.

Make it work for the lock screen too

Mar 16 2019, 3:08 PM · Plasma
rooty updated the diff for D19631: [sddm-theme/lock screen] Overhaul font sizes.

Implement changes in keyboard layout button

Mar 16 2019, 3:05 PM · Plasma
rooty updated the diff for D19631: [sddm-theme/lock screen] Overhaul font sizes.

Add battery life font size configuration

Mar 16 2019, 3:00 PM · Plasma
rooty updated the diff for D19631: [sddm-theme/lock screen] Overhaul font sizes.

Make properties less restricted

Mar 16 2019, 1:00 PM · Plasma
rooty added inline comments to D19631: [sddm-theme/lock screen] Overhaul font sizes.
Mar 16 2019, 11:13 AM · Plasma
rooty updated the diff for D19631: [sddm-theme/lock screen] Overhaul font sizes.

Use track and artist style from D17073

Mar 16 2019, 11:13 AM · Plasma

Mar 15 2019

rooty accepted D19777: Apply changes for tooltip from upstream.
Mar 15 2019, 8:23 AM · Plasma
rooty added a comment to D19777: Apply changes for tooltip from upstream.

Hold on I'm gonna try it with the git version

Mar 15 2019, 7:41 AM · Plasma
rooty added a comment to D19777: Apply changes for tooltip from upstream.

Yes, it works for me. How did you apply the patch ?

Mar 15 2019, 7:34 AM · Plasma
rooty requested changes to D19777: Apply changes for tooltip from upstream.

Does this work for you? It doesn't work for me at all.
There are no icons in the dock and the one applet that does show up has its label misplaced by a huge margin:

Mar 15 2019, 7:30 AM · Plasma

Mar 14 2019

rooty added a comment to D17073: [Task Manager] Do not crop album art in tooltip.

Looks amazing.

Mar 14 2019, 5:38 PM · Plasma
rooty added a comment to D17073: [Task Manager] Do not crop album art in tooltip.

HInt: Please dont discuss here the Latte case because it creates noise for all the reviewers interested in this

Mar 14 2019, 4:17 PM · Plasma
rooty added a comment to D17073: [Task Manager] Do not crop album art in tooltip.

P.S. We could also implement this in latte-dock. Not just that, but also give latte's ToolTipInstance a makeover (the fonts are really huge).
I've actually already used this diff to modify latte-dock's ToolTipInstance:

Mar 14 2019, 4:04 PM · Plasma
rooty accepted D17073: [Task Manager] Do not crop album art in tooltip.

I normally wouldn't ask this but seeing as my fonts have been acting up, can you please update the test plan screenshots? Sorry :D

Mar 14 2019, 3:55 PM · Plasma
rooty changed the visibility for F6690997: fix-31419.png.
Mar 14 2019, 1:07 PM
rooty committed R120:a623cb7fec62: Merge branch 'Plasma/5.15' (authored by rooty).
Merge branch 'Plasma/5.15'
Mar 14 2019, 1:06 PM
rooty committed R120:fb868892fc9b: [notifications] Prevent subpixel font placement (authored by rooty).
[notifications] Prevent subpixel font placement
Mar 14 2019, 1:01 PM

Mar 13 2019

rooty added a comment to D17073: [Task Manager] Do not crop album art in tooltip.

Just use a real bold if you want it bold. :) In which case, the label below it should have normal 100% opacity instead of 75%.

Mar 13 2019, 8:39 PM · Plasma
rooty requested changes to D17073: [Task Manager] Do not crop album art in tooltip.

We still need to resolve the DemiBold issue.
DemiBold fonts either aren't present or don't work in neon. (Or both...)

Mar 13 2019, 7:38 PM · Plasma
rooty added a comment to D17073: [Task Manager] Do not crop album art in tooltip.

Increase the contrast between the song name and the artist.

Mar 13 2019, 5:55 PM · Plasma
rooty accepted D19194: Adjust date string height to match time string with vertical panel.

+1 from me too

Mar 13 2019, 3:45 PM · Plasma
rooty accepted D19651: Improve the look of the Application Style KCM UI.
Mar 13 2019, 2:50 PM · Plasma
rooty added a comment to D17073: [Task Manager] Do not crop album art in tooltip.

@rooty is right though that usually there is always a hierarchy between the song and the artist. I'd also prefer a level 5 bold song title, but yeah it's a controversial topic these days.

Mar 13 2019, 12:49 PM · Plasma
rooty added a comment to D19651: Improve the look of the Application Style KCM UI.

Please consider abbreviating the labels:

  • dropping text in the last two dropdown menu items (No Text, Text Only, Beside Icons, Below Icons)
  • dropping the word location (it's implicit)
  • substituting the word text with the word label (it's more accurate)
Mar 13 2019, 12:41 PM · Plasma
rooty added a comment to D17073: [Task Manager] Do not crop album art in tooltip.

Level 5 for both labels would be acceptable to me if you made the song name bold.
I would actually prefer this. However, it's likely that mart would throw a hissy fit over this change :D

Mar 13 2019, 12:14 PM · Plasma
rooty added a comment to D17073: [Task Manager] Do not crop album art in tooltip.
  • Using a bigger font size means less characters could be display.

The song name is always going to be elided, so it doesn't matter.

Mar 13 2019, 9:33 AM · Plasma