Feed Advanced Search

Jan 24 2019

davidedmundson requested review of D18508: Somewhat guard failing to load backend.
Jan 24 2019, 10:22 PM · Plasma
davidedmundson committed R108:d4fce7a3ad0f: Separate clang and gcc compiler workarounds for kwin override policy (authored by davidedmundson).
Separate clang and gcc compiler workarounds for kwin override policy
Jan 24 2019, 4:51 PM
davidedmundson updated the title for P292 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Jan 24 2019, 4:49 PM
davidedmundson accepted D18503: Keep _NET_DESKTOP_NAMES in sync.
Jan 24 2019, 4:29 PM · KWin
davidedmundson committed R108:a088a7b1a482: Apply -Wno-inconsistent-missing-override for all compilers (authored by davidedmundson).
Apply -Wno-inconsistent-missing-override for all compilers
Jan 24 2019, 4:28 PM
davidedmundson closed D18488: Apply -Wno-inconsistent-missing-override for all compilers.
Jan 24 2019, 4:28 PM · KWin
davidedmundson triaged T10397: Qt 5.12 for plasma master as Low priority.
Jan 24 2019, 4:12 PM · build.kde.org
davidedmundson accepted D18499: [KCM Controls GridView] Add remove animation.
Jan 24 2019, 2:06 PM · Frameworks
davidedmundson accepted D18498: [Desktop Theme KCM] Support installing from remote locations.

Given how much is copy pasta, is there anything that can be made into a lib / put in kpackagetool?

Jan 24 2019, 2:05 PM · Plasma
davidedmundson accepted D12278: [Colors KCM] Port to new design.

Please add to https://notes.kde.org/p/plasma_5_16 before shipping

Jan 24 2019, 1:22 PM · Plasma
davidedmundson added inline comments to D12278: [Colors KCM] Port to new design.
Jan 24 2019, 1:10 PM · Plasma
davidedmundson added inline comments to D18486: [RFC] XWayland Multi DPI support.
Jan 24 2019, 12:17 PM · KWin
davidedmundson added inline comments to D18486: [RFC] XWayland Multi DPI support.
Jan 24 2019, 12:13 PM · KWin
davidedmundson added inline comments to D18182: Fix new file creation leading to dupe items on a fresh view.
Jan 24 2019, 12:01 PM · Plasma
davidedmundson accepted D18493: Useful error output when shell loading is aborted due to kactivitymanagerd not being activatable.
Jan 24 2019, 11:46 AM · Plasma
davidedmundson added a comment to D18078: [plasma-workspace-wallpapers] Improve wallpaper selection.

Ok, so two important tasks.

Jan 24 2019, 1:46 AM · Plasma
davidedmundson requested review of D18489: warnings--.
Jan 24 2019, 1:22 AM · Plasma
davidedmundson committed R120:0aee25b30f44: Remove duplicated file (authored by davidedmundson).
Remove duplicated file
Jan 24 2019, 12:29 AM
davidedmundson closed D17920: Remove duplicated file.
Jan 24 2019, 12:29 AM · Plasma
davidedmundson committed R120:8567ccc526f4: Merge branch 'Plasma/5.15' (authored by davidedmundson).
Merge branch 'Plasma/5.15'
Jan 24 2019, 12:20 AM
davidedmundson committed R120:2fd853aea2ce: [applets/appmenu] Show placeholder when configuring and empty (authored by davidedmundson).
[applets/appmenu] Show placeholder when configuring and empty
Jan 24 2019, 12:15 AM
davidedmundson closed D18481: [applets/appmenu] Show placeholder when configuring and empty.
Jan 24 2019, 12:15 AM · Plasma
davidedmundson committed R120:ea67f7103044: [applets/appmenu] Set iconSource properly (authored by davidedmundson).
[applets/appmenu] Set iconSource properly
Jan 24 2019, 12:15 AM
davidedmundson closed D18480: [applets/appmenu] Set iconSource properly.
Jan 24 2019, 12:15 AM · Plasma
davidedmundson updated the diff for D18481: [applets/appmenu] Show placeholder when configuring and empty.

use plasmoid.title

Jan 24 2019, 12:15 AM · Plasma
davidedmundson added a comment to D18078: [plasma-workspace-wallpapers] Improve wallpaper selection.

Can you please confirm the source of these images.
We need to be sure they all fall under: https://community.kde.org/Policies/Licensing_Policy

Jan 24 2019, 12:09 AM · Plasma

Jan 23 2019

davidedmundson added a comment to D18488: Apply -Wno-inconsistent-missing-override for all compilers.

Can't we just run clang-tidy to fix them?

Jan 23 2019, 9:49 PM · KWin
davidedmundson accepted D18482: [KRDB] Write correct tooltip colors into gtkrc in kcminit.

Because of a bug preventing proper propagation of environment variables to apps launched through Kickoff/KRunner (KRun?) via klauncher(??) this is hardly noticeable but when you e.g. open Gimp or Inkscape through "Open With" in Dolphin or manually using

Jan 23 2019, 9:26 PM · Plasma
davidedmundson requested review of D18488: Apply -Wno-inconsistent-missing-override for all compilers.
Jan 23 2019, 9:16 PM · KWin
davidedmundson added a comment to D18486: [RFC] XWayland Multi DPI support.

As for the xwayland patch.

Jan 23 2019, 8:55 PM · KWin
davidedmundson added a comment to D18486: [RFC] XWayland Multi DPI support.

I'm still a bit skeptical of a few parts, it makes an assumption that X clients all scale themselves perfectly, something that really doesn't hold but I'll see how the discussion on the xwl thread pans out.

Jan 23 2019, 8:47 PM · KWin
davidedmundson accepted D18485: [KRDB] Also try wildcard tooltip.
Jan 23 2019, 7:33 PM · Plasma
davidedmundson added inline comments to D18481: [applets/appmenu] Show placeholder when configuring and empty.
Jan 23 2019, 7:33 PM · Plasma
davidedmundson added a comment to D18481: [applets/appmenu] Show placeholder when configuring and empty.

With this patch as-is the placeholder is also shown if the applet is on the desktop and the active window doesn't have a menu.

Jan 23 2019, 7:08 PM · Plasma
davidedmundson added a comment to D18481: [applets/appmenu] Show placeholder when configuring and empty.

Jan 23 2019, 7:05 PM · Plasma
davidedmundson requested review of D18481: [applets/appmenu] Show placeholder when configuring and empty.
Jan 23 2019, 7:03 PM · Plasma
davidedmundson requested review of D18480: [applets/appmenu] Set iconSource properly.
Jan 23 2019, 6:45 PM · Plasma
davidedmundson added a comment to D18460: Make sure we check for any GL errors generated from glGetIntegerv.

The nvidia thing is with glGetError
checkglerror is in our code which handles that case.

Jan 23 2019, 4:55 PM · KWin
davidedmundson committed R119:47995c3bf127: Merge branch 'Plasma/5.15' (authored by davidedmundson).
Merge branch 'Plasma/5.15'
Jan 23 2019, 4:00 PM
davidedmundson closed D18471: [kcms/cursortheme] Fix size combo.
Jan 23 2019, 3:49 PM · Plasma
davidedmundson committed R119:9096bdefc66e: [kcms/cursortheme] Fix size combo (authored by davidedmundson).
[kcms/cursortheme] Fix size combo
Jan 23 2019, 3:49 PM
davidedmundson committed R119:5c18d665b7e8: [kcms/cursortheme] Set theme before loading size (authored by davidedmundson).
[kcms/cursortheme] Set theme before loading size
Jan 23 2019, 3:49 PM
davidedmundson closed D18470: [kcms/cursortheme] Set theme before loading size.
Jan 23 2019, 3:48 PM · Plasma
davidedmundson requested review of D18471: [kcms/cursortheme] Fix size combo.
Jan 23 2019, 2:37 PM · Plasma
davidedmundson requested review of D18470: [kcms/cursortheme] Set theme before loading size.
Jan 23 2019, 2:36 PM · Plasma
davidedmundson added a comment to D18453: Reload Shm texture when buffer size changes.

Could this be our firefox issue?

Jan 23 2019, 12:20 PM · KWin
davidedmundson requested changes to D18418: Adjust some KCMs to implement new Appearance section layout [1/3].
Jan 23 2019, 11:20 AM · Plasma
davidedmundson accepted D18461: [kcmkwin/compositing] Use new icon for Effects KCM.
Jan 23 2019, 12:29 AM · KWin

Jan 22 2019

davidedmundson added a comment to D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings.

Almost every project has already been gone over with clang-tidy.
Including kwin which was then force-pushed back by you. This was back in June 2017.
I've got little sympathy if we have a warning after explicitly reverting the fix to the warning.

Jan 22 2019, 7:40 PM · Build System, Frameworks
davidedmundson added a comment to D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.

Probably the best way to go.

Jan 22 2019, 5:38 PM · KWin
davidedmundson accepted D18430: [DesktopView] Don't set a window icon.
Jan 22 2019, 2:30 PM · Plasma
davidedmundson added a comment to D18410: Implement PlasmaShellSurface::popupBehavior in kwin.

There's an extra twist.
You can put the digital-clock on the desktop. You can then open the popup, and then pin it so that it's above windows.
Being transient to the desktop won't help there.

Jan 22 2019, 1:48 PM · KWin
davidedmundson accepted D17691: Add rows info to the plasma virtual desktop protocol.
Jan 22 2019, 12:43 PM · Frameworks
davidedmundson committed R126:2493b32b1715: Merge branch 'Plasma/5.15' (authored by davidedmundson).
Merge branch 'Plasma/5.15'
Jan 22 2019, 12:40 PM
davidedmundson committed R126:e8fe68581741: Load Plasma QtQuick settings in KCMShell (authored by davidedmundson).
Load Plasma QtQuick settings in KCMShell
Jan 22 2019, 12:40 PM
davidedmundson closed D18443: Load Plasma QtQuick settings in KCMShell.
Jan 22 2019, 12:40 PM · Plasma
davidedmundson accepted D18454: Fonts KCM: Port from kde_file.h to QFileInfo.
Jan 22 2019, 11:48 AM · Plasma
davidedmundson added inline comments to D18453: Reload Shm texture when buffer size changes.
Jan 22 2019, 11:41 AM · KWin
davidedmundson requested review of D18443: Load Plasma QtQuick settings in KCMShell.
Jan 22 2019, 12:33 AM · Plasma
davidedmundson added a comment to T10384: Unify styles for lists and their buttons.

This is definitely an area that needs fixing ++

Jan 22 2019, 12:14 AM · Goal: Consistency, Kirigami, KDE Human Interface Guidelines, VDG

Jan 21 2019

davidedmundson accepted D18440: [client] Wrap wl_shell_surface_set_{class,title}.

ShellSurface is super-duper deprecated. I wouldn't invest too much time on it.

Jan 21 2019, 9:54 PM · Frameworks
davidedmundson committed R120:fc2d0c4f56eb: Handle ShutdowntypeDefault in KSMserver legacy code (authored by davidedmundson).
Handle ShutdowntypeDefault in KSMserver legacy code
Jan 21 2019, 7:42 PM
davidedmundson committed R120:ad1a76b800e0: Merge branch 'Plasma/5.15' (authored by davidedmundson).
Merge branch 'Plasma/5.15'
Jan 21 2019, 7:42 PM
davidedmundson closed D18435: Handle ShutdowntypeDefault in KSMserver legacy code.
Jan 21 2019, 7:42 PM · Plasma
davidedmundson added a comment to D18435: Handle ShutdowntypeDefault in KSMserver legacy code.

This should go into 5.15, right?

Jan 21 2019, 7:24 PM · Plasma
davidedmundson requested review of D18435: Handle ShutdowntypeDefault in KSMserver legacy code.
Jan 21 2019, 6:49 PM · Plasma
davidedmundson added a comment to T7246: User Manager.

Not that I know of.

Jan 21 2019, 6:37 PM · Plasma: KCM Redesign
davidedmundson accepted D18328: Fix VirtualDesktopManager::createVirtualDesktop.
Jan 21 2019, 5:58 PM · KWin
davidedmundson added a comment to D18328: Fix VirtualDesktopManager::createVirtualDesktop.

Changes definitely make sense, much more readable now.

Jan 21 2019, 5:45 PM · KWin
davidedmundson accepted D18342: Make sure that new virtual desktops can be activated by using plasma virtual desktop protocol.
Jan 21 2019, 5:36 PM · KWin
davidedmundson added a comment to D18410: Implement PlasmaShellSurface::popupBehavior in kwin.

The default state works fine without tricks.

Jan 21 2019, 4:57 PM · KWin
davidedmundson added inline comments to D17691: Add rows info to the plasma virtual desktop protocol.
Jan 21 2019, 4:24 PM · Frameworks
davidedmundson accepted D18428: actually remove unused ksnrc file.
Jan 21 2019, 2:21 PM · Plasma
davidedmundson added a comment to D18366: Fix flickering with Qt 5.12.

Also relevant is of course Fredrik's comment in the Qt bug report

Jan 21 2019, 12:24 PM · KWin
davidedmundson added a comment to D18419: Move KCMs in "Workspace Theme" to more appropriate locations.

To clarify one thing, I didn't say "porting". The original task was to go through all of them unifying them, rethinking design and following Fabian's new HIG as well as making sure all options are in the right place, etc.. I personally don't particularly care too much which tech is used.

Jan 21 2019, 8:43 AM · Plasma
davidedmundson added a comment to D18410: Implement PlasmaShellSurface::popupBehavior in kwin.

Fair enough. I want some name that hints it doesn't include panels.

Jan 21 2019, 5:44 AM · KWin
davidedmundson added a comment to T7246: User Manager.

We should refrain from starting things from scratch.

Jan 21 2019, 4:14 AM · Plasma: KCM Redesign

Jan 20 2019

davidedmundson accepted D18413: Don't put some KCMs in a single-item top-level category.
Jan 20 2019, 10:43 PM · Plasma
davidedmundson requested changes to D18419: Move KCMs in "Workspace Theme" to more appropriate locations.

We have all agreed before that we will not do any top-down shuffling until all the work updating KCMs bottom-up has been completed. It's documented in that linked thread. That ground-up work has not finished.

Jan 20 2019, 10:04 PM · Plasma
davidedmundson accepted D18415: Use nullptr.
Jan 20 2019, 9:18 PM
davidedmundson accepted D18411: [Analog Clock] Port config window to QQC2 and use Kirigami FormLayout.
Jan 20 2019, 6:07 PM · Plasma
davidedmundson accepted D18401: [Look And Feel KCM] Use new icon.
Jan 20 2019, 5:58 PM · Plasma
davidedmundson requested review of D18410: Implement PlasmaShellSurface::popupBehavior in kwin.
Jan 20 2019, 5:54 PM · KWin
davidedmundson added a comment to D18406: Silence warnings in TabBoxHandler.

Regarding the latter, we could use clang-tidy,

Jan 20 2019, 5:08 PM · KWin
davidedmundson closed D18370: Set libkworkspace minimum version.
Jan 20 2019, 3:59 PM · Plasma
davidedmundson committed R119:270c67514052: Set libkworkspace minimum version (authored by davidedmundson).
Set libkworkspace minimum version
Jan 20 2019, 3:59 PM
davidedmundson added a comment to D18401: [Look And Feel KCM] Use new icon.

which we can depend on for the 5.16 release.

Jan 20 2019, 3:49 PM · Plasma
davidedmundson requested review of D18408: Set new PlasmaShellSurface::PopupBehavior flags.
Jan 20 2019, 3:43 PM · Frameworks

Jan 19 2019

davidedmundson added inline comments to D18376: Fix software cursors with drm backend.
Jan 19 2019, 1:15 PM · KWin
davidedmundson added a comment to D18376: Fix software cursors with drm backend.

Can you apply for a dev account, there should be an option on identity.kde.org put my name davidedmundson@kde.org as an approver.

Jan 19 2019, 1:07 PM · KWin

Jan 18 2019

davidedmundson accepted D18373: Set desktop name "atomically" when using the plasma virtual desktop protocol.
Jan 18 2019, 11:17 PM · KWin
davidedmundson accepted D18374: Fix "context objects" in VirtualDesktopManager::setVirtualDesktopManagement.
Jan 18 2019, 11:10 PM · KWin
davidedmundson accepted D18372: Delete names of removed desktops from kwinrc.
Jan 18 2019, 9:47 PM · KWin
davidedmundson requested review of D18370: Set libkworkspace minimum version.
Jan 18 2019, 7:44 PM · Plasma
davidedmundson accepted D18367: [scenes/opengl] Destroy the lanczos filter when the backend is still alive.
Jan 18 2019, 7:15 PM · KWin
davidedmundson added a comment to D17773: Copy to Clipboard in English.

How can this affect discover?

Jan 18 2019, 6:44 PM · Plasma
davidedmundson committed R871:aa781f86780a: Use nullptr (authored by davidedmundson).
Use nullptr
Jan 18 2019, 3:39 PM
davidedmundson updated the summary of D18365: Add a flag to keep a window on top.
Jan 18 2019, 2:43 PM · Frameworks
davidedmundson accepted D18363: [build] Search for kirigami as a runtime dependency.
Jan 18 2019, 2:30 PM · Plasma
davidedmundson accepted D18362: [build] Search for kirigami as a runtime dependency.
Jan 18 2019, 2:30 PM · Plasma