Differential D18435

Handle ShutdowntypeDefault in KSMserver legacy code
ClosedPublic
Actions

Authored by davidedmundson on Jan 21 2019, 6:49 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R120:fc2d0c4f56eb: Handle ShutdowntypeDefault in KSMserver legacy code
Summary

In the ksmserver porting most code was moved to explicitly calling
logout or shutdown methods rather than a random enum.

A legacy code path remained for compatibility. This path is used by the
containmentactions, in the refactor handling of
KWorkspace::ShutdownTypeDefault was lost.

BUG: 403466

Test Plan

Set different default modes
Logged out using containment actions

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Jan 21 2019, 6:49 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 21 2019, 6:49 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jan 21 2019, 6:49 PM
ngraham added a subscriber: ngraham.Jan 21 2019, 6:52 PM

This should go into 5.15, right?

broulik accepted this revision.Jan 21 2019, 7:09 PM
This revision is now accepted and ready to land.Jan 21 2019, 7:09 PM
davidedmundson added a comment.Jan 21 2019, 7:24 PM

This should go into 5.15, right?

Yep.

Closed by commit R120:fc2d0c4f56eb: Handle ShutdowntypeDefault in KSMserver legacy code (authored by davidedmundson). · Explain WhyJan 21 2019, 7:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mksmserver/logout.cpp (7 lines)

Diff 50020

View Options

ksmserver/logout.cpp

Loading...