Differential D18413

Don't put some KCMs in a single-item top-level category
ClosedPublic
Actions

Authored by ngraham on Jan 20 2019, 7:08 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R119:827a39eb070d: Don't put some KCMs in a single-item top-level category
Summary

This patch lets the Colors, Notifications, and Accessibility KCMs display proper tooltip that contains their captions, rather than useless tooltips that reveals the now-obsolete implementation detail that the KCMs are the only items in their single-item categories.

Test Plan

For example the Colors KCM, before:

After:

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Jan 20 2019, 7:08 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 20 2019, 7:08 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jan 20 2019, 7:08 PM
rapiteanu added a subscriber: rapiteanu.Jan 20 2019, 8:05 PM

I like this change, but isn't Accessibility and Notifications in the same boat as Colors? Also, as a related patch, shouldn't Display and Monitors be uniform with the rest of this menu and display 'Contains 3 elements' instead of actually describing the category?

ngraham updated this revision to Diff 49963.Jan 20 2019, 8:48 PM

Also do the same for the Notifications and Accessibility KCMs

ngraham retitled this revision from [Colors KCM] Don't put the KCM in a single-item top-level category to Don't put some KCMs in a single-item top-level category.Jan 20 2019, 8:49 PM
ngraham edited the summary of this revision. (Show Details)
ngraham edited the test plan for this revision. (Show Details)
davidedmundson accepted this revision.Jan 20 2019, 10:42 PM
This revision is now accepted and ready to land.Jan 20 2019, 10:42 PM
Closed by commit R119:827a39eb070d: Don't put some KCMs in a single-item top-level category (authored by ngraham). · Explain WhyJan 20 2019, 10:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 49971

View Options

kcms/access/kcmaccess.desktop

Loading...
View Options

kcms/colors/colors.desktop

Loading...
View Options

kcms/knotify/kcmnotify.desktop

Loading...