[kcms/cursortheme] Fix size combo
ClosedPublic

Authored by davidedmundson on Jan 23 2019, 2:37 PM.

Details

Summary

The biggest problem fixed was that m_preferredSize was sometimes treated as
an absolute value, sometimes as an index. This patch splits the two
concepts.

It also fixes the binding of the combobox to handle updates properly.

BUG: 403019

Test Plan

Clicked between themes
Closed and reopened the KCM had a valid value

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Jan 23 2019, 2:37 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 23 2019, 2:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jan 23 2019, 2:37 PM

Thanks, this fixes it, and the code change looks sane!

While testing, I noticed that this combobox suffers from the same problem suffered by that the sub-pixel rendering combobox in the Fonts KCM: you can only close but pop-up by clicking on the button again: https://bugs.kde.org/show_bug.cgi?id=403403

kcms/cursortheme/kcmcursortheme.cpp
173

retrun -> return

ngraham accepted this revision.Jan 23 2019, 3:16 PM

Can we get this into the 5.15 branch?

This revision is now accepted and ready to land.Jan 23 2019, 3:16 PM
This revision was automatically updated to reflect the committed changes.