The biggest problem fixed was that m_preferredSize was sometimes treated as
an absolute value, sometimes as an index. This patch splits the two
concepts.
It also fixes the binding of the combobox to handle updates properly.
BUG: 403019
ngraham |
Plasma |
The biggest problem fixed was that m_preferredSize was sometimes treated as
an absolute value, sometimes as an index. This patch splits the two
concepts.
It also fixes the binding of the combobox to handle updates properly.
BUG: 403019
Clicked between themes
Closed and reopened the KCM had a valid value
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Thanks, this fixes it, and the code change looks sane!
While testing, I noticed that this combobox suffers from the same problem suffered by that the sub-pixel rendering combobox in the Fonts KCM: you can only close but pop-up by clicking on the button again: https://bugs.kde.org/show_bug.cgi?id=403403
kcms/cursortheme/kcmcursortheme.cpp | ||
---|---|---|
173 | retrun -> return |