Move -Wsuggest-override -Wlogical-op to regular compiler settings
ClosedPublic

Authored by aacid on Thu, Jan 10, 7:38 PM.

Details

Summary

They really help making the code better so it's good to have all applications getting those warnings

Diff Detail

Repository
R240 Extra CMake Modules
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aacid created this revision.Thu, Jan 10, 7:38 PM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptThu, Jan 10, 7:38 PM
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript
aacid requested review of this revision.Thu, Jan 10, 7:38 PM

IMHO a good idea, +1.

apol added a subscriber: apol.Thu, Jan 10, 11:23 PM

+1 to me too.

aacid added a comment.Sat, Jan 12, 5:40 PM

Since i have two +1 i'll commit this next saturday unless someone shouts in disagreement

This revision was not accepted when it landed; it landed in state Needs Review.Sat, Jan 19, 11:01 AM
This revision was automatically updated to reflect the committed changes.