Differential D18461

[kcmkwin/compositing] Use new icon for Effects KCM
ClosedPublic
Actions

Authored by ngraham on Jan 23 2019, 12:14 AM.

Details

Reviewers
davidedmundson
GB_2
Group Reviewers
VDG
Commits
R108:4f69dc6833c9: [kcmkwin/compositing] Use new icon for Effects KCM
Summary

Use the new icon introduced in D18457

Test Plan

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Jan 23 2019, 12:14 AM
Restricted Application added a project: KWin. · View Herald TranscriptJan 23 2019, 12:14 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
ngraham requested review of this revision.Jan 23 2019, 12:14 AM
davidedmundson accepted this revision.Jan 23 2019, 12:29 AM
This revision is now accepted and ready to land.Jan 23 2019, 12:29 AM
zzag added a subscriber: zzag.Jan 23 2019, 1:30 AM

Please start the subject line with [kcmkwin/compositing] or [kcmkwin/kwincompositing].

ngraham added a comment.Jan 23 2019, 2:48 AM

That seems like it would be misleading, since this is for the effects KCM, not the compositing KCM. It does happen to be inside the compositing KCM's folder for some reason (not sure why), but the word "effects" should probably appear somewhere in the commit message for clarity's sake. How's this?

[kcmkwin/compositing] Use new icon for Effects KCM

GB_2 retitled this revision from [kcmkwineffects] Use new icon to [kcmkwin/compositing] Use new icon for Effects KCM.Jan 23 2019, 6:06 AM
GB_2 added a subscriber: GB_2.
In D18461#398243, @ngraham wrote:

That seems like it would be misleading, since this is for the effects KCM, not the compositing KCM. It does happen to be inside the compositing KCM's folder for some reason (not sure why), but the word "effects" should probably appear somewhere in the commit message for clarity's sake. How's this?

[kcmkwin/compositing] Use new icon for Effects KCM

Yes, that's what the title should be like.

GB_2 accepted this revision.Jan 23 2019, 6:08 AM
Codezela added a subscriber: Codezela.Jan 23 2019, 7:21 AM

the screen edges icon need some change
maybe something in the corners of the icon

ngraham added a comment.Jan 23 2019, 11:04 PM
In D18461#398274, @Codezela wrote:

the screen edges icon need some change
maybe something in the corners of the icon

Definitely so, but that's not related to this patch. :)

Closed by commit R108:4f69dc6833c9: [kcmkwin/compositing] Use new icon for Effects KCM (authored by ngraham). · Explain WhyJan 24 2019, 3:02 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 50160

View Options

kcmkwin/kwincompositing/kcmkwineffects.desktop

Loading...