Fix new file creation leading to dupe items on a fresh view
Needs ReviewPublic

Authored by hein on Fri, Jan 11, 12:45 PM.

Details

Reviewers
McPain
Group Reviewers
Plasma
Summary

This was a regression caused by the code attempting to insert new items
at drop position, if available. setSortMode was being called in a slot
connected to the dir model's rowsInserted, but the Positioner has to be
initialized earlier as a proxy needs to handle
sourceRowsAboutToBeInserted as well.

Thanks to an investigation and patch by Oleg Solovyov in D17689 for
helping to get to the bottom of this.

This is aimed at 5.12+.

BUG:401023

Diff Detail

Repository
R119 Plasma Desktop
Branch
Plasma/5.12
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7112
Build 7130: arc lint + arc unit
hein created this revision.Fri, Jan 11, 12:45 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFri, Jan 11, 12:45 PM
hein requested review of this revision.Fri, Jan 11, 12:45 PM
hein updated this revision to Diff 49233.Fri, Jan 11, 12:46 PM
hein edited the summary of this revision. (Show Details)

Add BUG to message.

hein updated this revision to Diff 49234.Fri, Jan 11, 12:48 PM

Forgot a hunk when moving to 5.12 branch.

McPain accepted this revision.Mon, Jan 14, 9:09 AM

It works, thanks.
Removed D17689 and D17707 patches so I close then

This revision is now accepted and ready to land.Mon, Jan 14, 9:09 AM
fvogt added a subscriber: fvogt.Tue, Jan 15, 8:50 AM
fvogt added inline comments.
containments/desktop/plugins/folder/foldermodel.cpp
152

The comment refers to the first connect now, but is mostly aimed at the second. Maybe move it and add another one for the added connect call?

152–153

It doesn't use Qt::QueuedConnection explicitly - is the comment wrong or is it done implicitly?

hein updated this revision to Diff 49500.Tue, Jan 15, 8:58 AM

Fix comments and make code reflect comment intent

hein requested review of this revision.Tue, Jan 15, 8:59 AM

Requesting re-review due to significant behavior changes following @fvogt's comment

McPain added inline comments.Tue, Jan 15, 1:37 PM
containments/desktop/plugins/folder/foldermodel.cpp
152–153

According to e94888701 and cc9c3d32a, the comment is wrong.