Differential D18499

[KCM Controls GridView] Add remove animation
ClosedPublic
Actions

Authored by broulik on Jan 24 2019, 2:03 PM.

Details

Reviewers
mart
davidedmundson
Group Reviewers
Plasma
Commits
R296:d8505b807d55: [KCM Controls GridView] Add remove animation
Summary

This is what all the grid KCMs have been doing, so it makes sense to put it into the component for consistency and maintainability.
It makes for a much nicer user experience when the view has items that can be deleted.

Test Plan

Animation looks exactly the same as it did before in the KCMs but allows us to remove 15 lines of boilerplate code from each grid kcm in plasma-desktop

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 24 2019, 2:03 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 24 2019, 2:03 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Jan 24 2019, 2:03 PM
davidedmundson accepted this revision.Jan 24 2019, 2:06 PM
This revision is now accepted and ready to land.Jan 24 2019, 2:06 PM
Closed by commit R296:d8505b807d55: [KCM Controls GridView] Add remove animation (authored by broulik). · Explain WhyJan 24 2019, 2:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 50190

View Options

src/qmlcontrols/kcmcontrols/qml/GridView.qml

Loading...