Feed Advanced Search

Mar 24 2019

knauss updated the diff for D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

make parallel network requests.

Mar 24 2019, 2:29 PM · Build System, Frameworks
knauss updated the diff for D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

complete diff.

Mar 24 2019, 12:31 PM · Build System, Frameworks
knauss updated the diff for D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

now with glob matching and another round of renaming blacklist files.

Mar 24 2019, 12:19 PM · Build System, Frameworks

Mar 23 2019

knauss updated the diff for D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

remove BLACKLSIT for httpcheck

Mar 23 2019, 10:17 PM · Build System, Frameworks
knauss updated the diff for D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

add httpupdate and split out blacklist file

Mar 23 2019, 10:14 PM · Build System, Frameworks
knauss added a comment to D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

this would be a nice addition to Krazy. on my todo list.

Mar 23 2019, 9:43 PM · Build System, Frameworks
winterz added a comment to D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

this would be a nice addition to Krazy. on my todo list.

Mar 23 2019, 3:57 PM · Build System, Frameworks
vkrause added inline comments to D19996: WIP Add a global test for insecure http: URLs used in code or documentation.
Mar 23 2019, 3:32 PM · Build System, Frameworks
knauss updated the diff for D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

search for http://\S

Mar 23 2019, 2:07 PM · Build System, Frameworks
cgiboudeaux added inline comments to D19996: WIP Add a global test for insecure http: URLs used in code or documentation.
Mar 23 2019, 2:04 PM · Build System, Frameworks
vkrause added inline comments to D19996: WIP Add a global test for insecure http: URLs used in code or documentation.
Mar 23 2019, 1:58 PM · Build System, Frameworks
knauss updated the diff for D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

add more excludes.

Mar 23 2019, 1:58 PM · Build System, Frameworks
knauss updated the diff for D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

update http regex

Mar 23 2019, 1:51 PM · Build System, Frameworks
knauss updated the diff for D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

update python script.

Mar 23 2019, 1:48 PM · Build System, Frameworks
cgiboudeaux added inline comments to D19996: WIP Add a global test for insecure http: URLs used in code or documentation.
Mar 23 2019, 1:46 PM · Build System, Frameworks
vkrause requested review of D19996: WIP Add a global test for insecure http: URLs used in code or documentation.
Mar 23 2019, 1:33 PM · Build System, Frameworks

Mar 5 2019

dfaure closed D19538: ECMGeneratePkgConfigFile: make all vars dependent on ${prefix}.
Mar 5 2019, 2:40 PM · Build System, Frameworks
apol accepted D19538: ECMGeneratePkgConfigFile: make all vars dependent on ${prefix}.
Mar 5 2019, 1:26 PM · Build System, Frameworks
dfaure added a comment to D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.

Makes sense --> https://phabricator.kde.org/D19538

Mar 5 2019, 10:58 AM · Build System, Frameworks
dfaure requested review of D19538: ECMGeneratePkgConfigFile: make all vars dependent on ${prefix}.
Mar 5 2019, 10:49 AM · Build System, Frameworks

Mar 4 2019

vkrause closed D19486: Add UDev find module.
Mar 4 2019, 8:05 PM · Build System, Frameworks
kossebau added a comment to D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.

FWIW, this still results in inproper pc files, from what I heard recently. The prefix variable can be overriden from outside when calling pkg-config (cmp. pkg-config --help) to allow for relocatable installations. Same like CMake Config files also allow relocation by having the install prefix not hardcoded into directory var values.

Mar 4 2019, 6:51 PM · Build System, Frameworks
dfaure closed D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.
Mar 4 2019, 12:35 PM · Build System, Frameworks
cgiboudeaux accepted D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.

Thanks.

Mar 4 2019, 12:23 PM · Build System, Frameworks
dfaure updated the diff for D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.

Update unittests, passes now

Mar 4 2019, 11:52 AM · Build System, Frameworks
cgiboudeaux added a comment to D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.

The autotest has to be fixed as well

Mar 4 2019, 11:35 AM · Build System, Frameworks
cgiboudeaux requested changes to D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.
Mar 4 2019, 11:27 AM · Build System, Frameworks
cgiboudeaux added a comment to D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.

The autotest has to be fixed as well

Mar 4 2019, 11:27 AM · Build System, Frameworks
fazevedo accepted D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.

Works for me !

Mar 4 2019, 11:20 AM · Build System, Frameworks
dfaure requested review of D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.
Mar 4 2019, 10:26 AM · Build System, Frameworks
vkrause added a comment to D18943: Add Fontconfig find modudle.

What I don't understand though is which FindFontconfig this used to find, there is non in plasma-desktop...

kdelibs4support provides one.

Mar 4 2019, 8:49 AM · Build System, Frameworks
vkrause closed D19499: Restore FindFontconfig backward compatibility for plasma-desktop.
Mar 4 2019, 7:37 AM · Build System, Frameworks

Mar 3 2019

cgiboudeaux accepted D19499: Restore FindFontconfig backward compatibility for plasma-desktop.
Mar 3 2019, 9:31 PM · Build System, Frameworks
kossebau added a comment to D18943: Add Fontconfig find modudle.

What I don't understand though is which FindFontconfig this used to find, there is non in plasma-desktop...

Mar 3 2019, 9:24 PM · Build System, Frameworks
vkrause added a comment to D18943: Add Fontconfig find modudle.

D19499 fixes that here

Mar 3 2019, 9:17 PM · Build System, Frameworks
vkrause requested review of D19499: Restore FindFontconfig backward compatibility for plasma-desktop.
Mar 3 2019, 9:17 PM · Build System, Frameworks
vkrause added a comment to D18943: Add Fontconfig find modudle.

This commit breaks plasma-desktop compilation for me (on ubuntu && arch => undefined refrence in plasma-desktop/kcms/kfontinst).

Mar 3 2019, 9:10 PM · Build System, Frameworks
matthieugras added a comment to D18943: Add Fontconfig find modudle.

This commit breaks plasma-desktop compilation for me (on ubuntu && arch => undefined refrence in plasma-desktop/kcms/kfontinst).

Mar 3 2019, 6:55 PM · Build System, Frameworks
cgiboudeaux accepted D19486: Add UDev find module.
Mar 3 2019, 10:53 AM · Build System, Frameworks
vkrause updated the diff for D19486: Add UDev find module.

Add backward compatibility variables.

Mar 3 2019, 10:38 AM · Build System, Frameworks
cgiboudeaux added a comment to D19486: Add UDev find module.

We probably need to set uppercase variables for the moment. plasma-desktop and powerdevil include the ECM modules dir before their local copy, so any older release would fail to build with ECM >= 5.57

Mar 3 2019, 10:27 AM · Build System, Frameworks
cgiboudeaux added a comment to D19486: Add UDev find module.

We probably need to set uppercase variables for the moment. plasma-desktop and powerdevil include the ECM modules dir before their local copy, so any older release would fail to build with ECM >= 5.57

Mar 3 2019, 10:18 AM · Build System, Frameworks
vkrause closed D18943: Add Fontconfig find modudle.
Mar 3 2019, 9:47 AM · Build System, Frameworks
vkrause requested review of D19486: Add UDev find module.
Mar 3 2019, 9:26 AM · Build System, Frameworks
dfaure requested changes to D15795: Fix warnings about deprecated install dirs.

The warning needs to be removed then. We can't really warn at the time of using a variable.

Mar 3 2019, 12:20 AM · Build System, Frameworks

Mar 2 2019

cgiboudeaux accepted D18943: Add Fontconfig find modudle.

LGTM

Mar 2 2019, 11:57 AM · Build System, Frameworks
vkrause added a comment to D18943: Add Fontconfig find modudle.

ping?

Mar 2 2019, 10:07 AM · Build System, Frameworks

Feb 26 2019

jjazeix added a comment to D19016: Update Android toolchain files to reality.
In D19016#420246, @apol wrote:

Applications can still override it, note it's a default.
Also note this: https://developer.android.com/distribute/best-practices/develop/target-sdk

Feb 26 2019, 3:57 PM · Build System, Frameworks
apol added a comment to D19016: Update Android toolchain files to reality.

Applications can still override it, note it's a default.
Also note this: https://developer.android.com/distribute/best-practices/develop/target-sdk

Feb 26 2019, 2:54 PM · Build System, Frameworks

Feb 25 2019

jjazeix added inline comments to D19016: Update Android toolchain files to reality.
Feb 25 2019, 9:29 PM · Build System, Frameworks

Feb 22 2019

dfaure added a comment to D19075: Fix FindEGL.

If anyone hits a cmake error about "/usr/include/EGL/EGL/egl.h" after updating ECM (e.g. in kwayland or plasma-framework), remove the cache in the builddir and rerun cmake. This commit is actually correct, it's just incompatible with existing caches.

Feb 22 2019, 3:20 PM · Build System, Frameworks
vkrause closed D19223: Fix releaseme checkout when this is included in a sub-directory.
Feb 22 2019, 1:47 PM · Build System, Frameworks
apol accepted D19223: Fix releaseme checkout when this is included in a sub-directory.
Feb 22 2019, 1:31 PM · Build System, Frameworks
vkrause requested review of D19223: Fix releaseme checkout when this is included in a sub-directory.
Feb 22 2019, 12:24 PM · Build System, Frameworks

Feb 20 2019

apol added a comment to D15795: Fix warnings about deprecated install dirs.

Has this been fixed? I haven't seen these warnings

Feb 20 2019, 5:21 PM · Build System, Frameworks
apol added a comment to D17863: Add ecm_check_linker_flags function.

Yep, I'd say let's get it in kstars and if other applications start needing it, we move it to ECM to share.

Feb 20 2019, 5:14 PM · Build System, Frameworks

Feb 19 2019

tcberner closed D19075: Fix FindEGL.
Feb 19 2019, 12:15 PM · Build System, Frameworks
sitter closed D18952: new find module for Canberra.
Feb 19 2019, 9:57 AM · Build System, Frameworks
sitter updated the diff for D18952: new find module for Canberra.

explicitly set FOUND_VAR so it is camelcase too

Feb 19 2019, 9:56 AM · Build System, Frameworks
cgiboudeaux accepted D18952: new find module for Canberra.

Thanks! just a little thing to fix before pushing

Feb 19 2019, 8:09 AM · Build System, Frameworks

Feb 18 2019

vkrause added a comment to D19005: android: don't default to gcc anymore.
In D19005#414313, @apol wrote:

Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be "default_value"?

no, the value is coming from the cache, so that's the one we're setting. What this patch tries to make sure is that we don't forward an empty value (resetting a proper variable to "").

Feb 18 2019, 5:02 PM · Build System, Frameworks
sitter updated the diff for D18952: new find module for Canberra.

fix bad copy paste in compat setup

Feb 18 2019, 4:24 PM · Build System, Frameworks
sitter updated the diff for D18952: new find module for Canberra.
  • pkgconfig is now quiet
  • variables are now camelcase
    • old variables are still set for compat
  • new imported target (also sets pkgconfig's cflags, which I presume is the sane thing to do)
  • set package description url & description
Feb 18 2019, 12:36 PM · Build System, Frameworks
bcooksley added a comment to D19075: Fix FindEGL.

If someone could please trigger all of the Dependency Builds for FreeBSD once this has been landed that would be appreciated: https://build.kde.org/view/Failing/

Feb 18 2019, 9:55 AM · Build System, Frameworks
apol added a comment to D19005: android: don't default to gcc anymore.

Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be "default_value"?

Feb 18 2019, 1:01 AM · Build System, Frameworks
apol accepted D19075: Fix FindEGL.
Feb 18 2019, 12:16 AM · Build System, Frameworks

Feb 17 2019

hausmann accepted D19075: Fix FindEGL.

Thank you:)

Feb 17 2019, 8:47 PM · Build System, Frameworks

Feb 16 2019

vkrause updated the diff for D18943: Add Fontconfig find modudle.

Search for pkgconfig quietly.

Feb 16 2019, 11:30 AM · Build System, Frameworks
cgiboudeaux added inline comments to D18943: Add Fontconfig find modudle.
Feb 16 2019, 11:13 AM · Build System, Frameworks
cgiboudeaux added a comment to D18952: new find module for Canberra.

Yes, imported targets are the future/present :)

Canberra::Canberra sounds good to me as target name

Feb 16 2019, 11:09 AM · Build System, Frameworks
tcberner updated the diff for D19075: Fix FindEGL.

Simply set NAMES EGL/egl.h and fixup the header version check.

Feb 16 2019, 10:51 AM · Build System, Frameworks
tcberner added a comment to D19075: Fix FindEGL.

I think that it should be NAMES EGL/egl.h

Feb 16 2019, 10:47 AM · Build System, Frameworks
hausmann added a comment to D19075: Fix FindEGL.

I think that it should be NAMES EGL/egl.h

Feb 16 2019, 10:20 AM · Build System, Frameworks
aacid added a comment to D18952: new find module for Canberra.

Yes, imported targets are the future/present :)

Feb 16 2019, 9:57 AM · Build System, Frameworks
tcberner updated the diff for D19075: Fix FindEGL.

Store the path gathered via pkgconfig in COMPLETE_EGL_INCLUDE_DIR and
use its parent directory for EGL_INCLUDE_DIR.

Feb 16 2019, 9:57 AM · Build System, Frameworks
hausmann requested changes to D19075: Fix FindEGL.
Feb 16 2019, 8:12 AM · Build System, Frameworks
hausmann added a comment to D19075: Fix FindEGL.

Yeah I think find_path should use the same style as the test program (EGL/egl.h). It is the style of inclusion as per the specification. I think that’s better than the ../ approach.

Feb 16 2019, 8:12 AM · Build System, Frameworks
tcberner added a comment to D19075: Fix FindEGL.

Possibly the returend EGL_INCLUDE_DIR should possibly be stripped of the suffix too, as most will proably include 'EGL/egl.h', and not 'egl.h', I guess?

Feb 16 2019, 7:23 AM · Build System, Frameworks
tcberner added a reviewer for D19075: Fix FindEGL: FreeBSD.
Feb 16 2019, 7:19 AM · Build System, Frameworks
tcberner added a dependency for D19075: Fix FindEGL: D18960: Add compile check to FindEGL.
Feb 16 2019, 7:19 AM · Build System, Frameworks
tcberner added a dependent revision for D18960: Add compile check to FindEGL: D19075: Fix FindEGL.
Feb 16 2019, 7:19 AM · Build System, Frameworks
tcberner requested review of D19075: Fix FindEGL.
Feb 16 2019, 7:18 AM · Build System, Frameworks
bcooksley added a comment to D18960: Add compile check to FindEGL.
/usr/local/bin/gmake -f CMakeFiles/cmTC_fd24d.dir/build.make CMakeFiles/cmTC_fd24d.dir/build
gmake[1]: Entering directory '/usr/home/jenkins/kwayland/build/CMakeFiles/CMakeTmp'
Building CXX object CMakeFiles/cmTC_fd24d.dir/src.cxx.o
/usr/bin/c++   -I/usr/local/include/EGL  -DHAVE_EGL   -o CMakeFiles/cmTC_fd24d.dir/src.cxx.o -c /usr/home/jenkins/kwayland/build/CMakeFiles/CMakeTmp/src.cxx
/usr/home/jenkins/kwayland/build/CMakeFiles/CMakeTmp/src.cxx:2:10: fatal error: 'EGL/egl.h' file not found
#include <EGL/egl.h>
         ^~~~~~~~~~~
1 error generated.
gmake[1]: *** [CMakeFiles/cmTC_fd24d.dir/build.make:66: CMakeFiles/cmTC_fd24d.dir/src.cxx.o] Error 1
gmake[1]: Leaving directory '/usr/home/jenkins/kwayland/build/CMakeFiles/CMakeTmp'
gmake: *** [Makefile:121: cmTC_fd24d/fast] Error 2
Feb 16 2019, 6:17 AM · Build System, Frameworks

Feb 15 2019

vkrause closed D19016: Update Android toolchain files to reality.
Feb 15 2019, 1:05 PM · Build System, Frameworks
apol accepted D19016: Update Android toolchain files to reality.

Thanks!

Feb 15 2019, 12:41 PM · Build System, Frameworks

Feb 14 2019

vkrause added a comment to D19005: android: don't default to gcc anymore.

In fact none of those seem to work here. D19016 works here though, and I suspect that the 14 -> 21 in there should fix ECM on the CI.

Feb 14 2019, 5:32 PM · Build System, Frameworks
vkrause requested review of D19016: Update Android toolchain files to reality.
Feb 14 2019, 5:30 PM · Build System, Frameworks
vkrause added a comment to D19005: android: don't default to gcc anymore.

Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be "default_value"?

Feb 14 2019, 5:22 PM · Build System, Frameworks
vkrause accepted D19005: android: don't default to gcc anymore.
Feb 14 2019, 3:35 PM · Build System, Frameworks
apol requested review of D19005: android: don't default to gcc anymore.
Feb 14 2019, 2:36 PM · Build System, Frameworks
hausmann added a comment to D18960: Add compile check to FindEGL.

Ooops. Could you paste the error from the cmake error output? I'm curious which part of the EGL compile test fails.

Feb 14 2019, 7:55 AM · Build System, Frameworks

Feb 13 2019

tcberner added a comment to D18960: Add compile check to FindEGL.

Seems this is sadly breaking something for FreeBSD though, see
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/21/console

Feb 13 2019, 5:24 PM · Build System, Frameworks
kossebau added a comment to D18960: Add compile check to FindEGL.

Seems this is sadly breaking something for FreeBSD though, see
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/21/console

Feb 13 2019, 5:16 PM · Build System, Frameworks
sitter added a comment to D18952: new find module for Canberra.

Good point, I've also noticed that (all?) our finders now also create an IMPORTED target. Should we maybe add that too? If so I guess Canberra::Canberra would be the preferred target name?

Feb 13 2019, 8:59 AM · Build System, Frameworks
sitter updated the diff for D18952: new find module for Canberra.

document in rst syntax

Feb 13 2019, 8:58 AM · Build System, Frameworks
hausmann closed D18960: Add compile check to FindEGL.
Feb 13 2019, 8:47 AM · Build System, Frameworks

Feb 12 2019

apol accepted D18960: Add compile check to FindEGL.
Feb 12 2019, 6:14 PM · Build System, Frameworks
apol added inline comments to D18952: new find module for Canberra.
Feb 12 2019, 5:43 PM · Build System, Frameworks
vkrause updated the diff for D18943: Add Fontconfig find modudle.

Update indentation, add docs link, remove ancient copy from attic.

Feb 12 2019, 3:59 PM · Build System, Frameworks
vkrause added a comment to D18960: Add compile check to FindEGL.

+1 This makes sense to me, considering how broken some vendor [E]GL stacks are.

Feb 12 2019, 3:50 PM · Build System, Frameworks