In D16223#344018, @mchabrecek wrote:Is it approved and will be landed, or I have to send another arc diff with these 3 adjustments?
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Oct 16 2018
Oct 16 2018
- Fixed spacing
Is it approved and will be landed, or I have to send another arc diff with these 3 adjustments?
You have to make the changes requested by Nikita.
In D16223#343997, @nmel wrote:Thanks and welcome aboard Miroslav!
Thanks and welcome aboard Miroslav!
Looks much better, thanks!
Oct 15 2018
Oct 15 2018
I only skim-read the changes, looks fine.
And Krusader seems to work with the changes.
I have submitted the first patch here regarding signals and slots. It doesn't solve all the connect() statements. There many hundreds of them. I want to do it in more patches. One reason is that this is my first patch to this project. So I didn't work at something for 6 months and then struggle to submit it. It is here, can you check it? https://phabricator.kde.org/D16223.
Oct 11 2018
Oct 11 2018
gengisdave updated the diff for D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.
I thought I had already committed that... changed to a more human macro name
Oct 9 2018
Oct 9 2018
Thank you for help,
Oct 7 2018
Oct 7 2018
asensi added a comment to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.
Maybe a visual hint would be good so that the users know this feature exists.
asensi updated the diff for D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.
Some changes were made after Alex Bikadorov made some propositions.
asensi updated the diff for D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.
Some changes were made after Alex Bikadorov made some propositions.
Oct 6 2018
Oct 6 2018
Hello,
I started to work on replacing old connect() wih Qt5 syntax.
Alex wrote me that it would be the best to do automatically by some script, I don't see it realistic.
There are some tricky cases, which I don't know how to convert. May be you can help me.
Oct 4 2018
Oct 4 2018
abika requested changes to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.
Deletion was working as expected during tests. Maybe a visual hint would be good so that the users know this feature exists.
Oct 2 2018
Oct 2 2018
Since INSERT becomes kind of "global" macro, I suggest we rename it to UDS_ENTRY_INSERT, since the insert word is too generic while the implementation is not. Thanks!
Sep 28 2018
Sep 28 2018
Sep 23 2018
Sep 23 2018
asensi updated the diff for D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.
Another address was updated
Sep 22 2018
Sep 22 2018
asensi updated the diff for D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.
An address was updated
asensi updated the diff for D15678: Solve a memory leak in the Locate dialog, achieve that its destructor is able to work, and so on.
Thanks, Nikita, those lines will be added to the commit message:
FIXED: Memory leak in the Locate dialog Differential Revision: https://phabricator.kde.org/D15678
Confirmed by the build (https://build.kde.org/job/Extragear/job/krusader/job/kf5-qt5%20FreeBSDQt5.11/4/warnings12Result/), 51 warnings fixed and 'missing-override' is not in the remaining 57.
Confirmed by the build (https://build.kde.org/job/Extragear/job/krusader/job/kf5-qt5%20FreeBSDQt5.11/4/warnings12Result/), 51 warnings fixed and 'missing-override' is not in the remaining 57.
Thanks Davide! This looks less cluttered.
nmel accepted D15678: Solve a memory leak in the Locate dialog, achieve that its destructor is able to work, and so on.
Thanks Toni!
In D15400#328384, @gengisdave wrote:every user is a tester too.
More importantly, whenever we make a change after this is merged, we will see the warning and fix the code. We put an effort before v2.7 release to make Krusader warning-free and we should keep it this way. So now the -Wsuggest-override is on the list of warning directives that we track. Thanks Davide (and Toni ;) )!
Sep 21 2018
Sep 21 2018
asensi updated the test plan for D15678: Solve a memory leak in the Locate dialog, achieve that its destructor is able to work, and so on.
The new version works using Kubuntu 18.04. Other people can do their checks. Thanks, Davide! (and Nikita :-) )
Sep 19 2018
Sep 19 2018
gengisdave updated the diff for D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.
Changed in favor of a macro solution (as suggested by Nikita).
gengisdave added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.
In D15376#325404, @asensi wrote:What do you think about creating a specialized version of UDSEntry, e.g. KrUDSEntry? This way the code:
Added flag for GCC as default
I've looked at the Clang behaviour: the -Winconsistent-missing-override flag is always set (Debug, Release and none), so GCC should be set the same. My initial thought was to not users to be worried; on a second thought, every user is a tester too.
Sep 15 2018
Sep 15 2018
Why not to update the flags for both debug and release (CMAKE_CXX_FLAGS var)? What's your reasoning? Does it hurt the release build?
Sep 14 2018
Sep 14 2018
I've tested with clang compiler and no additional flags are needed, on a clean Fedora 28 I used:
Sep 13 2018
Sep 13 2018
Thanks Davide! (and Nikita :-) )
It's nice to hear from you again, Davide!
Indeed, all warnings of this type are fixed. Thanks Davide!
In D15376#324514, @gengisdave wrote:Where to put the macro? The three files don't have a common header file and I haven't found a suitable .h file; any advice?
Sep 12 2018
Sep 12 2018
gengisdave added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.
The use of a Macro was my second way to solve this, but I thought it would add more complexity to the code; instead, this patch makes the code unclear to read.
I updated the diff to v2 to fix spaces as requested.
and reproducible adding -Wsuggest-override or -Winconsistent-missing-override (not sure, haven't tested with clang) to CMAKE_CXX_FLAGS
Should we add this into cmake config file to ensure that these flags are always on?
inline
Sep 10 2018
Sep 10 2018
Sep 9 2018
Sep 9 2018
gengisdave requested review of D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.
Sep 4 2018
Sep 4 2018
In T9581#158530, @abika wrote:My concern now is this: If you put effort in creating a Windows package for Krusader and there will be bugs (I bet there will), there should be someone working on it. Unfortunately we already don't have enough developer time to solve the >100 open bugs currently open for Krusader. And support for Windows will come on top of that. I would like to avoid a half working Windows version which will never be "stable" and that the effort will be for nothing.
Regarding background: You might want to read the blog posts here: http://kfunk.org/tag/kde-windows/ -- specifically: http://kfunk.org/2016/06/18/kde-on-windows-update/
Sep 3 2018
Sep 3 2018
Hi Lydia and everyone else,
Thank you very much for all, Lydia, although as far as Krusader developers know, there is no Windows version of Krusader (contributions are very welcome :-)).
Sep 2 2018
Sep 2 2018
Aug 23 2018
Aug 23 2018
Aug 17 2018
Aug 17 2018
Aug 16 2018
Aug 16 2018
Aug 15 2018
Aug 15 2018
Aug 14 2018
Aug 14 2018
Aug 13 2018
Aug 13 2018
For future reference, the commits may be seen in:
Aug 12 2018
Aug 12 2018
pushed. Forgot to include the link to this Diff in the commit message:/
Aug 9 2018
Aug 9 2018
It looks right to me :-)
For my part, I accept the proposal, thanks :-)
Aug 5 2018
Aug 5 2018
Apply to stable branch. This will go after changelog / news update commits.
- updated documentation ChangeLog
Jul 29 2018
Jul 29 2018
In D14416#299836, @nmel wrote:Hi Pino, Thanks for the suggestion. I didn't know about the tool. I briefly read the doc and found
Updating the configuration happens automatically, either when KDE gets started or when kded detects a new update file in the above mentioned location.
which means non-KDE users are out of luck. Am I right?
Thanks Toni! Works nicely.
In D14416#299821, @pino wrote:Or, even better, use kconf_update to automatically migrate the setting to the new name, with no need to add fallback code to the application itself.
See https://techbase.kde.org/Development/Tools/Using_kconf_update
You can find examples of scripts for kconf_update in many applications, e.g. kmail, konversation, kontact, okular, tellico, kget, kcalc, akregator, gwenview, kile, etc.
Or, even better, use kconf_update to automatically migrate the setting to the new name, with no need to add fallback code to the application itself.
See https://techbase.kde.org/Development/Tools/Using_kconf_update
You can find examples of scripts for kconf_update in many applications, e.g. kmail, konversation, kontact, okular, tellico, kget, kcalc, akregator, gwenview, kile, etc.
Please also add FIXED: tag. See https://phabricator.kde.org/w/krusader/#commit-patch-guidelines
Please add fallback logic for the old setting. We can deprecate the fallback code with 2.9+ release.
Jul 28 2018
Jul 28 2018