Replace "sensative" with "sensitive" in several places
Needs RevisionPublic

Authored by szafar on Jul 27 2018, 3:17 AM.

Details

Reviewers
yurchor
nmel
Group Reviewers
Krusader
Summary

s/sensative/sensitive

BUG: 396869

Test Plan

Change the sort order, review the consequences in several cases. See what happens with the "Case Sensitive Sort" preference (and the old "Case Sensative Sort" one) in the "krusaderrc" file, in several cases.

Diff Detail

Repository
R167 Krusader
Branch
bug-sensitive
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1234
Build 1248: arc lint + arc unit
szafar requested review of this revision.Jul 27 2018, 3:17 AM
szafar created this revision.
asensi added a subscriber: asensi.Jul 28 2018, 7:36 AM

Hi Shadab,

I've tried the source code and it seems to work as it was expected. However, as it's written in https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages : in the diff a "BUG: <bugnumber>" line should exist, and finally a "Differential Revision: https://phabricator.kde.org/D<number>" line. You can add those lines after executing git commit -a, and with e.g. git show > file.diff the diff file would contain those messages.

asensi retitled this revision from BUG: 396869 to Replace "sensative" with "sensitive" in several places.Jul 28 2018, 7:45 AM
asensi edited the summary of this revision. (Show Details)
asensi edited the test plan for this revision. (Show Details)
asensi added a reviewer: Krusader.
asensi added a project: Krusader.
asensi added a subscriber: Krusader.
yurchor accepted this revision as: yurchor.Jul 28 2018, 7:47 AM
This revision is now accepted and ready to land.Jul 28 2018, 7:47 AM
nmel requested changes to this revision.Jul 29 2018, 4:48 AM
nmel added a subscriber: nmel.

Please add fallback logic for the old setting. We can deprecate the fallback code with 2.9+ release.

krusader/Panel/PanelView/krview.cpp
235

Would you please add the code to read old "Case Sensative Sort" and apply if it's set? This will ensure smooth config migration.

This revision now requires changes to proceed.Jul 29 2018, 4:48 AM
pino added a subscriber: pino.Jul 29 2018, 4:58 AM

Or, even better, use kconf_update to automatically migrate the setting to the new name, with no need to add fallback code to the application itself.
See https://techbase.kde.org/Development/Tools/Using_kconf_update
You can find examples of scripts for kconf_update in many applications, e.g. kmail, konversation, kontact, okular, tellico, kget, kcalc, akregator, gwenview, kile, etc.

nmel added a comment.Jul 29 2018, 5:36 AM
In D14416#299821, @pino wrote:

Or, even better, use kconf_update to automatically migrate the setting to the new name, with no need to add fallback code to the application itself.
See https://techbase.kde.org/Development/Tools/Using_kconf_update
You can find examples of scripts for kconf_update in many applications, e.g. kmail, konversation, kontact, okular, tellico, kget, kcalc, akregator, gwenview, kile, etc.

Hi Pino, Thanks for the suggestion. I didn't know about the tool. I briefly read the doc and found

Updating the configuration happens automatically, either when KDE gets started or when kded detects a new update file in the above mentioned location.

which means non-KDE users are out of luck. Am I right?

pino added a comment.Jul 29 2018, 6:03 AM
In D14416#299836, @nmel wrote:

Hi Pino, Thanks for the suggestion. I didn't know about the tool. I briefly read the doc and found

Updating the configuration happens automatically, either when KDE gets started or when kded detects a new update file in the above mentioned location.

which means non-KDE users are out of luck. Am I right?

I don't think so, but better ask to some mailing list (e.g. kde-core-devel or kde-devel), since the last time I did stuff with kconf_update was many years ago...