Update icon size after the user changed it on Konfigurator
ClosedPublic
Actions

Authored by gengisdave on May 5 2020, 6:49 PM.

Details

Reviewers

yurchor
asensi

Group Reviewers

Krusader

Commits

R167:fca9e0fe4ccb: Update icon size after the user changed it on Konfigurator

Summary

When the user changes the icon size (brief or detailed view) on Konfigurator, all panels are not update. Krusader has to be restarted or the user must change view mode.

This patch force icon size after it was changed in Konfigurator.

Possible regression : as isGUIRestartNeeded is shared between all Konfigurator pages, another page requesting config refresh will cause icon size to be reset. The solution is emitting a separate signal.

FIXED: [ 391996 ] krusader config , after setted filelist icon size , user must switch viewmode (Brief/Detail) then krusader does.
BUG: 391996

Test Plan

No specific test. Icon size must change only when it's changed from Konfigurator.

Diff Detail

Repository

R167 Krusader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

gengisdave requested review of this revision.May 5 2020, 6:49 PM

gengisdave created this revision.

gengisdave edited the summary of this revision. (Show Details)May 5 2020, 6:53 PM

Works as expected for me. Thanks.

This revision is now accepted and ready to land.May 6 2020, 2:48 PM

Thanks, Davide! (and Yuri :-) ) The resulting code worked under Kubuntu 18.04 and Kubuntu 20.04, using the brief and the detailed view. Other people can do their checks.

asensi added inline comments.May 9 2020, 1:42 PM

krusader/Konfigurator/kgpanel.cpp
753	Could we reword the comment it so that it becomes clearer for developers? For example: We read the IconSize config file before and after applying the change, to see if it really changed