Add options for hiding some useless entries from Media Menu
Needs ReviewPublic

Authored by S-trace on Thu, Mar 26, 10:18 AM.

Details

Reviewers
None
Group Reviewers
Krusader
Summary

Add "Ignore SquashFS" option to the "Panel/Media Menu/" settings page:
Snap creates many SquashFS-mounted partitions, which are almost
useless in the Media Menu, because snap manages them.
So, let's allow the user to hide SquashFS mounts from the Media Menu

Add the list of mount points hidden in Media Menu to the "Panel/Media Menu/" page:
I'm using Media Menu for quick mount/umount of removable media or
normally umounted fixed media, and don't want to see in the Media Menu any
obliviously non-umountable partitions like / and /home - so, let's allow
user to hide some media by the mount point.

Test Plan
  1. Mount a SquashFS image
  2. Make sure SquashFS image mount is shown in the Media Menu
  3. Check "Hide SquashFS entries" checkbox on the "Panel/Media Menu/" page
  4. Make sure SquashFS image mount is no longer shown in the Media Menu
  5. Uncheck "Hide SquashFS entries" checkbox on the "Panel/Media Menu/" page
  6. Make sure SquashFS image mount is shown again in the Media Menu
  1. Make sure the root mount point is shown in Media Menu
  2. Add / to "Hide following mountpoints:" list on the "Panel/Media Menu/" page
  3. Make sure the root mount point is not shown in the Media Menu anymore
  4. Remove / from "Hide following mountpoints:" list on the "Panel/Media Menu/" page
  5. Make sure the root mount point is shown again in the Media Menu

Diff Detail

Repository
R167 Krusader
Lint
Lint Skipped
Unit
Unit Tests Skipped
S-trace requested review of this revision.Thu, Mar 26, 10:18 AM
S-trace created this revision.
S-trace updated this revision to Diff 78531.Thu, Mar 26, 10:32 AM
S-trace retitled this revision from Add "Ignore SquashFS" option to the "Panel/Media Menu/" settings page to Add options for hiding some useless entries from Media Menu.
S-trace edited the summary of this revision. (Show Details)
S-trace edited the test plan for this revision. (Show Details)

Add the list of mount points to hide in Media Menu to the "Panel/Media Menu/" page

I'm using Media Menu for quick mount/umount of removable media or normally umounted fixed media, and don't want to see in the Media Menu any obliviously non-umountable partitions like / and /home - so, let's allow the user to hide some media by the mount point.

My list to hide:
/
/boot/efi
/boot
/home

S-trace updated this revision to Diff 78533.Thu, Mar 26, 10:35 AM

Merge 2 features into a single diff

yurchor added inline comments.
krusader/GUI/mediabutton.cpp
173

Can it be some kind of

qDebug() << "isMountPointHidden is called for " << mountPoint;

?
Thanks in advance for your answer.

S-trace added inline comments.Thu, Mar 26, 11:05 AM
krusader/GUI/mediabutton.cpp
173

Oh, of course.
Forgot to remove this line.
How do you think, do we need this line in any form?

yurchor added inline comments.Thu, Mar 26, 11:09 AM
krusader/GUI/mediabutton.cpp
173

I'm not sure. I'm just a documentation maintainer of the project. Let's see what our developers think... ;)

S-trace edited the test plan for this revision. (Show Details)Thu, Mar 26, 5:02 PM