Differential D29429

Konfigurator: Avoid some duplications
ClosedPublic
Actions

Authored by asensi on May 4 2020, 9:07 PM.

Details

Reviewers
gengisdave
yurchor
Group Reviewers
Krusader
Maniphest Tasks
T13133: Konfigurator: Improve management of tooltips and “What's This” help
Commits
R167:e50593f5f332: Konfigurator: Avoid some duplications
Summary

Use a variable in order to avoid duplications (to prevent e.g. that one text is changed, but not a copy of it).

Test Plan

The test plan of the task defined in https://phabricator.kde.org/T13133

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
asensi requested review of this revision.May 4 2020, 9:07 PM
asensi created this revision.
gengisdave accepted this revision.May 4 2020, 9:14 PM
gengisdave added a subscriber: gengisdave.

Fine to me, please add a TODO to move the tooltip association inside createSpinBox() (eventually with the related QLabel)

This revision is now accepted and ready to land.May 4 2020, 9:14 PM
yurchor accepted this revision.May 5 2020, 6:42 AM
yurchor added a subscriber: yurchor.

Thanks, works as expected.

asensi retitled this revision from Avoid duplications using a variable to Konfigurator: Avoid some duplications.May 8 2020, 8:53 PM
asensi edited the test plan for this revision. (Show Details)
asensi added a task: T13133: Konfigurator: Improve management of tooltips and “What's This” help.
asensi added a comment.May 8 2020, 8:56 PM

Thanks for testing and informing, Yuri and Davide!

Closed by commit R167:e50593f5f332: Konfigurator: Avoid some duplications (authored by asensi). · Explain WhyMay 8 2020, 8:58 PM
This revision was automatically updated to reflect the committed changes.
asensi added a comment.May 8 2020, 9:03 PM
In D29429#663490, @gengisdave wrote:

Fine to me, please add a TODO to move the tooltip association inside createSpinBox() (eventually with the related QLabel)

All right, now that Add options for hiding some useless entries from Media Menu is committed (because inside its code there were changes to Konfigurator), it's a good time to apply changes to Konfigurator code (as it's not planned to be changed soon).

To achieve that, I created a task: Konfigurator: Improve management of tooltips and “What's This” help.

Revision Contents
Changeset List

Diff 82318

View Options

krusader/Konfigurator/kgadvanced.cpp

Loading...