Feed Advanced Search

Thu, Oct 24

nicolamori added a watcher for Amarok: nicolamori.
Thu, Oct 24, 11:40 AM

Sep 21 2019

jyasi added a watcher for Amarok: jyasi.
Sep 21 2019, 2:14 PM

Sep 9 2019

mfraser added a watcher for Amarok: mfraser.
Sep 9 2019, 8:38 PM

Jul 5 2019

ryanmccoskrie added a member for Amarok: ryanmccoskrie.
Jul 5 2019, 6:53 AM
ryanmccoskrie added a watcher for Amarok: ryanmccoskrie.
Jul 5 2019, 6:53 AM

Jun 1 2019

semareit added a watcher for Amarok: semareit.
Jun 1 2019, 11:00 AM

Apr 22 2019

James added a watcher for Amarok: James.
Apr 22 2019, 2:34 PM

Feb 23 2019

domson added a watcher for Amarok: domson.
Feb 23 2019, 1:12 AM

Jan 5 2019

cochise removed a watcher for Amarok: cochise.
Jan 5 2019, 7:26 AM

Oct 21 2018

eridani added a watcher for Amarok: eridani.
Oct 21 2018, 11:43 PM

Jun 6 2018

eoinoneill added a watcher for Amarok: eoinoneill.
Jun 6 2018, 7:27 AM

Apr 28 2018

markey closed D12492: Fixed fadebars.
Apr 28 2018, 2:09 PM · Amarok
markey accepted D12492: Fixed fadebars.
Apr 28 2018, 2:09 PM · Amarok

Apr 24 2018

malteveerman updated the diff for D12492: Fixed fadebars.

Cleaned up some includes.

Apr 24 2018, 12:44 PM · Amarok
malteveerman updated the diff for D12492: Fixed fadebars.

Added some performance optimizations to the analyzer applet.

Apr 24 2018, 12:20 PM · Amarok
malteveerman requested review of D12492: Fixed fadebars.
Apr 24 2018, 10:06 AM · Amarok

Apr 21 2018

markey closed D12316: Some analyzer applet tweaks.
Apr 21 2018, 1:04 PM · Amarok
markey accepted D12316: Some analyzer applet tweaks.
Apr 21 2018, 1:04 PM · Amarok
markey closed D12315: Fixed crash at shutdown.
Apr 21 2018, 1:01 PM · Amarok
markey accepted D12315: Fixed crash at shutdown.
Apr 21 2018, 12:40 PM · Amarok

Apr 18 2018

malteveerman updated the diff for D12315: Fixed crash at shutdown.

Removed unnecessary volatile

Apr 18 2018, 7:33 PM · Amarok
anthonyfieroni added inline comments to D12315: Fixed crash at shutdown.
Apr 18 2018, 6:38 PM · Amarok
malteveerman requested review of D12316: Some analyzer applet tweaks.
Apr 18 2018, 4:29 PM · Amarok
malteveerman requested review of D12315: Fixed crash at shutdown.
Apr 18 2018, 4:25 PM · Amarok

Apr 15 2018

markey closed D12223: Improvements to CurrentTrack applet.
Apr 15 2018, 1:52 PM · Amarok
markey accepted D12223: Improvements to CurrentTrack applet.
Apr 15 2018, 1:51 PM · Amarok
malteveerman requested review of D12223: Improvements to CurrentTrack applet.
Apr 15 2018, 12:22 PM · Amarok

Apr 12 2018

markey closed D11968: More interface stuttering work.
Apr 12 2018, 4:32 PM · Amarok
markey accepted D11968: More interface stuttering work.
Apr 12 2018, 4:31 PM · Amarok

Apr 11 2018

malteveerman updated the diff for D11968: More interface stuttering work.

Added a few random improvements and compilation warning fixes.

Apr 11 2018, 5:24 PM · Amarok

Apr 5 2018

malteveerman updated the diff for D11170: Use new kpackage_install_bundled_package macro.

Just a rebase.

Apr 5 2018, 8:49 PM
malteveerman requested review of D11968: More interface stuttering work.
Apr 5 2018, 6:01 PM · Amarok
malteveerman added a comment to D11862: Get rid of scripting.

See, the problem with removing features like this is, there will be a huge outcry from users. That's guaranteed, even without knowing for sure how much the scripting feature is really used in the wild.

I was discussing about this with Heiko. Maybe QtScript could be replaced with QJSEngine, similar to how the following patch for another project attempts to do it?

https://phabricator.kde.org/D7033

Apr 5 2018, 1:39 PM · Amarok

Apr 4 2018

markey added a comment to D11862: Get rid of scripting.

See, the problem with removing features like this is, there will be a huge outcry from users. That's guaranteed, even without knowing for sure how much the scripting feature is really used in the wild.

Apr 4 2018, 6:42 PM · Amarok
markey closed D11868: Reduce interface stuttering.
Apr 4 2018, 5:13 PM · Amarok
markey accepted D11868: Reduce interface stuttering.
Apr 4 2018, 5:13 PM · Amarok
markey closed D11867: Logger overhaul.

Pushed to master.

Apr 4 2018, 4:54 PM · Amarok
markey accepted D11867: Logger overhaul.
Apr 4 2018, 4:35 PM · Amarok

Apr 1 2018

malteveerman updated the diff for D11868: Reduce interface stuttering.

Put some more image savings out of the GUI thread.

Apr 1 2018, 11:13 PM · Amarok
malteveerman requested review of D11868: Reduce interface stuttering.
Apr 1 2018, 5:15 PM · Amarok
malteveerman requested review of D11867: Logger overhaul.
Apr 1 2018, 4:39 PM · Amarok
malteveerman requested review of D11862: Get rid of scripting.
Apr 1 2018, 3:20 PM · Amarok
markey closed D11788: Fixed wrong slot signatures in BrowserMessageArea.
Apr 1 2018, 1:58 PM · Amarok
markey accepted D11788: Fixed wrong slot signatures in BrowserMessageArea.
Apr 1 2018, 1:57 PM · Amarok
markey closed D11787: Small MySQL libraries fix for tests..
Apr 1 2018, 1:48 PM · Amarok
markey accepted D11787: Small MySQL libraries fix for tests..
Apr 1 2018, 1:47 PM · Amarok

Mar 30 2018

jackyalcine added a watcher for Amarok: jackyalcine.
Mar 30 2018, 8:19 PM

Mar 29 2018

malteveerman requested review of D11788: Fixed wrong slot signatures in BrowserMessageArea.
Mar 29 2018, 7:10 PM · Amarok
malteveerman requested review of D11787: Small MySQL libraries fix for tests..
Mar 29 2018, 5:02 PM · Amarok

Mar 26 2018

heikobecker closed D11710: Workaround for clang bug 23029.
Mar 26 2018, 8:11 PM · Amarok
heikobecker accepted D11710: Workaround for clang bug 23029.

Thanks!

Mar 26 2018, 8:11 PM · Amarok
malteveerman requested review of D11710: Workaround for clang bug 23029.
Mar 26 2018, 10:08 AM · Amarok
malteveerman added a comment to D11534: Some small changes and fixes.

There seems to be a bug in clang. But it doesn't seem to get fixed anytime soon. I'll write a workaround.

Mar 26 2018, 1:49 AM · Amarok

Mar 25 2018

heikobecker added inline comments to D11534: Some small changes and fixes.
Mar 25 2018, 5:58 PM · Amarok
markey closed D11534: Some small changes and fixes.
Mar 25 2018, 4:47 PM · Amarok
markey accepted D11534: Some small changes and fixes.
Mar 25 2018, 4:47 PM · Amarok

Mar 20 2018

malteveerman requested review of D11534: Some small changes and fixes.
Mar 20 2018, 11:10 PM · Amarok
markey closed D11349: Reactivate wikipedia applet.
Mar 20 2018, 3:57 PM · Amarok
malteveerman added a comment to D11349: Reactivate wikipedia applet.

I managed to fix the issue with missing QtWebEngine but I'm not sure what I can do about the missing qml module. Isn't it part of the WebEngine package?

Mar 20 2018, 8:07 AM · Amarok
malteveerman updated the diff for D11349: Reactivate wikipedia applet.

Fixed issue with missing optional dependency Qt5WebEngine.

Mar 20 2018, 8:07 AM · Amarok
markey requested changes to D11349: Reactivate wikipedia applet.

Generally this works for me now, but there are two more issues that I found:

Mar 20 2018, 4:12 AM · Amarok

Mar 18 2018

malteveerman updated the diff for D11349: Reactivate wikipedia applet.

Changed fileUrl() to filePath(). Builds now with older KPackage.

Mar 18 2018, 8:19 PM · Amarok
heikobecker added a comment to D11349: Reactivate wikipedia applet.

The method is only available since kpackage-5.42.0.

Mar 18 2018, 7:19 PM · Amarok
markey requested changes to D11349: Reactivate wikipedia applet.

Fails to build here:

Mar 18 2018, 6:43 PM · Amarok

Mar 15 2018

malteveerman requested review of D11349: Reactivate wikipedia applet.
Mar 15 2018, 10:21 AM · Amarok

Mar 14 2018

markey closed D11299: Fixed a crash in magnatune service.
Mar 14 2018, 7:22 PM · Amarok
markey accepted D11299: Fixed a crash in magnatune service.
Mar 14 2018, 7:21 PM · Amarok
markey closed D11171: Port NetworkAccessManager to new signal/slot syntax.
Mar 14 2018, 7:18 PM · Amarok
markey accepted D11171: Port NetworkAccessManager to new signal/slot syntax.
Mar 14 2018, 7:18 PM · Amarok

Mar 13 2018

malteveerman updated the diff for D11171: Port NetworkAccessManager to new signal/slot syntax.

Previous diff relied on a function of QMetaObject added in Qt 5.10. This now works with older versions of Qt, too.

Mar 13 2018, 9:04 PM · Amarok
malteveerman requested review of D11299: Fixed a crash in magnatune service.
Mar 13 2018, 8:57 PM · Amarok
markey closed D11192: Ported playdar collection away from qjson.
Mar 13 2018, 7:31 PM · Amarok
markey accepted D11192: Ported playdar collection away from qjson.
Mar 13 2018, 7:30 PM · Amarok
markey requested changes to D11171: Port NetworkAccessManager to new signal/slot syntax.

This does not build for me (GCC 7.2.0).

Mar 13 2018, 7:23 PM · Amarok

Mar 11 2018

heikobecker closed D11169: Another QUrl fix.
Mar 11 2018, 9:35 PM · Amarok
heikobecker accepted D11169: Another QUrl fix.
Mar 11 2018, 9:34 PM · Amarok
arojas closed D11239: Fix build with Qt 5.11.
Mar 11 2018, 8:46 PM · Amarok
heikobecker accepted D11239: Fix build with Qt 5.11.
Mar 11 2018, 8:10 PM · Amarok
arojas requested review of D11239: Fix build with Qt 5.11.
Mar 11 2018, 5:36 PM · Amarok

Mar 10 2018

malteveerman updated the diff for D11192: Ported playdar collection away from qjson.

Fixed hang on shutdown

Mar 10 2018, 3:57 PM · Amarok

Mar 9 2018

malteveerman requested review of D11192: Ported playdar collection away from qjson.
Mar 9 2018, 8:12 PM · Amarok
malteveerman added a comment to D11170: Use new kpackage_install_bundled_package macro.

While I personally have no problem with requiring 5.41.0, it's maybe a bit new. Apparently the current Ubuntu doesn't have it and we should possibly wait until 18.04 is released (26.04.)

Mar 9 2018, 7:16 PM
heikobecker added a comment to D11170: Use new kpackage_install_bundled_package macro.

While I personally have no problem with requiring 5.41.0, it's maybe a bit new. Apparently the current Ubuntu doesn't have it and we should possibly wait until 18.04 is released (26.04.)

Mar 9 2018, 4:52 PM
malteveerman moved T2738: KSharedPtr conversion from Work in Progress to Done on the Amarok board.
Mar 9 2018, 10:31 AM · Amarok
malteveerman moved T2723: Build back support for center widgets in the application from Work in Progress to Done on the Amarok board.
Mar 9 2018, 10:30 AM · Amarok
malteveerman requested review of D11171: Port NetworkAccessManager to new signal/slot syntax.
Mar 9 2018, 9:11 AM · Amarok
malteveerman requested review of D11170: Use new kpackage_install_bundled_package macro.
Mar 9 2018, 9:05 AM
malteveerman requested review of D11169: Another QUrl fix.
Mar 9 2018, 8:56 AM · Amarok
markey closed D11150: Use Kirigami's spacing and icon sizes and remove own implementation.
Mar 9 2018, 3:49 AM · Amarok
markey accepted D11150: Use Kirigami's spacing and icon sizes and remove own implementation.

Kirigami2 seems really nifty. Nice choice.

Mar 9 2018, 3:48 AM · Amarok

Mar 8 2018

malteveerman requested review of D11150: Use Kirigami's spacing and icon sizes and remove own implementation.
Mar 8 2018, 9:51 AM · Amarok

Mar 7 2018

nhuisman added a watcher for Amarok: nhuisman.
Mar 7 2018, 9:12 PM
markey added a comment to T8078: Port away from libmysqld (embedded server).

Just a note: Back in the day Amarok was actually using SQLite, but there were major performance issues for people with giant collections. E.g. I was just talking to a user on IRC with a 44k tracks collection.

Mar 7 2018, 7:09 PM · Amarok
markey closed D11033: Fix some deprecation warnings.
Mar 7 2018, 7:03 PM · Amarok
markey accepted D11033: Fix some deprecation warnings.
Mar 7 2018, 7:02 PM · Amarok

Mar 6 2018

heikobecker closed T2698: Tests for KF5 version as Resolved.

Fixed with df9fc58c8ac5ea2c8ed64f8d15ee87bab1af6681

Mar 6 2018, 10:15 PM · Amarok

Mar 5 2018

asturmlechner added a comment to T8078: Port away from libmysqld (embedded server).

Thanks, that's very good news :)

Mar 5 2018, 11:01 PM · Amarok
markey closed D10923: Make Webkit optional.
Mar 5 2018, 7:48 PM · Amarok
markey accepted D10923: Make Webkit optional.
Mar 5 2018, 7:48 PM · Amarok
markey closed D10924: Disable Discogs and Google cover search temporarily.
Mar 5 2018, 7:46 PM · Amarok