Fix copying and moving files to collection
ClosedPublic
Actions

Authored by pgomes on Apr 5 2020, 1:30 PM.

Details

Reviewers

amarok-devel
heikobecker

Group Reviewers

Amarok

Commits

R181:96eaac4fc099: Fix copying and moving files to collection

Summary

The importation of files to collections was not working. Both because its dialogs were crashing and because the copying method was wrong. This patch does the following:

fix the crash of confirmation dialog when either accepting or rejecting the import. The crash was caused because a "detroyed" signal was being used at a chain of deleted widgets, eventually causing a crash signal
fix the file copying (SqlCollectionLocation.cpp). The code was using a QURL (with the "file:///" scheme) to locate the destination, and thus failing to find the destination dir
fix the layout of Transcoding dialog. Before the buttonbox was doubled, and only the KPageDialog was being show. And was overlapped by another widget
fix the layout of the importation configuration menu (OrganizeCollectionDialog). Before the QDialog didn't have a layout, and resizing the window was not resizing widgets
restore the importation menu to "Copy to Collection". Before only "Move to Collection" was popping up an importation dialog. The reason was a wrong connection of signals

Diff Detail

Repository

R181 Amarok

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

pgomes requested review of this revision.Apr 5 2020, 1:30 PM

pgomes created this revision.

pgomes created this object with edit policy "Administrators".

heikobecker accepted this revision.Apr 11 2020, 11:00 AM

heikobecker added a subscriber: heikobecker.

heikobecker added inline comments.

src/widgets/TokenDropTarget.cpp
211	Any particular reason to change this? Admittedly it doesn't really matter, given nothing is promoted as external library.

This revision is now accepted and ready to land.Apr 11 2020, 11:00 AM

Oh, and although it was closed because of a missing backtrace it looks like this would fix: https://bugs.kde.org/show_bug.cgi?id=411716

Closed by commit R181:96eaac4fc099: Fix copying and moving files to collection (authored by pgomes). · Explain WhyApr 11 2020, 3:10 PM

This revision was automatically updated to reflect the committed changes.

In D28593#645766, @heikobecker wrote:

Oh, and although it was closed because of a missing backtrace it looks like this would fix: https://bugs.kde.org/show_bug.cgi?id=411716

Yes, this seems to be the same issue. I have added a ref to that at the commit message

pgomes marked an inline comment as done.Apr 11 2020, 3:13 PM

pgomes added inline comments.

src/widgets/TokenDropTarget.cpp
211	No particular reason. I reverted that at the final commit

Revision Contents
Changeset List

			Path	Packages
M			src/browsers/filebrowser/FileView.cpp (2 lines)
M			src/core-impl/collections/db/sql/SqlCollectionLocation.cpp (2 lines)
M			src/dialogs/OrganizeCollectionDialog.cpp (12 lines)
M			src/transcoding/TranscodingAssistantDialog.cpp (9 lines)
M			src/transcoding/TranscodingAssistantDialog.ui (2 lines)
M			src/transcoding/TranscodingPropertySliderWidget.cpp (4 lines)
M			src/widgets/TokenDropTarget.cpp (5 lines)