cochise (Cochise César)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Dec 23 2016, 9:20 PM (150 w, 6 d)
Availability
Available

Recent Activity

Feb 17 2019

cochise added a comment to D17816: Support for xattrs on kio copy/move.

My vacancies ended and I'm making the annual planning for my classes, so I will be busy for at least two weeks, but I plan to work on the subjob bug as soon my schedule allows it.

Feb 17 2019, 7:15 PM · Frameworks

Feb 3 2019

cochise added a comment to D17816: Support for xattrs on kio copy/move.

Can we ship it, or using a subjob on KIO::copy is mandatory here?

Feb 3 2019, 4:10 PM · Frameworks

Jan 17 2019

cochise added a comment to D17816: Support for xattrs on kio copy/move.

I'm not sure why the tests fail, and the tests failing are unrelated to xattrs. I think there is some problem in queuing the subjobs and ensuring they all have finished.
After the copy job is finished, the copyLocalDirectory test can't find the file inside the copied test directory. Manually testing recursive copy I can't find problems, but the autotest fail. So, I think some parts of the copy job are executed after the copyjob finishes if I add a subjob.
As I said, we can use start, instead of exec, to be asynchronous, but using a subjob seems to need some refactor, maybe adding a new state for the xattr subjob.

Jan 17 2019, 12:59 PM · Frameworks
cochise added a comment to D17816: Support for xattrs on kio copy/move.
Jan 17 2019, 12:59 PM · Frameworks

Jan 14 2019

cochise updated the diff for D17816: Support for xattrs on kio copy/move.

Use subjobs on file_copy and other small fixes

Jan 14 2019, 9:22 PM · Frameworks

Jan 8 2019

cochise updated the diff for D17816: Support for xattrs on kio copy/move.

For some reason the added kio was not included

Jan 8 2019, 1:21 PM · Frameworks
cochise updated the diff for D17816: Support for xattrs on kio copy/move.

All use cases working, added a new KIO to copy xattr

Jan 8 2019, 1:13 PM · Frameworks

Jan 5 2019

cochise added a comment to D17816: Support for xattrs on kio copy/move.

On a related note, is it possible that the "QSaveFile" is also responsible for a similar behaviour in Ark?

Jan 5 2019, 5:53 PM · Frameworks
cochise updated the diff for D17816: Support for xattrs on kio copy/move.

small cleanup

Jan 5 2019, 1:04 PM · Frameworks
cochise updated the summary of D17816: Support for xattrs on kio copy/move.
Jan 5 2019, 12:54 PM · Frameworks
cochise updated the diff for D17816: Support for xattrs on kio copy/move.

Tests refactored, but no multiplatform. Other small fixes.

Jan 5 2019, 12:53 PM · Frameworks
cochise removed a watcher for Amarok: cochise.
Jan 5 2019, 7:26 AM
cochise removed a watcher for Falkon: cochise.
Jan 5 2019, 7:26 AM
cochise removed a watcher for Kube: cochise.
Jan 5 2019, 7:25 AM

Jan 3 2019

cochise updated the summary of D17816: Support for xattrs on kio copy/move.
Jan 3 2019, 7:38 AM · Frameworks
cochise updated the summary of D17816: Support for xattrs on kio copy/move.
Jan 3 2019, 7:36 AM · Frameworks
cochise updated the diff for D17816: Support for xattrs on kio copy/move.

Tests added, includes and ifdefs reworked

Jan 3 2019, 7:24 AM · Frameworks

Dec 30 2018

cochise added a comment to D17816: Support for xattrs on kio copy/move.
In D17816#384056, @pino wrote:
  • NULL -> nullptr
  • there is not just glibc

I'm following the pattern in Baloo, that keeps NULL on Mac and *BSD. I don't have any of these systems to test, so I didn't touch it.
Didn't searched yet about compatibility of these functions on libc alternatives. Frameworks officially supports a subset of them I should check?

Dec 30 2018, 7:17 PM · Frameworks
cochise updated the diff for D17816: Support for xattrs on kio copy/move.

Bug resolved in a proper way with help of Tomaz Canabrava

Dec 30 2018, 5:46 PM · Frameworks
cochise updated the diff for D17816: Support for xattrs on kio copy/move.

As using qDebug supressed the error, I changed to qCWarning and managed to track the memory corruption. On my system, after getting the list of keys on source file, the local variable holding this file path gets corrupted. I'm using a code almost identical to official example [1], and enlarging the buffer, or allocating it on the heap didn't resoled the issue.
A hackish workaround is to not store the file path after conversion (const char*), and using QUrl.path().toLocal8Bit().data(); in all nine calls.
I'm not happy with this solution, but I think I reached my limit here. Commiting this hackish version for review, and going to make some tests.

Dec 30 2018, 5:25 AM · Frameworks
cochise updated the diff for D17816: Support for xattrs on kio copy/move.

Refactored to a function, works on all use cases. Data corruption remains

Dec 30 2018, 12:44 AM · Frameworks

Dec 29 2018

cochise added a comment to D17816: Support for xattrs on kio copy/move.

Why do we need the code in both CopyJob and File_unix?

Dec 29 2018, 11:22 AM · Frameworks

Dec 28 2018

cochise added a comment to D17816: Support for xattrs on kio copy/move.

There is one use case (copy of dirs with rename, due name conflict) where the patches not work, and I can't test on *BSD or Mac.

Dec 28 2018, 3:23 PM · Frameworks

Dec 27 2018

cochise updated the diff for D17816: Support for xattrs on kio copy/move.

Support for preserving xattrs on dirs, bugfix

Dec 27 2018, 4:58 PM · Frameworks
cochise added a comment to D17816: Support for xattrs on kio copy/move.

Tested coping from e to VFAT and btrfs.
Successfully copy/move to and from VFAT, losing the xattrs due to lack of support, but don't crash.
Successfully copy/move to and from btrfs, preserving xattrs.

Dec 27 2018, 11:12 AM · Frameworks
cochise requested review of D17816: Support for xattrs on kio copy/move.
Dec 27 2018, 9:38 AM · Frameworks

Nov 26 2017

cochise added a watcher for Zanshin: cochise.
Nov 26 2017, 5:23 PM
cochise added a watcher for Kopete: cochise.
Nov 26 2017, 5:17 PM
cochise added a watcher for QmlWeb: cochise.
Nov 26 2017, 5:16 PM
cochise added a watcher for Kube: cochise.
Nov 26 2017, 5:15 PM
cochise added a watcher for Falkon: cochise.
Nov 26 2017, 5:14 PM
cochise added a watcher for Calligra: 3.0: cochise.
Nov 26 2017, 5:14 PM
cochise added a watcher for Amarok: cochise.
Nov 26 2017, 5:12 PM