markey (Mark Kretschmann)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Sep 30 2017, 4:49 AM (51 w, 3 d)
Availability
Available

Recent Activity

May 10 2018

markey committed R181:d98ec3f7a913: Use new kpackage_install_bundled_package macro (authored by malteveerman).
Use new kpackage_install_bundled_package macro
May 10 2018, 7:22 AM
markey closed D11170: Use new kpackage_install_bundled_package macro.
May 10 2018, 6:58 AM
markey accepted D11170: Use new kpackage_install_bundled_package macro.

Ubuntu 18.04 is now released, and your patch builds fine with it.

May 10 2018, 6:58 AM

May 6 2018

markey committed R181:bce427f2fb54: If BUILD_TESTING was explicitly set to OFF then don't build tests. (authored by markey).
If BUILD_TESTING was explicitly set to OFF then don't build tests.
May 6 2018, 7:27 AM

May 5 2018

markey added a comment to R181:9d0e6bdc5695: Make building unit tests optional and default-disabled (option WITH_TESTS)..

Good idea. Done! :)

May 5 2018, 3:44 PM
markey committed R181:f4a0e027b358: Make gmock an optional dependency. Tests are built if gmock is found. (authored by markey).
Make gmock an optional dependency. Tests are built if gmock is found.
May 5 2018, 3:44 PM

May 4 2018

markey added a comment to R181:9d0e6bdc5695: Make building unit tests optional and default-disabled (option WITH_TESTS)..

Nope it's not redundant because there is no way to make BUILD_TESTING default to OFF, or is there? You see, that's the whole point, default-disabling the tests.

May 4 2018, 8:04 PM
markey committed R181:d5793a5dabf4: Remove .reviewboardrc - KDE now uses Phabricator. (authored by markey).
Remove .reviewboardrc - KDE now uses Phabricator.
May 4 2018, 3:27 PM

May 2 2018

markey committed R181:9d0e6bdc5695: Make building unit tests optional and default-disabled (option WITH_TESTS). (authored by markey).
Make building unit tests optional and default-disabled (option WITH_TESTS).
May 2 2018, 6:27 PM

Apr 28 2018

markey committed R181:8a6586da12f9: Fixed fadebars (authored by malteveerman).
Fixed fadebars
Apr 28 2018, 2:09 PM
markey closed D12492: Fixed fadebars.
Apr 28 2018, 2:09 PM · Amarok
markey accepted D12492: Fixed fadebars.
Apr 28 2018, 2:09 PM · Amarok

Apr 21 2018

markey committed R181:dd0049f7db07: Some analyzer applet tweaks (authored by malteveerman).
Some analyzer applet tweaks
Apr 21 2018, 1:04 PM
markey closed D12316: Some analyzer applet tweaks.
Apr 21 2018, 1:04 PM · Amarok
markey accepted D12316: Some analyzer applet tweaks.
Apr 21 2018, 1:04 PM · Amarok
markey committed R181:9a022879122f: Fixed crash at shutdown (authored by malteveerman).
Fixed crash at shutdown
Apr 21 2018, 1:01 PM
markey closed D12315: Fixed crash at shutdown.
Apr 21 2018, 1:01 PM · Amarok
markey accepted D12315: Fixed crash at shutdown.
Apr 21 2018, 12:40 PM · Amarok

Apr 15 2018

markey committed R181:bd0fa5c0b6f0: Improvements to CurrentTrack applet (authored by malteveerman).
Improvements to CurrentTrack applet
Apr 15 2018, 1:52 PM
markey closed D12223: Improvements to CurrentTrack applet.
Apr 15 2018, 1:52 PM · Amarok
markey accepted D12223: Improvements to CurrentTrack applet.
Apr 15 2018, 1:51 PM · Amarok

Apr 12 2018

markey committed R181:838e52b555a1: More interface stuttering work (authored by malteveerman).
More interface stuttering work
Apr 12 2018, 4:32 PM
markey closed D11968: More interface stuttering work.
Apr 12 2018, 4:32 PM · Amarok
markey accepted D11968: More interface stuttering work.
Apr 12 2018, 4:31 PM · Amarok

Apr 4 2018

markey added a comment to D11862: Get rid of scripting.

See, the problem with removing features like this is, there will be a huge outcry from users. That's guaranteed, even without knowing for sure how much the scripting feature is really used in the wild.

Apr 4 2018, 6:42 PM · Amarok
markey committed R181:adcbef160f03: Fix missing include for std::thread. (authored by markey).
Fix missing include for std::thread.
Apr 4 2018, 5:15 PM
markey committed R181:02c610b65185: Reduce interface stuttering (authored by malteveerman).
Reduce interface stuttering
Apr 4 2018, 5:14 PM
markey closed D11868: Reduce interface stuttering.
Apr 4 2018, 5:13 PM · Amarok
markey accepted D11868: Reduce interface stuttering.
Apr 4 2018, 5:13 PM · Amarok
markey committed R181:5f138b0fcc14: Logger overhaul (authored by malteveerman).
Logger overhaul
Apr 4 2018, 4:56 PM
markey closed D11867: Logger overhaul.

Pushed to master.

Apr 4 2018, 4:54 PM · Amarok
markey accepted D11867: Logger overhaul.
Apr 4 2018, 4:35 PM · Amarok

Apr 1 2018

markey committed R181:5176c93e41e4: Fixed wrong slot signatures in BrowserMessageArea (authored by malteveerman).
Fixed wrong slot signatures in BrowserMessageArea
Apr 1 2018, 1:58 PM
markey closed D11788: Fixed wrong slot signatures in BrowserMessageArea.
Apr 1 2018, 1:58 PM · Amarok
markey accepted D11788: Fixed wrong slot signatures in BrowserMessageArea.
Apr 1 2018, 1:57 PM · Amarok
markey committed R181:ef7ec2c70f60: Small MySQL libraries fix for tests. (authored by malteveerman).
Small MySQL libraries fix for tests.
Apr 1 2018, 1:48 PM
markey closed D11787: Small MySQL libraries fix for tests..
Apr 1 2018, 1:48 PM · Amarok
markey accepted D11787: Small MySQL libraries fix for tests..
Apr 1 2018, 1:47 PM · Amarok

Mar 25 2018

markey committed R181:16d825772150: Some small changes and fixes (authored by malteveerman).
Some small changes and fixes
Mar 25 2018, 4:47 PM
markey closed D11534: Some small changes and fixes.
Mar 25 2018, 4:47 PM · Amarok
markey accepted D11534: Some small changes and fixes.
Mar 25 2018, 4:47 PM · Amarok

Mar 20 2018

markey committed R181:7a63540fc23a: Reactivate wikipedia applet (authored by malteveerman).
Reactivate wikipedia applet
Mar 20 2018, 3:57 PM
markey closed D11349: Reactivate wikipedia applet.
Mar 20 2018, 3:57 PM · Amarok
markey requested changes to D11349: Reactivate wikipedia applet.

Generally this works for me now, but there are two more issues that I found:

Mar 20 2018, 4:12 AM · Amarok

Mar 19 2018

markey committed R181:241583115f47: Ask mysql for libs to link to (authored by heikobecker).
Ask mysql for libs to link to
Mar 19 2018, 7:52 PM

Mar 18 2018

markey requested changes to D11349: Reactivate wikipedia applet.

Fails to build here:

Mar 18 2018, 6:43 PM · Amarok

Mar 14 2018

markey committed R181:d527cce9963c: Fixed a crash in magnatune service (authored by malteveerman).
Fixed a crash in magnatune service
Mar 14 2018, 7:22 PM
markey closed D11299: Fixed a crash in magnatune service.
Mar 14 2018, 7:22 PM · Amarok
markey accepted D11299: Fixed a crash in magnatune service.
Mar 14 2018, 7:21 PM · Amarok
markey committed R181:12d7ecbfe6e8: Port NetworkAccessManager to new signal/slot syntax (authored by malteveerman).
Port NetworkAccessManager to new signal/slot syntax
Mar 14 2018, 7:18 PM
markey closed D11171: Port NetworkAccessManager to new signal/slot syntax.
Mar 14 2018, 7:18 PM · Amarok
markey accepted D11171: Port NetworkAccessManager to new signal/slot syntax.
Mar 14 2018, 7:18 PM · Amarok

Mar 13 2018

markey committed R181:16d4997c3792: Ported playdar collection away from qjson (authored by malteveerman).
Ported playdar collection away from qjson
Mar 13 2018, 7:31 PM
markey closed D11192: Ported playdar collection away from qjson.
Mar 13 2018, 7:31 PM · Amarok
markey accepted D11192: Ported playdar collection away from qjson.
Mar 13 2018, 7:30 PM · Amarok
markey requested changes to D11171: Port NetworkAccessManager to new signal/slot syntax.

This does not build for me (GCC 7.2.0).

Mar 13 2018, 7:23 PM · Amarok

Mar 9 2018

markey committed R181:459ed3a342f0: Use Kirigami's spacing and icon sizes and remove own implementation (authored by malteveerman).
Use Kirigami's spacing and icon sizes and remove own implementation
Mar 9 2018, 3:49 AM
markey closed D11150: Use Kirigami's spacing and icon sizes and remove own implementation.
Mar 9 2018, 3:49 AM · Amarok
markey accepted D11150: Use Kirigami's spacing and icon sizes and remove own implementation.

Kirigami2 seems really nifty. Nice choice.

Mar 9 2018, 3:48 AM · Amarok

Mar 7 2018

markey added a comment to T8078: Port away from libmysqld (embedded server).

Just a note: Back in the day Amarok was actually using SQLite, but there were major performance issues for people with giant collections. E.g. I was just talking to a user on IRC with a 44k tracks collection.

Mar 7 2018, 7:09 PM · Amarok
markey committed R181:c9257ade2df7: Fix some deprecation warnings (authored by malteveerman).
Fix some deprecation warnings
Mar 7 2018, 7:03 PM
markey closed D11033: Fix some deprecation warnings.
Mar 7 2018, 7:03 PM · Amarok
markey accepted D11033: Fix some deprecation warnings.
Mar 7 2018, 7:02 PM · Amarok

Mar 5 2018

markey committed R181:d65ce101313e: Make Webkit optional (authored by heikobecker).
Make Webkit optional
Mar 5 2018, 7:49 PM
markey closed D10923: Make Webkit optional.
Mar 5 2018, 7:48 PM · Amarok
markey accepted D10923: Make Webkit optional.
Mar 5 2018, 7:48 PM · Amarok
markey committed R181:cf491101e892: Disable Discogs and Google cover search temporarily (authored by heikobecker).
Disable Discogs and Google cover search temporarily
Mar 5 2018, 7:46 PM
markey closed D10924: Disable Discogs and Google cover search temporarily.
Mar 5 2018, 7:46 PM · Amarok
markey accepted D10924: Disable Discogs and Google cover search temporarily.
Mar 5 2018, 7:45 PM · Amarok

Mar 4 2018

markey committed R181:df9fc58c8ac5: Port tests to Qt5/KF5 (authored by malteveerman).
Port tests to Qt5/KF5
Mar 4 2018, 6:30 PM
markey closed D10978: Port tests to Qt5/KF5.
Mar 4 2018, 6:30 PM · Amarok
markey accepted D10978: Port tests to Qt5/KF5.
Mar 4 2018, 6:26 PM · Amarok

Mar 2 2018

markey committed R181:ea60d1523218: Fixed a crash in analyzer applet when sample rate reported by engine controller… (authored by malteveerman).
Fixed a crash in analyzer applet when sample rate reported by engine controller…
Mar 2 2018, 6:21 PM
markey closed D10971: Fixed a crash in analyzer applet when sample rate reported by engine controller is zero.
Mar 2 2018, 6:21 PM · Amarok
markey accepted D10971: Fixed a crash in analyzer applet when sample rate reported by engine controller is zero.
Mar 2 2018, 6:21 PM · Amarok
markey committed R181:865b63279274: Ported importers to Qt5/KF5 (authored by malteveerman).
Ported importers to Qt5/KF5
Mar 2 2018, 6:11 PM
markey closed D10900: Ported importers to Qt5/KF5.
Mar 2 2018, 6:11 PM · Amarok
markey accepted D10900: Ported importers to Qt5/KF5.
Mar 2 2018, 6:11 PM · Amarok

Feb 28 2018

markey added a comment to D10923: Make Webkit optional.

Is this patch meant for master? Because the branch is "webkit-optional".

Feb 28 2018, 6:20 PM · Amarok

Feb 26 2018

markey committed R181:0d7ae231eea9: Ported some services to Qt5/KF5 (authored by malteveerman).
Ported some services to Qt5/KF5
Feb 26 2018, 7:26 PM
markey closed D10831: Ported some services to Qt5/KF5.
Feb 26 2018, 7:26 PM · Amarok
markey accepted D10831: Ported some services to Qt5/KF5.
Feb 26 2018, 7:26 PM · Amarok

Feb 25 2018

markey committed R181:4b9a4e88c9f6: Fix for Amarok::saveLocation() not setting separator before subdirectory. (authored by malteveerman).
Fix for Amarok::saveLocation() not setting separator before subdirectory.
Feb 25 2018, 12:16 PM
markey closed D10819: Fix for Amarok::saveLocation() not setting separator before subdirectory..
Feb 25 2018, 12:16 PM · Amarok
markey added a comment to D10819: Fix for Amarok::saveLocation() not setting separator before subdirectory..

Hey Malte, please fix your real name for the next patch. KDE commit hook rejects this:

Feb 25 2018, 12:15 PM · Amarok
markey accepted D10819: Fix for Amarok::saveLocation() not setting separator before subdirectory..
Feb 25 2018, 10:37 AM · Amarok

Feb 23 2018

markey committed R181:3a25034e5006: New context area (authored by malteveerman).
New context area
Feb 23 2018, 6:50 PM
markey closed D10708: New context area.
Feb 23 2018, 6:48 PM · Amarok
markey accepted D10708: New context area.
Feb 23 2018, 5:43 PM · Amarok

Feb 20 2018

markey committed R181:d78f666e58de: Port core application away from kdelibs4 (authored by malteveerman).
Port core application away from kdelibs4
Feb 20 2018, 7:45 PM
markey closed D10526: Port core application away from kdelibs4.
Feb 20 2018, 7:40 PM · Amarok
markey accepted D10526: Port core application away from kdelibs4.

Looks good to me. Builds and works fine too.

Feb 20 2018, 7:35 PM · Amarok

Feb 15 2018

markey added a comment to D10526: Port core application away from kdelibs4.

Can I suggest we release 2.9 as planned, with the current state and maybe
some more bugfixes, before integrating this patch? Once migration to kf5 is
complete, and new patches will be needed for that, we may start thinking
about a 3.0.

Feb 15 2018, 7:42 PM · Amarok

Oct 22 2017

markey committed R181:cd7b5aa2e9bc: Disable GPodder service for now as it can crash Amarok on startup. (authored by markey).
Disable GPodder service for now as it can crash Amarok on startup.
Oct 22 2017, 6:21 PM
markey committed R181:4b19048bab54: streamlined plugin system (authored by malteveerman).
streamlined plugin system
Oct 22 2017, 6:12 PM
markey closed D8229: streamlined plugin system.
Oct 22 2017, 6:07 PM · Amarok
markey accepted D8229: streamlined plugin system.

Seems to work ok here.

Oct 22 2017, 6:06 PM · Amarok

Oct 9 2017

markey committed R181:dcb859b8df66: some crash and hang fixes (authored by malteveerman).
some crash and hang fixes
Oct 9 2017, 6:05 PM
markey closed D8213: some crash and hang fixes.
Oct 9 2017, 6:03 PM
markey accepted D8213: some crash and hang fixes.

Nice fixes. Builds fine too.

Oct 9 2017, 5:59 PM