malteveerman (Malte Veerman)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2017, 12:12 PM (36 w, 5 d)
Availability
Available

Recent Activity

Tue, Jun 12

malteveerman updated the diff for D13438: Removed obsolete PackagePath role from AppletModel.

Fixed some issues with newer kf5 and qt versions.

Tue, Jun 12, 1:50 PM

Fri, Jun 8

malteveerman requested review of D13438: Removed obsolete PackagePath role from AppletModel.
Fri, Jun 8, 10:55 PM

Apr 24 2018

malteveerman updated the diff for D12492: Fixed fadebars.

Cleaned up some includes.

Apr 24 2018, 12:44 PM · Amarok
malteveerman updated the diff for D12492: Fixed fadebars.

Added some performance optimizations to the analyzer applet.

Apr 24 2018, 12:20 PM · Amarok
malteveerman requested review of D12492: Fixed fadebars.
Apr 24 2018, 10:06 AM · Amarok

Apr 18 2018

malteveerman updated the diff for D12315: Fixed crash at shutdown.

Removed unnecessary volatile

Apr 18 2018, 7:33 PM · Amarok
malteveerman requested review of D12316: Some analyzer applet tweaks.
Apr 18 2018, 4:29 PM · Amarok
malteveerman requested review of D12315: Fixed crash at shutdown.
Apr 18 2018, 4:25 PM · Amarok

Apr 15 2018

malteveerman requested review of D12223: Improvements to CurrentTrack applet.
Apr 15 2018, 12:22 PM · Amarok

Apr 11 2018

malteveerman updated the diff for D11968: More interface stuttering work.

Added a few random improvements and compilation warning fixes.

Apr 11 2018, 5:24 PM · Amarok

Apr 5 2018

malteveerman updated the diff for D11170: Use new kpackage_install_bundled_package macro.

Just a rebase.

Apr 5 2018, 8:49 PM
malteveerman requested review of D11968: More interface stuttering work.
Apr 5 2018, 6:01 PM · Amarok
malteveerman added a comment to D11862: Get rid of scripting.

See, the problem with removing features like this is, there will be a huge outcry from users. That's guaranteed, even without knowing for sure how much the scripting feature is really used in the wild.

I was discussing about this with Heiko. Maybe QtScript could be replaced with QJSEngine, similar to how the following patch for another project attempts to do it?

https://phabricator.kde.org/D7033

Apr 5 2018, 1:39 PM · Amarok

Apr 1 2018

malteveerman updated the diff for D11868: Reduce interface stuttering.

Put some more image savings out of the GUI thread.

Apr 1 2018, 11:13 PM · Amarok
malteveerman requested review of D11868: Reduce interface stuttering.
Apr 1 2018, 5:15 PM · Amarok
malteveerman requested review of D11867: Logger overhaul.
Apr 1 2018, 4:39 PM · Amarok
malteveerman requested review of D11862: Get rid of scripting.
Apr 1 2018, 3:20 PM · Amarok

Mar 29 2018

malteveerman requested review of D11788: Fixed wrong slot signatures in BrowserMessageArea.
Mar 29 2018, 7:10 PM · Amarok
malteveerman requested review of D11787: Small MySQL libraries fix for tests..
Mar 29 2018, 5:02 PM · Amarok

Mar 26 2018

malteveerman requested review of D11710: Workaround for clang bug 23029.
Mar 26 2018, 10:08 AM · Amarok
malteveerman added a comment to D11534: Some small changes and fixes.

There seems to be a bug in clang. But it doesn't seem to get fixed anytime soon. I'll write a workaround.

Mar 26 2018, 1:49 AM · Amarok

Mar 20 2018

malteveerman requested review of D11534: Some small changes and fixes.
Mar 20 2018, 11:10 PM · Amarok
malteveerman added a comment to D11349: Reactivate wikipedia applet.

I managed to fix the issue with missing QtWebEngine but I'm not sure what I can do about the missing qml module. Isn't it part of the WebEngine package?

Mar 20 2018, 8:07 AM · Amarok
malteveerman updated the diff for D11349: Reactivate wikipedia applet.

Fixed issue with missing optional dependency Qt5WebEngine.

Mar 20 2018, 8:07 AM · Amarok

Mar 18 2018

malteveerman updated the diff for D11349: Reactivate wikipedia applet.

Changed fileUrl() to filePath(). Builds now with older KPackage.

Mar 18 2018, 8:19 PM · Amarok

Mar 15 2018

malteveerman requested review of D11349: Reactivate wikipedia applet.
Mar 15 2018, 10:21 AM · Amarok

Mar 13 2018

malteveerman updated the diff for D11171: Port NetworkAccessManager to new signal/slot syntax.

Previous diff relied on a function of QMetaObject added in Qt 5.10. This now works with older versions of Qt, too.

Mar 13 2018, 9:04 PM · Amarok
malteveerman requested review of D11299: Fixed a crash in magnatune service.
Mar 13 2018, 8:57 PM · Amarok

Mar 10 2018

malteveerman updated the diff for D11192: Ported playdar collection away from qjson.

Fixed hang on shutdown

Mar 10 2018, 3:57 PM · Amarok

Mar 9 2018

malteveerman requested review of D11192: Ported playdar collection away from qjson.
Mar 9 2018, 8:12 PM · Amarok
malteveerman added a comment to D11170: Use new kpackage_install_bundled_package macro.

While I personally have no problem with requiring 5.41.0, it's maybe a bit new. Apparently the current Ubuntu doesn't have it and we should possibly wait until 18.04 is released (26.04.)

Mar 9 2018, 7:16 PM
malteveerman moved T2738: KSharedPtr conversion from Work in Progress to Done on the Amarok board.
Mar 9 2018, 10:31 AM · Amarok
malteveerman moved T2723: Build back support for center widgets in the application from Work in Progress to Done on the Amarok board.
Mar 9 2018, 10:30 AM · Amarok
malteveerman requested review of D11171: Port NetworkAccessManager to new signal/slot syntax.
Mar 9 2018, 9:11 AM · Amarok
malteveerman requested review of D11170: Use new kpackage_install_bundled_package macro.
Mar 9 2018, 9:05 AM
malteveerman requested review of D11169: Another QUrl fix.
Mar 9 2018, 8:56 AM · Amarok

Mar 8 2018

malteveerman requested review of D11150: Use Kirigami's spacing and icon sizes and remove own implementation.
Mar 8 2018, 9:51 AM · Amarok

Mar 4 2018

malteveerman requested review of D11033: Fix some deprecation warnings.
Mar 4 2018, 8:58 PM · Amarok

Mar 2 2018

malteveerman requested review of D10978: Port tests to Qt5/KF5.
Mar 2 2018, 8:31 PM · Amarok
malteveerman requested review of D10971: Fixed a crash in analyzer applet when sample rate reported by engine controller is zero.
Mar 2 2018, 2:55 PM · Amarok

Feb 27 2018

malteveerman requested review of D10900: Ported importers to Qt5/KF5.
Feb 27 2018, 7:17 PM · Amarok

Feb 25 2018

malteveerman updated the diff for D10831: Ported some services to Qt5/KF5.
Feb 25 2018, 4:52 PM · Amarok
malteveerman updated the summary of D10831: Ported some services to Qt5/KF5.
Feb 25 2018, 4:47 PM · Amarok
malteveerman updated the diff for D10831: Ported some services to Qt5/KF5.
Feb 25 2018, 4:45 PM · Amarok
malteveerman added a comment to T8078: Port away from libmysqld (embedded server).

I've already begun porting Amarok to SQLite3, since it is provided by the basic flatpak runtime. I'll post the finished patch when it works.

Feb 25 2018, 2:30 PM · Amarok
malteveerman added a comment to D10831: Ported some services to Qt5/KF5.

gpodder service using mygpo-qt, which is still in a qt4 world

Even though it may not be available on every distro out there yet (for lack of consumers), libmygpo-qt-1.0.9 supports Qt5 already. At least clementine also makes use of it, but only in their qt5 branch.

Feb 25 2018, 1:14 PM · Amarok
malteveerman updated the diff for D10831: Ported some services to Qt5/KF5.

Fixed branch and commit author

Feb 25 2018, 1:10 PM · Amarok
malteveerman added a comment to D10831: Ported some services to Qt5/KF5.

I've created this revision against the wrong branch. How do I fix that?

Feb 25 2018, 12:52 PM · Amarok
malteveerman requested review of D10831: Ported some services to Qt5/KF5.
Feb 25 2018, 12:49 PM · Amarok
malteveerman requested review of D10819: Fix for Amarok::saveLocation() not setting separator before subdirectory..
Feb 25 2018, 9:48 AM · Amarok

Feb 21 2018

malteveerman added a comment to D10708: New context area.

I have no idea why the vlc backend doesn't work. But I think it's a bug in the backend, not the analyzer.

Feb 21 2018, 10:11 PM · Amarok
malteveerman added a comment to D10708: New context area.

Analyzer should work as well, if you are using the gstreamer phonon backend. Vlc backend doesn't work unfortunately.

Feb 21 2018, 9:56 PM · Amarok
malteveerman updated the summary of D10708: New context area.
Feb 21 2018, 4:19 PM · Amarok
malteveerman updated the diff for D10708: New context area.

Added resizing of applets in config mode

Feb 21 2018, 4:19 PM · Amarok
malteveerman requested review of D10708: New context area.
Feb 21 2018, 11:49 AM · Amarok

Feb 16 2018

malteveerman added a comment to D10526: Port core application away from kdelibs4.

I guess this was really meant as '...away from kdelibs4support' instead of kdelibs4, hence the confusion. But yes it is targeting the correct branch.

Feb 16 2018, 4:35 AM · Amarok
malteveerman updated the summary of D10526: Port core application away from kdelibs4.
Feb 16 2018, 4:35 AM · Amarok

Feb 15 2018

dos awarded D10526: Port core application away from kdelibs4 a Yellow Medal token.
Feb 15 2018, 8:11 PM · Amarok
kpiwowarski awarded D10526: Port core application away from kdelibs4 a Yellow Medal token.
Feb 15 2018, 8:44 AM · Amarok
malteveerman requested review of D10526: Port core application away from kdelibs4.
Feb 15 2018, 5:15 AM · Amarok
malteveerman added a watcher for Amarok: malteveerman.
Feb 15 2018, 4:54 AM

Feb 7 2018

malteveerman added a reviewer for D10355: Use the new KPackage::fileUrl() method to load mainscripts.: Frameworks.
Feb 7 2018, 12:12 AM · Frameworks
malteveerman updated the summary of D10355: Use the new KPackage::fileUrl() method to load mainscripts..
Feb 7 2018, 12:09 AM · Frameworks
malteveerman requested review of D10355: Use the new KPackage::fileUrl() method to load mainscripts..
Feb 7 2018, 12:03 AM · Frameworks

Oct 18 2017

malteveerman added a comment to D8174: Port to new signal/slot syntax.

There are no changes to the plugin system in this revision. Please try this and see if that fixes your issue.

Oct 18 2017, 1:07 PM · Amarok

Oct 9 2017

malteveerman updated the diff for D8229: streamlined plugin system.

Added new amarok-plugin.metadata file.

Oct 9 2017, 9:53 PM · Amarok
malteveerman added a reviewer for D8229: streamlined plugin system: Amarok.
Oct 9 2017, 9:34 PM · Amarok
malteveerman created D8229: streamlined plugin system.
Oct 9 2017, 9:33 PM · Amarok

Oct 8 2017

malteveerman updated the summary of D8213: some crash and hang fixes.
Oct 8 2017, 9:43 PM
malteveerman created D8213: some crash and hang fixes.
Oct 8 2017, 9:40 PM

Oct 7 2017

malteveerman updated the summary of D8174: Port to new signal/slot syntax.
Oct 7 2017, 11:20 AM · Amarok
malteveerman created D8174: Port to new signal/slot syntax.
Oct 7 2017, 11:18 AM · Amarok