eoinoneill (Eoin O'Neill)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 6 2018, 8:28 PM (113 w, 18 h)
Availability
Available

Recent Activity

Yesterday

eoinoneill committed R37:5f8e2a6bda03: Made icon for text-enabled filtering. (authored by eoinoneill).
Made icon for text-enabled filtering.
Fri, Jun 5, 3:44 AM
eoinoneill committed R37:1a6f775cd544: Fix icon alignment bug. (authored by eoinoneill).
Fix icon alignment bug.
Fri, Jun 5, 3:44 AM
eoinoneill committed R37:edd8e743e86d: Fix double-click behavior of Filter Widget. (authored by eoinoneill).
Fix double-click behavior of Filter Widget.
Fri, Jun 5, 3:44 AM
eoinoneill committed R37:b87f45720d25: Added mouse click filter on menus holding KisLabelFilter/Selector Widgets. (authored by eoinoneill).
Added mouse click filter on menus holding KisLabelFilter/Selector Widgets.
Fri, Jun 5, 3:44 AM
eoinoneill committed R37:922b3a967543: Changed filter widget size. (authored by eoinoneill).
Changed filter widget size.
Fri, Jun 5, 3:44 AM
eoinoneill committed R37:a3f5f3136cda: Fix visuals of colored pie. (authored by eoinoneill).
Fix visuals of colored pie.
Fri, Jun 5, 3:44 AM
eoinoneill committed R37:b365970392d4: Working FilterWidget Pie Vis. (authored by eoinoneill).
Working FilterWidget Pie Vis.
Fri, Jun 5, 3:44 AM
eoinoneill committed R37:b04efebbd4cb: Fixup - color_layer_filter_widget corrections. (authored by eoinoneill).
Fixup - color_layer_filter_widget corrections.
Fri, Jun 5, 3:44 AM
eoinoneill committed R37:0a3f0a78abe6: ColorLabelFilter: Fix selection of multiple layers + label assignment. (authored by eoinoneill).
ColorLabelFilter: Fix selection of multiple layers + label assignment.
Fri, Jun 5, 3:44 AM
eoinoneill committed R37:7651baef2868: Added KisColorLabelButton to Onion Skins Docker. (authored by eoinoneill).
Added KisColorLabelButton to Onion Skins Docker.
Fri, Jun 5, 3:44 AM
eoinoneill committed R37:b414c2828c78: KisColorFilter -- Propagated widget style change to Label Selector. (authored by eoinoneill).
KisColorFilter -- Propagated widget style change to Label Selector.
Fri, Jun 5, 3:44 AM
eoinoneill committed R37:e9ad92c8ac50: Fix Resizing Widget Issues (authored by eoinoneill).
Fix Resizing Widget Issues
Fri, Jun 5, 3:44 AM
eoinoneill committed R37:fab811e8c2c2: Visual Alterations To KisColorLabelButton (authored by eoinoneill).
Visual Alterations To KisColorLabelButton
Fri, Jun 5, 3:44 AM

Mon, Jun 1

eoinoneill committed R37:29e2ab628c7b: KisLayerFilterWidget appimage build fix. (authored by eoinoneill).
KisLayerFilterWidget appimage build fix.
Mon, Jun 1, 6:22 PM

Thu, May 28

eoinoneill committed R37:d03f44f8c32e: Merge branch 'krita/4.3' into jounip/T8764-clone-frames (authored by eoinoneill).
Merge branch 'krita/4.3' into jounip/T8764-clone-frames
Thu, May 28, 2:53 AM
eoinoneill committed R37:89909142a169: Merge branch 'krita/4.3' into jounip/T8764-clone-frames (authored by eoinoneill).
Merge branch 'krita/4.3' into jounip/T8764-clone-frames
Thu, May 28, 2:53 AM
eoinoneill committed R37:ac9f1b8e6b29: Got it building, but had to make major changes. (authored by eoinoneill).
Got it building, but had to make major changes.
Thu, May 28, 2:53 AM

Fri, May 15

eoinoneill committed R37:cb013fe2bd06: Fix: Node Solo Can No Longer Accidently Nuke Previous Visibility Settings (authored by eoinoneill).
Fix: Node Solo Can No Longer Accidently Nuke Previous Visibility Settings
Fri, May 15, 11:02 PM
eoinoneill committed R37:d8e564e6ae1a: Fix: Node Solo Can No Longer Accidently Nuke Previous Visibility Settings (authored by eoinoneill).
Fix: Node Solo Can No Longer Accidently Nuke Previous Visibility Settings
Fri, May 15, 11:00 PM
eoinoneill committed R37:d3f708903c32: Fix frames being rendered outside requested range (authored by jounip).
Fix frames being rendered outside requested range
Fri, May 15, 7:55 PM

Tue, May 12

eoinoneill updated the task description for T12769: "Animation Next" Main Task..
Tue, May 12, 9:14 PM · Krita
eoinoneill committed R37:88342ecc54f0: Fix: Properly Play Animations / Display Onion Skins During Isolation of Hidden… (authored by eoinoneill).
Fix: Properly Play Animations / Display Onion Skins During Isolation of Hidden…
Tue, May 12, 9:12 PM
eoinoneill committed R37:207c48948edb: Fix: Properly Play Animations / Display Onion Skins During Isolation of Hidden… (authored by eoinoneill).
Fix: Properly Play Animations / Display Onion Skins During Isolation of Hidden…
Tue, May 12, 9:04 PM

Fri, May 8

eoinoneill committed R37:a0404a1906c8: Timeline now correctly highlights current frame after loading document. (authored by eoinoneill).
Timeline now correctly highlights current frame after loading document.
Fri, May 8, 6:49 PM

Thu, May 7

eoinoneill committed R37:9d6a9446f6ce: Timeline now correctly highlights current frame after loading document. (authored by eoinoneill).
Timeline now correctly highlights current frame after loading document.
Thu, May 7, 9:39 PM
eoinoneill updated the task description for T12769: "Animation Next" Main Task..
Thu, May 7, 8:36 PM · Krita

May 7 2020

eoinoneill committed R37:2446ca4e78b6: Onion Skin Alignment After Image Crop Fix (authored by eoinoneill).
Onion Skin Alignment After Image Crop Fix
May 7 2020, 12:55 AM

May 6 2020

eoinoneill updated the task description for T12769: "Animation Next" Main Task..
May 6 2020, 7:47 PM · Krita

Apr 22 2020

eoinoneill updated the task description for T12769: "Animation Next" Main Task..
Apr 22 2020, 4:56 AM · Krita

Apr 17 2020

eoinoneill committed R37:7b61f8765a8b: Corrections for PaintDevice::createKeyframeChannel and KeyframeChannel… (authored by eoinoneill).
Corrections for PaintDevice::createKeyframeChannel and KeyframeChannel…
Apr 17 2020, 2:04 AM
eoinoneill committed R37:92341b2241e0: Correction to `KisKeyframeChannel::affectedFrames` Segfault (authored by eoinoneill).
Correction to `KisKeyframeChannel::affectedFrames` Segfault
Apr 17 2020, 2:04 AM

Apr 6 2020

eoinoneill added a comment to T12769: "Animation Next" Main Task..

@Bollebib I think doing that wouldn't be too difficult but would require a new Export UI for the compositions docker to accommodate for more advanced settings (kind of like the existing Animation Exporter UI?)

Apr 6 2020, 4:44 PM · Krita

Apr 2 2020

eoinoneill updated the task description for T12902: New KisLayerFilterWidget.
Apr 2 2020, 1:14 AM · Krita

Mar 30 2020

eoinoneill updated the task description for T12769: "Animation Next" Main Task..
Mar 30 2020, 8:40 PM · Krita
eoinoneill updated the task description for T12769: "Animation Next" Main Task..
Mar 30 2020, 6:36 PM · Krita

Mar 25 2020

eoinoneill added a comment to T12769: "Animation Next" Main Task..

Timeline Docker: Time Change Shouldn't Mark Document as "Changed" (https://bugs.kde.org/show_bug.cgi?id=409443)

Mar 25 2020, 8:35 PM · Krita

Mar 23 2020

eoinoneill updated the task description for T12769: "Animation Next" Main Task..
Mar 23 2020, 9:15 PM · Krita

Mar 20 2020

eoinoneill committed R37:200726964206: Opacity Keyframes Cache Correction -- Data-Race Correction (authored by eoinoneill).
Opacity Keyframes Cache Correction -- Data-Race Correction
Mar 20 2020, 5:27 AM
eoinoneill committed R37:12ca3f6656d0: Opacity Keyframes Cache Correction -- Affected Frames Correction (authored by eoinoneill).
Opacity Keyframes Cache Correction -- Affected Frames Correction
Mar 20 2020, 5:27 AM

Mar 18 2020

eoinoneill updated the task description for T12769: "Animation Next" Main Task..
Mar 18 2020, 1:46 AM · Krita
eoinoneill committed R37:7dd356fd41a4: Added ability to edit layers that are in isolation mode. (authored by eoinoneill).
Added ability to edit layers that are in isolation mode.
Mar 18 2020, 1:38 AM

Mar 17 2020

eoinoneill updated the task description for T12769: "Animation Next" Main Task..
Mar 17 2020, 8:10 PM · Krita

Mar 9 2020

eoinoneill updated the task description for T12769: "Animation Next" Main Task..
Mar 9 2020, 5:26 PM · Krita
eoinoneill committed R37:78dfc7279732: Fix Animation Cache Clear for Transform Masks (authored by eoinoneill).
Fix Animation Cache Clear for Transform Masks
Mar 9 2020, 5:23 PM

Mar 5 2020

eoinoneill updated the task description for T12769: "Animation Next" Main Task..
Mar 5 2020, 12:09 AM · Krita
eoinoneill committed R37:6091c8cd683a: API Improvement for Priority Stack (Animation Cache Correction) (authored by eoinoneill).
API Improvement for Priority Stack (Animation Cache Correction)
Mar 5 2020, 12:08 AM
eoinoneill committed R37:b2626d6ff904: Current Frame Caching Correction and Improvement (authored by eoinoneill).
Current Frame Caching Correction and Improvement
Mar 5 2020, 12:08 AM

Mar 4 2020

eoinoneill updated the task description for T12769: "Animation Next" Main Task..
Mar 4 2020, 7:34 PM · Krita
eoinoneill updated the task description for T12769: "Animation Next" Main Task..
Mar 4 2020, 7:32 PM · Krita
eoinoneill updated the task description for T12769: "Animation Next" Main Task..
Mar 4 2020, 4:13 AM · Krita

Mar 3 2020

eoinoneill committed R37:22f07ce810ce: Fixed formatting for MR 59 by Scott P. (authored by eoinoneill).
Fixed formatting for MR 59 by Scott P.
Mar 3 2020, 9:26 PM
eoinoneill committed R37:d3ed7c8340ee: Disable opacity keyframe option if it already exists (authored by scottpetrovic).
Disable opacity keyframe option if it already exists
Mar 3 2020, 9:26 PM
eoinoneill committed R37:eddd66b2dade: Revert "Update opacity keyframes with frame cache" (authored by scottpetrovic).
Revert "Update opacity keyframes with frame cache"
Mar 3 2020, 9:26 PM
eoinoneill added a reverting change for R37:3c723f35a41c: Update opacity keyframes with frame cache: R37:eddd66b2dade: Revert "Update opacity keyframes with frame cache".
Mar 3 2020, 9:26 PM
eoinoneill committed R37:35ede6baacba: Don't use frame delegate to calculate posiiton for animation curve (authored by scottpetrovic).
Don't use frame delegate to calculate posiiton for animation curve
Mar 3 2020, 9:26 PM
eoinoneill committed R37:0c243f52af42: Update opacity keyframes with frame cache (authored by scottpetrovic).
Update opacity keyframes with frame cache
Mar 3 2020, 9:26 PM
eoinoneill committed R37:9a9374a2c1be: Improve the opacity animation UX with a few changes (authored by scottpetrovic).
Improve the opacity animation UX with a few changes
Mar 3 2020, 9:26 PM
eoinoneill added a comment to T12769: "Animation Next" Main Task..

For the in-progress one, you need to check out the MR that @scottpetrovic was working on: https://invent.kde.org/kde/krita/-/merge_requests/56 - note that most issues were fixed already

Mar 3 2020, 4:10 AM · Krita
eoinoneill updated subscribers of T12769: "Animation Next" Main Task..

@tymond (or @dkazakov) About the animation caching system being broken, do we have a good idea / list of all things that need to be fixed for the animation cache, so I can pick it up from there?

Mar 3 2020, 12:17 AM · Krita

Mar 2 2020

eoinoneill updated the task description for T12769: "Animation Next" Main Task..
Mar 2 2020, 10:26 PM · Krita
eoinoneill updated the task description for T12769: "Animation Next" Main Task..
Mar 2 2020, 8:04 PM · Krita
eoinoneill updated the task description for T12769: "Animation Next" Main Task..
Mar 2 2020, 8:01 PM · Krita
eoinoneill updated the task description for T12769: "Animation Next" Main Task..
Mar 2 2020, 7:59 PM · Krita
eoinoneill updated the task description for T12769: "Animation Next" Main Task..
Mar 2 2020, 7:36 PM · Krita
eoinoneill updated the task description for T12769: "Animation Next" Main Task..
Mar 2 2020, 7:36 PM · Krita
eoinoneill updated the task description for T12769: "Animation Next" Main Task..
Mar 2 2020, 7:34 PM · Krita

Jan 7 2020

eoinoneill committed R37:04d11744aabb: Add Graceful Assert for `KoToolBox::buttonSize` Display Indexing (authored by eoinoneill).
Add Graceful Assert for `KoToolBox::buttonSize` Display Indexing
Jan 7 2020, 3:37 AM

Nov 20 2019

eoinoneill added a comment to T11969: Dmitry's notes from CppConfPiter'19.

The main idea of "reactive programming" and "functional programming" is that we don't use any pointers at all :) We can use them internally, like @tusooaw replied above, but all the "user-level" code works with "immutable" (?) copies of the objects. I'm not sure how applicable it is to Krita, but the general idea is: "don't use pointers at all" :)

Nov 20 2019, 9:32 AM · Krita

Nov 16 2019

eoinoneill added a comment to T11969: Dmitry's notes from CppConfPiter'19.

@dkazakov These are interesting points and I'm interested in hearing more of your thoughts on implementing these ideas in future updates.

Nov 16 2019, 9:47 PM · Krita

Aug 9 2019

eoinoneill committed R37:2cfe3745f430: Allow 'Add Clone Layer' to Work on Multiple Layers (authored by eoinoneill).
Allow 'Add Clone Layer' to Work on Multiple Layers
Aug 9 2019, 9:22 AM
eoinoneill added a comment to T11343: Quick Action search functionality.

Should be worth adding that we came to the conclusion that this should be implemented as a (bundled?) python plugin. QActions can all be fetched via the current python plugin interface so it shouldn't be too hard to implement.

Aug 9 2019, 7:41 AM · Krita

Aug 8 2019

eoinoneill created T11350: Stamp Brush / Tool Proposal.
Aug 8 2019, 7:19 PM · Krita

Jul 29 2019

eoinoneill committed R37:fa3c22deab25: Gradient Stop Sorting by Value (authored by eoinoneill).
Gradient Stop Sorting by Value
Jul 29 2019, 4:35 AM

May 23 2019

eoinoneill committed R1012:bd24931418f3: Added 'Paste Reference' to Reference Tool Documentation (authored by eoinoneill).
Added 'Paste Reference' to Reference Tool Documentation
May 23 2019, 1:55 AM

May 21 2019

eoinoneill committed R37:00d3e6d939f0: Feature: 'Reference Tool' now allows loading images directly from clipboard. (authored by eoinoneill).
Feature: 'Reference Tool' now allows loading images directly from clipboard.
May 21 2019, 7:06 AM

Mar 6 2019

eoinoneill closed D19554: Feature: Simplex Noise Generator.

Pushed, closing now. Thanks.

Mar 6 2019, 12:41 AM · Krita
eoinoneill committed R37:7be5c3c2b7a3: Feature: Simplex Noise Generator (authored by eoinoneill).
Feature: Simplex Noise Generator
Mar 6 2019, 12:34 AM

Mar 5 2019

eoinoneill updated the summary of D19554: Feature: Simplex Noise Generator.
Mar 5 2019, 10:06 PM · Krita
eoinoneill requested review of D19554: Feature: Simplex Noise Generator.
Mar 5 2019, 10:05 PM · Krita

Jan 30 2019

eoinoneill committed R37:f63db12bc812: Added Real-Time Preview when Changing Generator Layer Properties. (authored by eoinoneill).
Added Real-Time Preview when Changing Generator Layer Properties.
Jan 30 2019, 12:23 AM
eoinoneill committed R37:1272564eeeab: Changed The Properties for Generator (Fill) Layers to be Non-Modal (authored by eoinoneill).
Changed The Properties for Generator (Fill) Layers to be Non-Modal
Jan 30 2019, 12:23 AM

Jan 29 2019

eoinoneill abandoned D18462: Changed The Properties Dialog for Generator (Fill) Layers to be Non-Modal.

I've gone ahead and fixed the above. I will push this up after working on a few other minor changes to the way fill layers preview.

Jan 29 2019, 11:07 PM · Krita
eoinoneill committed R37:ef1ece55743c: Revert Patch D18462 (authored by eoinoneill).
Revert Patch D18462
Jan 29 2019, 9:49 PM

Jan 23 2019

eoinoneill added a comment to D18462: Changed The Properties Dialog for Generator (Fill) Layers to be Non-Modal.

@rempt Hey, I was just trying to merge my commit but noticed that my changes were already in the code. It looks like it happened on commit cf5346cb2233dc05e7c621544ec6a5f074111e9e , you may have accidentally merged my code when you were testing this patch. I was thinking about just fixing it since it is already there, but I think it may be cleaner if you revert that commit and remove the original test patch so that I can keep these changes in one single commit (so that cherry picking or reversion will be easier in the future.)

Jan 23 2019, 10:36 PM · Krita
eoinoneill added a comment to D18462: Changed The Properties Dialog for Generator (Fill) Layers to be Non-Modal.

Alright, I'll go ahead and push this up then. I've got rid of the extra undo (though that also exists in the adjustment layer code from the previous implementation, which I will work on next weekend or so.) Also, nice catch on the reference, I've added that back to the code.

Jan 23 2019, 10:17 PM · Krita
eoinoneill retitled D18462: Changed The Properties Dialog for Generator (Fill) Layers to be Non-Modal from Changed The Properties for Generator (Fill) Layers to be Non-Modal to Changed The Properties Dialog for Generator (Fill) Layers to be Non-Modal.
Jan 23 2019, 12:56 AM · Krita
eoinoneill requested review of D18462: Changed The Properties Dialog for Generator (Fill) Layers to be Non-Modal.
Jan 23 2019, 12:55 AM · Krita

Dec 16 2018

eoinoneill closed D17590: Added Fill Layer Content Option for New Documents.
Dec 16 2018, 9:08 PM · Krita
eoinoneill committed R37:cb8d3c974330: Added Fill Layer Content Option for New Documents (authored by eoinoneill).
Added Fill Layer Content Option for New Documents
Dec 16 2018, 9:05 PM

Dec 15 2018

eoinoneill updated the diff for D17590: Added Fill Layer Content Option for New Documents.

I've changed the order of the options per request. Additionally, I've added some tooltips to make it more clear what given settings do.

Dec 15 2018, 10:09 PM · Krita
eoinoneill closed D17515: Use Foreground Color for Initial 'New Fill Layer' Dialog.
Dec 15 2018, 8:33 PM · Krita

Dec 14 2018

eoinoneill requested review of D17590: Added Fill Layer Content Option for New Documents.
Dec 14 2018, 11:13 PM · Krita

Dec 12 2018

eoinoneill committed R37:97f861336d4b: Use Foreground Color for Initial 'New Fill Layer' Dialog (authored by eoinoneill).
Use Foreground Color for Initial 'New Fill Layer' Dialog
Dec 12 2018, 8:34 PM
eoinoneill added a comment to D17515: Use Foreground Color for Initial 'New Fill Layer' Dialog.

I'm actually not sure why the resize call was there in the original code, but I decided to keep it as it was. I moved it closer to dlg.exec() to try to keep window appearance code closer to the window showing code.

Dec 12 2018, 8:17 PM · Krita
eoinoneill updated the summary of D17515: Use Foreground Color for Initial 'New Fill Layer' Dialog.
Dec 12 2018, 4:39 AM · Krita
eoinoneill requested review of D17515: Use Foreground Color for Initial 'New Fill Layer' Dialog.
Dec 12 2018, 12:24 AM · Krita

Oct 30 2018

eoinoneill closed D15755: Global Kinetic Scrolling.
Oct 30 2018, 1:35 AM · Krita
eoinoneill closed D16021: Template Files No Longer Added to 'Recent Documents' List on the Krita Greeting Page.
Oct 30 2018, 1:34 AM · Krita
eoinoneill closed D16024: Remove Ability to Add Masks to Locked Layers.
Oct 30 2018, 1:34 AM · Krita
eoinoneill closed D16027: Normal Map Brush Now Works in 32bit and 16bit modes.
Oct 30 2018, 1:33 AM · Krita