eoinoneill (Eoin O'Neill)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 6 2018, 8:28 PM (83 w, 6 d)
Availability
Available

Recent Activity

Aug 9 2019

eoinoneill committed R37:2cfe3745f430: Allow 'Add Clone Layer' to Work on Multiple Layers (authored by eoinoneill).
Allow 'Add Clone Layer' to Work on Multiple Layers
Aug 9 2019, 9:22 AM
eoinoneill added a comment to T11343: Quick Action search functionality.

Should be worth adding that we came to the conclusion that this should be implemented as a (bundled?) python plugin. QActions can all be fetched via the current python plugin interface so it shouldn't be too hard to implement.

Aug 9 2019, 7:41 AM · Krita

Aug 8 2019

eoinoneill created T11350: Stamp Brush / Tool Proposal.
Aug 8 2019, 7:19 PM · Krita

Jul 29 2019

eoinoneill committed R37:fa3c22deab25: Gradient Stop Sorting by Value (authored by eoinoneill).
Gradient Stop Sorting by Value
Jul 29 2019, 4:35 AM

May 23 2019

eoinoneill committed R1012:bd24931418f3: Added 'Paste Reference' to Reference Tool Documentation (authored by eoinoneill).
Added 'Paste Reference' to Reference Tool Documentation
May 23 2019, 1:55 AM

May 21 2019

eoinoneill committed R37:00d3e6d939f0: Feature: 'Reference Tool' now allows loading images directly from clipboard. (authored by eoinoneill).
Feature: 'Reference Tool' now allows loading images directly from clipboard.
May 21 2019, 7:06 AM

Mar 6 2019

eoinoneill closed D19554: Feature: Simplex Noise Generator.

Pushed, closing now. Thanks.

Mar 6 2019, 12:41 AM · Krita
eoinoneill committed R37:7be5c3c2b7a3: Feature: Simplex Noise Generator (authored by eoinoneill).
Feature: Simplex Noise Generator
Mar 6 2019, 12:34 AM

Mar 5 2019

eoinoneill updated the summary of D19554: Feature: Simplex Noise Generator.
Mar 5 2019, 10:06 PM · Krita
eoinoneill requested review of D19554: Feature: Simplex Noise Generator.
Mar 5 2019, 10:05 PM · Krita

Jan 30 2019

eoinoneill committed R37:f63db12bc812: Added Real-Time Preview when Changing Generator Layer Properties. (authored by eoinoneill).
Added Real-Time Preview when Changing Generator Layer Properties.
Jan 30 2019, 12:23 AM
eoinoneill committed R37:1272564eeeab: Changed The Properties for Generator (Fill) Layers to be Non-Modal (authored by eoinoneill).
Changed The Properties for Generator (Fill) Layers to be Non-Modal
Jan 30 2019, 12:23 AM

Jan 29 2019

eoinoneill abandoned D18462: Changed The Properties Dialog for Generator (Fill) Layers to be Non-Modal.

I've gone ahead and fixed the above. I will push this up after working on a few other minor changes to the way fill layers preview.

Jan 29 2019, 11:07 PM · Krita
eoinoneill committed R37:ef1ece55743c: Revert Patch D18462 (authored by eoinoneill).
Revert Patch D18462
Jan 29 2019, 9:49 PM

Jan 23 2019

eoinoneill added a comment to D18462: Changed The Properties Dialog for Generator (Fill) Layers to be Non-Modal.

@rempt Hey, I was just trying to merge my commit but noticed that my changes were already in the code. It looks like it happened on commit cf5346cb2233dc05e7c621544ec6a5f074111e9e , you may have accidentally merged my code when you were testing this patch. I was thinking about just fixing it since it is already there, but I think it may be cleaner if you revert that commit and remove the original test patch so that I can keep these changes in one single commit (so that cherry picking or reversion will be easier in the future.)

Jan 23 2019, 10:36 PM · Krita
eoinoneill added a comment to D18462: Changed The Properties Dialog for Generator (Fill) Layers to be Non-Modal.

Alright, I'll go ahead and push this up then. I've got rid of the extra undo (though that also exists in the adjustment layer code from the previous implementation, which I will work on next weekend or so.) Also, nice catch on the reference, I've added that back to the code.

Jan 23 2019, 10:17 PM · Krita
eoinoneill retitled D18462: Changed The Properties Dialog for Generator (Fill) Layers to be Non-Modal from Changed The Properties for Generator (Fill) Layers to be Non-Modal to Changed The Properties Dialog for Generator (Fill) Layers to be Non-Modal.
Jan 23 2019, 12:56 AM · Krita
eoinoneill requested review of D18462: Changed The Properties Dialog for Generator (Fill) Layers to be Non-Modal.
Jan 23 2019, 12:55 AM · Krita

Dec 16 2018

eoinoneill closed D17590: Added Fill Layer Content Option for New Documents.
Dec 16 2018, 9:08 PM · Krita
eoinoneill committed R37:cb8d3c974330: Added Fill Layer Content Option for New Documents (authored by eoinoneill).
Added Fill Layer Content Option for New Documents
Dec 16 2018, 9:05 PM

Dec 15 2018

eoinoneill updated the diff for D17590: Added Fill Layer Content Option for New Documents.

I've changed the order of the options per request. Additionally, I've added some tooltips to make it more clear what given settings do.

Dec 15 2018, 10:09 PM · Krita
eoinoneill closed D17515: Use Foreground Color for Initial 'New Fill Layer' Dialog.
Dec 15 2018, 8:33 PM · Krita

Dec 14 2018

eoinoneill requested review of D17590: Added Fill Layer Content Option for New Documents.
Dec 14 2018, 11:13 PM · Krita

Dec 12 2018

eoinoneill committed R37:97f861336d4b: Use Foreground Color for Initial 'New Fill Layer' Dialog (authored by eoinoneill).
Use Foreground Color for Initial 'New Fill Layer' Dialog
Dec 12 2018, 8:34 PM
eoinoneill added a comment to D17515: Use Foreground Color for Initial 'New Fill Layer' Dialog.

I'm actually not sure why the resize call was there in the original code, but I decided to keep it as it was. I moved it closer to dlg.exec() to try to keep window appearance code closer to the window showing code.

Dec 12 2018, 8:17 PM · Krita
eoinoneill updated the summary of D17515: Use Foreground Color for Initial 'New Fill Layer' Dialog.
Dec 12 2018, 4:39 AM · Krita
eoinoneill requested review of D17515: Use Foreground Color for Initial 'New Fill Layer' Dialog.
Dec 12 2018, 12:24 AM · Krita

Oct 30 2018

eoinoneill closed D15755: Global Kinetic Scrolling.
Oct 30 2018, 1:35 AM · Krita
eoinoneill closed D16021: Template Files No Longer Added to 'Recent Documents' List on the Krita Greeting Page.
Oct 30 2018, 1:34 AM · Krita
eoinoneill closed D16024: Remove Ability to Add Masks to Locked Layers.
Oct 30 2018, 1:34 AM · Krita
eoinoneill closed D16027: Normal Map Brush Now Works in 32bit and 16bit modes.
Oct 30 2018, 1:33 AM · Krita
eoinoneill closed D16069: Fix Layer Merge Bug With Invisible 'PutAfter' Node.
Oct 30 2018, 1:33 AM · Krita
eoinoneill closed D16423: Give KoResourceItemChooser's Search Field Focus When Shown.
Oct 30 2018, 1:33 AM · Krita

Oct 29 2018

eoinoneill committed R37:d31631850552: ResourceItemChooser's filter field will now automatically receive focus when… (authored by eoinoneill).
ResourceItemChooser's filter field will now automatically receive focus when…
Oct 29 2018, 9:43 PM

Oct 25 2018

eoinoneill requested review of D16423: Give KoResourceItemChooser's Search Field Focus When Shown.
Oct 25 2018, 4:18 AM · Krita

Oct 14 2018

eoinoneill committed R37:393cf3bd7f26: Fixed brush distance option for multihand tool. BUG:395209 (authored by eoinoneill).
Fixed brush distance option for multihand tool. BUG:395209
Oct 14 2018, 2:07 PM

Oct 13 2018

eoinoneill committed R37:27bbf168b1a4: Fixed bug where undo after contiguous selection would sometimes break undo… (authored by eoinoneill).
Fixed bug where undo after contiguous selection would sometimes break undo…
Oct 13 2018, 7:44 PM

Oct 12 2018

eoinoneill committed R37:86039f8ce3b2: Fixed safe-assert on right click context menu in animation curves docker. BUG… (authored by eoinoneill).
Fixed safe-assert on right click context menu in animation curves docker. BUG…
Oct 12 2018, 1:03 PM
eoinoneill committed R37:5c629ca6407a: Fixed bug in bristle engine where 'ink soak' setting was still enabled even… (authored by eoinoneill).
Fixed bug in bristle engine where 'ink soak' setting was still enabled even…
Oct 12 2018, 9:08 AM
eoinoneill committed R37:d4fbf53155b2: Fixed bug where smudge brush did not respect 'Overlay Mode' while 'Smudge… (authored by eoinoneill).
Fixed bug where smudge brush did not respect 'Overlay Mode' while 'Smudge…
Oct 12 2018, 8:12 AM

Oct 10 2018

eoinoneill committed R37:7cd9f0b1afa1: Merge branch 'kinetic-COMPLETE' (authored by eoinoneill).
Merge branch 'kinetic-COMPLETE'
Oct 10 2018, 5:34 PM
eoinoneill committed R37:49da90708aa5: Global Kinetic Scrolling Added (authored by eoinoneill).
Global Kinetic Scrolling Added
Oct 10 2018, 5:34 PM
eoinoneill committed R37:8e19e4649445: Masks Can No Longer Be Added to Locked Layers (authored by eoinoneill).
Masks Can No Longer Be Added to Locked Layers
Oct 10 2018, 9:56 AM
eoinoneill committed R37:cf6a4209b832: Template Files No Longer Added to 'Recent Documents' List on the Krita Greeting… (authored by eoinoneill).
Template Files No Longer Added to 'Recent Documents' List on the Krita Greeting…
Oct 10 2018, 9:39 AM
eoinoneill committed R37:f7e40ac35804: Kis Tangent Normal Paintop Now Works in 16-Bit and 32-Bit Image Modes. (authored by eoinoneill).
Kis Tangent Normal Paintop Now Works in 16-Bit and 32-Bit Image Modes.
Oct 10 2018, 9:37 AM
eoinoneill committed R37:a2f1b0cbe300: Fixed Merge Multiple 'putAfter' Bug Causing Wrong Layers To Merge (authored by eoinoneill).
Fixed Merge Multiple 'putAfter' Bug Causing Wrong Layers To Merge
Oct 10 2018, 9:33 AM

Oct 9 2018

eoinoneill requested review of D16069: Fix Layer Merge Bug With Invisible 'PutAfter' Node.
Oct 9 2018, 10:31 AM · Krita
eoinoneill abandoned D16041: Correction for Merge Multiple Layers with Alpha Inheritance.

This has been resolved.

Oct 9 2018, 7:48 AM · Krita

Oct 8 2018

eoinoneill updated the diff for D15755: Global Kinetic Scrolling.

Changed KisKineticScrolling module from widgets to widgetutils in order to give other widgetutils access to KineticScrolling.

Oct 8 2018, 4:38 PM · Krita
eoinoneill retitled D16041: Correction for Merge Multiple Layers with Alpha Inheritance from Correction to Merge Multiple Layers with Alpha Inheritance to Correction for Merge Multiple Layers with Alpha Inheritance.
Oct 8 2018, 9:52 AM · Krita
eoinoneill updated the test plan for D16041: Correction for Merge Multiple Layers with Alpha Inheritance.
Oct 8 2018, 9:50 AM · Krita
eoinoneill requested review of D16041: Correction for Merge Multiple Layers with Alpha Inheritance.
Oct 8 2018, 9:48 AM · Krita

Oct 7 2018

eoinoneill requested review of D16027: Normal Map Brush Now Works in 32bit and 16bit modes.
Oct 7 2018, 7:36 PM · Krita
eoinoneill requested review of D16024: Remove Ability to Add Masks to Locked Layers.
Oct 7 2018, 6:11 PM · Krita
eoinoneill updated the diff for D16021: Template Files No Longer Added to 'Recent Documents' List on the Krita Greeting Page.

Added the break, removed unrelated formatting changes.

Oct 7 2018, 5:03 PM · Krita
eoinoneill requested review of D16021: Template Files No Longer Added to 'Recent Documents' List on the Krita Greeting Page.
Oct 7 2018, 4:41 PM · Krita
eoinoneill updated the diff for D15755: Global Kinetic Scrolling.

So I've corrected some of the issues regarding:

  • Properly formatting if statements
  • ToolboxScrollArea missing signal, as @rempt posted above.
  • Added all parameters of Kinetic Scrolling to configuration file for potential user overrides (not all are exposed in options panel).
  • Added kinetic scrolling to brush preset history docker.
Oct 7 2018, 10:28 AM · Krita

Oct 6 2018

eoinoneill updated the diff for D15755: Global Kinetic Scrolling.

Had to update this again due to a major naming refactor in backend I forgot to account for.

Oct 6 2018, 8:54 PM · Krita
eoinoneill updated the diff for D15755: Global Kinetic Scrolling.

So I've made the necessary revisions to the cmake file situation. Now the functions should be exported for linking.

Oct 6 2018, 7:54 PM · Krita

Sep 25 2018

woltherav awarded D15755: Global Kinetic Scrolling a Love token.
Sep 25 2018, 11:34 PM · Krita
eoinoneill requested review of D15755: Global Kinetic Scrolling.
Sep 25 2018, 10:15 PM · Krita

Sep 17 2018

eoinoneill updated the diff for D15564: Frame Color Selection Fix.

Some menu options in krita seem to already respond to the release of other mouse buttons, so I believed that it was unnecessary to check which button was pressed. However, I think that checking will lead to safer behavior (no chance of a Qt::NoButton or obscure mouse event triggering an accidental frame color selection.)

Sep 17 2018, 10:49 PM · Krita, Bugsquad
eoinoneill added a comment to D15564: Frame Color Selection Fix.

Sorry about that, I've revised the title of the diff.

Sep 17 2018, 3:53 AM · Krita, Bugsquad
eoinoneill retitled D15564: Frame Color Selection Fix from Bug Fix 394072 - Frame Color Selection Fix to Frame Color Selection Fix.
Sep 17 2018, 3:52 AM · Krita, Bugsquad
eoinoneill requested review of D15564: Frame Color Selection Fix.
Sep 17 2018, 1:54 AM · Krita, Bugsquad

Sep 15 2018

eoinoneill added a member for Bugsquad: eoinoneill.
Sep 15 2018, 8:17 PM

Jun 6 2018

eoinoneill added a watcher for Amarok: eoinoneill.
Jun 6 2018, 7:27 AM

Apr 6 2018

eoinoneill added a watcher for Krita: eoinoneill.
Apr 6 2018, 8:29 PM