The new code works using Kubuntu 18.04. Other people can do their checks. Thanks, Davide!
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Sep 15 2019
The new code works using Kubuntu 18.04. Other people can do their checks. Thanks, Davide!
Sep 4 2019
The baloon-like message presents strange behaviors when doing some resizing, if someone wants propose HTML+CSS code, or an image, or other way, in order to draw attention of more developers...
The disabled source code was removed, as nobody objected to it, and it's undoable.
Sometimes people are aware that there's a git history, but leave code disabled on purpose. Anyway, this change can be undone, too :-)
Sep 2 2019
I also have seen it when I tested published changelog files and wanted to remove it. Thanks for bringing my thoughts to live. :)
It's not rendered but mentioned in old comment in the report-bugs/index.html - can you remove the comment as well?
Reviewed and tested - all good! Thanks for the fix, Toni!
Sep 1 2019
Kindly ping
Kindly ping
Thanks, Nikita! After asking in the krusader-users mailing list, no objections were made since Aug . 19. The commit will be made.
Aug 31 2019
Aug 29 2019
Aug 28 2019
Aug 27 2019
"application/vnd.rar" was incorporated to krArc/krarc.protocol, as suggested by N. Higa. Two reminders were also added.
In D23476#520060, @nhiga wrote:Should we also add application/vnd.rar to krArc/krarc.protocol?
Note: The krarc.protocol file is also being talked about by N. Higa in https://phabricator.kde.org/D23476
Aug 26 2019
Aug 24 2019
Aug 22 2019
P.S.: Some steps still have to be done, like the ones that Nikita commented "It will be great to have starting steps for each type of work (for example, want to do Bug Triaging - go to the specific bugzilla link showing the list of not triaged bugs and try to repro bugs one by one, and then post your comments in the bugs)" or mentioning that a linked page is in English.
I suppose that today you have received a "Invitation to participate in a survey" mail from Lydia Pintscher. It reminds of when she wrote in https://phabricator.kde.org/T9581 about Krusader on Windows and "have you thought about using this as an opportunity to recruit someone new? Maybe a blog post or mailing list post asking if there is someone with the will and knowledge to drive this forward?", which has something to do with the subject of the present code review.
Aug 21 2019
Changes that were suggested.
In D23309#515717, @pino wrote:TBH I'd just add the instructions to https://krusader.org/get-involved/, and not to the user documentation.
Aug 20 2019
Some spaces were added, as Yuri suggested.
Aug 19 2019
How do you think a person is going to search whether kde4 version of krusader is getting updates? Will she likely go to a search engine and type something like "krusader kde4" where the mentioned repo will be in top positions due to good naming?
Aug 18 2019
It looks OK for me, thanks for it, Nikita!
It looks OK for me, thanks for it, Nikita!
For example, you can fork krusader on github or other platform [...]. What do you think about this idea, Toni?
For my part, I accept the proposal, Thanks for it, Nikita!
Well, some months have passed since Davide's commit :-( , let's see when normal Krusader users can take profit.
In D22957#513827, @nmel wrote:This is a very serious change because now #ifndef Q_OS_WIN or #else block after #ifdef Q_OS_WIN will include the code that previously was ignored. We must look at all those code paths and test features it affects. BTW, does it mean that some of those code paths do not work correctly in the current state?
Aug 16 2019
Thanks, Nikita! Because it's very handy, and it has been already tried a lot, it looks like a good idea to add the "Shortcuts to move tab" commit to the stable branch, and add to the ChangeLog file:
FIXED: [ 328937 ] Shortcuts for move tab
Aug 12 2019
Ok. Thanks, Alex and Davide!
Aug 10 2019
Aug 9 2019
Thanks, Nikita!
Aug 8 2019
An article about it has been published recently:
About deprecation of QFontMetrics::width() https://kdepepo.wordpress.com/2019/08/05/about-deprecation-of-qfontmetricswidth/
by @cfeck (Christoph Feck, who has commited some changes to the repository of Krusader).
Please also add the versioning data to the appdata file (maybe also add the information for the previous version this time):
Aug 7 2019
Hi, Luigi! Well, I was referring to the virtual machines running prior operating systems (and physical machines, I remember that the LTS support of Ubuntu 14.04 ended at the end of April and I still saw some of those machines). Sometimes the reason is that some programs do not run in recent versions of operating systems, other causes may exist.
There's also the case of Lliurex 16, an operating system installed in thousands of computers, I had to work with it and there I could only build the "kde4" version of Krusader.
Aug 5 2019
The new code works using Kubuntu 18.04 and 19.04. Krusader behaves as expected when it's asked to be closed:
- when its internal editor is not used,
- when its internal editor has a file that is not saved,
- when its internal editor has a file that is not saved and the computer is asked to reboot.
Aug 4 2019
the target audience of Krusader are more advanced users
If any developer is reading this, he'll probably know that those developments end up being a very complex subject. Thank you for all the source code, Alex!
Aug 2 2019
Aug 1 2019
Minor changes were performed.
I think the same, Nikita, and thanks for testing and informing!
I agree with you, Nikita. Thanks for testing and all the information!
Jul 30 2019
The new files were updated (copyright years were changed).
Jul 29 2019
This is the new version of the source code, after some minor improvements, having updated it because of the changes to the source code that have happened since the last time (like in krsearchdialog.cpp), and having used daily the classes meanwhile.
Jul 27 2019
Jul 23 2019
(optional) I'd use QFontMetrics::horizontalAdvance(A) and QFontMetrics::width(A) for additional type check.
Jul 22 2019
Jul 21 2019
It's an improvement. Thanks!
Jul 19 2019
The new code works using Kubuntu 18.04. Although the final behavior of Synchronizer is not perfect, the patch improves the current situation, therefore: thanks, Alex! (and Yuri :-) )
Jul 18 2019
The new code works as expected using Kubuntu 18.04. Thanks, Alex! (and Yuri and Nikita :-) )