Feed Advanced Search

Yesterday

asensi updated the diff for D23309: Change the document about helping Krusader, add other ways.

Changes that were suggested.

Wed, Aug 21, 9:30 PM · Krusader, Documentation
asensi added inline comments to D23309: Change the document about helping Krusader, add other ways.
Wed, Aug 21, 9:29 PM · Krusader, Documentation
asensi added a comment to D23309: Change the document about helping Krusader, add other ways.
In D23309#515717, @pino wrote:

TBH I'd just add the instructions to https://krusader.org/get-involved/, and not to the user documentation.

Wed, Aug 21, 6:32 AM · Krusader, Documentation

Tue, Aug 20

asensi updated the diff for D23276: Add more compressed file types to the list of file types that krarc supports.

Some spaces were added, as Yuri suggested.

Tue, Aug 20, 10:01 PM · Krusader
asensi added inline comments to D23276: Add more compressed file types to the list of file types that krarc supports.
Tue, Aug 20, 9:59 PM · Krusader
asensi requested review of D23309: Change the document about helping Krusader, add other ways.
Tue, Aug 20, 9:53 PM · Krusader, Documentation

Mon, Aug 19

asensi added a comment to D23001: For the "kde4" branch: 08 - Update the synchronizer.docbook file because of the latest changes REVIEW: 124335.

How do you think a person is going to search whether kde4 version of krusader is getting updates? Will she likely go to a search engine and type something like "krusader kde4" where the mentioned repo will be in top positions due to good naming?

Mon, Aug 19, 9:17 PM · Krusader, Documentation
asensi updated the summary of D23276: Add more compressed file types to the list of file types that krarc supports.
Mon, Aug 19, 9:07 PM · Krusader
asensi requested review of D23276: Add more compressed file types to the list of file types that krarc supports.
Mon, Aug 19, 9:05 PM · Krusader

Sun, Aug 18

asensi accepted D23235: Released v2.7.2.

It looks OK for me, thanks for it, Nikita!

Sun, Aug 18, 8:30 PM · Krusader
asensi accepted D23236: Updates related to v2.7.2 release.

It looks OK for me, thanks for it, Nikita!

Sun, Aug 18, 8:30 PM · Krusader
asensi added a comment to D23001: For the "kde4" branch: 08 - Update the synchronizer.docbook file because of the latest changes REVIEW: 124335.

For example, you can fork krusader on github or other platform [...]. What do you think about this idea, Toni?

Sun, Aug 18, 8:21 PM · Krusader, Documentation
asensi accepted D23197: Updated ChangeLog and NEWS with v2.7.2 changes.

For my part, I accept the proposal, Thanks for it, Nikita!

Sun, Aug 18, 7:57 PM · Krusader
asensi added a comment to D23197: Updated ChangeLog and NEWS with v2.7.2 changes.

Well, some months have passed since Davide's commit :-( , let's see when normal Krusader users can take profit.

Sun, Aug 18, 7:50 PM · Krusader
asensi added a comment to D22957: Replace Q_WS_WIN with Q_OS_WIN in all the source code.
In D22957#513827, @nmel wrote:

This is a very serious change because now #ifndef Q_OS_WIN or #else block after #ifdef Q_OS_WIN will include the code that previously was ignored. We must look at all those code paths and test features it affects. BTW, does it mean that some of those code paths do not work correctly in the current state?

Sun, Aug 18, 7:41 PM · Krusader
asensi updated the summary of D22957: Replace Q_WS_WIN with Q_OS_WIN in all the source code.
Sun, Aug 18, 7:33 PM · Krusader
asensi updated subscribers of D23243: Avoid that Krusader crashes when trying to view any archive using the ark part.
Sun, Aug 18, 7:24 PM · Krusader
asensi requested review of D23243: Avoid that Krusader crashes when trying to view any archive using the ark part.
Sun, Aug 18, 7:20 PM · Krusader

Fri, Aug 16

asensi added a comment to D23197: Updated ChangeLog and NEWS with v2.7.2 changes.

Thanks, Nikita! Because it's very handy, and it has been already tried a lot, it looks like a good idea to add the "Shortcuts to move tab" commit to the stable branch, and add to the ChangeLog file:

FIXED: [ 328937 ] Shortcuts for move tab
Fri, Aug 16, 8:55 PM · Krusader

Mon, Aug 12

asensi retitled D23118: Because Ctrl+Alt+T is now a global shortcut, use another shortcut for the embedded terminal emulator from Because Ctrl+Alt+T is now a global shortcut, use another one for the embedded terminal emulator to Because Ctrl+Alt+T is now a global shortcut, use another shortcut for the embedded terminal emulator.
Mon, Aug 12, 9:53 PM · Krusader
asensi requested review of D23118: Because Ctrl+Alt+T is now a global shortcut, use another shortcut for the embedded terminal emulator.
Mon, Aug 12, 9:52 PM · Krusader
asensi committed R167:2fb1d7febde8: Clarify the aim of two lines written recently by David Faure (authored by asensi).
Clarify the aim of two lines written recently by David Faure
Mon, Aug 12, 9:24 PM
asensi closed D22883: Clarify the aim of two lines written recently by David Faure.
Mon, Aug 12, 9:24 PM · Krusader
asensi added a comment to D22883: Clarify the aim of two lines written recently by David Faure.

Ok. Thanks, Alex and Davide!

Mon, Aug 12, 9:24 PM · Krusader

Sat, Aug 10

asensi edited the content of Release Howto.
Sat, Aug 10, 6:38 AM · Krusader

Fri, Aug 9

asensi edited the content of Release Howto.
Fri, Aug 9, 10:20 PM · Krusader
asensi edited the content of Release Howto.
Fri, Aug 9, 10:12 PM · Krusader
asensi accepted D22982: Updated release information in docs.

Thanks, Nikita!

Fri, Aug 9, 5:57 AM · Krusader, Documentation
asensi updated subscribers of D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.
Fri, Aug 9, 5:42 AM · Krusader

Thu, Aug 8

asensi updated subscribers of D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.

An article about it has been published recently:

About deprecation of QFontMetrics::width()
https://kdepepo.wordpress.com/2019/08/05/about-deprecation-of-qfontmetricswidth/

by @cfeck (Christoph Feck, who has commited some changes to the repository of Krusader).

Thu, Aug 8, 10:20 PM · Krusader
asensi added a comment to D22982: Updated release information in docs.

Please also add the versioning data to the appdata file (maybe also add the information for the previous version this time):

Thu, Aug 8, 8:48 PM · Krusader, Documentation

Wed, Aug 7

asensi added a comment to D23001: For the "kde4" branch: 08 - Update the synchronizer.docbook file because of the latest changes REVIEW: 124335.

Hi, Luigi! Well, I was referring to the virtual machines running prior operating systems (and physical machines, I remember that the LTS support of Ubuntu 14.04 ended at the end of April and I still saw some of those machines). Sometimes the reason is that some programs do not run in recent versions of operating systems, other causes may exist.
There's also the case of Lliurex 16, an operating system installed in thousands of computers, I had to work with it and there I could only build the "kde4" version of Krusader.

Wed, Aug 7, 3:41 PM · Krusader, Documentation
asensi requested review of D23003: For the "kde4" branch: 10 - Avoid closing the tab when the user {presses Esc inside the Krusader internal editor in order to try to exit searching}; thanks to Martin Kotelnik.
Wed, Aug 7, 3:12 PM · Krusader
asensi requested review of D23002: For the "kde4" branch: 09 - Make Alt+. the default shortcut for toggling hidden files.
Wed, Aug 7, 3:12 PM · Documentation, Krusader
asensi requested review of D23001: For the "kde4" branch: 08 - Update the synchronizer.docbook file because of the latest changes REVIEW: 124335.
Wed, Aug 7, 3:12 PM · Krusader, Documentation
asensi requested review of D23000: For the "kde4" branch: 07 - In the synchronizer: until the bug 270150 is solved, stop using protocols like FISH, SFTP, SMB, etc. Check if the target or the source directory are empty.
Wed, Aug 7, 3:11 PM · Krusader
asensi requested review of D22999: For the "kde4" branch: 06 - Reverse defaults for Synchronizer.
Wed, Aug 7, 3:11 PM · Krusader
asensi requested review of D22998: For the "kde4" branch: 05 - Fix definition scope for Synchronizer in CMake.
Wed, Aug 7, 3:11 PM · Krusader
asensi requested review of D22997: For the "kde4" branch: 04 - Update the main CMakeLists.txt to enable by default the building of synchronizer.
Wed, Aug 7, 3:10 PM · Krusader
asensi requested review of D22996: For the "kde4" branch: 03 - Use the same font for file name and renamed file name; solved by Tobias BUG: 326649.
Wed, Aug 7, 3:10 PM · Krusader
asensi requested review of D22995: For the "kde4" branch: 02 - Names of files are correctly seen when a zip file is opened, even if they are utf-8 encoded.
Wed, Aug 7, 3:10 PM · Krusader
asensi requested review of D22994: For the "kde4" branch: 01 - Solve a bug that didn't allow Krusader to search files inside zip archives; thanks to Dawid Weiss BUG: 292867 REVIEW: 124343.
Wed, Aug 7, 3:10 PM · Krusader

Mon, Aug 5

asensi requested review of D22957: Replace Q_WS_WIN with Q_OS_WIN in all the source code.
Mon, Aug 5, 9:06 PM · Krusader
asensi accepted D22932: Remove 'isExiting' logic from closing sequence.

The new code works using Kubuntu 18.04 and 19.04. Krusader behaves as expected when it's asked to be closed:

  • when its internal editor is not used,
  • when its internal editor has a file that is not saved,
  • when its internal editor has a file that is not saved and the computer is asked to reboot.
Mon, Aug 5, 5:23 AM · Krusader

Sun, Aug 4

asensi added a comment to D22891: If an item that is going to be renamed is also going to be hidden by default, then warn the user.

the target audience of Krusader are more advanced users

Sun, Aug 4, 10:28 PM · Krusader
asensi added a comment to D22666: Achieve that Krusader searches correctly if the "Follow links" checkbox is disabled.

If any developer is reading this, he'll probably know that those developments end up being a very complex subject. Thank you for all the source code, Alex!

Sun, Aug 4, 10:14 PM · Krusader

Fri, Aug 2

asensi requested review of D22891: If an item that is going to be renamed is also going to be hidden by default, then warn the user.
Fri, Aug 2, 12:59 PM · Krusader

Thu, Aug 1

asensi requested review of D22883: Clarify the aim of two lines written recently by David Faure.
Thu, Aug 1, 9:50 PM · Krusader
asensi updated the diff for D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Minor changes were performed.

Thu, Aug 1, 8:56 PM · Krusader
asensi added inline comments to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.
Thu, Aug 1, 8:52 PM · Krusader
asensi added a comment to D22673: Set the focus on the first search result.

I think the same, Nikita, and thanks for testing and informing!

Thu, Aug 1, 8:41 PM · Krusader
asensi added a comment to D22666: Achieve that Krusader searches correctly if the "Follow links" checkbox is disabled.

I agree with you, Nikita. Thanks for testing and all the information!

Thu, Aug 1, 8:39 PM · Krusader
asensi retitled D22666: Achieve that Krusader searches correctly if the "Follow links" checkbox is disabled from Achieve that Krusader searches correctly if the the "Follow links" checkbox is disabled to Achieve that Krusader searches correctly if the "Follow links" checkbox is disabled.
Thu, Aug 1, 8:38 PM · Krusader
asensi committed R167:c6e33258099b: Set the focus on the first search result (authored by asensi).
Set the focus on the first search result
Thu, Aug 1, 6:01 AM
asensi committed R167:996f481fe499: Achieve that Krusader searches correctly if the "Follow links" checkbox is… (authored by asensi).
Achieve that Krusader searches correctly if the "Follow links" checkbox is…
Thu, Aug 1, 6:01 AM
asensi committed R167:a4ad17bab0be: Set the focus on the first search result (authored by asensi).
Set the focus on the first search result
Thu, Aug 1, 5:56 AM
asensi closed D22673: Set the focus on the first search result.
Thu, Aug 1, 5:56 AM · Krusader
asensi committed R167:ce1941db1d8e: Achieve that Krusader searches correctly if the "Follow links" checkbox is… (authored by asensi).
Achieve that Krusader searches correctly if the "Follow links" checkbox is…
Thu, Aug 1, 5:51 AM
asensi closed D22666: Achieve that Krusader searches correctly if the "Follow links" checkbox is disabled.
Thu, Aug 1, 5:51 AM · Krusader

Tue, Jul 30

asensi updated the diff for D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

The new files were updated (copyright years were changed).

Tue, Jul 30, 8:48 AM · Krusader

Mon, Jul 29

asensi updated the diff for D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

This is the new version of the source code, after some minor improvements, having updated it because of the changes to the source code that have happened since the last time (like in krsearchdialog.cpp), and having used daily the classes meanwhile.

Mon, Jul 29, 9:25 PM · Krusader

Sat, Jul 27

asensi added reviewers for D22666: Achieve that Krusader searches correctly if the "Follow links" checkbox is disabled: gengisdave, nmel, abika, yurchor.
Sat, Jul 27, 7:33 PM · Krusader
asensi added reviewers for D22673: Set the focus on the first search result: gengisdave, nmel, abika, yurchor.
Sat, Jul 27, 7:30 PM · Krusader

Tue, Jul 23

asensi accepted D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.

(optional) I'd use QFontMetrics::horizontalAdvance(A) and QFontMetrics::width(A) for additional type check.

Tue, Jul 23, 10:11 PM · Krusader
asensi requested review of D22673: Set the focus on the first search result.
Tue, Jul 23, 6:38 AM · Krusader

Jul 22 2019

asensi requested review of D22666: Achieve that Krusader searches correctly if the "Follow links" checkbox is disabled.
Jul 22 2019, 10:06 PM · Krusader

Jul 21 2019

asensi accepted D22435: Remove obsolete qt version check.

It's an improvement. Thanks!

Jul 21 2019, 5:32 AM · Krusader

Jul 19 2019

asensi accepted D22177: Panel: Improve open actions in context menu.
Jul 19 2019, 10:32 PM · Krusader
asensi accepted D22174: Synchronizer: Set column headers to adjust widths automatically.

The new code works using Kubuntu 18.04. Although the final behavior of Synchronizer is not perfect, the patch improves the current situation, therefore: thanks, Alex! (and Yuri :-) )

Jul 19 2019, 10:27 PM · Krusader

Jul 18 2019

asensi added a comment to D22177: Panel: Improve open actions in context menu.

The new code works as expected using Kubuntu 18.04. Thanks, Alex! (and Yuri and Nikita :-) )

Jul 18 2019, 9:36 PM · Krusader

May 25 2019

asensi accepted D21323: Shortcuts for move tab.

The new code works using Kubuntu 19.04. Other people can do their checks. Davide, using the same keys as Chromium, Firefox, Libreoffice Calc, etc. is a advantage. Thanks, Davide! (and Nikita :-) )

May 25 2019, 7:09 AM · Krusader

Oct 7 2018

asensi added a comment to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Maybe a visual hint would be good so that the users know this feature exists.

Oct 7 2018, 5:26 PM · Krusader
asensi updated the diff for D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Some changes were made after Alex Bikadorov made some propositions.

Oct 7 2018, 5:01 PM · Krusader
asensi added inline comments to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.
Oct 7 2018, 4:43 PM · Krusader
asensi updated the diff for D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Some changes were made after Alex Bikadorov made some propositions.

Oct 7 2018, 4:08 PM · Krusader

Oct 2 2018

asensi added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Since INSERT becomes kind of "global" macro, I suggest we rename it to UDS_ENTRY_INSERT, since the insert word is too generic while the implementation is not. Thanks!

Oct 2 2018, 5:13 PM · Krusader

Sep 28 2018

asensi committed R167:366a570b0830: Solve a memory leak in the Locate dialog, achieve that its destructor is able… (authored by asensi).
Solve a memory leak in the Locate dialog, achieve that its destructor is able…
Sep 28 2018, 6:41 AM
asensi committed R167:e9587d582ed6: Solve a memory leak in the Locate dialog, achieve that its destructor is able… (authored by asensi).
Solve a memory leak in the Locate dialog, achieve that its destructor is able…
Sep 28 2018, 6:38 AM
asensi closed D15678: Solve a memory leak in the Locate dialog, achieve that its destructor is able to work, and so on.
Sep 28 2018, 6:38 AM · Krusader

Sep 23 2018

asensi updated the diff for D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Another address was updated

Sep 23 2018, 6:55 AM · Krusader

Sep 22 2018

asensi updated the diff for D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

An address was updated

Sep 22 2018, 6:11 PM · Krusader
asensi requested review of D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.
Sep 22 2018, 4:22 PM · Krusader
asensi updated the diff for D15678: Solve a memory leak in the Locate dialog, achieve that its destructor is able to work, and so on.

Thanks, Nikita, those lines will be added to the commit message:

FIXED: Memory leak in the Locate dialog
Differential Revision: https://phabricator.kde.org/D15678
Sep 22 2018, 3:57 PM · Krusader
asensi added a comment to D15400: Fix compile warnings on missing override declarations.

Confirmed by the build (https://build.kde.org/job/Extragear/job/krusader/job/kf5-qt5%20FreeBSDQt5.11/4/warnings12Result/), 51 warnings fixed and 'missing-override' is not in the remaining 57.

Sep 22 2018, 9:57 AM · Krusader

Sep 21 2018

asensi updated the test plan for D15678: Solve a memory leak in the Locate dialog, achieve that its destructor is able to work, and so on.
Sep 21 2018, 1:35 PM · Krusader
asensi requested review of D15678: Solve a memory leak in the Locate dialog, achieve that its destructor is able to work, and so on.
Sep 21 2018, 1:28 PM · Krusader
asensi accepted D15400: Fix compile warnings on missing override declarations.

The new version works using Kubuntu 18.04. Other people can do their checks. Thanks, Davide! (and Nikita :-) )

Sep 21 2018, 1:17 PM · Krusader

Sep 13 2018

asensi added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Thanks Davide! (and Nikita :-) )

Sep 13 2018, 6:14 PM · Krusader
asensi accepted D15400: Fix compile warnings on missing override declarations.

It's nice to hear from you again, Davide!

Sep 13 2018, 4:34 PM · Krusader

Sep 3 2018

asensi added a comment to T9581: Publish Krusader in the Microsoft Store.

Thank you very much for all, Lydia, although as far as Krusader developers know, there is no Windows version of Krusader (contributions are very welcome :-)).

Sep 3 2018, 4:49 PM · Krusader, Windows

Aug 19 2018

asensi committed R938:f6fe9aad5896: Several minor changes were made (authored by asensi).
Several minor changes were made
Aug 19 2018, 11:57 AM

Aug 17 2018

asensi committed R167:8af1dcaf489b: Several minor changes (authored by asensi).
Several minor changes
Aug 17 2018, 4:25 PM
asensi committed R167:382462097eaf: Several minor changes (authored by asensi).
Several minor changes
Aug 17 2018, 1:38 PM

Aug 15 2018

asensi edited the content of Release Howto.
Aug 15 2018, 6:58 AM · Krusader

Aug 14 2018

asensi edited the content of Release Howto.
Aug 14 2018, 8:02 PM · Krusader

Aug 13 2018

asensi added a comment to D14265: Search: Simplify result tab layout in search dialog.

For future reference, the commits may be seen in:

Aug 13 2018, 10:52 AM · Krusader

Aug 9 2018

asensi edited the content of Release Howto.
Aug 9 2018, 6:37 PM · Krusader
asensi accepted D14619: Updated ChangeLog and NEWS with v2.7.1 changes.

It looks right to me :-)

Aug 9 2018, 5:44 PM · Krusader
asensi edited the content of Release Howto.
Aug 9 2018, 11:24 AM · Krusader
asensi accepted D14622: Published v2.7.1.

For my part, I accept the proposal, thanks :-)

Aug 9 2018, 11:20 AM · Krusader