Thanks! This review continues on https://invent.kde.org/utilities/krusader/-/merge_requests/8

Ctrl+Up and Ctrl+Down would stop working 😔 and IIRC Davide was trying to solve that.

Taking into account the latest messages here, and after several months of using this helpful commit, I've published the commit before the Phabricator to Gitlab migration started. Please, feel free to suggest or improve whatever you consider.

Taking into account the latest messages here, and after several months of using this helpful commit, I've published the commit before the Phabricator to Gitlab migration started. Please, feel free to suggest or improve whatever you consider.

Dear developers,

Dear developers,

Thank you, Davide and Yuri!

Adapted the proposal to the current code base, with minor improvements.

Thank you, Davide!

Note: After adding the last review request, this task is assumed to be complete.

Two lines were also removed.

Add the setToolTip()calling , so hints are also shown on labels on mouse-over .

Thank you, Davide, for those important changes!

I also accept the new version of the proposal, of course :-)

Thanks, Davide! (and Yuri :-) ) The resulting code worked under Kubuntu 18.04 and Kubuntu 20.04, using the brief and the detailed view. Other people can do their checks.

Thanks, Davide! The resulting code worked under Kubuntu 18.04 and Kubuntu 20.04, other people can do their checks. I attach some .desktop files:

Both changes described there have been applied. Thanks, Davide!

It this code review is accepted, I'll add similar code but for widgets which are not spinBoxes.

In D29429#663490, @gengisdave wrote:

Fine to me, please add a TODO to move the tooltip association inside createSpinBox() (eventually with the related QLabel)

Thanks for testing and informing, Yuri and Davide!