Feed Advanced Search

Yesterday

asensi added a comment to D27534: Utilize the building way used in other places like the 'Release Howto' and the INSTALL file. Use `make -j$(nproc)`.

Hello, what do you think about using make -j$(nproc) instead of just make this way all the available
cores are used for compiling.
This is just a little trick I sometimes forget to change when I follow build instructions.

Sat, Feb 22, 7:32 PM · Krusader
asensi updated the summary of D27534: Utilize the building way used in other places like the 'Release Howto' and the INSTALL file. Use `make -j$(nproc)`.
Sat, Feb 22, 7:31 PM · Krusader
asensi updated the diff for D27534: Utilize the building way used in other places like the 'Release Howto' and the INSTALL file. Use `make -j$(nproc)`.

As Alex Lohnau proposed, use make -j$(nproc).

Sat, Feb 22, 7:30 PM · Krusader

Thu, Feb 20

asensi requested review of D27534: Utilize the building way used in other places like the 'Release Howto' and the INSTALL file. Use `make -j$(nproc)`.
Thu, Feb 20, 11:31 PM · Krusader

Wed, Feb 19

asensi accepted D27302: Update obsolete KProcess::error.

I've been using daily those changes for more than a week and everything looked alright. Other people can do their checks. Thanks, Davide!

Wed, Feb 19, 10:30 PM · Krusader
asensi accepted D27290: Update obsolete QWidget::getContentsMargins.

I've been using daily those changes for more than a week and everything looked alright. Other people can do their checks. Thanks, Davide!

Wed, Feb 19, 10:30 PM · Krusader
asensi accepted D27289: Update obsolete QString::sprintf.

I've been using daily those changes for more than a week and everything looked alright. Other people can do their checks. Thanks, Davide!

Wed, Feb 19, 10:29 PM · Krusader

Sun, Feb 16

asensi added a comment to D27259: Manage the use of Shift+F4 when opening a local file that exists, or a remote folder or remote file that exists.

Note: There are related changes in https://phabricator.kde.org/D27446

Sun, Feb 16, 9:38 PM · Krusader
asensi requested review of D27446: Changes in names of variables, functions, and comments (due to recent changes and old ones).
Sun, Feb 16, 9:30 PM · Krusader

Sat, Feb 15

asensi committed R167:9b9fa9d70d00: Manage the use of Shift+F4 when opening a local file that exists, or a remote… (authored by asensi).
Manage the use of Shift+F4 when opening a local file that exists, or a remote…
Sat, Feb 15, 5:26 PM
asensi closed D27259: Manage the use of Shift+F4 when opening a local file that exists, or a remote folder or remote file that exists.

Thanks, Yuri and Davide!

Sat, Feb 15, 5:25 PM · Krusader
asensi committed R167:a11b93d57157: Allow Krusader to be built under the 16.04 LTS versions of Ubuntu, Kubuntu, etc (authored by asensi).
Allow Krusader to be built under the 16.04 LTS versions of Ubuntu, Kubuntu, etc
Sat, Feb 15, 5:15 PM
asensi closed D27335: Allow Krusader to be built under the 16.04 LTS versions of Ubuntu, Kubuntu, etc.
Sat, Feb 15, 5:15 PM · Documentation, Krusader
asensi committed R167:419ac6ec8394: Manage what happens when a PanelViewerBase (e.g. using Shift+F3) is being used… (authored by asensi).
Manage what happens when a PanelViewerBase (e.g. using Shift+F3) is being used…
Sat, Feb 15, 5:14 PM
asensi closed D27258: Manage what happens when a PanelViewerBase (e.g. using Shift+F3) tries to open a nonexistent local file.

Closed by commit https://cgit.kde.org/krusader.git/commit/?id=419ac6ec839414bbae52849af536bc8ba1da83e4

Sat, Feb 15, 5:12 PM · Krusader
asensi added a comment to D27258: Manage what happens when a PanelViewerBase (e.g. using Shift+F3) tries to open a nonexistent local file.

Thanks, Yuri and Davide!

Sat, Feb 15, 5:01 PM · Krusader
asensi added a comment to D27335: Allow Krusader to be built under the 16.04 LTS versions of Ubuntu, Kubuntu, etc.

Thanks, Yuri, Antonio and Davide!

Sat, Feb 15, 5:00 PM · Documentation, Krusader

Tue, Feb 11

asensi requested review of D27335: Allow Krusader to be built under the 16.04 LTS versions of Ubuntu, Kubuntu, etc.
Tue, Feb 11, 11:07 PM · Documentation, Krusader

Sat, Feb 8

asensi requested review of D27259: Manage the use of Shift+F4 when opening a local file that exists, or a remote folder or remote file that exists.
Sat, Feb 8, 7:37 PM · Krusader
asensi requested review of D27258: Manage what happens when a PanelViewerBase (e.g. using Shift+F3) tries to open a nonexistent local file.
Sat, Feb 8, 7:16 PM · Krusader

Fri, Feb 7

asensi committed R167:babb658a5768: Update information in the INSTALL file, make some steps clearer, cover some… (authored by asensi).
Update information in the INSTALL file, make some steps clearer, cover some…
Fri, Feb 7, 11:47 PM
asensi closed D27076: Update information in the INSTALL file, make some steps clearer, cover some more cases.
Fri, Feb 7, 11:47 PM · Krusader

Fri, Jan 31

asensi requested review of D27076: Update information in the INSTALL file, make some steps clearer, cover some more cases.
Fri, Jan 31, 10:10 PM · Krusader
asensi committed R938:ca2559adf4aa: More information was added about how people can help Krusader (authored by asensi).
More information was added about how people can help Krusader
Fri, Jan 31, 2:18 AM
asensi committed R938:13e2074c7093: Fix links on docs.kde.org (authored by yurchor).
Fix links on docs.kde.org
Fri, Jan 31, 2:18 AM

Thu, Jan 30

asensi closed D24480: Change the document about helping Krusader, add other ways (2).

Closing it manually because it wasn't closed automatically when performing the commit.

Thu, Jan 30, 11:13 PM · Krusader
asensi closed D26754: Fix links on docs.kde.org.

Closing it manually because it wasn't closed automatically when performing the commit.

Thu, Jan 30, 11:12 PM
asensi committed R167:10c9b00623b0: Change the document about helping Krusader, add other ways (authored by asensi).
Change the document about helping Krusader, add other ways
Thu, Jan 30, 11:10 PM
asensi closed D23309: Change the document about helping Krusader, add other ways.
Thu, Jan 30, 11:10 PM · Krusader, Documentation
asensi added a comment to D24480: Change the document about helping Krusader, add other ways (2).

This modification and the related one (https://phabricator.kde.org/D23309) can be applied after the latest changes by Yuri to the website (https://phabricator.kde.org/D26754). Thanks Pino, Yuri and Nikita!

Thu, Jan 30, 10:56 PM · Krusader
asensi added a comment to D23309: Change the document about helping Krusader, add other ways.

This modification and the related one (https://phabricator.kde.org/D24480) can be applied after the latest changes by Yuri to the website (https://phabricator.kde.org/D26754). Thanks Pino, Yuri and Nikita!

Thu, Jan 30, 10:50 PM · Krusader, Documentation

Wed, Jan 29

asensi added a comment to D26754: Fix links on docs.kde.org.

Hi! This change seems to be very necessary nowadays. If there's any problem applying it, I can commit it myself.

Wed, Jan 29, 9:57 PM

Mon, Jan 27

asensi accepted D24987: Add Kompare as compare application with KIO support.

The new version of the proposal keeps being acceptable, of course :-)

Mon, Jan 27, 11:22 PM · Krusader
asensi added a comment to D26291: rework of keyboard widgets focus.

So we have to consider that CTRL+UP/DOWN cannot be used anymore as before and users may complain about it. However, this did
also not work for the embedded terminal (see bug report) and for the sidebar before this patch.

Mon, Jan 27, 11:18 PM · Krusader, Documentation
asensi closed D26741: Synchronizer: Set the focus on the Compare button after selecting a profile.
Mon, Jan 27, 10:59 PM · Krusader
asensi committed R167:5c79a2790110: Synchronizer: Set the focus on the Compare button after selecting a profile (authored by asensi).
Synchronizer: Set the focus on the Compare button after selecting a profile
Mon, Jan 27, 10:59 PM
asensi updated the diff for D26741: Synchronizer: Set the focus on the Compare button after selecting a profile.

Previously, syncList->setFocus(); was utilized as it was used in three other places in the same file, although with btnCompareDirs->setFocus(); the intentions becomes clearer. Thanks, Alex! (and Yuri :-)

Mon, Jan 27, 10:57 PM · Krusader

Sat, Jan 25

asensi updated the diff for D24480: Change the document about helping Krusader, add other ways (2).

An address was changed, following what Yuri recently applied (e.g. it can be seen in Fix links on docs.kde.org).

Sat, Jan 25, 7:52 PM · Krusader

Jan 24 2020

asensi requested review of D26887: Synchronizer: Avoid that, in several cases, the default action is to overwrite a file with an old version of it.
Jan 24 2020, 12:23 AM · Krusader

Jan 23 2020

asensi added a comment to T12568: Permissions and docs.kde.org.

The source code of Krusader has been modified in order to make Krusader build with older software.
With that, maybe some time can be gained.

Jan 23 2020, 10:51 PM · Sysadmin
asensi committed R167:582588663724: Change docbooks in order to make Krusader build at least under (K)Ubuntu 18.04… (authored by asensi).
Change docbooks in order to make Krusader build at least under (K)Ubuntu 18.04…
Jan 23 2020, 10:03 PM
asensi closed D26817: Change docbooks in order to make Krusader build at least under (K)Ubuntu 18.04 LTS and in docs.kde.org.
Jan 23 2020, 10:03 PM · Krusader, Documentation
asensi retitled D26817: Change docbooks in order to make Krusader build at least under (K)Ubuntu 18.04 LTS and in docs.kde.org from Change docbooks in order to make Krusader build at least under Kubuntu/Ubuntu 18.04 LTS to Change docbooks in order to make Krusader build at least under (K)Ubuntu 18.04 LTS and in docs.kde.org.
Jan 23 2020, 9:43 PM · Krusader, Documentation

Jan 22 2020

asensi updated the diff for D26817: Change docbooks in order to make Krusader build at least under (K)Ubuntu 18.04 LTS and in docs.kde.org.

The changes suggested by Yuri Chornoivan were made, also the USB entity was defined.

Jan 22 2020, 9:41 PM · Krusader, Documentation

Jan 21 2020

asensi requested review of D26817: Change docbooks in order to make Krusader build at least under (K)Ubuntu 18.04 LTS and in docs.kde.org.
Jan 21 2020, 10:20 PM · Krusader, Documentation

Jan 20 2020

asensi accepted D13007: Synchronizer: Rework.

Well, as Martin couldn't answer in https://phabricator.kde.org/T8761, time passes, modifications are made in the source code and therefore we are at danger of losing Alex's work (because e.g. nowadays the proposal no longer can be applied as it is), and the situation does not get better: I've tried what Alex proposed and it worked under Kubuntu 18.04 LTS and Kubuntu 19.10 (after adapting that code to the current Krusader codebase, I attach a file that contains the adaptation).

Jan 20 2020, 11:42 PM
asensi created T12568: Permissions and docs.kde.org.
Jan 20 2020, 11:11 PM · Sysadmin

Jan 18 2020

asensi accepted D26754: Fix links on docs.kde.org.

The mentioned links work. Thanks, Yuri!

Jan 18 2020, 7:23 PM

Jan 17 2020

asensi requested review of D26741: Synchronizer: Set the focus on the Compare button after selecting a profile.
Jan 17 2020, 10:24 PM · Krusader

Jan 16 2020

asensi added a comment to D24987: Add Kompare as compare application with KIO support.

Meanwhile the other issues are talked about, I performed some tests under Kubuntu 18.04 LTS and Kubuntu 19.10 and the resulting code worked. Thanks, Alex, Yuri and Pino!

Jan 16 2020, 11:20 PM · Krusader
asensi accepted D24809: Archive: Fix invalid destination URL when packing/unpacking from remote location.

The proposal was tested and local and SMB files were correctly transferred files using Kubuntu 18.04 LTS and Kubuntu 19.10. Other people can do their checks. Thanks, Alex! (and Davide for testing)

Jan 16 2020, 10:13 PM · Krusader

Jan 15 2020

asensi accepted D26269: Remove deprecated mostLocalUrl.

The improvements worked under Kubuntu 18.04 LTS and Kubuntu 19.10, other people can do their checks. Thanks, Davide!

Jan 15 2020, 11:08 PM · Krusader
asensi added a comment to D26291: rework of keyboard widgets focus.

The base of the idea is good, although after applying changes... Krusader users are not able to keep using the handy Ctrl+ and Ctrl+ to move focus even if they redefine the Move Focus Up and Move Focus Down keys :-?

Jan 15 2020, 10:49 PM · Krusader, Documentation
asensi accepted D26280: Move 'connect' call before openUrl.

Thanks, the proposal worked under Kubuntu 18.04 LTS and Kubuntu 19.10, other people can do their checks.

Jan 15 2020, 10:21 PM · Krusader
asensi added a comment to D26334: Select item from search window.

Note: In other words, the proposal solves the cases where people e.g. search for a file, press Return (or double-click) on a result, and sometimes that action leads them to that file, and sometimes it doesn't.

Jan 15 2020, 10:07 PM · Krusader

Jan 14 2020

asensi accepted D26325: Update deprecated KUrlLabel::leftClickedUrl.

The new code works using Kubuntu 18.04 LTS and Kubuntu 19.10, other people can do their checks. Thanks, Davide!

Jan 14 2020, 10:18 PM · Krusader
asensi accepted D26334: Select item from search window.

That bug has been hindering Krusader users for too long, thanks Davide! :-)

Jan 14 2020, 10:00 PM · Krusader

Oct 7 2019

asensi updated the diff for D23309: Change the document about helping Krusader, add other ways.

The first part of the splitted code remains in this code review, and the second part is now in https://phabricator.kde.org/D24480 .

Oct 7 2019, 9:32 PM · Krusader, Documentation
asensi added a comment to D23309: Change the document about helping Krusader, add other ways.

This diff contains combined changes on two separate repositories. Phabricator will have a problem with this kind of change. Please split into two reviews. I'm ok with the content.

Oct 7 2019, 9:31 PM · Krusader, Documentation
asensi requested review of D24480: Change the document about helping Krusader, add other ways (2).
Oct 7 2019, 9:28 PM · Krusader
asensi added a comment to D24026: Replace explicite type casting with dynamic casts.

Hi, Alex, thanks for improving the source code, I would like to add that the krusader/GUI/krhistorycombobox.cpp code has been reviewed recently and replacing

auto keyEvent = static_cast<QKeyEvent *>(event);

with

auto keyEvent = dynamic_cast<QKeyEvent *>(event);

would not be what it's written in https://doc.qt.io/qt-5/qobject.html:

QKeyEvent *keyEvent = static_cast<QKeyEvent *>(event);

The same could be said about

krusader/Panel/krsearchbar.cpp

and its existing

auto *ke = static_cast<QKeyEvent *>(event);
Oct 7 2019, 9:17 PM · Krusader

Sep 15 2019

asensi committed R167:db9797b643d6: Replace Q_WS_WIN with Q_OS_WIN in all the source code (authored by asensi).
Replace Q_WS_WIN with Q_OS_WIN in all the source code
Sep 15 2019, 10:13 PM
asensi closed D22957: Replace Q_WS_WIN with Q_OS_WIN in all the source code.
Sep 15 2019, 10:13 PM · Krusader
asensi added a comment to D22957: Replace Q_WS_WIN with Q_OS_WIN in all the source code.

I agree with you. Thanks Alex and Nikita! (and Moritz :-)

Sep 15 2019, 10:12 PM · Krusader
asensi committed R167:7905b361c959: Identify the "vnd.comicbook+zip" and "vnd.comicbook-rar" MIME types in order to… (authored by asensi).
Identify the "vnd.comicbook+zip" and "vnd.comicbook-rar" MIME types in order to…
Sep 15 2019, 9:57 PM
asensi closed D23549: Identify the "vnd.comicbook+zip" and "vnd.comicbook-rar" MIME types in order to allow some operations.
Sep 15 2019, 9:57 PM · Krusader
asensi added a comment to D23549: Identify the "vnd.comicbook+zip" and "vnd.comicbook-rar" MIME types in order to allow some operations.

Thanks, Alex!

Sep 15 2019, 9:56 PM · Krusader
asensi added a comment to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

And thanks Nikita, Alex, and Moritz! (and Yuri :-)

Sep 15 2019, 9:55 PM · Krusader
asensi committed R167:8c0bece064ac: Shift+Del can remove cruft from the history of the "Search for" comboBox in the… (authored by asensi).
Shift+Del can remove cruft from the history of the "Search for" comboBox in the…
Sep 15 2019, 9:40 PM
asensi closed D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.
Sep 15 2019, 9:40 PM · Krusader
asensi added a comment to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Code looks good and still works!

Sep 15 2019, 9:39 PM · Krusader
asensi accepted D23912: Respect .hidden files.
Sep 15 2019, 9:36 PM · Krusader
asensi accepted D23924: Add QT::KeyMenu action to search results.
Sep 15 2019, 9:36 PM · Krusader
asensi updated the diff for D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Alex's recommendations were applied in order to ease the reading of the source code (and the changes could be applied quickly :-) ).

Sep 15 2019, 6:20 PM · Krusader
asensi committed R167:c264e2a3deed: Avoid that Krusader crashes when trying to view any archive using the ark part (authored by asensi).
Avoid that Krusader crashes when trying to view any archive using the ark part
Sep 15 2019, 5:32 PM
asensi closed D23243: Avoid that Krusader crashes when trying to view any archive using the ark part.
Sep 15 2019, 5:32 PM · Krusader
asensi added a comment to D23243: Avoid that Krusader crashes when trying to view any archive using the ark part.

Some tests were also performed by Moritz Bunkus (https://bugs.kde.org/show_bug.cgi?id=411446#c10) and he didn't see any problem.

Sep 15 2019, 5:30 PM · Krusader
asensi closed D23885: Update build status icon.
Sep 15 2019, 5:16 PM · Krusader
asensi committed R938:368310e08ac6: Update build status icon (authored by asensi).
Update build status icon
Sep 15 2019, 5:16 PM
asensi added a comment to D23885: Update build status icon.

All right, Davide and Nikita, thanks!

Sep 15 2019, 4:49 PM · Krusader
asensi committed R167:e229f9ba7301: Identify the "application/vnd.rar" MIME type in order to allow some operations (authored by asensi).
Identify the "application/vnd.rar" MIME type in order to allow some operations
Sep 15 2019, 4:32 PM
asensi closed D23476: Identify the "application/vnd.rar" MIME type in order to allow some operations.
Sep 15 2019, 4:32 PM · Krusader
asensi added a comment to D23476: Identify the "application/vnd.rar" MIME type in order to allow some operations.

Note: For the tests that I performed under Kubuntu 18.04, executing dpkg -l showed:
kio 5.44.0-0ubuntu1 amd64 Resource and network access abstraction

Sep 15 2019, 4:30 PM · Krusader
asensi added a comment to D22957: Replace Q_WS_WIN with Q_OS_WIN in all the source code.

Some tests were also performed by Moritz Bunkus (https://bugs.kde.org/show_bug.cgi?id=411446#c10) and he didn't see any problem.

Sep 15 2019, 4:21 PM · Krusader
asensi committed R167:07848cc8ebc8: Provide keyboard shortcuts in (de-)selection and (de-)filter dialogs (authored by asensi).
Provide keyboard shortcuts in (de-)selection and (de-)filter dialogs
Sep 15 2019, 4:11 PM
asensi closed D23606: Provide two keyboard shortcuts in (de-)selection and filter dialogs.
Sep 15 2019, 4:11 PM · Krusader
asensi added a comment to D23606: Provide two keyboard shortcuts in (de-)selection and filter dialogs.

Some tests were also performed by Moritz Bunkus (https://bugs.kde.org/show_bug.cgi?id=411446#c10) and he didn't see any problem.

Sep 15 2019, 4:00 PM · Krusader
asensi added a comment to D23912: Respect .hidden files.

The new code works using Kubuntu 18.04. Other people can do their checks. Thanks, Davide!

Sep 15 2019, 3:44 PM · Krusader
asensi added a comment to D23924: Add QT::KeyMenu action to search results.

The new code works using Kubuntu 18.04. Other people can do their checks. Thanks, Davide!

Sep 15 2019, 3:38 PM · Krusader
asensi added a comment to D23880: Handle Ctrl+Left/Right not working in brief view.

The new code works using Kubuntu 18.04. Other people can do their checks. Thanks, Davide!

Sep 15 2019, 3:35 PM · Krusader

Sep 4 2019

asensi added a comment to D23409: In the main page, add a very visible link asking people to help Krusader.

The baloon-like message presents strange behaviors when doing some resizing, if someone wants propose HTML+CSS code, or an image, or other way, in order to draw attention of more developers...

Sep 4 2019, 10:49 PM · Krusader
asensi committed R938:5aa1bd67ff0c: An old, unused page was deleted (authored by asensi).
An old, unused page was deleted
Sep 4 2019, 10:47 PM
asensi closed D23574: Erase an old page.
Sep 4 2019, 10:47 PM · Krusader
asensi updated the diff for D23574: Erase an old page.

The disabled source code was removed, as nobody objected to it, and it's undoable.

Sep 4 2019, 10:44 PM · Krusader
asensi added a comment to D23574: Erase an old page.

Sometimes people are aware that there's a git history, but leave code disabled on purpose. Anyway, this change can be undone, too :-)

Sep 4 2019, 10:21 PM · Krusader

Sep 2 2019

asensi added a comment to D23574: Erase an old page.

I also have seen it when I tested published changelog files and wanted to remove it. Thanks for bringing my thoughts to live. :)
It's not rendered but mentioned in old comment in the report-bugs/index.html - can you remove the comment as well?

Sep 2 2019, 9:49 PM · Krusader
asensi added a comment to D23606: Provide two keyboard shortcuts in (de-)selection and filter dialogs.

Reviewed and tested - all good! Thanks for the fix, Toni!

Sep 2 2019, 9:46 PM · Krusader

Sep 1 2019

asensi added a comment to D22891: If an item that is going to be renamed is also going to be hidden by default, then warn the user.

Kindly ping

Sep 1 2019, 6:53 PM · Krusader
asensi added a comment to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Kindly ping

Sep 1 2019, 6:29 PM · Krusader
asensi retitled D23118: Changed shortcut for the embedded terminal emulator from Because Ctrl+Alt+T is now a global shortcut, use another shortcut for the embedded terminal emulator to Changed shortcut for the embedded terminal emulator.
Sep 1 2019, 5:42 PM · Krusader