nhiga (N. Higa)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 7 2019, 4:20 AM (64 w, 4 d)
Availability
Available

Recent Activity

May 12 2020

nhiga set the repository for D29223: Update Taiwanese holidays to R175 KHolidays.
May 12 2020, 3:17 AM · Frameworks, KDE PIM

May 6 2020

nhiga added a comment to D29223: Update Taiwanese holidays.

Officially-recognized days (including 言論自由日) and the dates for 2020 can be found in this document. Names without ※ means it is officially-recognized but is not stated in the law.

May 6 2020, 12:27 PM · Frameworks, KDE PIM
nhiga updated the diff for D29223: Update Taiwanese holidays.

Added 植樹節.

May 6 2020, 12:11 PM · Frameworks, KDE PIM

May 4 2020

nhiga added a comment to D29223: Update Taiwanese holidays.

Some historical arrangements of some holidays (e.g. Children's Day between 1998-2010) are currently ignored, but I believe this is less important.

May 4 2020, 3:24 AM · Frameworks, KDE PIM
nhiga updated the diff for D29223: Update Taiwanese holidays.
May 4 2020, 3:17 AM · Frameworks, KDE PIM
nhiga added a comment to D29223: Update Taiwanese holidays.

On the Spring festival 春節 of 2020, the publicholidays.tw page and the official source listed on that page both showed Jan 23 to 29 as the days off.

I think both of us can be correct:

  • I referred to this document by Ministry of the Interior, R. O. C. (Taiwan) for 2020. I believe that document is showing the "minimum requirements by law", which means all employees should be able to haves days off on the listed holidays.
  • For government offices, I believe that the regulations "政府機關調整上班日期處理要點" will be applied and civil servants have extra days off in some conditions. For example it says " 四、上班日為星期一或星期五,其後一日或前一日逢星期二或星期四之紀念日及節日之放假,調整該上班日為放假日。農曆除夕前一日為上班日者,調整該上班日為放假日。 ", so I think this is why Jan 23 is also a day off for them.

Would you also indicate the plan for the festivals specified as "2020" in this diff for future years?

I plan to follow the format in the holiday_hk_* files, so it will be something like:

:: 應放假之紀念日及節日(以農曆為基礎)
May 4 2020, 1:50 AM · Frameworks, KDE PIM

May 3 2020

nhiga added a comment to D29372: Taiwan: Use "zh_TW" language code.

I would say that the file should also be renamed.

May 3 2020, 1:45 PM · Frameworks
nhiga added a comment to D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list.

specified the start year of Peace Memorial Day 228和平紀念日

Great! This is what I have missed in my patch.

The star * ones are specified using the "lunar new year date" minus/plus some days, hoping to make it easier to adapt to additional years in the future.

I appreciate this new idea and I think it is worth discussing which way of dealing lunar calendar-based holidays is better.
I consider my method a no-brainer because:

  • In many cases, Lunar calendar-based (public) holidays in Taiwan are actually the same as (or similar to) those in Hong Kong, so basically we can refer to the dates in holiday_hk_en-gb (which contains the dates up to 2030). One notable exception is the Mid-Autumn Festival - for Hong Kong the holiday is on the day after Mid-Autumn Festival.
  • Or, just refer to the document published by the Ministry of the Interior, R. O. C. (Taiwan), which is really straightforward.

For your method:

  • We can see the patterns for those holidays (i.e. Lunar new year date + XX days + extra months or days (leap month 閏月 / leap days 閏日))
  • If you are (very) familiar with lunar calendar, this method may actually be better. Otherwise, you will have to be really careful with the leap months/days.

There are holidays entries regarding specific arrangements (an extra day is observed in lieu of an extra working day) that can't be calculated in advance

If you are referring to 補假 (substitute holiday / supplementary holiday), the logic is stated in the law (紀念日及節日實施辦法):

紀念日及節日之放假日逢例假日應予補假。例假日為星期六者於前一個上班日補假,為星期日者於次一個上班日補假。但農曆除夕及春節放假日逢例假日,均於次一個上班日補假。

I believe that means:

  • If a public holiday is on Saturday, the substitute holiday will be the previous working day;
  • If a public holiday is on Sunday, the substitute holiday will be the next working day;
  • However, for Lunar New Year's eve and Lunar New Year, the substitute holiday will always be the previous working day.

I think there are still issues with the 4 season dates

I have not enabled "Astronomical Events" plugin, but the astronomical seasons (especially June solstice, which is not a holiday for Japan and Hong Kong) are still automatically displayed for me. And apparently kholidays has the astronomical seasons support already in src/astroseasons.cpp.
Some other issues:

  • Official holiday names should be used.
  • Using a third-party and non-official site such as publicholidays.tw as reference seems unreliable. My patch refers to the law and official documents to ensure accuracy.
  • Hence, I excluded all non-official holidays, such as Easter, which has been included in your patch.
  • But I cannot say I am 100% sure that I have not missed any official commemorative days. For example, Wikipedia says the Freedom of Expression Day (言論自由日) is an official one, but I wonder why it is not included in the law 紀念日及節日實施辦法. The website I linked above should be displaying the latest (and official) revision of the law. I hope someone from Taiwan can provide more information on this.
May 3 2020, 1:40 PM · Frameworks
nhiga added a reviewer for D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list: cgiboudeaux.
May 3 2020, 12:22 PM · Frameworks
nhiga added a comment to D29223: Update Taiwanese holidays.

@cgiboudeaux
Thanks for the heads-up.

May 3 2020, 12:20 PM · Frameworks, KDE PIM

Apr 27 2020

nhiga added a comment to D29223: Update Taiwanese holidays.

I suppose you rename the file for a good reason. Are there different "official" languages for Taiwan?

Apr 27 2020, 1:20 PM · Frameworks, KDE PIM
nhiga added a comment to D29223: Update Taiwanese holidays.

Notes:

  1. Holidays for indigenous peoples have not been included. Some of them seem to have a fixed date, but for other festivals we know the range but not the exact dates. For example, it is known that 豐年祭(收穫祭) is celebrated between July 1 and September 30 (source), but the actual date (which is also a day off for the respective ethnic group) is picked by the Amis people. This calendar does not give us any hint on the exact date of 豐年祭.
  2. 勞動節 (Labor Day) is a day off for many people, but at the same time civil servants, teachers, etc. do not have a day off, so I did not mark it as "public". Similarly, "軍人節" is a day off for military members only, and others do not have a day off.
  3. Some holidays such as Children's Day are referred to as festivals (節日) and not as commemorative days (紀念日), but for simplicity, I am marking them as "commemorative".
Apr 27 2020, 10:55 AM · Frameworks, KDE PIM
nhiga requested review of D29223: Update Taiwanese holidays.
Apr 27 2020, 10:17 AM · Frameworks, KDE PIM
nhiga added a comment to D28874: Taiwanese holidays.

By the way, the holiday file for People's Republic of China (i.e. mainland China) also needs update too because the dates of Lunar calendar based holidays are only available for 2009.
The comment in the file says "these have to wait for lunar calendar support", but it looks like Qt and KDE have yet to support Lunar calendar, so we have to update the dates manually for the time being.

Apr 27 2020, 1:42 AM · Frameworks

Apr 26 2020

nhiga added a comment to D28874: Taiwanese holidays.

Thank you for your attempt to add Taiwanese holidays to KDE. However, I am afraid that this patch has to be reviewed again.

Apr 26 2020, 12:48 PM · Frameworks

Feb 16 2020

nhiga added a comment to D27419: Update Japanese holidays.

I tested these changes locally. works

do you have commit access?

Feb 16 2020, 4:15 AM · Frameworks, KDE PIM

Feb 15 2020

nhiga requested review of D27419: Update Japanese holidays.
Feb 15 2020, 2:08 AM · Frameworks, KDE PIM

Sep 8 2019

nhiga updated the test plan for D23730: Add new protocol for 7z archives.
Sep 8 2019, 1:43 AM · Dolphin, Frameworks
nhiga requested review of D23780: Add new protocol for 7z archives.
Sep 8 2019, 1:32 AM · Frameworks

Sep 5 2019

nhiga added a comment to D23730: Add new protocol for 7z archives.

There is a weird bug if I name the protocol as "7z" or "7zip":

  1. If I double click on the 7z file, Dolphin gives the "invalid protocol" error.
  2. If I try to manually enter the URL in Dolphin, i.e. 7z:/tmp/bar.7z or 7zip:/tmp/bar.7z, it does not work too - it is somehow being treated as a host (hostname) instead of a protocol.
Sep 5 2019, 2:30 PM · Dolphin, Frameworks
nhiga added a comment to D23730: Add new protocol for 7z archives.

Notes:

  1. I am not sure whether it is needed to include k7zip.h in archive/kio_archivebase.cpp.
  2. It can take some time to load the 7z archive using this new protocol.
Sep 5 2019, 12:19 PM · Dolphin, Frameworks
nhiga requested review of D23730: Add new protocol for 7z archives.
Sep 5 2019, 12:08 PM · Dolphin, Frameworks

Aug 28 2019

nhiga added a comment to D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath.

When this patch is applied and Krusader is not installed:

Aug 28 2019, 11:57 AM · Frameworks
nhiga updated the test plan for D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath.
Aug 28 2019, 11:49 AM · Frameworks

Aug 27 2019

nhiga added a comment to D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath.

This patch may be related to Bug 411330.

Aug 27 2019, 1:14 PM · Frameworks
nhiga requested review of D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath.
Aug 27 2019, 1:11 PM · Frameworks
nhiga added a comment to D23476: Identify the "application/vnd.rar" MIME type in order to allow some operations.

Should we also add application/vnd.rar to krArc/krarc.protocol?

Aug 27 2019, 11:55 AM · Krusader

Aug 16 2019

nhiga added a comment to D23173: Avoid partial upgrade on Arch Linux.

Then I will leave this patch on KDE Phabricator. Next time, I will submit to GitLab if the project is on KDE GitLab.

Aug 16 2019, 1:09 AM

Aug 15 2019

nhiga added a comment to D23173: Avoid partial upgrade on Arch Linux.

kdesrc-build has moved to GitLab for patches: https://invent.kde.org/kde/kdesrc-build/merge_requests

Would you be able to re-submit this there? Thanks!

@sysadmin I feel like we should really have a way of notifying people who try to submit a patch on Phab when the project has moved to GitLab.

Aug 15 2019, 2:04 PM
nhiga requested review of D23173: Avoid partial upgrade on Arch Linux.
Aug 15 2019, 10:38 AM

Aug 10 2019

nhiga added a comment to D23037: Add support for cb7 comic book archives.
Aug 10 2019, 10:04 AM · Okular
nhiga added a comment to D23037: Add support for cb7 comic book archives.

@aacid Please check your email. I noticed that your public key (0x3A6A4DB839EAA6D7) seems to have expired, but I used that key to encrypt my message anyway.

Aug 10 2019, 1:58 AM · Okular

Aug 9 2019

nhiga updated subscribers of D23037: Add support for cb7 comic book archives.

Sorry for the mess, I accidentally changed the status and subscriber list.

Aug 9 2019, 9:49 AM · Okular
nhiga reclaimed D23037: Add support for cb7 comic book archives.
Aug 9 2019, 7:59 AM · Okular
nhiga abandoned D23037: Add support for cb7 comic book archives.
Aug 9 2019, 7:21 AM · Okular
nhiga updated the diff for D23037: Add support for cb7 comic book archives.
Aug 9 2019, 7:21 AM · Okular
nhiga updated the diff for D23037: Add support for cb7 comic book archives.
Aug 9 2019, 7:02 AM · Okular
nhiga requested review of D23037: Add support for cb7 comic book archives.
Aug 9 2019, 2:34 AM · Okular

Jul 22 2019

nhiga updated the diff for D21637: Display BLAKE2 file checksums for RAR files.
Jul 22 2019, 2:35 AM · Ark

Jul 18 2019

nhiga added inline comments to D21637: Display BLAKE2 file checksums for RAR files.
Jul 18 2019, 1:13 AM · Ark

Jul 6 2019

nhiga updated the summary of D22297: Add id="current-color-scheme" to collapse-all icons.
Jul 6 2019, 12:14 PM · Frameworks
nhiga added a reviewer for D22297: Add id="current-color-scheme" to collapse-all icons: davidhurka.

Would you please try this diff and see if it resolves the bug?

Jul 6 2019, 11:45 AM · Frameworks
nhiga added a comment to D22297: Add id="current-color-scheme" to collapse-all icons.

Summary will be filled in later.

Jul 6 2019, 11:38 AM · Frameworks
nhiga requested review of D22297: Add id="current-color-scheme" to collapse-all icons.
Jul 6 2019, 11:36 AM · Frameworks

Jun 26 2019

nhiga requested review of D22099: Update UK Early May bank holiday for 2020.
Jun 26 2019, 12:59 AM · KDE PIM

Jun 23 2019

nhiga abandoned D21979: [System Load Viewer] Add a tooltip about the "CPUs separately" option.
Jun 23 2019, 11:13 AM · Plasma
nhiga added a comment to D21979: [System Load Viewer] Add a tooltip about the "CPUs separately" option.

Sorry, my mistake. I missed that this tooltip is set on the wrong checkbox. It needs to be set on the "CPUs separately" checkbox

Jun 23 2019, 1:07 AM · Plasma

Jun 22 2019

nhiga updated the diff for D21979: [System Load Viewer] Add a tooltip about the "CPUs separately" option.

Rephrased the tooltip message according to ngraham's suggestion.

Jun 22 2019, 11:28 AM · Plasma
nhiga requested review of D21979: [System Load Viewer] Add a tooltip about the "CPUs separately" option.
Jun 22 2019, 6:14 AM · Plasma

Jun 7 2019

nhiga removed a reviewer for D21637: Display BLAKE2 file checksums for RAR files: kde-utils-devel.
Jun 7 2019, 4:00 AM · Ark
nhiga requested review of D21637: Display BLAKE2 file checksums for RAR files.
Jun 7 2019, 3:59 AM · Ark

Apr 18 2019

nhiga updated the diff for D20507: Update Japanese holidays.

Updated 2020 "substitute holidays".

Apr 18 2019, 5:43 AM · Frameworks, KDE PIM
nhiga requested review of D20507: Update Japanese holidays.
Apr 18 2019, 4:41 AM · Frameworks, KDE PIM
nhiga updated the diff for D20507: Update Japanese holidays.

Fixed indentation.

Apr 18 2019, 4:40 AM · Frameworks, KDE PIM
nhiga updated the diff for D20507: Update Japanese holidays.

Fixed a syntax error.

Apr 18 2019, 4:36 AM · Frameworks, KDE PIM
nhiga reclaimed D20507: Update Japanese holidays.
Apr 18 2019, 4:36 AM · Frameworks, KDE PIM

Apr 17 2019

nhiga abandoned D20507: Update Japanese holidays.

It turns out that the Japanese version only works partially. I am going to investigate the issue and will update this revision later. Sorry for the inconvenience.

Apr 17 2019, 2:50 PM · Frameworks, KDE PIM

Apr 16 2019

nhiga added a reviewer for D20507: Update Japanese holidays: KDE PIM.
Apr 16 2019, 2:56 AM · Frameworks, KDE PIM
nhiga added a comment to D20571: Add public holidays for Lower Saxony (Germany).

Thank you for the patch. Could you please fix the indentation at Line 44 (<file>plan2/holiday_de-ns_de</file>) and add a newline at the end of the file holidays/plan2/holiday_de-ns_de?

Apr 16 2019, 2:54 AM · KDE PIM

Apr 13 2019

nhiga added a comment to D20507: Update Japanese holidays.

Note: Due to imperial transition, there is no "The Emperor's Birthday" in 2019.

Apr 13 2019, 2:26 PM · Frameworks, KDE PIM
nhiga requested review of D20507: Update Japanese holidays.
Apr 13 2019, 2:22 PM · Frameworks, KDE PIM

Apr 12 2019

nhiga abandoned D20333: libzip: Fix CRC checksum display.
Apr 12 2019, 3:07 AM · Ark
nhiga added a comment to D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin.

With krarc, users can open 7z and RAR files as folder in Dolphin (with patches [1] [2]). This is also useful for Gwenview - if you have pictures in a 7z or RAR archive, then you can view them in Gwenview without decompressing the whole archive to another location. However, I'm not sure whether it's appropriate to add these Krusader-specific things to KIO.

Apr 12 2019, 2:33 AM · Frameworks

Apr 11 2019

nhiga added a comment to D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin.

I've just updated my KDE Identity account - my full name and email address can now be found by searching the username "nhiga" on KDE Identity - People. I'm sorry for the inconvenience caused.

Apr 11 2019, 3:37 AM · Frameworks

Apr 10 2019

nhiga requested review of D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin.
Apr 10 2019, 4:59 AM · Frameworks

Apr 7 2019

nhiga requested review of D20333: libzip: Fix CRC checksum display.
Apr 7 2019, 4:50 AM · Ark