Erase an old page
ClosedPublic

Authored by asensi on Aug 29 2019, 9:14 PM.

Details

Summary

There's an old page in the web site:

https://krusader.org/release/git/changelog/index.html

that is also visible when people go to

https://krusader.org/release/git/changelog

and before deleting it, I ask if it's being used, just in case (although it's not utilized by any other web page of krusader.org).

Diff Detail

Repository
R938 Krusader Website
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
asensi requested review of this revision.Aug 29 2019, 9:14 PM
asensi created this revision.
asensi retitled this revision from An old page was deleted to Erase an old page.
nmel accepted this revision.Sep 2 2019, 5:46 AM
nmel added a subscriber: nmel.

I also have seen it when I tested published changelog files and wanted to remove it. Thanks for bringing my thoughts to live. :)

It's not rendered but mentioned in old comment in the report-bugs/index.html - can you remove the comment as well?

This revision is now accepted and ready to land.Sep 2 2019, 5:46 AM
asensi added a comment.Sep 2 2019, 9:49 PM

I also have seen it when I tested published changelog files and wanted to remove it. Thanks for bringing my thoughts to live. :)
It's not rendered but mentioned in old comment in the report-bugs/index.html - can you remove the comment as well?

I saw that comment although I left it in case someone needed to use something similar again. If nobody sees any need for it, I can remove it.

nmel added a comment.Sep 3 2019, 6:26 AM

It can be restored from git history in case it's needed. It's your call.

Sometimes people are aware that there's a git history, but leave code disabled on purpose. Anyway, this change can be undone, too :-)

asensi updated this revision to Diff 65394.Sep 4 2019, 10:44 PM

The disabled source code was removed, as nobody objected to it, and it's undoable.

This revision was automatically updated to reflect the committed changes.