Provide two keyboard shortcuts in (de-)selection and filter dialogs
AcceptedPublic

Authored by asensi on Sat, Aug 31, 4:35 PM.

Details

Reviewers
nmel
Group Reviewers
Krusader
Summary

Provide keyboard shortcuts for "Apply selection to folders" in (de-)selection dialog, and for "Apply filter to folders" in filter dialog. Other related minor changes.

GUI

FIXED: [ 411446 ] Provide keyboard shortcut for "apply selection to folders" in (de-)selection dialog
BUG: https://bugs.kde.org/show_bug.cgi?id=411446

Test Plan

Open the selection dialog (Ctrl++ or "Edit > Select Group..."), check that Alt+S can be used to enable "Apply selection to folders", accept, and check that what it was intended (files, folders) ends selected.

Try it but in order to deselect files (and folders).

Try it but in order to "Apply filter to folders" in filter dialog ("View > Custom" menu).

Edited the ~/.config/kdeglobals file, add the following (if it wasn't before):

[Development]
AutoCheckAccelerators=false

and repeat the tests.

Leave the ~/.config/kdeglobals file as it previously was.

Diff Detail

Repository
R167 Krusader
Lint
Lint Skipped
Unit
Unit Tests Skipped
asensi requested review of this revision.Sat, Aug 31, 4:35 PM
asensi created this revision.
nmel accepted this revision.Mon, Sep 2, 5:40 AM
nmel added a subscriber: nmel.

Reviewed and tested - all good! Thanks for the fix, Toni!

Just to express my personal feeling - Alt+S is more natural for search terms, while Alt+F is for folder setting. However, this type of change may disrupt someone's work flow. That's why I'm fine with Alt+S.

This revision is now accepted and ready to land.Mon, Sep 2, 5:40 AM
asensi added a comment.Mon, Sep 2, 9:46 PM

Reviewed and tested - all good! Thanks for the fix, Toni!

Just to express my personal feeling - Alt+S is more natural for search terms, while Alt+F is for folder setting.
However, this type of change may disrupt someone's work flow. That's why I'm fine with Alt+S.

All right, Nikita. And thanks for reviewing and testing!