Fix identation.

https://phabricator.kde.org/D5138

Add find_programm(SH_EXE sh)

• Fix cmake
• find_program call for xmllint

Use QStorageInfo.

Ok, I think I found the issue in QStorageInfo -- it calls getmntinfo() with flags=0 [1] . Instead one of the valid arguments 1-4 [2].

Do you actually intend to test this on Mac?

Nope, I don't have a Mac :) -- but I hoped, that there were some Mac users who could check it on their end too (as you also have kqueue/kevent) -- but I did not know that most of the stuff is not yet ported for Mac.

Use sigwaitinfo() to get information on the sending-pid.

In D5555#112148, @aacid wrote:

No repo?

I can successfully unlock the lockscreen, with this code .

Should be fine.

I want to look at this some more this weekend.

In D5825#109093, @davidedmundson wrote:

but now that it is all here already, let's just call this a prototype, for someone who knows C/kevent/kqueue to fix.

So what doesn't work?

I agree. I'll try and figure out whats wrong inside QStorageInfo, and then update the review here to be using it.

Hm, QStorageInfo does not seem to return anything sensible on FreeBSD:

• Turn around cases of the if-clause.
• Fix cmake matches -> MATCHES.

Drop space after if.

add stdlib.h and xlocale.h rather than replace locale.h

We talked about it some more, and think that it is maybe better to not do any cmake magic.

Switch to Q_OS_LINUX.

Wrong minority -- these streets are FreeBSD territory :P

As NPTL is LInuxy (or is it used anywhere else?), and that throw comes from it according to the comment, how about replacing the defined(__GLIBCXX__) by Q_OS_LINUX or some __NPTL__FOO__ magic?

Well, without that block it simply won't compile at all...

Fix typo.

Add #cmakedefine01 HAVE_ST_BIRTHTIME to config-kioslave-file.h.cmake

Use cmake to check for st_birthime.

I personally would vote in favor of a really thin abstraction around the webview features we use. Then allow building against either webkit or webengine. For our use cases, either should be good.

That would be great, as it could also be used in other parts of KDE tempted to switch to WebEngine only.

Well, then the answer would be "WebKit" :) which is why I want to still have the option if possible -- you can add a cmake warning about "WebKit being less secure than WebEngine".
As for unmaintained, there is the hope for the fork at [1].

The same way one does on Linux... I probably don't quite understand your question.

Yes, I'm sure, unfortunately :) -- chromium is ported that is true. However, it requires lots of patches (500ish files need to be patched), most of which have to be modified and adapted to work with the version shipped inside the WebEngine tarball.

On FreeBSD we still do not have QtWebengine (it's rather hard to port). So we would like if would not be a replacement but selectable. I.e. that one can choose between WebKit and WebEngine (the latter being default).

Maybe I picked the wrong repo?

Looks good to me, that is all the ports that depend on it, still find libinotify after modifying the patches to use this version.

On FreeBSD we have linux/input.h provided by multimedia/v4l_compat [1] -- which we already depend on at the moment.