Do not depend on bash uncessarily, and do not validate icons by default.

Authored by adridg on Jun 3 2017, 5:28 PM.



I don't think it makes sense, that the icons are xmllint'ed every time someone builds the icons.
This is an action that should take place once, before cutting the next release.

Also, from a first glance, the scripts do not actually require bash, and should work with -- let's call it 'standard' -- /bin/sh.

Diff Detail

R266 Breeze Icons
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
tcberner created this revision.Jun 3 2017, 5:28 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 3 2017, 5:28 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
tcberner updated this revision to Diff 15115.Jun 3 2017, 5:37 PM
  • Fix cmake
  • find_program call for xmllint
tcberner updated this revision to Diff 15116.Jun 3 2017, 5:42 PM

Add find_programm(SH_EXE sh)

aacid added a subscriber: aacid.Jun 5 2017, 10:27 PM

i think it'd be much more acceptable if you made it equal to be "running tests" like we have on other repos, so on by default but when running make check.

adridg commandeered this revision.Jun 24 2017, 2:53 PM
adridg added a reviewer: tcberner.
adridg added a subscriber: adridg.

Taking over to follow up Albert's suggestion -- this could be two patches, one to de-bash it, one to make validation optional.

adridg updated this revision to Diff 15820.Jun 24 2017, 3:01 PM

Make the diff smaller: only de-bash it, and save make-validation-optional
for a later patch.

I don't think i know enough sh to give it a "this is compatible with basic sh", but i guess that if it works you can commit it.

Only thing is that maybe you don't really need to de-bash and icons-dark/light2Dark since they seem things you run manually? but if they still work on other non bash shells i guess it doesn't hurt either.

This revision was automatically updated to reflect the committed changes.