Add role for file creation time.
ClosedPublic

Authored by tcberner on Jun 16 2017, 6:07 PM.

Details

Summary

At least on FreeBSD UFS and ZFS support birthtimes of files.

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tcberner created this revision.Jun 16 2017, 6:07 PM
Restricted Application added a subscriber: Konqueror. · View Herald TranscriptJun 16 2017, 6:07 PM

I get an empty "Created" column on Linux/Ext4, but I guess that's ok since the column is hidden by default.

+1 otherwise

adridg added a subscriber: adridg.Jun 17 2017, 6:18 PM

This is partly related to another review, since committed, for actually filling the creation (birth) time of files. On FreeBSD, this information is available for some filesystems. On Linux, this information is not available through the stat() system call, but statx() was recently added to the kernel, so it's possible that KFileItemMetaData (or whatever that class was) gains support for creation time on Linux too, and then this column is filled in automagically.

emmanuelp accepted this revision as: Dolphin.Jun 20 2017, 8:55 AM

Adding potential reviewers who have committed to Dolphin recently.

elvisangelaccio accepted this revision.Jun 27 2017, 5:21 PM
This revision is now accepted and ready to land.Jun 27 2017, 5:21 PM
tcberner updated this revision to Diff 16025.Jun 29 2017, 6:10 PM

Update diff against current src.

tcberner updated this revision to Diff 16026.Jun 29 2017, 6:12 PM

Unbreak DleetionTimeRole

thiago added a subscriber: thiago.Jul 3 2017, 3:56 AM

Qt 5.10 will have QFileInfo::birthTime too.

@tcberner Any reason why this is not pushed yet?

It could still go into 17.08, at least until July 20.

This revision was automatically updated to reflect the committed changes.

Sorry, forgot about it :)