Fix up codec_ogg's and codec_flac's CMakeLists.txt for FreeBSD, v2
AbandonedPublic

Authored by the on May 13 2017, 4:28 AM.

Details

Reviewers
tcberner
aacid
Group Reviewers
FreeBSD
Summary

accepted, with minor modifications:

  • wrapped oversized lines
  • use capital letters for cmake commands (set -> SET)

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
tcberner accepted this revision.May 24 2017, 6:10 PM

Should be fine.

This revision is now accepted and ready to land.May 24 2017, 6:10 PM
aacid requested changes to this revision.May 27 2017, 4:39 PM
aacid added a subscriber: aacid.

Why didn't you set the repository this should end up in?

This revision now requires changes to proceed.May 27 2017, 4:39 PM
the added a comment.May 29 2017, 5:39 AM

sorry, but I don't know what you are talking about...
I have set the repository to "R347 KWave" - what is wrong with that?

aacid added a comment.May 29 2017, 8:50 PM

I can't see any mention of kwave anywhere, except in your last comment.

Can you please take a screenshot on your side and post it somewhere? Something must be broken in phabricator if you set the repository but i can't see it.

the added a comment.Jun 3 2017, 5:33 AM

I am not aware of having done anything wrong, however, maybe I did...
What happens if you click on "Edit Revision" on the upper right side?

It brings me here:
https://phabricator.kde.org/differential/revision/edit/5826/
and on that page I clearly can see a line with "Repository".
So what's going wrong here?

aacid added a comment.Jun 4 2017, 10:54 PM

No idea what's wrong, i can see it in the edit url too, but not on https://phabricator.kde.org/D5826 which is strange since i can see it in other repos, maybe because you added it after it was already approved?

Anyway, i find it strange you didn't add the kwave maintainer, don't you feel it's important to have his feedback?

the added a comment.Jun 5 2017, 5:47 AM

?????????
who do you think that I am???
and who do you think shall then be the "maintainer" of Kwave if not me?

I added the repo because that tool complained about it when clicking on "Submit", at the start, not afterwards.

However, I now applied that patch manually.
Maybe that stupid tool works better next time...

the abandoned this revision.Jun 5 2017, 8:18 PM

already applied manually

aacid added a comment.Jun 5 2017, 10:04 PM
In D5826#114169, @the wrote:

?????????
who do you think that I am???

Ah, you're one of those people that choose a different username in phabricator.kde.org than in identity.kde.org to make it harder for anyone to figure out who you are.

Sorry for trying to help.

and who do you think shall then be the "maintainer" of Kwave if not me?

I added the repo because that tool complained about it when clicking on "Submit", at the start, not afterwards.

However, I now applied that patch manually.
Maybe that stupid tool works better next time...

the added a comment.Jun 7 2017, 4:37 AM

Albert Astals Cid wrote:

[...]
Ah, you're one of those people that choose a different username in
phabricator.kde.org than in identity.kde.org to make it harder for
anyone to figure out who you are.

Once again you are wrong.

I did not "choose" that!

"the" is an account that I have for quite a long time and which is used
for apps.kde.org and (as it seems) also for phabricator. This is my
first choice.

The account identitiy.kde.org ("eschenbacher") -> I did not choose that,
I never had the chance to suggest a user name, someone has just assigned
it to me when I asked for access to source control (svn/git) some years
ago, without asking me. And now I have two accounts.

What do you suggest I should do now?

Sorry for trying to help.

At the moment I see only complaints, no help, sorry...

aacid added a comment.Jun 7 2017, 9:42 PM

At the moment I see only complaints, no help, sorry...

No? And what do you think it was trying to make sure that the kwave maintainer was added to a kwave review?

Anyhow, leave me alone, it's clear you don't apreciate my comments, so let's stop this conversation that is helping noone at this point.