Change default pkgconfig install path for FreeBSD
ClosedPublic
Actions

Authored by tcberner on May 8 2017, 1:35 PM.

Details

Reviewers

apol
kfunk

Group Reviewers

FreeBSD

Commits

Summary

FreeBSD, opposed to most other sytems, does not install pkgconfig files to
lib/pkgconfig, but to libdata/pkgconfig.

Repository

R240 Extra CMake Modules

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added subscribers: Build System, Frameworks. · View Herald Transcript

Drop space after if.

kfunk added inline comments.

modules/ECMGeneratePkgConfigFile.cmake
172–176	`matches` -> `MATCHES` -- I'm surprised that actually works as-is. Also: Why not `if (CMAKE_SYSTEM_NAME MATCHES ...)` and switch the bodies inside the if & else branch to simplify?

kfunk requested changes to this revision.May 8 2017, 3:27 PM

This revision now requires changes to proceed.May 8 2017, 3:27 PM

tcberner marked an inline comment as done.May 8 2017, 4:17 PM

Well, for me that looks good now

This revision is now accepted and ready to land.May 8 2017, 6:10 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			modules/ECMGeneratePkgConfigFile.cmake (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	14284	94056e2		May 8 2017, 1:35 PM	★	★
Diff 2	14285	94056e2	Drop space after `if`.	May 8 2017, 1:52 PM	★	★
Diff 3	14296	94056e2	* Turn around cases of the if-clause.	May 8 2017, 4:16 PM	★	★
Diff 4	14305	94056e2	R240:416c7e9facf905c5be757dd1a1c66e2ed878f641	May 8 2017, 6:18 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
fea5950d9095	75f31e021fd8	94056e2e4629	Tobias C. Berner	Change default pkgconfig install path for FreeBSD (Show More…)	May 8 2017, 1:30 PM