Differential D5798

Fix up codec_ogg's and codec_flac's CMakeLists.txt for FreeBSD
AbandonedPublic
Actions

Authored by adridg on May 10 2017, 5:19 PM.

Details

Reviewers
the
tcberner
Group Reviewers
FreeBSD
Summary
  • codec_ogg:
    • Fix call to to CHECK_LIBRARY_EXISTS by passing VORBIS_LIBDIR instead of VORBIS_INCLUDEDIR.
    • Use the values from pkg-config instead ogg->OGG_LIBRARIES and so on.
    • While here, also fix indentation.
  • codec_flac
    • Add FLAC_INCLUDEDIR to CMAKE_REQUIRED_INCLUDES.

Diff Detail

Repository
R347 KWave
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
tcberner created this revision.May 10 2017, 5:19 PM
This revision now requires changes to proceed.May 13 2017, 4:30 AM
the added a comment.Jun 5 2017, 8:20 PM

already applied manually, with only minor (formal) modifications
(see https://phabricator.kde.org/D5826)
please close...

adridg commandeered this revision.May 31 2020, 3:31 PM
adridg abandoned this revision.
adridg added a reviewer: tcberner.

Revision Contents
Changeset List

Diff 14374

View Options

plugins/codec_flac/CMakeLists.txt

Loading...
View Options

plugins/codec_ogg/CMakeLists.txt

Loading...