rakuco (Raphael Kubo da Costa)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Mar 17 2016, 12:20 PM (183 w, 2 d)
Availability
Available

Recent Activity

Feb 26 2019

rakuco added a comment to D16610: Don't redefine nulltpr on FreeBSD.

I've sent a patch upstream with a more general approach: https://sourceforge.net/p/libpgf/patches/12/

Feb 26 2019, 9:28 PM

Feb 24 2019

rakuco added a comment to D16610: Don't redefine nulltpr on FreeBSD.

I don't think this should be a FreeBSD-specific check; even on other systems where the build is not currently broken we shouldn't be redefining nullptr anyway. I've sent a patch upstream with a more general approach: https://sourceforge.net/p/libpgf/patches/12/

Feb 24 2019, 6:37 PM

Jan 4 2019

rakuco committed R206:5171464e8877: unifiedmailboxagent: Stop using std::optional. (authored by rakuco).
unifiedmailboxagent: Stop using std::optional.
Jan 4 2019, 4:52 PM
rakuco closed D17917: unifiedmailboxagent: Stop using std::optional..
Jan 4 2019, 4:46 PM · KDE PIM

Jan 2 2019

rakuco added a reviewer for D17917: unifiedmailboxagent: Stop using std::optional.: FreeBSD.
Jan 2 2019, 2:05 PM · KDE PIM
rakuco requested review of D17917: unifiedmailboxagent: Stop using std::optional..
Jan 2 2019, 2:04 PM · KDE PIM

Dec 30 2018

rakuco added a comment to D17606: [WIP] Use <optional> if available..

Maybe we could just get rid of the optional in this agent until we can switch to C++17 proper. I hate not having it, but it's just one or two occurrences here and probably not worth the magic to satisfy all compilers.

Dec 30 2018, 4:36 PM · KDE PIM

Jul 15 2018

rakuco abandoned D8062: cmake: Stop warning if dot is not found when CMake is run..

I've finally posted a more comprehensive patch in D14146 -- so much time passed that I lost my original branch and did something similar in spirit :-)

Jul 15 2018, 9:46 PM
rakuco requested review of D14146: cmake: Simplify and improve FindGraphviz.cmake.
Jul 15 2018, 9:44 PM

Apr 29 2018

rakuco added inline comments to D11845: Make clang happy..
Apr 29 2018, 12:33 PM · Kopete

Feb 18 2018

rakuco added a comment to D10450: Generate a custom target in kcoreaddons_desktop_to_json.

I agree this can be abandoned -- whatever solution we agree upon should probably be done in plasma-desktop.

Feb 18 2018, 6:02 PM · Frameworks

Feb 17 2018

rakuco added a comment to D10450: Generate a custom target in kcoreaddons_desktop_to_json.

This isn't just a problem on KDE Neon though, is it? I thought FreeBSD is also affected?

Feb 17 2018, 10:32 PM · Frameworks
rakuco added a comment to D10450: Generate a custom target in kcoreaddons_desktop_to_json.

Per my previous comment, I still don't see how changing this to a target would solve anything.

Feb 17 2018, 11:32 AM · Frameworks

Feb 14 2018

rakuco committed R165:cf9e064331b6: autotests: Fix testenv script on Unix. (authored by rakuco).
autotests: Fix testenv script on Unix.
Feb 14 2018, 7:24 AM
rakuco closed D10491: autotests: Fix testenv script on Unix..
Feb 14 2018, 7:24 AM · KDE PIM

Feb 13 2018

rakuco requested review of D10491: autotests: Fix testenv script on Unix..
Feb 13 2018, 8:07 PM · KDE PIM

Feb 12 2018

rakuco requested changes to D10450: Generate a custom target in kcoreaddons_desktop_to_json.

@kossebau's right: the problem lies in lookandfeeltool depending on kcm.cpp, while the kcoreaddons_desktop_to_json() call makes the kcm_lookandfeel target depend on the generation of the json file. It's pretty easy to reproduce this bug by running make lookandfeeltool_autogen with a fresh build directory.

Feb 12 2018, 4:50 PM · Frameworks

Oct 6 2017

rakuco added a comment to D8062: cmake: Stop warning if dot is not found when CMake is run..

@jriddell @kossebau: ping?

Oct 6 2017, 8:00 AM

Sep 30 2017

rakuco added a comment to D8062: cmake: Stop warning if dot is not found when CMake is run..

FindGraphviz.cmake uses DOT as well for finding the version of GraphViz that is installed -- not that the current module or code supports checking hthat version, but it's there.

Sep 30 2017, 5:04 PM

Sep 29 2017

rakuco created D8062: cmake: Stop warning if dot is not found when CMake is run..
Sep 29 2017, 8:53 PM

Aug 8 2017

rakuco committed R32:dd18e9a13558: filetemplates plugin: Make testfiletemplates depend on kdevfiletemplates (authored by rakuco).
filetemplates plugin: Make testfiletemplates depend on kdevfiletemplates
Aug 8 2017, 5:02 PM
rakuco committed R32:384dd42f077f: Merge branch '1.7' (authored by rakuco).
Merge branch '1.7'
Aug 8 2017, 4:45 PM
rakuco committed R32:aaba10b67532: Bazaar VCS: Include time.h for time_t. (authored by rakuco).
Bazaar VCS: Include time.h for time_t.
Aug 8 2017, 4:45 PM
rakuco committed R32:b028e73fd22c: Merge branch '1.5' (authored by rakuco).
Merge branch '1.5'
Aug 8 2017, 4:32 PM
rakuco committed R32:e81313bc8677: Install the Grantlee filter into the right location. (authored by rakuco).
Install the Grantlee filter into the right location.
Aug 8 2017, 4:32 PM
rakuco committed R32:57abc9df0c35: Add missing include to fix the build with recent GCCs. (authored by rakuco).
Add missing include to fix the build with recent GCCs.
Aug 8 2017, 4:16 PM
rakuco committed R32:4eed75814ae9: Look for ext/hash_map and unordered_map instead of checking gcc's version. (authored by rakuco).
Look for ext/hash_map and unordered_map instead of checking gcc's version.
Aug 8 2017, 4:16 PM
rakuco committed R32:f3e0daaba7a9: Add missing include to fix the build with recent GCCs. (authored by rakuco).
Add missing include to fix the build with recent GCCs.
Aug 8 2017, 4:15 PM

Jul 28 2017

rakuco added a comment to D6925: kmix assumes volume range 1:100 for oss mixer instead of 0:100..

Given the amount of commits to the repository in the past years I'm not sure you'll be able to review this patch. Perhaps someone with a KDE Multimedia hat?

Jul 28 2017, 5:50 PM

Jun 3 2017

rakuco added a comment to D6076: Do not depend on bash uncessarily, and do not validate icons by default..

See also: https://git.reviewboard.kde.org/r/129246/

Jun 3 2017, 5:54 PM · Frameworks

Apr 24 2017

rakuco added a comment to D5555: Include xlocale.h rather than locale.h for strtod_l.

Note that at least glibc defines strtod_l in stdlib.h, I think it's safer to include both stdlib.h for glibc and xlocale.h for OSX and the BSDs.

Apr 24 2017, 9:09 AM

Mar 27 2017

rakuco committed R446:ff6a9a25c6fb: khtml: Delete pointer _before_ returning. (authored by rakuco).
khtml: Delete pointer _before_ returning.
Mar 27 2017, 12:20 PM

Dec 29 2016

rakuco added a comment to D3850: Pass -fno-operator-names when supported.

Isn't it better to use check_cxx_compiler_flag to see if the flag is supported and enable it in case it is?

Dec 29 2016, 10:52 PM

Sep 10 2016

rakuco committed R172:2d0754d4ccb2: Enclose -DMAIL_DATA_DIR in quotes. (authored by rakuco).
Enclose -DMAIL_DATA_DIR in quotes.
Sep 10 2016, 6:38 AM
rakuco committed R172:dab5034a5508: Properly quote test names with spaces. (authored by rakuco).
Properly quote test names with spaces.
Sep 10 2016, 6:38 AM
rakuco committed R172:8eba21485841: Use quotemeta so that the system() call doesn't choke on paths with spaces. (authored by rakuco).
Use quotemeta so that the system() call doesn't choke on paths with spaces.
Sep 10 2016, 6:38 AM
rakuco committed R108:fecb8ec7fff8: Merge branch 'KDE/4.11' (authored by rakuco).
Merge branch 'KDE/4.11'
Sep 10 2016, 6:30 AM
rakuco committed R108:34f28508910c: Remove assertion in KDecorationUnstable's constructor. (authored by rakuco).
Remove assertion in KDecorationUnstable's constructor.
Sep 10 2016, 6:30 AM
rakuco committed R173:dab5034a5508: Properly quote test names with spaces. (authored by rakuco).
Properly quote test names with spaces.
Sep 10 2016, 6:29 AM
rakuco committed R173:8eba21485841: Use quotemeta so that the system() call doesn't choke on paths with spaces. (authored by rakuco).
Use quotemeta so that the system() call doesn't choke on paths with spaces.
Sep 10 2016, 6:29 AM
rakuco committed R173:2d0754d4ccb2: Enclose -DMAIL_DATA_DIR in quotes. (authored by rakuco).
Enclose -DMAIL_DATA_DIR in quotes.
Sep 10 2016, 6:29 AM
rakuco committed R108:f26a99b2e089: Add a few more headers required by getaddrinfo(3). (authored by rakuco).
Add a few more headers required by getaddrinfo(3).
Sep 10 2016, 6:19 AM
rakuco committed R108:4b323220b467: Merge branch 'KDE/4.9' (authored by rakuco).
Merge branch 'KDE/4.9'
Sep 10 2016, 6:15 AM
rakuco committed R108:4e710b3be328: Clean up the X11 definitions after the X11 includes. (authored by rakuco).
Clean up the X11 definitions after the X11 includes.
Sep 10 2016, 6:08 AM
rakuco committed R32:934b7b7b7571: Fix finding the unordered_map header. (authored by rakuco).
Fix finding the unordered_map header.
Sep 10 2016, 4:04 AM
rakuco committed R106:fc3e1bc8ceb1: Update signal name and signature after r969907. (authored by rakuco).
Update signal name and signature after r969907.
Sep 10 2016, 3:40 AM

Aug 21 2016

rakuco created T3489: lxr.kde.org: kf5-qt5 general search crashes Glimpse.
Aug 21 2016, 10:28 AM · Sysadmin

Mar 29 2016

rakuco added a comment to D1216: Disallow ptrace on greeter and kcheckpass process on FreeBSD .

Looks great to me now; I'll leave it to Martin to accept the diff.

Mar 29 2016, 4:47 PM · Plasma

Mar 28 2016

rakuco added inline comments to D1216: Disallow ptrace on greeter and kcheckpass process on FreeBSD .
Mar 28 2016, 3:01 PM · Plasma

Mar 25 2016

rakuco added a reviewer for D1217: Add 'QTGSTREAMER_INCLUDES' to the include directories as it contains the boost header location.: cordlandwehr.

Looks good to me, but @cordlandwehr should probably take a look at this too.

Mar 25 2016, 2:01 PM
rakuco added a comment to D1217: Add 'QTGSTREAMER_INCLUDES' to the include directories as it contains the boost header location..

The patch makes sense to me. Since QTGSTREAMER_INCLUDES already contains QTGSTREAMER_INCLUDE_DIR, you can probably remove the latter from include_directories().

Mar 25 2016, 1:02 PM

Mar 23 2016

rakuco added a comment to D1201: Display System Memory on FreeBSD too.

How about using the same calls present in Modules/memory/memory_fbsd.cpp (basically read the contents of the hw.physmem sysctl)?

Mar 23 2016, 9:36 AM

Mar 17 2016

rakuco added a comment to D1160: filetemplates plugin: Make testfiletemplates depend on kdevfiletemplates.

I've committed this to the 1.7 branch, with the required changes. Will you guys merge it to 5.0 or should I take care of it?

Mar 17 2016, 2:35 PM · KDevelop
rakuco committed R33:dd18e9a13558: filetemplates plugin: Make testfiletemplates depend on kdevfiletemplates (authored by rakuco).
filetemplates plugin: Make testfiletemplates depend on kdevfiletemplates
Mar 17 2016, 2:35 PM
rakuco closed D1160: filetemplates plugin: Make testfiletemplates depend on kdevfiletemplates by committing R33:dd18e9a13558: filetemplates plugin: Make testfiletemplates depend on kdevfiletemplates.
Mar 17 2016, 2:35 PM · KDevelop
rakuco added reviewers for D1160: filetemplates plugin: Make testfiletemplates depend on kdevfiletemplates: kfunk, mwolff.
Mar 17 2016, 12:57 PM · KDevelop
rakuco retitled D1160: filetemplates plugin: Make testfiletemplates depend on kdevfiletemplates from to filetemplates plugin: Make testfiletemplates depend on kdevfiletemplates.
Mar 17 2016, 12:40 PM · KDevelop