FrameworksRelease
ActivePublic

Recent Activity

Today

apol abandoned D14218: Introduce a test to make sure we're not offering duplicated icons.

Doesn't seem relevant anymore

Fri, Dec 6, 1:00 AM · Frameworks
davidedmundson accepted D25727: Expose enum to the metaobject compiler.
Fri, Dec 6, 12:35 AM · Frameworks
apol updated the diff for D25727: Expose enum to the metaobject compiler.

Alternative approach without Q_NAMESPACE_EXPORT, which is too new

Fri, Dec 6, 12:33 AM · Frameworks

Yesterday

ngraham added a comment to D8773: Improve discoverability of drag-and-drop of toolbar actions.

Haha yes almost exactly like that! Maybe today I'd use a sheet instead of a separate dialog window. But I have great faith that the 2019 David is able to conquer the challenges of 2009. :)

Thu, Dec 5, 11:28 PM · Frameworks
davidedmundson added a comment to D8773: Improve discoverability of drag-and-drop of toolbar actions.

That is excellent!

Thu, Dec 5, 11:25 PM · Frameworks
dfaure added a comment to D8773: Improve discoverability of drag-and-drop of toolbar actions.

That is excellent! But in the implementation, mind the "multiple kxmlgui-clients" use case, like konqueror or kdevelop (or kate I guess). It can make things tricky...
(you drop between two clients, how do you know which one should memorize the action into its kxmlgui file?)

Thu, Dec 5, 11:01 PM · Frameworks
aacid added a comment to D25720: Fix shortcut conflict between Cut and Delete File.

Trying to assign anything to Shift+Delete shows the "conflicting shortcuts" error dialog.

Thu, Dec 5, 11:00 PM · Frameworks
aacid added a comment to D25755: Replace iterators with range-based for.

is something you can use if you feel bored, i made it mandatory in poppler

Thu, Dec 5, 10:54 PM · Frameworks
davidedmundson added a comment to D8773: Improve discoverability of drag-and-drop of toolbar actions.

@ngraham
Like this: http://static.davidedmundson.co.uk/toolbars_change_01.ogv ?

Thu, Dec 5, 10:52 PM · Frameworks
dfaure accepted D25767: KAutoSaveFile: add a unit test to check max. filename length.
Thu, Dec 5, 10:50 PM · Frameworks
ngraham added a comment to D8774: Show Configure Toolbars dialog as modal.

Oops, sorry! I added comments to D8773.

Thu, Dec 5, 10:47 PM · Frameworks
ngraham requested changes to D8773: Improve discoverability of drag-and-drop of toolbar actions.

What I would like to see is that when you open the "Edit Toolbar" dialog that you then can drag around tool bar buttons and drag them from and to the dialog, like Firefox does it and how @colomar suggested. Given you can already re-arrange toolbar buttons whilst said dialog is open, what needs to be added is the ability to drag those from and to the dialog.

Yes, exactly. The closer to Firefox' "Customize" UX, the better. No more separate dialogs, just one mode where you configure your UI.

Thu, Dec 5, 10:46 PM · Frameworks
dfaure requested changes to D24489: KAutosaveFile not respecting maximum filename length.

Why is this not in the same commit as the related unittest, as is common practice?

Thu, Dec 5, 10:45 PM · Frameworks
dfaure added a comment to D8774: Show Configure Toolbars dialog as modal.

The description says this depends on D8773 which isn't approved.

Thu, Dec 5, 10:34 PM · Frameworks
davidedmundson requested review of D25775: Check cursor_open return value.
Thu, Dec 5, 10:32 PM · Baloo, Frameworks
ngraham added a comment to D25743: Expose IndexerState enum to QML.

Thanks, now it compiles! I'm not sure it's working perfectly though. I updated D25447 to use this, but it's claiming that my indexer is suspended, while balooctl status disagrees.

Thu, Dec 5, 9:52 PM · Baloo, Frameworks
winterz added a comment to D25753: EBN extra-cmake-modules transport cleanup.

please send me a list of urls that don't have https: and I'll add them to the whitelist

Thu, Dec 5, 9:26 PM · Build System, Frameworks
zrax updated the diff for D25770: Several enhancements to gitolite syntax definition..

Fix "+" in keywords to not act as a word break.

Thu, Dec 5, 9:24 PM · Frameworks, Kate
ngraham added a comment to D14218: Introduce a test to make sure we're not offering duplicated icons.

@apol we have a duplicate test in breeze-icons now; is this still relevant?

Thu, Dec 5, 9:15 PM · Frameworks
cgiboudeaux closed D25753: EBN extra-cmake-modules transport cleanup.
Thu, Dec 5, 9:14 PM · Build System, Frameworks
cgiboudeaux accepted D25753: EBN extra-cmake-modules transport cleanup.
Thu, Dec 5, 9:12 PM · Build System, Frameworks
davidedmundson updated the diff for D25743: Expose IndexerState enum to QML.

redo without the export

Thu, Dec 5, 9:11 PM · Baloo, Frameworks
ngraham added a comment to D8774: Show Configure Toolbars dialog as modal.

Can this land?

Thu, Dec 5, 9:00 PM · Frameworks
ngraham added a comment to D24433: Move URL parsing methods from kioslave to query object.

@bruns, is this good to go now?

Thu, Dec 5, 8:55 PM · Baloo, Frameworks
ngraham closed D23730: Add new protocol for 7z archives.
Thu, Dec 5, 8:37 PM · Frameworks, Dolphin
ngraham closed D23780: Add new protocol for 7z archives.
Thu, Dec 5, 8:33 PM · Frameworks
dhaumann added a comment to D25755: Replace iterators with range-based for.

Do we dislike iterators now?

We don't, and they still make sense for when you need the key, but range for is just much nier to look at :)

I'm fine with that statement. But are we going to be reviewing changing all the KDE code from iterators to range for? Feels like an overkill to me.

Thu, Dec 5, 8:18 PM · Frameworks
dhaumann accepted D25770: Several enhancements to gitolite syntax definition..

Looks good. But does the highlighting work for RW+CD? I am wondering whether + needs to be added to the weakDeliminator list?

Thu, Dec 5, 8:06 PM · Frameworks, Kate
zrax requested review of D25770: Several enhancements to gitolite syntax definition..
Thu, Dec 5, 6:55 PM · Frameworks, Kate
jhayes updated the diff for D25753: EBN extra-cmake-modules transport cleanup.
  • Corrected URL as review comments

Corrected url to http://www.sphinx-doc.org

Thu, Dec 5, 6:15 PM · Build System, Frameworks
cgiboudeaux added a comment to D25753: EBN extra-cmake-modules transport cleanup.

The sphinx doc URL is https://www.sphinx-doc.org (it just doesn't work without www)

Thu, Dec 5, 5:22 PM · Build System, Frameworks
ahmadsamir added a comment to D24489: KAutosaveFile not respecting maximum filename length.

Unit test added in D25767. AFAICS, both points addressed in this diff are needed to fix the referenced bug.

Thu, Dec 5, 5:01 PM · Frameworks
ahmadsamir added a reviewer for D24489: KAutosaveFile not respecting maximum filename length: mpyne.
Thu, Dec 5, 5:00 PM · Frameworks
ahmadsamir requested review of D25767: KAutoSaveFile: add a unit test to check max. filename length.
Thu, Dec 5, 4:59 PM · Frameworks
ahmadsamir added a dependent revision for D24489: KAutosaveFile not respecting maximum filename length: D25767: KAutoSaveFile: add a unit test to check max. filename length.
Thu, Dec 5, 4:59 PM · Frameworks
ngraham added a comment to D25720: Fix shortcut conflict between Cut and Delete File.

Apps that need both should be aware of it and remove the secondary Cut shortcut.

Or if you want to be mega fancy you can make kactioncollection (or something in xmlgui) do that

Thu, Dec 5, 3:19 PM · Frameworks
ahmadsamir updated subscribers of D25755: Replace iterators with range-based for.
Thu, Dec 5, 3:02 PM · Frameworks
ahmadsamir added a comment to D25755: Replace iterators with range-based for.

If we're going to iterate over a whole container, from cbegin() to cend(), and the container isn't going to change in the loop, then IMHO (H for humble :)) range-for would convey the intention better and make the code slightly easier to read/look cleaner.

Thu, Dec 5, 2:58 PM · Frameworks
jhayes updated the diff for D25753: EBN extra-cmake-modules transport cleanup.
  • Corrections made per review comments.

Reverted some non-working URL's back to http and updated one URL to the correct address

Thu, Dec 5, 2:50 PM · Build System, Frameworks
apol added a comment to D25755: Replace iterators with range-based for.
In D25755#572418, @apol wrote:

Do we dislike iterators now?

We don't, and they still make sense for when you need the key, but range for is just much nier to look at :)

Thu, Dec 5, 2:41 PM · Frameworks
feverfew added a comment to D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO.

Thanks for the reviews everyone! I'll update the diff and respond to the comments no later than Tuesday

Thu, Dec 5, 2:14 PM · Frameworks
broulik added a comment to D25755: Replace iterators with range-based for.
In D25755#572418, @apol wrote:

Do we dislike iterators now?

Thu, Dec 5, 2:07 PM · Frameworks
aacid added inline comments to D25755: Replace iterators with range-based for.
Thu, Dec 5, 1:42 PM · Frameworks
apol accepted D25757: EBN purpose constructor cleanup.
Thu, Dec 5, 12:29 PM · Frameworks
ahmadsamir added a comment to D25420: [KFileWidget] Avoid calling slotOk right after the url changed.

FWIW, this still doesn't work:

  • Open a pdf in okular
  • Invoke save as, navigate via the keyboard, highlight/select a dir, Enter, the file is saved inside that dir and the dialog closes
Thu, Dec 5, 12:13 PM · Frameworks
ahiemstra added a comment to D25311: Add KColumnHeadersProxyModel.

Sure, I can land it after saturday.

Thu, Dec 5, 11:53 AM · Frameworks
davidedmundson accepted D25311: Add KColumnHeadersProxyModel.

Though maybe we should wait till after tagging (Saturday) ?

Thu, Dec 5, 11:49 AM · Frameworks
ahiemstra updated the diff for D25311: Add KColumnHeadersProxyModel.
  • Add missing layoutChanged/reset signals
Thu, Dec 5, 11:21 AM · Frameworks
broulik added inline comments to D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO.
Thu, Dec 5, 11:04 AM · Frameworks
cgiboudeaux closed D25397: Install .pri file for KAuthCore.
Thu, Dec 5, 10:14 AM · Frameworks