OK, next step is to consider writing that separate class now rather than hoping to dump that task on a random future reader of the TODO ;-)
At least, starting it is the best way to find out how feasible it is.
Run icons through SVG cleaner
With the blue color, I like these icons. Please remember to update images in the test plan when you make changes such as this color change, they're very helpful for judging things e.g. on a phone.
I rewrote the patch to address the comments:
This is with the tape window moved up 1px
When I look at images of real cassettes, they are not centered, hence why I only did this slight adjustment.
If everyone is okay with this, I will update the revision with the optimized svgs.
I don't think that filling this space is useful.
Oh yes, that would be a good thing. Any of these will be fine: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization
Good rundown of the options.
In my experience 90 % of the users of this class don't care for the state feature, so I would rather move it to a separate class.
bool takeOwnership = true);
Can you clean the SVGs a bit?
This is just to make sure this TODO makes sense and is consensual.
I think the best would be to add additional parameter to KSNI. Change from:
void KStatusNotifierItem::setContextMenu(QMenu *menu);
to something like this:
void KStatusNotifierItem::setContextMenu(QMenu *menu, bool takeOwnership = true);
Then, after next release of Frameworks, change implementation in plasma-integration.
kf5-network.directory has been added to plasma-workspace.
Compare against lowercase value
The commit log talks about KCalendarCore instead of KIO :)
update to latest master