FrameworksRelease
ActivePublic

Recent Activity

Today

ngraham added a comment to D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart.

@bruns, is this good to go now?

Fri, Jul 19, 2:54 PM · Frameworks
apol closed D22546: Add missing components in org.kde.plasma.components 3.0.
Fri, Jul 19, 2:17 PM · Frameworks
mart accepted D22546: Add missing components in org.kde.plasma.components 3.0.
Fri, Jul 19, 2:15 PM · Frameworks
ngraham added a comment to D22557: [IndexCleaner] ignore non-existent entries inside config.

Shouldn't we make sure that entries get removed from the config file properly?

Fri, Jul 19, 2:12 PM · Baloo, Frameworks
dfaure added a comment to D22528: KIO FTP: Fix file copy hanging when copying to existing file.

I like very much your proposal about using two classes to avoid reintroducing problems in the future.

Fri, Jul 19, 1:52 PM · Frameworks
sitter added a comment to D22528: KIO FTP: Fix file copy hanging when copying to existing file.

Something like this https://phabricator.kde.org/P439

Fri, Jul 19, 1:46 PM · Frameworks
nicolasfella added a comment to D22554: Finer No-Dbus on Windows.

Now HAVE_DBUSMENUQT won't be set. Previously it was set to 0 in this case

Fri, Jul 19, 1:16 PM · Frameworks
nxiss7 updated the test plan for D22419: Fix cant enter directory error on Android FTP servers.
Fri, Jul 19, 1:04 PM · Frameworks
sitter added a comment to D22528: KIO FTP: Fix file copy hanging when copying to existing file.

Hm. I've had a quick look and I think the intent was that only the slavebase overridden functions call error or finished. So technically all internal functions that can have an error need to set an iError or return one so that the "public" function can then issue error() as needed. This seems to not very well enforced and probably never was, in fact there's a comment in the .h about this very fact

Fri, Jul 19, 12:50 PM · Frameworks
dfaure added a comment to D22528: KIO FTP: Fix file copy hanging when copying to existing file.

Please wait.

Fri, Jul 19, 12:18 PM · Frameworks
andriusr added inline comments to D22554: Finer No-Dbus on Windows.
Fri, Jul 19, 12:03 PM · Frameworks
poboiko updated the summary of D22502: [FileIndexerConfig] skip invalid entries from included/excludedFolders.
Fri, Jul 19, 11:42 AM · Baloo, Frameworks
poboiko requested review of D22557: [IndexCleaner] ignore non-existent entries inside config.
Fri, Jul 19, 11:37 AM · Baloo, Frameworks
fvogt added inline comments to D22555: [RFC] Add a kded module to manage various available fuse mount services.
Fri, Jul 19, 11:25 AM · Frameworks
chinmoyr requested review of D22555: [RFC] Add a kded module to manage various available fuse mount services.
Fri, Jul 19, 11:20 AM · Frameworks
brute4s99 updated the diff for D22554: Finer No-Dbus on Windows.

updated

Fri, Jul 19, 11:05 AM · Frameworks
nicolasfella added inline comments to D22554: Finer No-Dbus on Windows.
Fri, Jul 19, 10:55 AM · Frameworks
leinir updated the diff for D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets).
  • Refactor the naming of components etc a touch (and hide private bits)
  • Fix a few bits of stray naming in the docs
Fri, Jul 19, 10:55 AM · Frameworks
brute4s99 requested review of D22554: Finer No-Dbus on Windows.
Fri, Jul 19, 10:51 AM · Frameworks
nicolasfella closed D22536: Don't advertise using KPassivePopup.
Fri, Jul 19, 10:42 AM · Frameworks
meven added inline comments to D17595: Upstream Dolphin's file rename dialog.
Fri, Jul 19, 10:37 AM · Frameworks
ZaWertun added a comment to D22528: KIO FTP: Fix file copy hanging when copying to existing file.

Looks good to me. The slave indeed must issue an exit state there.

What email address would you like to have associated with the git commit?

Fri, Jul 19, 9:39 AM · Frameworks
sitter requested review of D22551: expose new KBusyIndicatorWidget.
Fri, Jul 19, 9:25 AM · Frameworks
sitter added inline comments to D17595: Upstream Dolphin's file rename dialog.
Fri, Jul 19, 9:13 AM · Frameworks
broulik closed D22523: Remove visibilityChanged connection in favor of existing eventFilter.
Fri, Jul 19, 9:13 AM · Frameworks
sitter accepted D22528: KIO FTP: Fix file copy hanging when copying to existing file.

Looks good to me. The slave indeed must issue an exit state there.

Fri, Jul 19, 9:01 AM · Frameworks
chinmoyr closed D21782: Add a warning dialog with details, continue, and cancel button.
Fri, Jul 19, 8:52 AM · Frameworks
chinmoyr updated the summary of D21782: Add a warning dialog with details, continue, and cancel button.
Fri, Jul 19, 8:42 AM · Frameworks
meven updated the diff for D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart.

Remove dead code

Fri, Jul 19, 7:19 AM · Frameworks
meven updated the diff for D17595: Upstream Dolphin's file rename dialog.

Add context about filename #

Fri, Jul 19, 7:14 AM · Frameworks
dfaure added a comment to D19986: Install .desktop file for kded5.

OK, changed in https://commits.kde.org/kded/b733c88e2d70db854cf99466ef52c9a3f9db118e

Fri, Jul 19, 6:45 AM · Frameworks
dfaure accepted D22523: Remove visibilityChanged connection in favor of existing eventFilter.

Good catch.

Fri, Jul 19, 6:42 AM · Frameworks
siddharthasahu added a comment to D21002: Remove kde4 migration agent completely.

Do I have to reset something on my machine after this?

Fri, Jul 19, 5:21 AM · Frameworks
ngraham closed D22541: Update refresh and restart icons to reflect new breeze-icons versions.
Fri, Jul 19, 2:40 AM · Frameworks
apol accepted D22536: Don't advertise using KPassivePopup.
Fri, Jul 19, 1:11 AM · Frameworks
apol requested review of D22546: Add missing components in org.kde.plasma.components 3.0.
Fri, Jul 19, 12:50 AM · Frameworks

Yesterday

davidedmundson added a comment to D22544: [RFC] Deprecate KPassivePopup.
Given it's brokeness and relative usefulness I propose to remove it.
Thu, Jul 18, 9:48 PM · Frameworks
dhaumann accepted D13867: [KMessageWidget] Pass widget to standardIcon().

The commit log says "Breeze now knows it's a KMessageWidget". Ok. And now? The commit log lacks what issue this patch fixes...

Thu, Jul 18, 9:18 PM · Frameworks
aspotashev added a comment to D22544: [RFC] Deprecate KPassivePopup.

kdialog also uses KPassivePopup

Thu, Jul 18, 9:08 PM · Frameworks
aspotashev added a comment to D22544: [RFC] Deprecate KPassivePopup.

The case where no notification daemon is running is IMHO an edge case that we don't need to support.

Thu, Jul 18, 9:07 PM · Frameworks
ndavis accepted D22541: Update refresh and restart icons to reflect new breeze-icons versions.

Looks good!

Thu, Jul 18, 9:07 PM · Frameworks
nicolasfella added a reviewer for D22544: [RFC] Deprecate KPassivePopup: broulik.
Thu, Jul 18, 9:02 PM · Frameworks
nicolasfella updated the summary of D22544: [RFC] Deprecate KPassivePopup.
Thu, Jul 18, 9:01 PM · Frameworks
nicolasfella updated the summary of D22544: [RFC] Deprecate KPassivePopup.
Thu, Jul 18, 9:01 PM · Frameworks
nicolasfella requested review of D22544: [RFC] Deprecate KPassivePopup.
Thu, Jul 18, 8:59 PM · Frameworks
ngraham updated the summary of D22541: Update refresh and restart icons to reflect new breeze-icons versions.
Thu, Jul 18, 8:21 PM · Frameworks
ngraham requested review of D22541: Update refresh and restart icons to reflect new breeze-icons versions.
Thu, Jul 18, 8:17 PM · Frameworks
apol added a comment to D21606: RFC: ThreadWeaver Job Decorators not used properly and have no effect.

I need this additionally

Thu, Jul 18, 7:54 PM · Frameworks
meven updated the diff for D17595: Upstream Dolphin's file rename dialog.

Fix email in copyright declaration

Thu, Jul 18, 7:52 PM · Frameworks
cfeck accepted D13867: [KMessageWidget] Pass widget to standardIcon().
Thu, Jul 18, 7:48 PM · Frameworks