FrameworksRelease
ActivePublic

Recent Activity

Today

kossebau closed D24651: Use ECMGenerateExportHeader to manage deprecated API better.
Wed, Oct 16, 8:23 PM · Frameworks
dfaure added a comment to D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum.

OK, next step is to consider writing that separate class now rather than hoping to dump that task on a random future reader of the TODO ;-)
At least, starting it is the best way to find out how feasible it is.

Wed, Oct 16, 8:14 PM · Frameworks
kossebau updated the task description for T11490: Control for visibility of symbols of deprecated API and compiler warnings.
Wed, Oct 16, 8:08 PM · KF6, Frameworks
kossebau requested review of D24710: Use ECMGenerateExportHeader to manage deprecated API better.
Wed, Oct 16, 8:06 PM · Frameworks
cblack closed D24537: Icons for windy weather.
Wed, Oct 16, 8:03 PM · Frameworks
cblack updated the diff for D24537: Icons for windy weather.

Run icons through SVG cleaner

Wed, Oct 16, 7:50 PM · Frameworks
cblack updated the test plan for D24537: Icons for windy weather.
Wed, Oct 16, 7:50 PM · Frameworks
trickyricky26 added a comment to D24537: Icons for windy weather.

With the blue color, I like these icons. Please remember to update images in the test plan when you make changes such as this color change, they're very helpful for judging things e.g. on a phone.

Wed, Oct 16, 7:08 PM · Frameworks
kossebau requested review of D24707: Use ECMGenerateExportHeader to manage deprecated API better.
Wed, Oct 16, 6:57 PM · Frameworks
thomasfischer updated the diff for D24641: Collect more information from version control systems.

I rewrote the patch to address the comments:

Wed, Oct 16, 6:22 PM · Build System, Frameworks
ngraham added a comment to D24598: Update elisa icon.

This is with the tape window moved up 1px


When I look at images of real cassettes, they are not centered, hence why I only did this slight adjustment.
If everyone is okay with this, I will update the revision with the optimized svgs.
I don't think that filling this space is useful.

Wed, Oct 16, 5:51 PM · Frameworks, Elisa
astippich added a comment to D24598: Update elisa icon.

This is with the tape window moved up 1px


When I look at images of real cassettes, they are not centered, hence why I only did this slight adjustment.
If everyone is okay with this, I will update the revision with the optimized svgs.
I don't think that filling this space is useful.

Wed, Oct 16, 4:55 PM · Frameworks, Elisa
meven updated the diff for D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum.

Update TODO

Wed, Oct 16, 4:44 PM · Frameworks
meven added a comment to D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum.

In my experience 90 % of the users of this class don't care for the state feature, so I would rather move it to a separate class.

Also this class is used everywhere, so the change would have massive repercussions, while most users (both subclasses and code using a kxmlguiclient pointer) don't care for the state thing.

I suggest extracting the feature into a helper class separate from the kxmlguiclient hierarchy.

Wed, Oct 16, 4:43 PM · Frameworks
davidedmundson accepted D24667: [KStatusNotifierItem] Allow left click when menu is null.
Wed, Oct 16, 4:28 PM · Frameworks
ndavis added a comment to D24537: Icons for windy weather.

Oh yes, that would be a good thing. Any of these will be fine: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization

Wed, Oct 16, 4:27 PM · Frameworks
vkrause added a task to D24703: Port (most of) KSslInfoDialog from KSslError to QSslError: T11620: Port from KSslError to QSslError.
Wed, Oct 16, 4:27 PM · Frameworks
davidedmundson added a comment to D24667: [KStatusNotifierItem] Allow left click when menu is null.

Good rundown of the options.

Wed, Oct 16, 4:27 PM · Frameworks
vkrause requested review of D24703: Port (most of) KSslInfoDialog from KSslError to QSslError.
Wed, Oct 16, 4:26 PM · Frameworks
kossebau updated the task description for T11490: Control for visibility of symbols of deprecated API and compiler warnings.
Wed, Oct 16, 3:55 PM · KF6, Frameworks
kossebau requested review of D24700: Use ECMGenerateExportHeader to manage deprecated API better.
Wed, Oct 16, 3:53 PM · Frameworks
dfaure added a comment to D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum.

In my experience 90 % of the users of this class don't care for the state feature, so I would rather move it to a separate class.

Wed, Oct 16, 3:44 PM · Frameworks
ngraham accepted D24652: Add folder-recent, extend hand of clock in folder-temp.
Wed, Oct 16, 3:40 PM · Frameworks
broulik added a comment to D24667: [KStatusNotifierItem] Allow left click when menu is null.

bool takeOwnership = true);

Wed, Oct 16, 3:30 PM · Frameworks
ngraham updated the summary of D24667: [KStatusNotifierItem] Allow left click when menu is null.
Wed, Oct 16, 3:20 PM · Frameworks
ervin closed D24697: Expose isImmutable to introspection (e.g. QML).
Wed, Oct 16, 2:48 PM · Frameworks
meven updated the task description for T8552: Polish Open/Save dialogs.
Wed, Oct 16, 2:27 PM · Frameworks, VDG
broulik accepted D24697: Expose isImmutable to introspection (e.g. QML).
Wed, Oct 16, 2:20 PM · Frameworks
ervin requested review of D24697: Expose isImmutable to introspection (e.g. QML).
Wed, Oct 16, 2:15 PM · Frameworks
kossebau added inline comments to D24663: Use ECMGenerateExportHeader to manage deprecated API better.
Wed, Oct 16, 2:00 PM · Frameworks
GB_2 added a comment to D24537: Icons for windy weather.

Can you clean the SVGs a bit?

Wed, Oct 16, 1:52 PM · Frameworks
ngraham accepted D24537: Icons for windy weather.

Shipit!

Wed, Oct 16, 1:49 PM · Frameworks
kossebau updated the summary of D24684: Use ECMGenerateExportHeader to manage deprecated API better.
Wed, Oct 16, 1:48 PM · Frameworks
meven added a comment to D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum.

This is just to make sure this TODO makes sense and is consensual.

Wed, Oct 16, 12:22 PM · Frameworks
meven requested review of D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum.
Wed, Oct 16, 12:21 PM · Frameworks
jgrulich added a dependent revision for D24689: Add support for SAE authentication used by WPA3: D24691: Add support for WPA3.
Wed, Oct 16, 11:28 AM · Frameworks
kmaterka added a comment to D24667: [KStatusNotifierItem] Allow left click when menu is null.

I think the best would be to add additional parameter to KSNI. Change from:

void KStatusNotifierItem::setContextMenu(QMenu *menu);

to something like this:

void KStatusNotifierItem::setContextMenu(QMenu *menu, bool takeOwnership = true);

Then, after next release of Frameworks, change implementation in plasma-integration.

Wed, Oct 16, 10:45 AM · Frameworks
guoyunhe added a comment to D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category.

kf5-network.directory has been added to plasma-workspace.

Wed, Oct 16, 10:11 AM · Frameworks
jgrulich added a reviewer for D24689: Add support for SAE authentication used by WPA3: Frameworks.
Wed, Oct 16, 9:37 AM · Frameworks
jgrulich updated the diff for D24689: Add support for SAE authentication used by WPA3.

Compare against lowercase value

Wed, Oct 16, 9:37 AM · Frameworks
jgrulich requested review of D24689: Add support for SAE authentication used by WPA3.
Wed, Oct 16, 9:35 AM · Frameworks
kmaterka added a reviewer for D24667: [KStatusNotifierItem] Allow left click when menu is null: Frameworks.
Wed, Oct 16, 8:45 AM · Frameworks
kmaterka retitled D24667: [KStatusNotifierItem] Allow left click when menu is null from Activate when both associatedWidget and menu are null to [KStatusNotifierItem] Allow left click when menu is null.
Wed, Oct 16, 8:43 AM · Frameworks
Diffusion closed D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.
Wed, Oct 16, 8:39 AM · Frameworks
zzag edited reviewers for D24663: Use ECMGenerateExportHeader to manage deprecated API better, added: KWin; removed: Plasma.
Wed, Oct 16, 8:35 AM · Frameworks
zzag added inline comments to D24663: Use ECMGenerateExportHeader to manage deprecated API better.
Wed, Oct 16, 8:33 AM · Frameworks
dfaure added a comment to D24684: Use ECMGenerateExportHeader to manage deprecated API better.

The commit log talks about KCalendarCore instead of KIO :)

Wed, Oct 16, 8:20 AM · Frameworks
meven requested review of D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue.
Wed, Oct 16, 7:48 AM · Frameworks, Dolphin
kossebau updated the diff for D24684: Use ECMGenerateExportHeader to manage deprecated API better.

update to latest master

Wed, Oct 16, 7:31 AM · Frameworks
meven requested review of D24685: Replace usage of SlaveBase::config()->readEntry by SlaveBase::configValue.
Wed, Oct 16, 7:27 AM · Frameworks