Create Task
Maniphest T12611

Make Breeze a framework and relocate all of its Plasma theme stuff (e.g. wallpaper) to a different repo still on the Plasma release schedule
Closed, WontfixPublic
Actions

Description

Plasma-framework is a framework, which means it has a different release schedule from Plasma and other products that use its release cycle, such as the Breeze repo. This causes various problems, such as making it impossible to synchronize visual changes between the Plasma Breeze theme and the Breeze QWidgets theme, or change the filetype of the wallpaper (which lives in Breeze) because the Breeze Plasma theme's metadata.desktop file which specifies the filetype lives in plasma-framework.

I'd like to propose that the Breeze repo be made a framework, and then we would move the wallpaper and other Plasma stuff out of it and into the plasma-workspace LNF package or another repo aligned with the Plasma release schedule.

Related Objects

ngraham created this task.Jan 28 2020, 6:55 PM
ngraham mentioned this in T12612: Move QQC2 desktop style visual theme into Breeze or some other repo aligned with the Plasma release cycle.Jan 29 2020, 12:29 AM

Alternatively, we could move the Breeze widget theme into a framework and not have to do this.

davidedmundson added a subscriber: davidedmundson.Jan 29 2020, 1:06 AM

We previously have discussed several times making the plasma breeze theme (plus the low level SVG classes etc) a tier 1 framework so it's quick to build a nice looking UI from scratch on embedded devices which lack native controls.
Putting this into plasma would go against that.

Alternatively, we could move the Breeze widget theme into a framework and not have to do this.

That's an idea that's certainly worth considering further.
It would resolve the need for app developers to have Plasma 6 released to release their apps.

davidedmundson added a comment.Jan 29 2020, 1:18 AM

RE: Wallpapers specifically

Yes, that 100% should not belong in the theme.
It's also in the desktop layout package and defined in the lnf package. We should have been clearer to deprecate this when that happened.

Anything remaining of plasma theme should be about low level controls and shapes alone (i.e something an app on plasma-mobile might use) and absolutely nothing to do with plasmashell.

ngraham added a comment.Jan 29 2020, 2:28 AM
In T12611#219181, @davidedmundson wrote:

RE: Wallpapers specifically

Yes, that 100% should not belong in the theme.
It's also in the desktop layout package and defined in the lnf package. We should have been clearer to deprecate this when that happened.

Anything remaining of plasma theme should be about low level controls and shapes alone (i.e something an app on plasma-mobile might use) and absolutely nothing to do with plasmashell.

Yeah. What I'd like is to keep the wallpaper in a repo on the Plasma release cycle (maybe not Breeze though; plasma-workspace?) but break the implicit dependencies to stuff in frameworks, like that desktop file that specifies the wallpaper's filename extension.

In T12611#219177, @davidedmundson wrote:

Alternatively, we could move the Breeze widget theme into a framework and not have to do this.

That's an idea that's certainly worth considering further.
It would resolve the need for app developers to have Plasma 6 released to release their apps.

Cool, let's make this task about that then.

ngraham renamed this task from Move Breeze Plasma theme into Breeze repo or some other repo aligned with the Plasma release cycle to Make Breeze a framework and relocate all of its Plasma theme stuff (e.g. wallpaper) to a different repo still on the Plasma release schedule.Jan 29 2020, 2:29 AM
ngraham updated the task description. (Show Details)
mart added a subscriber: mart.EditedJan 29 2020, 11:32 AM

for the defaulr wallpaper actually I would like to drop the default lookup from the plasma theme desktop file completely
and just use a key in the look and feel instead (which was pretty much D21225)

davidedmundson added a comment.Jan 29 2020, 11:55 AM

for the defaulr wallpaper actually I would like to drop the default lookup from the plasma theme desktop file completely

Ack, makes sense. Better than it being scattered across 3 places (if you include desktop layout js files)
I'll do something in Image::useSingleImageDefaults, to fix the issue we are seeing now and deprecate that plasma theme part.

ndavis added a subscriber: ndavis.Jan 30 2020, 5:32 AM
nicolasfella moved this task from Backlog to Needs Input on the KF6 board.Nov 22 2020, 12:13 AM
ngraham closed this task as Wontfix.Nov 4 2022, 2:29 PM

We've decided to keep it in the Plasma schedule. Instead, for Plasma 6, plasma-framework is going to be merged into plasma-workspace, which will automatically fix the issue described in https://bugs.kde.org/show_bug.cgi?id=345997.