Feed Advanced Search

Today

davidedmundson updated the diff for D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin.

All changes except the parameters of filterRowCallback

Wed, Dec 11, 10:34 PM · Frameworks
mlaurent updated the diff for D25902: Fix decrement index and not iterator as discussed with David.

Fix other code

Wed, Dec 11, 8:45 PM · Frameworks, Dolphin
kossebau added a comment to D25323: [text thumbnail] Force Syntax Highligthing when no definition for file was found.

See D25891 (not tested by myself, only saw it) for another approach to this. So seems in general setTheme() always needs an explicit rehighlight() afterwards (but why only in some cases)?
AbstractHighlighter::setTheme claims that "Subclasses can re-implement this method to e.g. trigger re-highlighing or to do general palette color setup. ", so SyntaxHighlighter actually is missing to comply here?

Wed, Dec 11, 8:24 PM · Frameworks, Dolphin
iliakats closed D25891: fix preview of plain text files when using dark theme.
Wed, Dec 11, 8:13 PM · Frameworks, Dolphin
anthonyfieroni added inline comments to D25902: Fix decrement index and not iterator as discussed with David.
Wed, Dec 11, 8:11 PM · Frameworks, Dolphin
anthonyfieroni accepted D25891: fix preview of plain text files when using dark theme.
Wed, Dec 11, 8:06 PM · Frameworks, Dolphin
mlaurent added a reviewer for D25902: Fix decrement index and not iterator as discussed with David: dfaure.
Wed, Dec 11, 6:47 PM · Frameworks, Dolphin
mlaurent requested review of D25902: Fix decrement index and not iterator as discussed with David.
Wed, Dec 11, 6:47 PM · Frameworks, Dolphin
vkrause closed D25858: Use QStyle for determining icon sizes.
Wed, Dec 11, 6:10 PM · Frameworks
nibags closed D25870: SELinux: add "glblub" keyword and update permissions list.
Wed, Dec 11, 6:09 PM · Frameworks, Kate
vkrause added a task to D25858: Use QStyle for determining icon sizes: T11637: Investigate if KIconThemes is needed as a framework.
Wed, Dec 11, 6:09 PM · Frameworks
ndavis updated the test plan for D25897: Add 32, 48 and 64 px user-desktop icons.
Wed, Dec 11, 5:48 PM · Frameworks
ndavis requested review of D25897: Add 32, 48 and 64 px user-desktop icons.
Wed, Dec 11, 5:47 PM · Frameworks
iliakats updated the diff for D25891: fix preview of plain text files when using dark theme.

performance improvement: only do one round of highlighting (skip the one run in the constructor of QSyntaxHighlighter)

Wed, Dec 11, 4:40 PM · Frameworks, Dolphin
iliakats added a reviewer for D25891: fix preview of plain text files when using dark theme: Dolphin.
Wed, Dec 11, 3:47 PM · Frameworks, Dolphin
iliakats requested review of D25891: fix preview of plain text files when using dark theme.
Wed, Dec 11, 3:46 PM · Frameworks, Dolphin
leinir closed D25888: Support multiple children elements in comment elements.
Wed, Dec 11, 3:33 PM · Frameworks
ngraham accepted D25888: Support multiple children elements in comment elements.

Awesome!

Wed, Dec 11, 3:32 PM · Frameworks
leinir added reviewers for D25888: Support multiple children elements in comment elements: Frameworks, KNewStuff, ngraham.
Wed, Dec 11, 3:29 PM · Frameworks
leinir requested review of D25888: Support multiple children elements in comment elements.
Wed, Dec 11, 3:28 PM · Frameworks
broulik closed D25887: [ColorScope] Work with plain QObjects again.
Wed, Dec 11, 3:02 PM · Frameworks
mart accepted D25887: [ColorScope] Work with plain QObjects again.
Wed, Dec 11, 3:01 PM · Frameworks
broulik requested review of D25887: [ColorScope] Work with plain QObjects again.
Wed, Dec 11, 3:00 PM · Frameworks
broulik closed D25885: [Breeze Desktop Theme] Add monochrome user-desktop icon.
Wed, Dec 11, 2:56 PM · Frameworks
ngraham updated the test plan for D25878: Use clearer relative dates.
Wed, Dec 11, 2:54 PM · Frameworks
ngraham updated the summary of D25878: Use clearer relative dates.
Wed, Dec 11, 2:53 PM · Frameworks
ngraham updated the diff for D25878: Use clearer relative dates.

Don't use relative dates farther than three days back

Wed, Dec 11, 2:51 PM · Frameworks
kossebau added a comment to D23682: Make use of KPluginMetaData where we can.

Also some nitpicks on the style... remember that API dox tool and compiler both need all data duplicated sadly, both deprecated-at version and what-to-do-instead.

Wed, Dec 11, 2:49 PM · Frameworks
kossebau added a comment to D23682: Make use of KPluginMetaData where we can.

Do not forget to bump 5.64 to 5.66 in all places :)

Wed, Dec 11, 2:37 PM · Frameworks
ngraham accepted D25885: [Breeze Desktop Theme] Add monochrome user-desktop icon.

Nice work!

Wed, Dec 11, 2:19 PM · Frameworks
broulik requested review of D25885: [Breeze Desktop Theme] Add monochrome user-desktop icon.
Wed, Dec 11, 2:16 PM · Frameworks
mart accepted D23682: Make use of KPluginMetaData where we can.
Wed, Dec 11, 2:15 PM · Frameworks
dhaumann accepted D25870: SELinux: add "glblub" keyword and update permissions list.
Wed, Dec 11, 2:07 PM · Frameworks, Kate
dhaumann accepted D25869: Python: improve numbers, add octals, binaries and "breakpoint" keyword.
Wed, Dec 11, 2:06 PM · Frameworks, Kate
ngraham added a comment to D25878: Use clearer relative dates.

So no "in two days"/"two days ago"? That's too confusing?

Wed, Dec 11, 1:33 PM · Frameworks
broulik added a comment to D25878: Use clearer relative dates.

Yeah i think yesterday and tomorrow is fine but everything beyond that becomes more annoying than helpful

Wed, Dec 11, 1:15 PM · Frameworks
ngraham added a comment to D25878: Use clearer relative dates.

I was on the fence about that too. We could move to absolute dates after three days, maybe.

Wed, Dec 11, 1:06 PM · Frameworks
filipf added a comment to D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.

Let's track the arrow issue in: https://bugs.kde.org/show_bug.cgi?id=415049

Wed, Dec 11, 12:56 PM · Frameworks
filipf closed D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.
Wed, Dec 11, 12:50 PM · Frameworks
filipf updated the test plan for D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.
Wed, Dec 11, 12:48 PM · Frameworks
davidre added a dependent revision for D25875: [KColorschemeManager] Prevent changes to the palette if a custom one is set: D25877: [KColorschemeManager] Add option to reenable following global theme.
Wed, Dec 11, 11:31 AM · Frameworks
davidre added a dependency for D25877: [KColorschemeManager] Add option to reenable following global theme: D25875: [KColorschemeManager] Prevent changes to the palette if a custom one is set.
Wed, Dec 11, 11:31 AM · Frameworks
broulik added a comment to D25878: Use clearer relative dates.

Not a fan of Mathematics there. "Five days ago" I first have to open my calendar and count what day that was.

Wed, Dec 11, 11:23 AM · Frameworks
davidre updated the test plan for D25875: [KColorschemeManager] Prevent changes to the palette if a custom one is set.
Wed, Dec 11, 11:09 AM · Frameworks
ngraham requested review of D25878: Use clearer relative dates.
Wed, Dec 11, 11:08 AM · Frameworks
davidre requested review of D25877: [KColorschemeManager] Add option to reenable following global theme.
Wed, Dec 11, 11:08 AM · Frameworks
fvogt added a comment to D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.

Please don't link external sites (GitHub) in the committed message.

RE: Menu
There is nothing in QQC2::Button to add a menu

If we want that it would have to be a custom button subclass, rather than something we support in the style.

Wed, Dec 11, 11:05 AM · Frameworks
davidre added a reviewer for D25875: [KColorschemeManager] Prevent changes to the palette if a custom one is set: Frameworks.
Wed, Dec 11, 11:04 AM · Frameworks
davidre requested review of D25875: [KColorschemeManager] Prevent changes to the palette if a custom one is set.
Wed, Dec 11, 10:48 AM · Frameworks
mart added a comment to D25015: Update breeze theme shadows.

Got it. The shape is actually rounded BUT the desktop contract effect is applied in the whole rectangle underneath, and it makes everything look like a rectangle. Here's the widget with fully transparent background, but with the contract effect on:


Of course, I can't just turn off the contrast desktop effect. I'm unsure how to move forward with this.
Here's Plasma without desktop effect:

As you can see, shadows are working!

Wed, Dec 11, 10:35 AM · Frameworks
vkrause added inline comments to D25865: kfilemetadata EBN transport protocol cleanup.
Wed, Dec 11, 9:55 AM · Baloo, Frameworks
davidedmundson accepted D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.

Please don't link external sites (GitHub) in the committed message.

Wed, Dec 11, 9:45 AM · Frameworks
broulik closed D25685: [QImageItem/QPixmapItem] Don't lose precision during calculation.
Wed, Dec 11, 9:38 AM · Frameworks
cgiboudeaux closed D25829: kconfig EBN transport protocol cleanup.
Wed, Dec 11, 9:09 AM · Frameworks
cgiboudeaux closed D25864: kdeclarative EBN spelling cleanup.
Wed, Dec 11, 9:08 AM · Frameworks
cgiboudeaux accepted D25864: kdeclarative EBN spelling cleanup.
Wed, Dec 11, 9:07 AM · Frameworks
cgiboudeaux closed D25866: kholidays EBN transport protocol cleanup.
Wed, Dec 11, 9:04 AM · Frameworks
cgiboudeaux accepted D25866: kholidays EBN transport protocol cleanup.
Wed, Dec 11, 9:03 AM · Frameworks
nibags added reviewers for D25870: SELinux: add "glblub" keyword and update permissions list: dhaumann, cullmann, Framework: Syntax Highlighting.
Wed, Dec 11, 7:03 AM · Frameworks, Kate
nibags requested review of D25870: SELinux: add "glblub" keyword and update permissions list.
Wed, Dec 11, 7:02 AM · Frameworks, Kate
nibags updated the diff for D25869: Python: improve numbers, add octals, binaries and "breakpoint" keyword.
  • Fix autotest
Wed, Dec 11, 5:47 AM · Frameworks, Kate
nibags updated the summary of D25869: Python: improve numbers, add octals, binaries and "breakpoint" keyword.
Wed, Dec 11, 5:40 AM · Frameworks, Kate
nibags requested review of D25869: Python: improve numbers, add octals, binaries and "breakpoint" keyword.
Wed, Dec 11, 5:35 AM · Frameworks, Kate
jhayes requested review of D25866: kholidays EBN transport protocol cleanup.
Wed, Dec 11, 1:22 AM · Frameworks
jhayes requested review of D25865: kfilemetadata EBN transport protocol cleanup.
Wed, Dec 11, 12:42 AM · Baloo, Frameworks

Yesterday

leinir added inline comments to D25849: Ensure the dialog title is correct with an uninitialised engine.
Tue, Dec 10, 9:47 PM · Frameworks
leinir updated the diff for D25849: Ensure the dialog title is correct with an uninitialised engine.
  • Less string puzzles are better
Tue, Dec 10, 9:47 PM · Frameworks
davidedmundson accepted D25685: [QImageItem/QPixmapItem] Don't lose precision during calculation.
Tue, Dec 10, 9:40 PM · Frameworks
dhaumann added a comment to D23457: Port regex search to QRegularExpression.

Personally, I am not convinced replacing \s with [ \t], and deviating from PCRE default behaviour is a good idea in this case.

Tue, Dec 10, 9:11 PM · Frameworks, Kate
jhayes requested review of D25864: kdeclarative EBN spelling cleanup.
Tue, Dec 10, 8:47 PM · Frameworks
apol accepted D25858: Use QStyle for determining icon sizes.
Tue, Dec 10, 8:41 PM · Frameworks
chehrlic added inline comments to D7700: Show list of tags in PlacesView.
Tue, Dec 10, 5:48 PM · Frameworks, Dolphin
broulik added a dependent revision for D25859: Add Battery1 interface: D25860: [plasmoid] Show device battery percentage.
Tue, Dec 10, 5:45 PM · Frameworks
broulik requested review of D25859: Add Battery1 interface.
Tue, Dec 10, 5:24 PM · Frameworks
vkrause requested review of D25858: Use QStyle for determining icon sizes.
Tue, Dec 10, 5:21 PM · Frameworks
leinir closed D25855: Don't show the info icon on the big preview delegate.
Tue, Dec 10, 4:56 PM · Frameworks
ndavis accepted D25855: Don't show the info icon on the big preview delegate.
Tue, Dec 10, 4:54 PM · Frameworks
leinir added reviewers for D25855: Don't show the info icon on the big preview delegate: Frameworks, KNewStuff, ngraham, abetts, VDG.
Tue, Dec 10, 4:53 PM · Frameworks
leinir requested review of D25855: Don't show the info icon on the big preview delegate.
Tue, Dec 10, 4:49 PM · Frameworks
ndavis added a comment to D25820: SimpleScreenRecorder icon added.

Good start! The lens flare looks upside down

That was intentionally to make it distinguishable from digiKam.

Tue, Dec 10, 4:49 PM · Breeze, Frameworks
ahiemstra closed D25311: Add KColumnHeadersProxyModel.
Tue, Dec 10, 3:13 PM · Frameworks
ngraham requested changes to D25849: Ensure the dialog title is correct with an uninitialised engine.
Tue, Dec 10, 3:04 PM · Frameworks
ahmadsamir added a comment to D23457: Port regex search to QRegularExpression.

Personally, I am not convinced replacing \s with [ \t], and deviating from PCRE default behaviour is a good idea in this case.

Tue, Dec 10, 2:56 PM · Frameworks, Kate
leinir added reviewers for D25849: Ensure the dialog title is correct with an uninitialised engine: Frameworks, KNewStuff, ngraham.
Tue, Dec 10, 2:50 PM · Frameworks
leinir requested review of D25849: Ensure the dialog title is correct with an uninitialised engine.
Tue, Dec 10, 2:50 PM · Frameworks
dhaumann added a comment to D23457: Port regex search to QRegularExpression.

Was anything of the previously commented issues addressed?

Tue, Dec 10, 1:43 PM · Frameworks, Kate
leinir closed D25824: Support archive installs with adoption commands.
Tue, Dec 10, 1:28 PM · Frameworks
apol accepted D25824: Support archive installs with adoption commands.
Tue, Dec 10, 12:52 PM · Frameworks
ahmadsamir updated the diff for D23457: Port regex search to QRegularExpression.

clang-fromat the code in this diff

Tue, Dec 10, 12:08 PM · Frameworks, Kate
leinir updated the diff for D25824: Support archive installs with adoption commands.
  • Ensure rootPath is definitely clean and has a / at the end
Tue, Dec 10, 11:21 AM · Frameworks
leinir added inline comments to D25824: Support archive installs with adoption commands.
Tue, Dec 10, 11:20 AM · Frameworks
davidedmundson closed D25833: Expose getter to KConfigWatcher's config.
Tue, Dec 10, 11:15 AM · Frameworks
broulik accepted D25833: Expose getter to KConfigWatcher's config.
Tue, Dec 10, 10:58 AM · Frameworks
apol accepted D25829: kconfig EBN transport protocol cleanup.
Tue, Dec 10, 9:52 AM · Frameworks
apol accepted D25827: kcodecs EBN transport protocol cleanup.
Tue, Dec 10, 9:52 AM · Frameworks
davidedmundson added a dependent revision for D25833: Expose getter to KConfigWatcher's config: D25834: [effects/startupfeedback] Port to KConfigWatcher.
Tue, Dec 10, 9:39 AM · Frameworks
davidedmundson requested review of D25833: Expose getter to KConfigWatcher's config.
Tue, Dec 10, 9:26 AM · Frameworks
ngraham closed D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts".
Tue, Dec 10, 9:06 AM · Frameworks
davidedmundson closed D25791: Fix writeFlags with KConfigCompilerSignallingItem.
Tue, Dec 10, 8:41 AM · Frameworks
ervin accepted D25791: Fix writeFlags with KConfigCompilerSignallingItem.

Indeed not pretty and error prone but as you say: should be fine in autogenerated code

Tue, Dec 10, 8:31 AM · Frameworks