Feed Advanced Search

Today

aacid added a comment to D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache.

@jtamate Does that "let's continue in that other review" mean we should cancel this one? Still shows on the list of reviews to consider

Sun, Jul 21, 5:22 PM · Frameworks
ngraham added a comment to D22609: Add spacers as a customization option for toolbars.

Also, I would recommend doing most of the comment changes in a separate patch. They are good and useful, but not related to adding this awesome new spacer item.

Sun, Jul 21, 4:19 PM · Frameworks
ngraham added a comment to D22609: Add spacers as a customization option for toolbars.

How about naming it "Flexible space" or "Expanding spacer" to make it a bit clearer?

Sun, Jul 21, 4:17 PM · Frameworks
ngraham updated subscribers of D22609: Add spacers as a customization option for toolbars.
Sun, Jul 21, 4:16 PM · Frameworks
davidedmundson closed D22611: Remove deprecated tests.
Sun, Jul 21, 2:11 PM · Frameworks
broulik accepted D22611: Remove deprecated tests.
Sun, Jul 21, 2:11 PM · Frameworks
davidedmundson requested review of D22611: Remove deprecated tests.
Sun, Jul 21, 2:06 PM · Frameworks
felixernst updated the summary of D22609: Add spacers as a customization option for toolbars.
Sun, Jul 21, 12:50 PM · Frameworks
felixernst updated the diff for D22609: Add spacers as a customization option for toolbars.

Use insertWidget(before, spacer) instead of addWidget(spacer)

Sun, Jul 21, 12:44 PM · Frameworks
brute4s99 updated the diff for D22105: WIP : Fix SFTP Plugin of KIO for Windows.

updated

Sun, Jul 21, 12:32 PM · Frameworks, Dolphin
felixernst planned changes to D22609: Add spacers as a customization option for toolbars.
Sun, Jul 21, 12:31 PM · Frameworks
apol added a comment to D22599: Make first and last name available separately.
In D22599#499008, @pino wrote:

How would first + last name work, when
a) you have multiple first names
b) you have multiple last names
c) you have only one "name" -- http://wookware.org/name.html

Sun, Jul 21, 12:11 PM · Frameworks
felixernst updated the test plan for D22609: Add spacers as a customization option for toolbars.
Sun, Jul 21, 11:56 AM · Frameworks
felixernst updated the summary of D22609: Add spacers as a customization option for toolbars.
Sun, Jul 21, 11:55 AM · Frameworks
felixernst updated the test plan for D22609: Add spacers as a customization option for toolbars.
Sun, Jul 21, 11:53 AM · Frameworks
felixernst requested review of D22609: Add spacers as a customization option for toolbars.
Sun, Jul 21, 11:49 AM · Frameworks
dfaure requested changes to D22105: WIP : Fix SFTP Plugin of KIO for Windows.
Sun, Jul 21, 10:53 AM · Frameworks, Dolphin
jbbgameich added a comment to D22599: Make first and last name available separately.

In case a, all first names would probably be in a string separated by spaces, same for multiple last names.
In case c, I guess only the last name would be set maybe.

Sun, Jul 21, 10:52 AM · Frameworks
sitter requested changes to D21795: [KAuth] Add support for action details in Polkit1 backend..

The way details are enumerated needs changing IMO. And this effectively bumps the required polkitqt version through exactly one call, so maybe an #if conditional to not have the forced bump might be good

Sun, Jul 21, 10:42 AM · Frameworks
brute4s99 added inline comments to D22105: WIP : Fix SFTP Plugin of KIO for Windows.
Sun, Jul 21, 10:10 AM · Frameworks, Dolphin
pino added a comment to D22606: add missing semicolon.

Patch landed, and build successfully everywhere.
Congratulations for your first patch :)

Sun, Jul 21, 9:47 AM · Baloo, Frameworks
pino closed D22606: add missing semicolon.
Sun, Jul 21, 9:40 AM · Baloo, Frameworks
antonioh added a comment to D22606: add missing semicolon.

No, I don't have permissions to push that I know of, here are my details: Antonio Huete Jimenez <tuxillo@quantumachine.net>

Sun, Jul 21, 9:34 AM · Baloo, Frameworks
dfaure added a comment to D14631: Adds a new RenameDialog to KIO with more options for batch renaming.

KIO::move (implemented by CopyJob) can move N files to a single destination directory, but they get the same name at that dest.
KIO::moveAs (implemented by CopyJob too) can move/rename a single file to a specific filename at destination.

Sun, Jul 21, 9:33 AM · Frameworks
pino accepted D22606: add missing semicolon.

Do you have permissions to push patches on your own? If not, please specify your email so I can properly attribute this patch to you.

Sun, Jul 21, 9:33 AM · Baloo, Frameworks
antonioh requested review of D22606: add missing semicolon.
Sun, Jul 21, 9:30 AM · Baloo, Frameworks
cgiboudeaux added a comment to D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.

Thinking again: KDE_INSTALL_USE_QT_SYS_PATHS has no effect on XDG_CONFIG_DIRS and XDG_DATA_DIRS. Running prefix.sh is useful even if KDE_INSTALL_USE_QT_SYS_PATHS is true.

Sun, Jul 21, 9:28 AM · Build System, Frameworks
pino added a comment to D22599: Make first and last name available separately.

How would first + last name work, when
a) you have multiple first names
b) you have multiple last names
c) you have only one "name" -- http://wookware.org/name.html

Sun, Jul 21, 9:17 AM · Frameworks
emateli added a comment to D14631: Adds a new RenameDialog to KIO with more options for batch renaming.

Before continuing work I'd like to hear some opinions on this.

Sun, Jul 21, 9:13 AM · Frameworks
cgiboudeaux accepted D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.
Sun, Jul 21, 9:12 AM · Build System, Frameworks
apol accepted D22599: Make first and last name available separately.
Sun, Jul 21, 9:07 AM · Frameworks
apol added a comment to D22586: KRun QML proxy: fix path/URL confusion.

You'd think I would remember my own APIs.... :-)

Sun, Jul 21, 9:05 AM · Frameworks
apol updated the diff for D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.

Support older cmakes

Sun, Jul 21, 9:04 AM · Build System, Frameworks
aacid requested changes to D19903: Fix build with msvc.

yep, having it build with gcc is important :)

Sun, Jul 21, 8:52 AM · Frameworks
pino added inline comments to D22105: WIP : Fix SFTP Plugin of KIO for Windows.
Sun, Jul 21, 8:43 AM · Frameworks, Dolphin
aacid closed D22419: Fix can't enter directory error on some FTP servers with Turkish locale.
Sun, Jul 21, 8:36 AM · Frameworks
vonreth added a comment to D22105: WIP : Fix SFTP Plugin of KIO for Windows.

Please revert the changes to qCDebug

Sun, Jul 21, 8:34 AM · Frameworks, Dolphin
jgrulich added a comment to D18114: FakeInput: add support for pointer move with absolute coordinates.

@jgrulich With D22571 looking promising do you want to put the keyboard parts of this diff into a separate one? There is still the question about keysyms and key events but we should discuss this in the new diff. Maybe we can have both: Keysyms for special keys / combinations like Alt+Tab and text input via text-input protocol?

Sun, Jul 21, 8:08 AM · Frameworks
jbbgameich added reviewers for D22599: Make first and last name available separately: Plasma: Mobile, apol.
Sun, Jul 21, 12:29 AM · Frameworks
jbbgameich requested review of D22599: Make first and last name available separately.
Sun, Jul 21, 12:26 AM · Frameworks

Yesterday

brute4s99 updated the diff for D22105: WIP : Fix SFTP Plugin of KIO for Windows.

udpated

Sat, Jul 20, 11:41 PM · Frameworks, Dolphin
sitter closed D22551: expose new KBusyIndicatorWidget.
Sat, Jul 20, 10:32 PM · Frameworks
kossebau closed D22581: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON).
Sat, Jul 20, 9:45 PM · Frameworks
kossebau closed D22582: Remove designer plugin generation for KF5WebKit.
Sat, Jul 20, 9:44 PM · Frameworks
nibags closed D22567: TypeScript: fix keywords in conditional expressions.
Sat, Jul 20, 8:15 PM · Frameworks, Kate
nibags closed D22568: Fix generator and test paths of CMake.
Sat, Jul 20, 8:14 PM · Frameworks, Kate
cullmann accepted D22567: TypeScript: fix keywords in conditional expressions.

Looks reasonable, thanks!

Sat, Jul 20, 7:31 PM · Frameworks, Kate
cullmann accepted D22568: Fix generator and test paths of CMake.

Yep, accident ;=)

Sat, Jul 20, 7:29 PM · Frameworks, Kate
nxiss7 added a comment to D22419: Fix can't enter directory error on some FTP servers with Turkish locale.

nxisss can we have your real name and email for commit this to the codebase?

Sat, Jul 20, 6:52 PM · Frameworks
aacid added a comment to D22419: Fix can't enter directory error on some FTP servers with Turkish locale.

nxisss can we have your real name and email for commit this to the codebase?

Sat, Jul 20, 6:37 PM · Frameworks
dfaure updated the diff for D22586: KRun QML proxy: fix path/URL confusion.

You'd think I would remember my own APIs.... :-)

Sat, Jul 20, 5:57 PM · Frameworks
apol added a comment to D22586: KRun QML proxy: fix path/URL confusion.

LGTM other than that.

Sat, Jul 20, 5:52 PM · Frameworks
dfaure accepted D22419: Fix can't enter directory error on some FTP servers with Turkish locale.
Sat, Jul 20, 5:17 PM · Frameworks
nxiss7 updated the diff for D22419: Fix can't enter directory error on some FTP servers with Turkish locale.
Sat, Jul 20, 5:14 PM · Frameworks
marten abandoned D7820: man ioslave: spurious numbers included in clang(1) man page.
Sat, Jul 20, 4:09 PM · Frameworks, Dolphin, Plasma
romangg added a comment to D18114: FakeInput: add support for pointer move with absolute coordinates.

@jgrulich With D22571 looking promising do you want to put the keyboard parts of this diff into a separate one? There is still the question about keysyms and key events but we should discuss this in the new diff. Maybe we can have both: Keysyms for special keys / combinations like Alt+Tab and text input via text-input protocol?

Sat, Jul 20, 3:50 PM · Frameworks
dfaure accepted D22419: Fix can't enter directory error on some FTP servers with Turkish locale.

So it's a bug in the android FTP server? Nice ;-)

Sat, Jul 20, 3:35 PM · Frameworks
cgiboudeaux added inline comments to D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.
Sat, Jul 20, 3:26 PM · Build System, Frameworks
dfaure requested review of D22586: KRun QML proxy: fix path/URL confusion.
Sat, Jul 20, 2:41 PM · Frameworks
apol accepted D22581: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON).
Sat, Jul 20, 2:21 PM · Frameworks
apol accepted D22582: Remove designer plugin generation for KF5WebKit.
Sat, Jul 20, 2:19 PM · Frameworks
kossebau updated the test plan for D22581: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON).
Sat, Jul 20, 2:01 PM · Frameworks
kossebau updated the diff for D22581: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON).

Comparing with kdelibs4support, there the designer plugin is always build,
so defaulting BUILD_DESIGNERPLUGIN=ON feels more consistent

Sat, Jul 20, 2:00 PM · Frameworks
nxiss7 retitled D22419: Fix can't enter directory error on some FTP servers with Turkish locale from Fix can't enter directory error on Android FTP servers with Turkish locale to Fix can't enter directory error on some FTP servers with Turkish locale.
Sat, Jul 20, 1:52 PM · Frameworks
kossebau requested review of D22582: Remove designer plugin generation for KF5WebKit.
Sat, Jul 20, 1:48 PM · Frameworks
kossebau requested review of D22581: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON).
Sat, Jul 20, 1:48 PM · Frameworks
hpereiradacosta added a comment to D22083: introduce concept of header and footer for kpageview.

Hi Marco,
Patch works like a charm in standard config dialogs.
As a somewhat off topic remark though, it does not work in kcmultidialog (in framework kcmutils), even though it derives from kpageddialog.
This shows up for instance in the "window manager settings" you can get from the decoration menu (Alt+F3), or simply when running oxygen-setting or breeze-settings.
Looking into kcmultidialog, it seems there is some internal handling of margins in there, for a reason unknown to me. Maybe you want to investigate there too (in a different patch)

Sat, Jul 20, 1:36 PM · Frameworks
ngraham closed D22574: Re-map default "Switch input mode" shortcut to not confict with konsolepart.
Sat, Jul 20, 1:35 PM · Frameworks, Kate
nxiss7 retitled D22419: Fix can't enter directory error on some FTP servers with Turkish locale from Fix cant enter directory error on Android FTP servers to Fix can't enter directory error on Android FTP servers with Turkish locale.
Sat, Jul 20, 1:07 PM · Frameworks
albertvaka accepted D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.
Sat, Jul 20, 12:53 PM · Build System, Frameworks
apol updated the diff for D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.

Improve wording

Sat, Jul 20, 12:49 PM · Build System, Frameworks
albertvaka added inline comments to D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.
Sat, Jul 20, 12:47 PM · Build System, Frameworks
apol requested review of D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.
Sat, Jul 20, 12:14 PM · Build System, Frameworks
dfaure requested changes to D22105: WIP : Fix SFTP Plugin of KIO for Windows.
Sat, Jul 20, 11:24 AM · Frameworks, Dolphin
dfaure added inline comments to D17595: Upstream Dolphin's file rename dialog.
Sat, Jul 20, 10:07 AM · Frameworks
apol accepted D22577: Remove unused pnm.desktop file.
Sat, Jul 20, 9:58 AM · Frameworks
rempt requested review of D22577: Remove unused pnm.desktop file.
Sat, Jul 20, 9:34 AM · Frameworks
apol accepted D22551: expose new KBusyIndicatorWidget.
Sat, Jul 20, 9:06 AM · Frameworks
astippich closed D17500: Get mobipocket extractor up-to-date, but keep disabled.
Sat, Jul 20, 8:08 AM · Baloo, Frameworks
lbeltrame closed D21002: Remove kde4 migration agent completely.
Sat, Jul 20, 7:30 AM · Frameworks
lbeltrame added a comment to D21002: Remove kde4 migration agent completely.

Should be fixed with ff6b077d9200856dc6e393a04c6b3ae82d9792ed.

Sat, Jul 20, 7:27 AM · Frameworks
lbeltrame reopened D21002: Remove kde4 migration agent completely.

This breaks GPG wallets completely. They are no longer accounted for by kwalletd: reverting this change makes them work again.

Sat, Jul 20, 6:59 AM · Frameworks
cullmann accepted D22574: Re-map default "Switch input mode" shortcut to not confict with konsolepart.

Very reasonable! Thanks.

Sat, Jul 20, 6:58 AM · Frameworks, Kate
ngraham added reviewers for D22574: Re-map default "Switch input mode" shortcut to not confict with konsolepart: Kate, KTextEditor.
Sat, Jul 20, 1:55 AM · Frameworks, Kate
ngraham requested review of D22574: Re-map default "Switch input mode" shortcut to not confict with konsolepart.
Sat, Jul 20, 1:54 AM · Frameworks, Kate

Fri, Jul 19

apol requested review of D22570: Expose X-KDE-Wayland-Interfaces.
Fri, Jul 19, 8:56 PM · Frameworks
broulik requested review of D22569: [Dialog] Apply window type after changing flags.
Fri, Jul 19, 8:44 PM · Frameworks
ngraham added a comment to D17816: Support for xattrs on kio copy/move.

@cochise are you planning to resume work on this? If not, we may have to find someone else to finish it up, because I'd really like to get it in.

Fri, Jul 19, 7:44 PM · Frameworks
ngraham added a comment to D14631: Adds a new RenameDialog to KIO with more options for batch renaming.

Ping. :)

Fri, Jul 19, 7:43 PM · Frameworks
nibags requested review of D22568: Fix generator and test paths of CMake.
Fri, Jul 19, 7:41 PM · Frameworks, Kate
nibags requested review of D22567: TypeScript: fix keywords in conditional expressions.
Fri, Jul 19, 7:37 PM · Frameworks, Kate
nicolasfella added inline comments to D22554: Finer No-Dbus on Windows.
Fri, Jul 19, 5:42 PM · Frameworks
brute4s99 updated the diff for D22554: Finer No-Dbus on Windows.

updated

Fri, Jul 19, 5:35 PM · Frameworks
ngraham accepted D22557: [IndexCleaner] ignore non-existent entries inside config.

Ah, right, of course. Makes sense.

Fri, Jul 19, 5:33 PM · Baloo, Frameworks
nxiss7 updated the diff for D22419: Fix can't enter directory error on some FTP servers with Turkish locale.

Fixed comment.

Fri, Jul 19, 5:16 PM · Frameworks
brute4s99 added a comment to D22554: Finer No-Dbus on Windows.

Now HAVE_DBUSMENUQT won't be set. Previously it was set to 0 in this case

Fri, Jul 19, 5:11 PM · Frameworks
bruns added a comment to D22557: [IndexCleaner] ignore non-existent entries inside config.

Shouldn't we make sure that entries get removed from the config file properly?

Fri, Jul 19, 3:27 PM · Baloo, Frameworks
ngraham added a comment to D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart.

@bruns, is this good to go now?

Fri, Jul 19, 2:54 PM · Frameworks
apol closed D22546: Add missing components in org.kde.plasma.components 3.0.
Fri, Jul 19, 2:17 PM · Frameworks
mart accepted D22546: Add missing components in org.kde.plasma.components 3.0.
Fri, Jul 19, 2:15 PM · Frameworks