Add unshadowed opaque variants for Breeze Light and Dark desktop themes
AbandonedPublic

Authored by achauvel on Feb 28 2018, 1:23 AM.

Details

Reviewers
None
Summary

It seems to be quite popular since it got more than 1000 downloads on kde.store.org in a week, and each consists on a metadata.desktop file and a few symlinks.

See here for technical details: https://framagit.org/ariasuni/breeze-flat

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Lint Skipped
Unit
Unit Tests Skipped
achauvel created this revision.Feb 28 2018, 1:23 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 28 2018, 1:23 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
achauvel requested review of this revision.Feb 28 2018, 1:23 AM

FWIW, Breeze shadows can now be turned off entirely (System SettingsApplication StyleWindow DecorationsBreezeClick on the little Settings button in the cornerShadowsSize: None), so the only thing this really adds is opaque backgrounds. Not sure it's worth it IMHO. Maybe instead we should let people turn it off in Breeze without modifications.

FWIW, Breeze shadows can now be turned off entirely (System SettingsApplication StyleWindow DecorationsBreezeClick on the little Settings button in the cornerShadowsSize: None), so the only thing this really adds is opaque backgrounds.

You’re mistaken: this disable shadows only for window decorations. My themes disable shadows for panel (and widgets), Krunner and Kwin’s task switcher.

Not sure it's worth it IMHO. Maybe instead we should let people turn it off in Breeze without modifications.

Sure, you can add an option to use fallback resources; my solution is dead simple but a generic solution is better. I just don’t happen to have the time or knowledge to do it.

Also note that I use kquitapp5 plasmashell && plasmashell after applying my theme in order to make shadows disapear for Plasma; it works instantly for KWin.

Should I open a bug report on https://bugs.kde.org?

What bug would you be reporting?

To add an option to use the fallback of a Plasma theme (i.e. to disable shadows and transparency).

Yeah, if you abandon this patch, requesting that the feature be natively added would probably be sane.

I opened a bug but I didn’t have any answer so far.

Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. · View Herald TranscriptMay 5 2019, 10:52 AM
achauvel abandoned this revision.Sep 1 2023, 8:58 PM