FrameworksRelease
ActivePublic

Recent Activity

Today

ndavis updated the test plan for D24625: Fill middle mouse button area.
Mon, Oct 14, 8:18 AM · Frameworks
ndavis requested review of D24625: Fill middle mouse button area.
Mon, Oct 14, 8:15 AM · Frameworks
dfaure accepted D24560: remove legacy space handling code.

If you say so :-)

Mon, Oct 14, 7:47 AM · Frameworks
vkrause added a comment to D24590: Port KSslErrorUiData to QSslError.

Do we have tests for the thing you discovered breaks? Do we need them?

Mon, Oct 14, 7:34 AM · Frameworks
dfaure accepted D24588: [SslUi] Add api docs for askIgnoreSslErrors().
Mon, Oct 14, 7:31 AM · Frameworks
ndavis accepted D24612: Use the text rather than highlight color for rating/star emblem.

This icon never needed to be blue. I think I just kept it blue because that's what it was originally.

Mon, Oct 14, 6:35 AM · Frameworks
ndavis added a comment to D24621: [RFC] New Konsole and Yakuake icons.

The Yakuake icon is a major improvement. The little angled rectangle making the prompt arrow look like a Y is a little distracting, but also kind of charming and helps to distinguish it from Konsole. I kind of still prefer the plainer ">_" version though.

Mon, Oct 14, 5:16 AM · Frameworks
ndavis added a comment to D24537: Icons for windy weather.

I think cyan is an appropriate choice considering that people tend to associate air with shades of blue, even if air is transparent and that's just the colour of the sky. The shade could be changed if necessary, but I personally think it looks fine.

Mon, Oct 14, 3:47 AM · Frameworks
cblack updated the diff for D24537: Icons for windy weather.

Shift wind emblem to the right, clean scratch work, and rename night icons

Mon, Oct 14, 1:49 AM · Frameworks
cblack added a comment to D24537: Icons for windy weather.

That cyan looks odd. It sticks out way too much and AFAIK, it isn't commonly used to represent wind. Gray on more gray is going to be tricky as well though, especially when you've got partly cloudy vs cloudy. What if the wind was a bit more monochromatic? Wind is invisible, so it only really has shapes that are associated with how it moves around objects to represent it. Perhaps we can use darker colors for lighter backgrounds and lighter colors for darker backgrounds then? Here's an idea for an alternate shape type, but you don't have to use it:

Mon, Oct 14, 1:47 AM · Frameworks
Luwx added a comment to D24593: Modified breeze shadows.

Making good looking pure svg box shadows is a bit tricky.

Mon, Oct 14, 1:39 AM · Frameworks

Yesterday

cblack added a comment to D24621: [RFC] New Konsole and Yakuake icons.

They look nice, but I'm not sure how well they fit in with other Breeze icons.
Comparison montages:


Sun, Oct 13, 11:19 PM · Frameworks
mglb requested review of D24621: [RFC] New Konsole and Yakuake icons.
Sun, Oct 13, 10:10 PM · Frameworks
cullmann added a reviewer for D24568: Provide clang-format target with a KDE Frameworks style file: dfaure.

Perhaps David could give feedback if the file actually captures the intend to do proper KDE Frameworks/libs like formatting.
I had a mistake with the indented case statements, that should be fixed.

Sun, Oct 13, 8:25 PM · Build System, Frameworks
cullmann updated the diff for D24620: Windows MSVC compile fix.

Missed to add file with proper compiler guard :/

Sun, Oct 13, 8:17 PM · Frameworks
cullmann requested review of D24620: Windows MSVC compile fix.
Sun, Oct 13, 8:16 PM · Frameworks
trickyricky26 requested changes to D24598: Update elisa icon.

Please optimize the SVG files using one of these methods: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization

Sun, Oct 13, 7:28 PM · Elisa, Frameworks
mwolff added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.
In D24568#545736, @apol wrote:

I'm not sure how this works, but would it be possible to have a target that only works on a patch? You usually want to make sure what you modified didn't diverge from the code.

I think there is some hack around that:
http://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting

But actually, if your sources are already clang-formatted, you just need to run the clang-format target once before you commit, the your new code will be the only thing altered.

Sun, Oct 13, 7:24 PM · Build System, Frameworks
Diffusion closed D24555: Add draw-arrow icons.
Sun, Oct 13, 7:16 PM · Frameworks
kossebau updated the task description for T11490: Control for visibility of symbols of deprecated API and compiler warnings.
Sun, Oct 13, 5:38 PM · KF6, Frameworks
kossebau requested review of D24617: Use ECMGenerateExportHeader to manage deprecated API better.
Sun, Oct 13, 5:34 PM · Baloo, Frameworks
mlaurent accepted D24608: Use ECMGenerateExportHeader to manage deprecated API better.

Seems ok for me

Sun, Oct 13, 5:23 PM · Frameworks
filipf added a comment to D24593: Modified breeze shadows.

b) radial gradients instead of linear on the four sides to make the center darker than the angles.

Sun, Oct 13, 5:03 PM · Frameworks
niccolove added a comment to D24593: Modified breeze shadows.

I'm sorry, when I use scour on svg files, it looks like git does not recognize that the file has changed. How can I fix that?

That means that the files actually haven't changed compared to the prior version. It looks like the diff is messed up and is using the scoured version as the base rather than the latest git master.

Sun, Oct 13, 4:34 PM · Frameworks
niccolove updated the test plan for D24593: Modified breeze shadows.
Sun, Oct 13, 4:31 PM · Frameworks
niccolove updated the diff for D24593: Modified breeze shadows.

Re-done the widgets/panel-background.svg

Sun, Oct 13, 4:27 PM · Frameworks
niccolove updated the diff for D24593: Modified breeze shadows.

Re-done the dialogs/background.svg

Sun, Oct 13, 4:21 PM · Frameworks
ngraham added a dependent revision for D24612: Use the text rather than highlight color for rating/star emblem: D24613: Use a lighter star color for non-default devices.
Sun, Oct 13, 4:20 PM · Frameworks
ngraham requested review of D24612: Use the text rather than highlight color for rating/star emblem.
Sun, Oct 13, 4:10 PM · Frameworks
aacid accepted D24590: Port KSslErrorUiData to QSslError.

Do we have tests for the thing you discovered breaks? Do we need them?

Sun, Oct 13, 3:32 PM · Frameworks
kossebau requested review of D24611: Use ECMGenerateExportHeader to manage deprecated API better.
Sun, Oct 13, 3:26 PM · Baloo, Frameworks
ngraham updated the task description for T8552: Polish Open/Save dialogs.
Sun, Oct 13, 3:23 PM · Frameworks, VDG
kossebau requested review of D24610: Use ECMGenerateExportHeader to manage deprecated API better.
Sun, Oct 13, 3:06 PM · Frameworks
kossebau updated the task description for T11490: Control for visibility of symbols of deprecated API and compiler warnings.
Sun, Oct 13, 1:58 PM · KF6, Frameworks
kossebau requested review of D24608: Use ECMGenerateExportHeader to manage deprecated API better.
Sun, Oct 13, 1:52 PM · Frameworks
ngraham accepted D24598: Update elisa icon.

Lovely!

Sun, Oct 13, 1:39 PM · Elisa, Frameworks
kossebau added a parent task for T11289: Deprecating KDesignerPlugin in favour of new ECMAddQtDesignerPlugin: T11590: Remove kdesignerplugin.
Sun, Oct 13, 1:24 PM · Frameworks
ochurlaud added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.

There is also https://techbase.kde.org/Policies/Frameworks_Coding_Style which though missed the move from techbase to community, other than the other policies.

I suspect that page should be moved over now as well, to become the real KF coding style page (so that "kdelibs" named one is no longer needed).

@nalvarez @ochurlaud Do you remember why this page was not moved?

Sun, Oct 13, 12:39 PM · Build System, Frameworks
astippich closed T8196: KFileMetadata: String lists. How do clients cope? as Resolved.

Baloo now only outputs multiple entries in the property map instead of stringlist as of D19088 and clients all handle this since Applications 19.08

Sun, Oct 13, 11:41 AM · Dolphin, Elisa, Frameworks, Baloo
kossebau closed D24595: Use ECMGenerateExportHeader to manage deprecated API better.
Sun, Oct 13, 11:41 AM · Frameworks
astippich added a comment to D24598: Update elisa icon.

Sun, Oct 13, 11:38 AM · Elisa, Frameworks
astippich updated the diff for D24598: Update elisa icon.
  • update
Sun, Oct 13, 11:37 AM · Elisa, Frameworks
cullmann retitled D24568: Provide clang-format target with a KDE Frameworks style file from Provide clang-format target with a common KDE style file to Provide clang-format target with a KDE Frameworks style file.
Sun, Oct 13, 11:34 AM · Build System, Frameworks
ahmadsamir updated the diff for D24588: [SslUi] Add api docs for askIgnoreSslErrors().

Since I wrote the docs bit anyway

Sun, Oct 13, 11:24 AM · Frameworks
ahmadsamir removed a task from D24588: [SslUi] Add api docs for askIgnoreSslErrors(): T11577: Port Konversation away from KTcpSocket.
Sun, Oct 13, 11:18 AM · Frameworks
ahmadsamir added a comment to D24588: [SslUi] Add api docs for askIgnoreSslErrors().

Hmm, why not just do KSslErrorUiData uiData(socket); in the caller, or even just askIgnoreSslErrors(KSslErrorUiData(socket), storedRules).
Don't know, just wondering (not objecting). @vkrause, any opinion?

That would be my gut feeling as well, ie. have sslui depend on the abstract error representation, not on all possible error sources. OTOH it's not changing the dependency situation overall here so no strong objection to that either. In any case the KTcpSocket variant should be deprecated eventually.

Sun, Oct 13, 11:07 AM · Frameworks
vkrause added a comment to D24588: [SslUi] Add api docs for askIgnoreSslErrors().

Hmm, why not just do KSslErrorUiData uiData(socket); in the caller, or even just askIgnoreSslErrors(KSslErrorUiData(socket), storedRules).
Don't know, just wondering (not objecting). @vkrause, any opinion?

Sun, Oct 13, 9:09 AM · Frameworks
vkrause updated the diff for D24590: Port KSslErrorUiData to QSslError.

Deal with errors with full QSslError level of detail until kssld is ported, make variables const.

Sun, Oct 13, 9:06 AM · Frameworks
vkrause planned changes to D24590: Port KSslErrorUiData to QSslError.

This actually breaks things when the error comes from a Qt source rather than a KIO one, as we now carry the QSslError level of detail forward far enough and compare it to the stored KSslError. This is a temporary problem until the kssld side is ported too, but it nevertheless needs a workaround until that is done.

Sun, Oct 13, 8:57 AM · Frameworks
mlaurent accepted D24595: Use ECMGenerateExportHeader to manage deprecated API better.
Sun, Oct 13, 7:54 AM · Frameworks