The use of tildes for doxygen code blocks is documented here: https://www.stack.nl/~dimitri/doxygen/manual/markdown.html#md_fenced
Abandoning this change in that case.
Could you also extend the unit test in autotest/input/highlight.d?
I guess it's ok to have this in. But please use this version at your daily work ;) I think we don't have many testers...
Looks good, please commit. With these kind of changes, we soon support up to 2^64 lines in a document? ;)
You can't really do that in threads, you need to access the buffer, otherwise you can redo all things again in extra logic (like using the ranges for getting replacement ranges....)
I would also advise against calling processEvents() to keep UIs responsive in all cases. It's tempting, but it is near impossible to get it right. What about conflicting actions, close/resize events, dbus calls, etc etc that are handled here?
Hmpf! Some googling didn't help. Just some thoughts.
If we are doing markdown, it could make sense why such common markdown isn't working too, otherwise this is bound to happen anyway. I've actually never seen this ~~~ thing.
It's looking good. I would say change the last tone to a tad lighter. The gray has too much black in it. I would probably move the hue to the yellow side.
Oh la la, I didn't even realize phonon was optional. New code is much better.
Please keep the Repository settings. Additionally, please format the title and description according to https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch
This was last round, otherwise it's ready to go, just fix the remaining issues. Thanks.
This is another example where a subtle outline could help visibility for dark themes, without having to resort to drawing a whole new version of it.
That always leads to evil things, like e.g. what happens if you press the X button of the view/window during that.
- Check every 500 lines or 100 machtes, whatever is first
- Fix false check due to wrong math as long no match was found
Sorry, I had forgot about that.
This change causes the ipv4 address test to fail due to a difference in size of list.
Here's a rough draft of something similar to the Logitech F 710, but with colors that are more similar to the original DualShock controller and white Xbox 360 controller: