FrameworksRelease
ActivePublic

Recent Activity

Today

argonel added a comment to D17466: Fix doxygen markdown rendering.

The use of tildes for doxygen code blocks is documented here: https://www.stack.nl/~dimitri/doxygen/manual/markdown.html#md_fenced

Tue, Dec 11, 12:44 AM · Documentation, Frameworks

Yesterday

cfeck added reviewers for D17495: [KMessageBox] Fix minimum dialog size when details are requested: ngraham, elvisangelaccio.
Mon, Dec 10, 10:54 PM · Frameworks
cfeck requested review of D17495: [KMessageBox] Fix minimum dialog size when details are requested.
Mon, Dec 10, 10:41 PM · Frameworks
i.Dark_Templar abandoned D17392: Fix checkDesktopFile function.

Abandoning this change in that case.

Mon, Dec 10, 9:05 PM · Frameworks
dhaumann added a comment to D17460: fixups for `extern` and `pragma`.

Could you also extend the unit test in autotest/input/highlight.d?

Mon, Dec 10, 7:34 PM · Frameworks, Kate
cullmann added a comment to D17441: tune editing actions for large number of small edits.

I guess it's ok to have this in. But please use this version at your daily work ;) I think we don't have many testers...

I always use Kate from git master. Is there anything in particular I should keep an eye out for?

Mon, Dec 10, 7:22 PM · Frameworks, Kate
ngraham added a comment to D17441: tune editing actions for large number of small edits.

I guess it's ok to have this in. But please use this version at your daily work ;) I think we don't have many testers...

Mon, Dec 10, 6:50 PM · Frameworks, Kate
dhaumann added a comment to D17441: tune editing actions for large number of small edits.

I guess it's ok to have this in. But please use this version at your daily work ;) I think we don't have many testers...

Mon, Dec 10, 6:48 PM · Frameworks, Kate
dhaumann accepted D17457: use STL were no implicit sharing is required.

Looks good, please commit. With these kind of changes, we soon support up to 2^64 lines in a document? ;)

Mon, Dec 10, 6:38 PM · Frameworks, Kate
cullmann added a comment to D17459: SearchBar: Add Cancel button to stop long running tasks.

You can't really do that in threads, you need to access the buffer, otherwise you can redo all things again in extra logic (like using the ranges for getting replacement ranges....)

Mon, Dec 10, 6:21 PM · Frameworks, Kate
brauch added a comment to D17459: SearchBar: Add Cancel button to stop long running tasks.

I would also advise against calling processEvents() to keep UIs responsive in all cases. It's tempting, but it is near impossible to get it right. What about conflicting actions, close/resize events, dbus calls, etc etc that are handled here?

Mon, Dec 10, 6:15 PM · Frameworks, Kate
loh.tar added a comment to D17459: SearchBar: Add Cancel button to stop long running tasks.

Hmpf! Some googling didn't help. Just some thoughts.

Mon, Dec 10, 5:15 PM · Frameworks, Kate
apol requested review of D17491: Fix documentation, QValueList isn't a thing anymore.
Mon, Dec 10, 5:09 PM · Frameworks
apol added a comment to D17466: Fix doxygen markdown rendering.

If we are doing markdown, it could make sense why such common markdown isn't working too, otherwise this is bound to happen anyway. I've actually never seen this ~~~ thing.

Mon, Dec 10, 4:39 PM · Documentation, Frameworks
heikobecker closed D17479: Fix build without phonon.
Mon, Dec 10, 3:39 PM · Frameworks
abetts added a comment to D17469: applications-games icon for dark theme.

It's looking good. I would say change the last tone to a tad lighter. The gray has too much black in it. I would probably move the hue to the yellow side.

Mon, Dec 10, 3:36 PM · Frameworks
sitter accepted D17479: Fix build without phonon.

Oh la la, I didn't even realize phonon was optional. New code is much better.

Mon, Dec 10, 3:32 PM · Frameworks
pranavgade updated the summary of D17425: Added DCB settings.
Mon, Dec 10, 3:30 PM · Frameworks
cfeck added a comment to D17425: Added DCB settings.

Please keep the Repository settings. Additionally, please format the title and description according to https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch

Mon, Dec 10, 3:26 PM · Frameworks
cfeck set the repository for D17425: Added DCB settings to R282 NetworkManagerQt.
Mon, Dec 10, 3:25 PM · Frameworks
broulik added a reviewer for D17479: Fix build without phonon: sitter.
Mon, Dec 10, 3:24 PM · Frameworks
heikobecker requested review of D17479: Fix build without phonon.
Mon, Dec 10, 3:15 PM · Frameworks
pranavgade updated the diff for D17425: Added DCB settings.
Mon, Dec 10, 3:15 PM · Frameworks
ndavis added a comment to D17469: applications-games icon for dark theme.

Here's a rough draft of something similar to the Logitech F 710, but with colors that are more similar to the original gray DualShock controller:

100%

200%

Maybe it is better to remove the dark sides? Only F710 has this design. Most controllers, including PS4 and XBox One, are pure white or black or other colors.

Mon, Dec 10, 3:09 PM · Frameworks
jgrulich added a comment to D17425: Added DCB settings.

This was last round, otherwise it's ready to go, just fix the remaining issues. Thanks.

Mon, Dec 10, 3:08 PM · Frameworks
jgrulich added inline comments to D17425: Added DCB settings.
Mon, Dec 10, 3:08 PM · Frameworks
ndavis added a comment to D17469: applications-games icon for dark theme.

This is another example where a subtle outline could help visibility for dark themes, without having to resort to drawing a whole new version of it.

Mon, Dec 10, 3:02 PM · Frameworks
pranavgade updated the diff for D17425: Added DCB settings.
Mon, Dec 10, 2:57 PM · Frameworks
cfeck set the repository for D17425: Added DCB settings to R282 NetworkManagerQt.
Mon, Dec 10, 2:50 PM · Frameworks
ngraham updated subscribers of D17469: applications-games icon for dark theme.

This is another example where a subtle outline could help visibility for dark themes, without having to resort to drawing a whole new version of it.

Mon, Dec 10, 2:47 PM · Frameworks
loh.tar added a comment to D17459: SearchBar: Add Cancel button to stop long running tasks.

That always leads to evil things, like e.g. what happens if you press the X button of the view/window during that.

Mon, Dec 10, 2:43 PM · Frameworks, Kate
loh.tar updated the diff for D17459: SearchBar: Add Cancel button to stop long running tasks.
  • Check every 500 lines or 100 machtes, whatever is first
  • Fix false check due to wrong math as long no match was found
Mon, Dec 10, 2:42 PM · Frameworks, Kate
jgrulich added inline comments to D17425: Added DCB settings.
Mon, Dec 10, 2:20 PM · Frameworks
guoyunhe added a comment to D17469: applications-games icon for dark theme.

Here's a rough draft of something similar to the Logitech F 710, but with colors that are more similar to the original gray DualShock controller:

100%

200%

Mon, Dec 10, 1:39 PM · Frameworks
pranavgade added a comment to D17425: Added DCB settings.

Sorry, I had forgot about that.

Mon, Dec 10, 1:22 PM · Frameworks
pranavgade updated the diff for D17425: Added DCB settings.
Mon, Dec 10, 1:21 PM · Frameworks
jgrulich added inline comments to D17425: Added DCB settings.
Mon, Dec 10, 12:05 PM · Frameworks
jgrulich closed D17474: A minor bug in ipv4 and ipv6 test.
Mon, Dec 10, 12:03 PM · Frameworks
pranavgade added a comment to D17474: A minor bug in ipv4 and ipv6 test.

This change causes the ipv4 address test to fail due to a difference in size of list.
[F6468448]

Mon, Dec 10, 12:02 PM · Frameworks
jgrulich accepted D17474: A minor bug in ipv4 and ipv6 test.
Mon, Dec 10, 12:02 PM · Frameworks
pranavgade requested review of D17474: A minor bug in ipv4 and ipv6 test.
Mon, Dec 10, 11:59 AM · Frameworks
pranavgade updated the diff for D17425: Added DCB settings.
Mon, Dec 10, 11:56 AM · Frameworks
jgrulich added inline comments to D17425: Added DCB settings.
Mon, Dec 10, 11:41 AM · Frameworks
ndavis added a comment to D17469: applications-games icon for dark theme.

Here's a rough draft of something similar to the Logitech F 710, but with colors that are more similar to the original DualShock controller and white Xbox 360 controller:

Mon, Dec 10, 11:29 AM · Frameworks
ndavis added a comment to D17419: Add view-private icon.
Mon, Dec 10, 11:28 AM · VDG, Frameworks, Breeze
pranavgade updated the diff for D17425: Added DCB settings.
Mon, Dec 10, 11:20 AM · Frameworks
pranavgade added inline comments to D17425: Added DCB settings.
Mon, Dec 10, 10:58 AM · Frameworks
jgrulich added inline comments to D17425: Added DCB settings.
Mon, Dec 10, 10:56 AM · Frameworks
pranavgade updated the diff for D17425: Added DCB settings.
Mon, Dec 10, 10:55 AM · Frameworks
pranavgade added inline comments to D17425: Added DCB settings.
Mon, Dec 10, 10:52 AM · Frameworks