FrameworksRelease
ActivePublic

Watchers

  • This project does not have any watchers.

Recent Activity

Today

marten updated the diff for D7841: kioexec: Do not start to watch a temporary copy until after the copy is complete.

Updated in accordance with review comments. Go easy - it's the first lambda that I've submitted...

Sun, Sep 24, 2:32 PM · Frameworks
mwolff created D7968: WIP: Forward QComboBox signals instead of QComboBox lineedit signals.
Sun, Sep 24, 12:31 PM · Frameworks
mwolff created D7967: KComboBox: Return early when setting editable to previous value.
Sun, Sep 24, 11:55 AM · Frameworks
mwolff created D7966: KComboBox: Reuse the existing completion object on new line edit.
Sun, Sep 24, 11:48 AM · Frameworks
cullmann added a comment to D7884: - Increase size of trailing mark.

I would rather go with the "make the markers much larger but less contrast" solution than a setting for their size.
Perhaps we really just need to look at how other editors do that.
Eye-cancer like markers are no solution either, but I agree that if people turn them on, they should be able to spot them easily.

Sun, Sep 24, 11:42 AM · Frameworks, Kate
dfaure accepted D7841: kioexec: Do not start to watch a temporary copy until after the copy is complete.

Makes sense.

Sun, Sep 24, 11:06 AM · Frameworks
dfaure requested changes to D7750: fix crash when more than one instances of ExtractorCollection are destructed.
Sun, Sep 24, 10:53 AM · Frameworks
anthonyfieroni added inline comments to D7884: - Increase size of trailing mark.
Sun, Sep 24, 10:18 AM · Frameworks, Kate
vkrause closed D7680: Fix build without KDocTools.
Sun, Sep 24, 9:57 AM · Frameworks
helio added a comment to D7884: - Increase size of trailing mark.

Is not that simple.
Change only the color is fine, but then the effect is almost imperceptible,
Right now from home i'm using a 25' 2560x1440 resolution with fonts in size 10. Is a regular monitor, not the most expensive.
Even changing the color a single pixel is barely visible. And yes, the fonts are.
If i go to HiDPI screen this becomes totally impossible to see ( unless you have eagle eyes ). This cases using a light background or white.
If you are using darker backgrounds, like i use Breeze Dark, a pixel even on the most bright red color still mixed up. So, no good.

Sun, Sep 24, 9:12 AM · Frameworks, Kate
vkrause closed D7678: Fix compilation on Linux without X11.
Sun, Sep 24, 9:12 AM · Frameworks
vkrause accepted D7951: ContextChecker: support '!' context switchting and fallthroughContext.
Sun, Sep 24, 9:10 AM · Frameworks
dfaure accepted D6709: [RFC] Add support for sharing file descriptor between KIO slave and KAuth helper.

Yes isListening() would make sense.

Sun, Sep 24, 8:57 AM · Frameworks
vkrause accepted D7699: Add support for custom search paths for application-specific syntax and theme definitions.
Sun, Sep 24, 8:53 AM · Framework: Syntax Highlighting, Frameworks
dfaure accepted D7891: expose the colorset for the stylesheet.
Sun, Sep 24, 8:49 AM · Frameworks
dfaure added a comment to D7954: Fix repaint loop in KToolBar.

Uploaded my patch, now with unittest: https://phabricator.kde.org/D7964

Sun, Sep 24, 8:45 AM · Frameworks

Yesterday

rkflx updated the task description for T6982: KSqueezedTextLabel: Investigate resize handling to fix failing autotest.
Sat, Sep 23, 9:50 PM · Frameworks
rkflx added a comment to T6982: KSqueezedTextLabel: Investigate resize handling to fix failing autotest.

Results of the investigation:

  • qWaitForWindowExposed was wrong, it only masked the real problem locally
  • When the label is not able to resize in a given layout and setIndent or other calls further reduce the space available, we have to react by squeezing the text. Therefore, a custom setIndent is needed for real. Concerns regarding BC can probably be countered by checking with abi-compliance-checker.
  • Respecting the chrome also in minimumSizeHint is feasible and should add some polish and sensible behaviour to the default minimum widths.
  • Regarding the comparison of resize handling with QLabel, it is a design decision whether we should react to changes by resizing or squeezing. After looking through the commit history and early applications, I could imagine the original authors had the following in mind (e.g. a statusbar frame of a browser displaying the link hovered over or the file name in a status dialog of a directory copying action): The label is placed in a layout, where the actual text to display is not known yet. Therefore it makes sense to give the label as much space as possible (i.e. Expanding size policy). Now the displayed text is changed quite often over the course of the lifetime of the application. Here it is reasonable to keep the size as is to avoid flickering (i.e. squeeze by default, adjustSize needs to be called manually). In summary: No changes needed, but this could be added to the documentation.
  • Testing all different size policies, no errors could be found and all resizing was in accordance to the docs (the trick was to display a frame, to differentiate between window and label and not get confused). It is worth noting that for Fixed, Minimum and MinimumExpanding text will never be squeezed (by design as well as implementation).
Sat, Sep 23, 9:49 PM · Frameworks
dfaure accepted D7954: Fix repaint loop in KToolBar.

OK, let's get the quick fix in, but I still think my alternative patch (removing all this code and applying http://www.davidfaure.fr/2017/0001-KAcceleratorManager-set-icon-text-on-actions-to-remo.patch instead) is a better solution.
It works in my tests, although the discussion in https://git.reviewboard.kde.org/r/129663/ got a little confusing.

Sat, Sep 23, 8:21 PM · Frameworks
mardelle created D7954: Fix repaint loop in KToolBar.
Sat, Sep 23, 4:43 PM · Frameworks
ngraham closed D7948: Only match real MIME types, not e.g. "raw CD image".
Sat, Sep 23, 1:59 PM · Frameworks
ngraham updated the diff for D7948: Only match real MIME types, not e.g. "raw CD image".

Grouping the startsWith() and contains() entries

Sat, Sep 23, 1:57 PM · Frameworks
ngraham added a comment to D7948: Only match real MIME types, not e.g. "raw CD image".

Ah, excellent idea.

Sat, Sep 23, 1:56 PM · Frameworks
dfaure accepted D7948: Only match real MIME types, not e.g. "raw CD image".

Yes (although I would then swap document to be after text/, to have all the "groups" together, and then the "substring searches").
In any case feel free to push.

Sat, Sep 23, 1:55 PM · Frameworks
ngraham abandoned D7944: Pre-select navigation bar URL when clicking on it to enter edit mode.

Fair enough. Your points are stronger than mine, now that I think about it.

Sat, Sep 23, 1:51 PM · Frameworks
ngraham updated the diff for D7948: Only match real MIME types, not e.g. "raw CD image".

Use startsWith() instead of contains() for greater speed and correctness, and do this for text MIME types as well

Sat, Sep 23, 1:43 PM · Frameworks
dhaumann created D7951: ContextChecker: support '!' context switchting and fallthroughContext.
Sat, Sep 23, 1:02 PM · Frameworks
chehrlic closed D7926: Remove pf.path() from container before the reference got screwed up by it.remove().
Sat, Sep 23, 12:29 PM · Frameworks
markg added a comment to D7446: Add a Recent Documents places item to Dolphin and file pickers by default.

It seems odd to have all of these special KIO URLs that we don't actually want to use because they're rough and underdeveloped. They're rough and underdeveloped because they're hidden by default, so nobody sees them, and nobody files bugs or submits patches for them. But I do see your point.

That said, the advantage to adding this as a Places item is that it shows up in file open/save dialogs for free, which is where it's most useful. If we make this into a whole new panel, we'll have to do a bunch of otherwise unnecessary special work to get it into open/save dialogs. I don't see the advantage.

If the objection is that the content isn't useful (why does it show URLs?), then I can fix that too, but only if by doing so, folks will be amenable to adding a "Recent Documents" entry by default. It really is useful to have recent documents aggregated somewhere.

Sat, Sep 23, 12:06 PM · Frameworks, Dolphin
dhaumann closed D7915: Highlighting indexer: check existence of referenced context names.

Closed with https://commits.kde.org/syntax-highlighting/c62be1a9cbf501c7fd6ed1f6ad02ebd461ccb8c6

Sat, Sep 23, 11:47 AM · Frameworks
gregormi added a comment to D7446: Add a Recent Documents places item to Dolphin and file pickers by default.

That said, the advantage to adding this as a Places item is that it shows up in file open/save dialogs for free, which is where it's most useful.

Sat, Sep 23, 10:43 AM · Frameworks, Dolphin
elvisangelaccio added a comment to D7944: Pre-select navigation bar URL when clicking on it to enter edit mode.

You're right that this improves one workflow and impairs another, but the way I see it, the patch simply brings consistency with the behavior you get if you hit ctrl-L/Replace Location.

Sat, Sep 23, 8:29 AM · Frameworks
dfaure added a comment to D7948: Only match real MIME types, not e.g. "raw CD image".

Yes, but then startsWith() would be even more correct (and slightly faster) than contains().

Sat, Sep 23, 7:18 AM · Frameworks
ngraham added reviewers for D7948: Only match real MIME types, not e.g. "raw CD image": Frameworks, nicolasfella, dfaure, kossebau, vhanda.
Sat, Sep 23, 4:40 AM · Frameworks
ngraham created D7948: Only match real MIME types, not e.g. "raw CD image".
Sat, Sep 23, 4:38 AM · Frameworks
ngraham added a comment to D7446: Add a Recent Documents places item to Dolphin and file pickers by default.

It seems odd to have all of these special KIO URLs that we don't actually want to use because they're rough and underdeveloped. They're rough and underdeveloped because they're hidden by default, so nobody sees them, and nobody files bugs or submits patches for them. But I do see your point.

Sat, Sep 23, 2:33 AM · Frameworks, Dolphin
ngraham added a comment to D7944: Pre-select navigation bar URL when clicking on it to enter edit mode.

Opps, I've corrected the bug number.

Sat, Sep 23, 1:39 AM · Frameworks
ngraham updated the summary of D7944: Pre-select navigation bar URL when clicking on it to enter edit mode.
Sat, Sep 23, 12:49 AM · Frameworks

Fri, Sep 22

elvisangelaccio added a comment to D7944: Pre-select navigation bar URL when clicking on it to enter edit mode.

The linked bug looks wrong.

Fri, Sep 22, 9:42 PM · Frameworks
markg added a comment to D7446: Add a Recent Documents places item to Dolphin and file pickers by default.

Yeah I also find weird to see weblinks in there. Maybe if we call it "History" would be a bit better (and it would also match the History tab in Kickoff).

Fri, Sep 22, 9:33 PM · Frameworks, Dolphin
elvisangelaccio added a comment to D7446: Add a Recent Documents places item to Dolphin and file pickers by default.

Yeah I also find weird to see weblinks in there. Maybe if we call it "History" would be a bit better (and it would also match the History tab in Kickoff).

Fri, Sep 22, 9:28 PM · Frameworks, Dolphin
markg added a comment to D7446: Add a Recent Documents places item to Dolphin and file pickers by default.

I don't think this is "semi-useful". " A Recent Documents feature in the file manager and open/save dialogs is IMHO really important, especially for lesst-technical users who use features like this on other platforms expensively instead of making extensive use of folder hierarchies. "The user can add it" is a problematic response since 99.9% of users don't know this exists, and therefore don't know that this functionality is available in the first place (and if they did, they would find it challenging to add).

The file managers and open/save dialogs in macOS and GNOME both have some kind of "recent stuff" feature shown by default, and it's really nice. And ad evidenced by the but report and the fact that people have voted for it, this is a desirable feature to some of our users.

Fri, Sep 22, 9:24 PM · Frameworks, Dolphin
ngraham added reviewers for D7944: Pre-select navigation bar URL when clicking on it to enter edit mode: KDE Applications, Frameworks, broulik, dfaure.
Fri, Sep 22, 9:23 PM · Frameworks
ngraham created D7944: Pre-select navigation bar URL when clicking on it to enter edit mode.
Fri, Sep 22, 9:21 PM · Frameworks
ngraham added a comment to D7446: Add a Recent Documents places item to Dolphin and file pickers by default.

I don't think this is "semi-useful". " A Recent Documents feature in the file manager and open/save dialogs is IMHO really important, especially for lesst-technical users who use features like this on other platforms expensively instead of making extensive use of folder hierarchies. "The user can add it" is a problematic response since 99.9% of users don't know this exists, and therefore don't know that this functionality is available in the first place (and if they did, they would find it challenging to add).

Fri, Sep 22, 9:00 PM · Frameworks, Dolphin
markg added a comment to D7446: Add a Recent Documents places item to Dolphin and file pickers by default.

You could continue and add about a dozen more "semi-useful" protocol links (ftp, settings, programs, bluetooth, and much more) ;) .
I don't think that's the route for the places panel to go. Not by default that is.
If the user wants it, it can be added just like any shortcut can be added in the places thingy. By default it should stay rather clean. recentdocuments is (in my opinion) not one that should be there by default. Also, for me personally it seems rather weird as recently visited url's are also in the recent documents.... And files I've accessed on the console don't appear in it at all (understandable though).

Fri, Sep 22, 8:54 PM · Frameworks, Dolphin
croick added a comment to D7167: Ignore default mark in icon border for single selectable mark.

I think the patch makes sense, but I would prefer using a Qt function qPopulationCount to count the bits instead of doing own bitmask magic. Could you provide an updated patch?

Fri, Sep 22, 7:47 PM · Frameworks
croick updated the diff for D7167: Ignore default mark in icon border for single selectable mark.
  • use qPopulationCount to count editable marks
Fri, Sep 22, 7:44 PM · Frameworks
dhaumann added a comment to D7884: - Increase size of trailing mark.

Kate already has many options, so we try to be careful with adding even more options.

Fri, Sep 22, 7:33 PM · Frameworks, Kate
ngraham added a comment to D7446: Add a Recent Documents places item to Dolphin and file pickers by default.

Anybody object?

Fri, Sep 22, 6:18 PM · Frameworks, Dolphin