FrameworksRelease
ActivePublic

Recent Activity

Today

kossebau added a comment to D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category.

You have ommited to update the minimum ECM version in all cases AFAICS.

Fri, Feb 28, 10:36 PM · Build System, Frameworks
bruns added a comment to D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category.

@kossebau - you have pushed commits depending on this change to several repositories, sometimes without waiting for acceptance, sometimes even bypassing Phabricator review completely.

Fri, Feb 28, 10:34 PM · Build System, Frameworks
bruns added inline comments to D27269: Use ecm_qt_install_logging_categories over manual categories file.
Fri, Feb 28, 10:30 PM · Frameworks
bruns added inline comments to D27178: Use ecm_qt_install_logging_categories over manual categories file.
Fri, Feb 28, 10:30 PM · Frameworks
rrosch added a comment to D25315: KDirModel: implement showing "/" as a root node, optionally.

Keep only matters for further calls to openUrl, not the first one. It's about whether to *add* or *replace* the currently open URL.
KDirModel takes care of that.

Fri, Feb 28, 9:30 PM · Frameworks
rrosch accepted D27731: Improve KDirModel to avoid showing '+' if there are no subdirs.
Fri, Feb 28, 9:08 PM · Frameworks
dfaure planned changes to D25315: KDirModel: implement showing "/" as a root node, optionally.

Tested on patched KF5 5.64, on Fedora 30 (32bit)... root node shows up! I had to change the call in my code that was originally:

model->dirLister()->openUrl(QUrl::fromLocalFile("/"), KDirLister::Keep);

[to] model->openUrl(QUrl::fromLocalFile("/"), KDirModel::ShowRoot);
and don't really know the implications of the change at this point. (Will it "Keep"? Does it matter that I now call the model's openURL vs the dirLister's?)

Fri, Feb 28, 9:05 PM · Frameworks
dfaure added a reviewer for D27731: Improve KDirModel to avoid showing '+' if there are no subdirs: rrosch.
Fri, Feb 28, 9:02 PM · Frameworks
dfaure requested review of D27731: Improve KDirModel to avoid showing '+' if there are no subdirs.
Fri, Feb 28, 9:02 PM · Frameworks
vkrause requested review of D27730: Add API to check whether a barcode is one- or two-dimensional.
Fri, Feb 28, 8:55 PM · Frameworks
vkrause requested review of D27727: Remove empty/unused private classes on internal types.
Fri, Feb 28, 7:51 PM · Frameworks
vkrause closed D27607: Deprecate KDBusConnectionPool.
Fri, Feb 28, 5:29 PM · Frameworks
cullmann accepted D27430: [PATCH] General update for CartoCSS syntax highlighting.

Ok, let's land that.

Fri, Feb 28, 5:07 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann accepted D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks.

I think this should go in now. I think the usage of the API is correct even for HiDPI.
In KF6, we should just fold that interface into the main class.

Fri, Feb 28, 5:01 PM · Frameworks, Kate
cullmann closed D27486: Add FreeCAD FCMacro extension to the python highlighting definition.
Fri, Feb 28, 4:58 PM · Frameworks, Kate
cullmann accepted D27486: Add FreeCAD FCMacro extension to the python highlighting definition.

Ok, makes sense, will increase version myself.

Fri, Feb 28, 4:57 PM · Frameworks, Kate
cullmann closed D27580: Updates for CMake 3.17.
Fri, Feb 28, 4:56 PM · Frameworks, Kate
cullmann accepted D27580: Updates for CMake 3.17.

Thanks for the update!

Fri, Feb 28, 4:56 PM · Frameworks, Kate
cullmann closed D27714: C++: constinit keyword and std::format syntax for strings. Improvement printf format..
Fri, Feb 28, 4:54 PM · Frameworks, Kate
cullmann accepted D27714: C++: constinit keyword and std::format syntax for strings. Improvement printf format..

Nice! Thanks for the improvements ;=)

Fri, Feb 28, 4:54 PM · Frameworks, Kate
davidedmundson requested review of D27724: Syncronise setNeedsSave between KCModule and ConfigModule in both directions.
Fri, Feb 28, 4:06 PM · Frameworks
davidedmundson accepted D27607: Deprecate KDBusConnectionPool.
Fri, Feb 28, 3:49 PM · Frameworks
vkrause added a comment to D27607: Deprecate KDBusConnectionPool.

ping?

Fri, Feb 28, 3:44 PM · Frameworks
broulik accepted D27628: Buttons: allow to scale up icons.

Lovely.

  • Media controller is fine now
  • Pin on systray popup is fine
  • buttons in NM applet are fine
Fri, Feb 28, 1:39 PM · Frameworks
sitter accepted D21795: [KAuth] Add support for action details in Polkit1 backend..

Much better. Since nobody has input on the deprecations I guess they must be alright. Do have a look into using QDBusError::InvalidArgs before landing though.

Fri, Feb 28, 1:07 PM · Frameworks
rrosch added a comment to D25315: KDirModel: implement showing "/" as a root node, optionally.

Ok, I found one of the "implications". With model->dirLister()->openUrl(m_initURL, KDirLister::Keep); I can list KIO urls like remote:, font:, and applications:, but with model->openUrl(m_initURL, KDirModel::ShowRoot); I cannot, and only seems to display the the local filesystem (specifically it lists "/"). I can probably work around it, but just wanted to pass that info along. I think it would be great if the "root" could be shown for these as well.

Fri, Feb 28, 12:37 PM · Frameworks
rrosch added a comment to D25315: KDirModel: implement showing "/" as a root node, optionally.

Tested on patched KF5 5.64, on Fedora 30 (32bit)... root node shows up! I had to change the call in my code that was originally:

Fri, Feb 28, 12:22 PM · Frameworks
davidedmundson added a comment to D25743: Expose IndexerState enum to QML.

Will do on Sunday (after tagging)

Fri, Feb 28, 12:13 PM · Baloo, Frameworks
wbauer closed D27654: [kio] Fix running konsole on Wayland.
Fri, Feb 28, 10:28 AM · Frameworks
emateli added a comment to D14631: Adds a new RenameDialog to KIO with more options for batch renaming.

Well, this patch is more or less complete but it doesn't make sense to be deployed without batch operations from KIO as it would spawn a job for each file to be renamed.

Fri, Feb 28, 9:25 AM · Frameworks
hchain closed D27717: fix min/max entries with dpointer.
Fri, Feb 28, 9:21 AM · Frameworks
meven accepted D27717: fix min/max entries with dpointer.
Fri, Feb 28, 9:01 AM · Frameworks
ervin accepted D27717: fix min/max entries with dpointer.
Fri, Feb 28, 9:00 AM · Frameworks
hchain requested review of D27717: fix min/max entries with dpointer.
Fri, Feb 28, 8:57 AM · Frameworks
ngraham added a reviewer for D14631: Adds a new RenameDialog to KIO with more options for batch renaming: Dolphin.
Fri, Feb 28, 4:01 AM · Frameworks
ngraham added a reviewer for D14631: Adds a new RenameDialog to KIO with more options for batch renaming: meven.

@emateli are you going to be able to finish this? Should someone take over? It would be a shame for such great work to get stalled so close to the finish line.

Fri, Feb 28, 4:00 AM · Frameworks

Yesterday

jpoelen requested review of D27714: C++: constinit keyword and std::format syntax for strings. Improvement printf format..
Thu, Feb 27, 11:12 PM · Frameworks, Kate
nicolasfella closed D25654: Rename actions to be consistent.
Thu, Feb 27, 9:57 PM · Frameworks
nicolasfella updated the diff for D25654: Rename actions to be consistent.

rebase

Thu, Feb 27, 9:56 PM · Frameworks
dfaure accepted D27654: [kio] Fix running konsole on Wayland.

Hum. OK. Weird.

Thu, Feb 27, 9:20 PM · Frameworks
nicolasfella accepted D27528: Adapt action numbering in Android to work like in KNotifications.

Let's get this in. Can you please give me your full name and email address so I can merge this?

Thu, Feb 27, 6:53 PM · Frameworks
niccolove updated the diff for D27695: WIP: Create a new TopArea element using widgets/toparea svg.

Fixed margin

Thu, Feb 27, 5:29 PM · Frameworks
niccolove updated the diff for D27444: Added top area.

Hardcoded colors

Thu, Feb 27, 4:27 PM · Frameworks
ngraham added a dependent revision for D27695: WIP: Create a new TopArea element using widgets/toparea svg: D27697: WIP: Added top area to notification header.
Thu, Feb 27, 3:51 PM · Frameworks
ahmadsamir closed D27616: [UrlHandler] Handle opening the online docs for KCM modules.
Thu, Feb 27, 3:44 PM · Frameworks
apol accepted D27616: [UrlHandler] Handle opening the online docs for KCM modules.
Thu, Feb 27, 2:19 PM · Frameworks
niccolove updated the summary of D27695: WIP: Create a new TopArea element using widgets/toparea svg.
Thu, Feb 27, 1:45 PM · Frameworks
leinir closed D27696: Fix scrolling on the EntryDetails page.
Thu, Feb 27, 11:41 AM · Frameworks
hexchain accepted D27696: Fix scrolling on the EntryDetails page.

Looks good on khotnewstuff-dialog. Thanks!

Thu, Feb 27, 11:13 AM · Frameworks
niccolove added inline comments to D27695: WIP: Create a new TopArea element using widgets/toparea svg.
Thu, Feb 27, 11:08 AM · Frameworks