FrameworksRelease
ActivePublic

Recent Activity

Today

bruns added a comment to D21839: [TermGenerator] Use UTF-8 ByteArray for termList.

As the limit is somewhat arbitrary, maybe we can just limit the QString? I don't think this has any serious side effects.

Yep, that's what I've suggested (if I understood you correctly).
I guess, we can put the trimming part right to termList(), it will further reduce code repetition. Something like

str = str.left(maxTermSize); 
list << str.toUtf8();
Sun, Jun 16, 10:42 PM · Baloo, Frameworks
bruns requested review of D21865: [TermGenerator] Do Term truncation prior to UTF-8 conversion.
Sun, Jun 16, 10:42 PM · Baloo, Frameworks
bruns added a dependent revision for D21863: [TermGenerator] Insert an empty position between independent terms: D21864: [QueryTest] Test if independent phrases are really independent.
Sun, Jun 16, 9:08 PM · Baloo, Frameworks
bruns requested review of D21864: [QueryTest] Test if independent phrases are really independent.
Sun, Jun 16, 9:08 PM · Baloo, Frameworks
bruns added a dependent revision for D21862: [QueryTest] Restructure tests to allow easier extension: D21864: [QueryTest] Test if independent phrases are really independent.
Sun, Jun 16, 9:08 PM · Baloo, Frameworks
bruns requested review of D21863: [TermGenerator] Insert an empty position between independent terms.
Sun, Jun 16, 9:06 PM · Baloo, Frameworks
bruns requested review of D21862: [QueryTest] Restructure tests to allow easier extension.
Sun, Jun 16, 9:05 PM · Baloo, Frameworks
elvisangelaccio accepted D15739: [Places panel] Don't show Root by default.
Sun, Jun 16, 8:24 PM · Frameworks
dhaumann added a comment to D21861: Add default variables for variables interface.

Btw, if there is a better place for initialization, I'd happily move the code to some other place.

Sun, Jun 16, 8:10 PM · Frameworks, Kate
dhaumann requested review of D21861: Add default variables for variables interface.
Sun, Jun 16, 8:10 PM · Frameworks, Kate
poboiko updated the summary of D21509: [UnIndexedFileIteratorTest] Add tests.
Sun, Jun 16, 6:19 PM · Baloo, Frameworks
poboiko updated the diff for D21509: [UnIndexedFileIteratorTest] Add tests.

Rebase on master.

Sun, Jun 16, 6:17 PM · Baloo, Frameworks
bruns closed D21855: [IdUtils] Fix aliasing warning.
Sun, Jun 16, 5:50 PM · Baloo, Frameworks
ngraham accepted D21855: [IdUtils] Fix aliasing warning.
Sun, Jun 16, 5:41 PM · Baloo, Frameworks
bruns closed D21835: [PostingIterator] Move positions() method to VectorPositionInfoIterator.
Sun, Jun 16, 5:28 PM · Baloo, Frameworks
poboiko added a comment to D21839: [TermGenerator] Use UTF-8 ByteArray for termList.

As the limit is somewhat arbitrary, maybe we can just limit the QString? I don't think this has any serious side effects.

Sun, Jun 16, 5:26 PM · Baloo, Frameworks
bruns added a comment to D21839: [TermGenerator] Use UTF-8 ByteArray for termList.

Actually, there is an issue with that code right now, which I wanted to fix, but forgot.
The trimming part finalArr = finalArr.mid(0, maxTermSize); actually should be performed on QString instead of QByteArray - unicode symbols inside term can consist of two bytes, and cutting at maxTermSize bytes can actually cut half of last symbol. I end up with terms like тождественно� inside balooshow -x.
Not to mention that russian terms end up being pretty small.

Sun, Jun 16, 5:19 PM · Baloo, Frameworks
poboiko added a comment to D21839: [TermGenerator] Use UTF-8 ByteArray for termList.

Actually, there is an issue with that code right now, which I wanted to fix, but forgot.
The trimming part finalArr = finalArr.mid(0, maxTermSize); actually should be performed on QString instead of QByteArray - unicode symbols inside term can consist of two bytes, and cutting at maxTermSize bytes can actually cut half of symbols. I end up with terms like тождественно� inside balooshow -x.
Not to mention that russian terms end up being pretty small.

Sun, Jun 16, 5:13 PM · Baloo, Frameworks
bruns closed D21839: [TermGenerator] Use UTF-8 ByteArray for termList.
Sun, Jun 16, 5:13 PM · Baloo, Frameworks
bruns closed D21844: [WriteTransactionTest] Clear mixup of QString and QByteArray.
Sun, Jun 16, 5:13 PM · Baloo, Frameworks
ngraham accepted D21835: [PostingIterator] Move positions() method to VectorPositionInfoIterator.
Sun, Jun 16, 5:12 PM · Baloo, Frameworks
ngraham accepted D21839: [TermGenerator] Use UTF-8 ByteArray for termList.
Sun, Jun 16, 5:12 PM · Baloo, Frameworks
ngraham accepted D21844: [WriteTransactionTest] Clear mixup of QString and QByteArray.

Whoops!

Sun, Jun 16, 5:07 PM · Baloo, Frameworks
bruns added a reviewer for D21855: [IdUtils] Fix aliasing warning: thiago.
Sun, Jun 16, 4:51 PM · Baloo, Frameworks
bruns requested review of D21855: [IdUtils] Fix aliasing warning.
Sun, Jun 16, 4:37 PM · Baloo, Frameworks
kossebau added a comment to D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

Any chance this could not be done by abusing KDECMakeSettings.cmake as injection vector? I know you are just following the example of what was done for appstreamcli, but IMHO this has already been a bad hack, screwing over the fine granular design of all the ECM modules trying to keep aspects separate. And yes, by the price of the overhead with more explicit module includes, but it's like that. Or we should just screw it and put everything in one big "KDEECMEverythingEvenKitchenSink.cmake" ;) And yes, one possible would like to have such a generic wrapper module in any case, for quick prototyping. But the individual modules should stay focussed.

Sun, Jun 16, 1:33 PM · Build System, Frameworks
bruns requested review of D21844: [WriteTransactionTest] Clear mixup of QString and QByteArray.
Sun, Jun 16, 1:05 PM · Baloo, Frameworks
cullmann added a comment to D17241: WIP:Disable highlighting after 512 characters on a line..
  • addConfigEntry(ConfigEntry(LineLengthLimit, "Line Length Limit", QString(), 4096));

+ addConfigEntry(ConfigEntry(LineLengthLimit, "Line Length Limit", QString(), 10000));

Sun, Jun 16, 9:12 AM · Frameworks, Kate
cullmann closed D17241: WIP:Disable highlighting after 512 characters on a line..
Sun, Jun 16, 9:11 AM · Frameworks, Kate
cullmann added a comment to D17241: WIP:Disable highlighting after 512 characters on a line..

Then let's try that. Even for all cases without hitting the limit the new code is faster.

Sun, Jun 16, 9:09 AM · Frameworks, Kate
bcooksley added a comment to D21313: Create specific directory for Qt logging categories file.

The Binary Factory uses the tooling shipped as part of the KDE SDK (which always builds everything from scratch, and I don't know if part of that includes ECM, hence why the issue doesn't show up there).

Sun, Jun 16, 8:43 AM · Build System, Frameworks
vkrause added a comment to D21313: Create specific directory for Qt logging categories file.

@apol @vkrause Perhaps something to check wit the CI or in general with the ECM Android toolchain to make sure the ECM of the host and the target are not accidentally mixed or both visible at the same time.

Sun, Jun 16, 7:51 AM · Build System, Frameworks
kossebau updated subscribers of D21313: Create specific directory for Qt logging categories file.

This change appears to be responsible for all Android builds being broken.
See https://build.kde.org/view/Failing/

Could someone take a look please?

Sun, Jun 16, 12:37 AM · Build System, Frameworks
bruns requested review of D21839: [TermGenerator] Use UTF-8 ByteArray for termList.
Sun, Jun 16, 12:30 AM · Baloo, Frameworks

Yesterday

bruns added a comment to D20967: [UserMetaData] Add method to query which attributes are set.

Please note that there are very few people involved with Windows builds (despite the number of projects that make use of them in general) so people may not always have the ability to respond to every review request.
That is why the CI system monitors the state of code and can catch issues as they happen.

Sat, Jun 15, 10:18 PM · Baloo, Frameworks
aspotashev added a reviewer for D19498: loadLibrary: Use enum values to define what type of plugin we load: Frameworks.
Sat, Jun 15, 10:11 PM · Frameworks
bcooksley added a comment to D20967: [UserMetaData] Add method to query which attributes are set.

Please note that there are very few people involved with Windows builds (despite the number of projects that make use of them in general) so people may not always have the ability to respond to every review request.
That is why the CI system monitors the state of code and can catch issues as they happen.

Sat, Jun 15, 9:37 PM · Baloo, Frameworks
dhaumann accepted D17241: WIP:Disable highlighting after 512 characters on a line..

+1

Sat, Jun 15, 9:27 PM · Frameworks, Kate
bruns added a comment to D20967: [UserMetaData] Add method to query which attributes are set.

Windows - thanks for ignoring every review request!

Sat, Jun 15, 9:26 PM · Baloo, Frameworks
bcooksley added a comment to D21313: Create specific directory for Qt logging categories file.

This change appears to be responsible for all Android builds being broken.
See https://build.kde.org/view/Failing/

Sat, Jun 15, 9:25 PM · Build System, Frameworks
bcooksley added a comment to D20967: [UserMetaData] Add method to query which attributes are set.

This change has unfortunately made MSVC unhappy - https://build.kde.org/view/Failing/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/lastFailedBuild/

Sat, Jun 15, 9:19 PM · Baloo, Frameworks
cullmann added a comment to D17241: WIP:Disable highlighting after 512 characters on a line..

I am not sure about the warning.
The line length limit default should be increased it think, we could just try something like 10000 for a start.
I would propose we try this without a warning and see if we get negative feedback.
Normally this should only kick in situations were before we slowed down to "unusable".
Would that be ok?

Sat, Jun 15, 9:06 PM · Frameworks, Kate
vonreth added inline comments to D21661: add snoretoast backend for KNotifications on Windows.
Sat, Jun 15, 8:03 PM · Frameworks
bruns requested review of D21835: [PostingIterator] Move positions() method to VectorPositionInfoIterator.
Sat, Jun 15, 7:34 PM · Baloo, Frameworks
sars added a comment to D17241: WIP:Disable highlighting after 512 characters on a line..

I tried the patch and it improved the performance really much! :) I was able to edit a line that contained over a million characters!

Sat, Jun 15, 6:59 PM · Frameworks, Kate
shubham added inline comments to D21661: add snoretoast backend for KNotifications on Windows.
Sat, Jun 15, 6:47 PM · Frameworks
vonreth added inline comments to D21661: add snoretoast backend for KNotifications on Windows.
Sat, Jun 15, 2:00 PM · Frameworks
astippich updated the diff for D21830: Format photo exposure bias value.
  • remove unnecessary else
Sat, Jun 15, 1:34 PM · Baloo, Frameworks
apol added a comment to D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects.

If I understand correctly, the only reason to use KContacts here is so we can use its PhoneNumber type. We could change it to a QString?

Sat, Jun 15, 1:27 PM · Frameworks
bruns added inline comments to D21830: Format photo exposure bias value.
Sat, Jun 15, 1:24 PM · Baloo, Frameworks