FrameworksRelease
ActivePublic

Recent Activity

Today

camiloh updated the summary of D23352: make button icons follow a reasonable size and layout.
Thu, Aug 22, 3:43 PM · Frameworks
camiloh updated the summary of D23352: make button icons follow a reasonable size and layout.
Thu, Aug 22, 3:43 PM · Frameworks
camiloh updated the diff for D23352: make button icons follow a reasonable size and layout.

correct import line

Thu, Aug 22, 3:41 PM · Frameworks
camiloh requested review of D23352: make button icons follow a reasonable size and layout.
Thu, Aug 22, 3:40 PM · Frameworks
apol updated the diff for D22968: Make it possible to modify contacts.

Make it possible to create new contacts

Thu, Aug 22, 3:39 PM · Frameworks
sitter added a comment to D23348: force applicationDirPath into first position when finding plugins.

That is a solvable problem, there's a property to control where things end up in the build tree:
set_target_properties(kio_ftp PROPERTIES LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin/kf5/kio")

Thu, Aug 22, 2:47 PM · Frameworks
cullmann added a comment to D23348: force applicationDirPath into first position when finding plugins.

;=) Yeah, all ugly.
Even with the above code btw. an uninstalled Kate would still not find the plugins as it wants them in some "ktexteditor" subdir in plugins but with the current CMake setup they will end in the build directory in directly the same dir as the application executable.

Thu, Aug 22, 2:32 PM · Frameworks
davidre requested review of D23349: Krita has split from Calligra and now uses Krita name instead of calligrakrita.
Thu, Aug 22, 2:30 PM · Frameworks
sitter added a comment to D23348: force applicationDirPath into first position when finding plugins.

Perhaps the answer actually is that QT_PLUGIN_PATH should not be necessary ;)

Thu, Aug 22, 2:25 PM · Frameworks
cullmann added a comment to D23348: force applicationDirPath into first position when finding plugins.

Yes, I have some review request that does something similar inside Kate and I am not sure that this would help us either.

Thu, Aug 22, 2:03 PM · Frameworks
sitter abandoned D23348: force applicationDirPath into first position when finding plugins.

Agh, you are very right of course. Things are never easy :/

Thu, Aug 22, 2:01 PM · Frameworks
cullmann added a comment to D23348: force applicationDirPath into first position when finding plugins.

Hmm, I don't think this is a good thing to do.

Thu, Aug 22, 1:49 PM · Frameworks
sitter requested review of D23348: force applicationDirPath into first position when finding plugins.
Thu, Aug 22, 1:22 PM · Frameworks
nicolasfella closed D23341: Fixed Telegram Desktop plugin on Fedora.
Thu, Aug 22, 12:59 PM · Frameworks
xvitaly added a comment to D23341: Fixed Telegram Desktop plugin on Fedora.

My email address is vitaly@easycoding.org

Thu, Aug 22, 12:54 PM · Frameworks
zzag accepted D23347: kdelibs4support: port away from deprecated KWindowSystem API.
Thu, Aug 22, 12:53 PM · Frameworks
nicolasfella accepted D23341: Fixed Telegram Desktop plugin on Fedora.

Thanks! I assume you don't have commit rights, so I'll need your email address please to merge this

Thu, Aug 22, 12:50 PM · Frameworks
dfaure requested review of D23347: kdelibs4support: port away from deprecated KWindowSystem API.
Thu, Aug 22, 12:21 PM · Frameworks
dfaure added a comment to D5856: Use KDirWatch removeDir/addDir instead of stopDirScan/restartDirScan.

Probably still valid, yes. Needs investigation, and a unittest....

Thu, Aug 22, 12:18 PM · Frameworks
dfaure closed D23215: Port to non-deprecated KWindowSystem::setMainWindow overload.
Thu, Aug 22, 12:13 PM · Frameworks
dfaure closed D23217: KIO: port to non-deprecated KWindowSystem::setMainWindow.
Thu, Aug 22, 12:12 PM · Frameworks
dfaure closed D23213: Deprecate slideWindow(QWidget *widget).
Thu, Aug 22, 12:03 PM · Frameworks
dfaure closed D23211: KWindowSystem: fix compilation with KWINDOWSYSTEM_NO_DEPRECATED.
Thu, Aug 22, 12:03 PM · Frameworks
dfaure closed D23108: Add KWindowSystem::setMainWindow(QWindow *) overload.
Thu, Aug 22, 12:01 PM · Frameworks
xvitaly updated the diff for D23341: Fixed Telegram Desktop plugin on Fedora.

Added telegram-desktop.desktop launcher to JSON.

Thu, Aug 22, 11:55 AM · Frameworks
nicolasfella requested changes to D23341: Fixed Telegram Desktop plugin on Fedora.

Please add this to https://cgit.kde.org/purpose.git/tree/src/plugins/telegram/telegramplugin.json#n136 too

Thu, Aug 22, 11:46 AM · Frameworks
sitter requested review of D23344: assert slave command finality.
Thu, Aug 22, 11:19 AM · Frameworks
dvratil closed D23340: Fix memory leak in KConfigWatcher.
Thu, Aug 22, 11:01 AM · Frameworks
xvitaly requested review of D23341: Fixed Telegram Desktop plugin on Fedora.
Thu, Aug 22, 10:57 AM · Frameworks
ndavis accepted D23300: Add FictionBook 2 icons.

LGTM

Thu, Aug 22, 10:56 AM · Frameworks
davidedmundson accepted D23340: Fix memory leak in KConfigWatcher.

:/ Thanks

Thu, Aug 22, 10:49 AM · Frameworks
yurchor updated the diff for D23300: Add FictionBook 2 icons.

Use black "fb" for 32px and 64px breeze-dark

Thu, Aug 22, 10:44 AM · Frameworks
dvratil requested review of D23340: Fix memory leak in KConfigWatcher.
Thu, Aug 22, 10:39 AM · Frameworks
dvratil requested review of D23339: Fix memory leak in ConfigView and Dialog.
Thu, Aug 22, 10:34 AM · Frameworks
ndavis added a comment to D23300: Add FictionBook 2 icons.

Much better. There is only one thing left that I think should be done for 32 and 64 px. Rather than having a black "fb" for Breeze and and a white "fb" for Breeze Dark, use either white for both with a drop shadow under the "fb" or just black for both and no drop shadow. I only used different colors on the 16 and 22 px icons because they don't have a background.

Thu, Aug 22, 10:30 AM · Frameworks
adridg closed D23335: Q_UNUSED doesn't need a ; after it..
Thu, Aug 22, 10:21 AM · Frameworks
yurchor updated the diff for D23300: Add FictionBook 2 icons.

Realign 32px versions, replace 16px and 22px with icons proposed by Noah Davis, add dark versions

Thu, Aug 22, 10:03 AM · Frameworks
adridg requested review of D23338: Use baseFactory for K_PLUGIN_FACTORY_DECLARATION_WITH_BASEFACTORY_SKEL.
Thu, Aug 22, 10:02 AM · Frameworks
yurchor reclaimed D23300: Add FictionBook 2 icons.

Unexpected free time.

Thu, Aug 22, 9:59 AM · Frameworks
meven added a reviewer for D23266: Export Plasma core lib log category, add a category to a qWarning: broulik.
Thu, Aug 22, 9:51 AM · Frameworks
zzag accepted D23108: Add KWindowSystem::setMainWindow(QWindow *) overload.

Looks good to me.

Thu, Aug 22, 9:32 AM · Frameworks
daandemeyer requested review of D23336: KDirOperator: Add follow new directories option.
Thu, Aug 22, 8:57 AM · Frameworks
davidedmundson accepted D23335: Q_UNUSED doesn't need a ; after it..
Thu, Aug 22, 8:54 AM · Frameworks
adridg requested review of D23335: Q_UNUSED doesn't need a ; after it..
Thu, Aug 22, 8:45 AM · Frameworks
dfaure updated the diff for D23108: Add KWindowSystem::setMainWindow(QWindow *) overload.

Fix memory leak in new overload

Thu, Aug 22, 8:40 AM · Frameworks
dfaure added inline comments to D23108: Add KWindowSystem::setMainWindow(QWindow *) overload.
Thu, Aug 22, 8:40 AM · Frameworks
meven added a reviewer for D23333: KDirOperator: Only enable "Create New" menu if the selected item is a directory: Frameworks.
Thu, Aug 22, 8:20 AM · Frameworks
meven added a comment to D23333: KDirOperator: Only enable "Create New" menu if the selected item is a directory.

+1

Thu, Aug 22, 8:19 AM · Frameworks
daandemeyer requested review of D23333: KDirOperator: Only enable "Create New" menu if the selected item is a directory.
Thu, Aug 22, 8:12 AM · Frameworks
daandemeyer abandoned D22699: Support passing target to ecm_qt_declare_logging_category.

KF6 is a long time out so I'm abandoning this.

Thu, Aug 22, 7:53 AM · Build System, Frameworks