What about users who manually create and mount FUSE-type encrypted directories? Plasma Vault is just a nice interface for this workflow, after all.
I was thinking in the same direction. When the mountpoint of a vault is changed (or new) a warning message about baloo's activity should be displayed. The message should be displayed regardless of baloo's enabled state. There's plenty of space for that in the dialogs.
The user could then disable indexing with balooctl or via systemsettings.
IMO configuration of this should be done by Plasma Vault anyway. Baloo's job would be to provide the tools to do it. It's framework after all and should make as few decisions as possible.
I am confused. If I look in the commit history of this revision there are two diffs, the first commit, and then the subsequent commit. Can phabricator not handle both of them sequentially?
- Add and use contains()
- Use QLaint1String
Shouldn't the sendFrame event sent by the compositor explicitly? The way it's currently send after each event compositors are not able to group these.
@vkrause Do you already have something in mind, when you say this does not scale? ...
Maybe when a new vault is configured, it should add itself to baloo exceptions.
Ok, good catch. Given the uninitialized variables in the other classes, this is good. Will integrate.
I'll remove the selColor attributes, since these will not work with dark color schemes.
Similar, I will remove all underline, italic, and bold attributes where not needed by default.
Sounds good to me.
Looks good to me, will integrate.
@julianstirling Can you profile the full xml file again? This patch does not contain the .xml file anymore, so in the current form I cannot commit this as is.
This is not a viable approach.
Any vaults created after baloo is configured may be indexed (unless they are inside ~/Vaults, of course).
For the near future I see no other way to exclude vaults from being indexed other than this one. :-(
I honestly don't know.
I saw it. Ok, now what?
How to find out where the vaults are?
You have to hit next a couple of times
When creating a Vault you can choose any location for it. ~/Vaults is just the default
How is that done?
Vault can also be mounted in other directories than ~/Vaults
- Improved unit test
- Replaced slotUnlock() with slotPop()
First of all, please review carefully for ABI compatibility, I do not know what to watch for that.
Sorry for the late reply and the slow process in general. Reallife keeps me busy...
If we want to test this, we would need a directory with files for each extractor (kfilemetadata includes such files for its autotests). Then, we should configure seccomp to kill the process if it calls a prohibited syscall. The test should then index all files in the directory. Unfortunately we can't test some things, e.g. the dbus integration and communication with baloo_file. This would need a test which starts the whole extractor as a child process. But i'm not sure if thats feasible. What do you think?
In case the decision goes in favor of the blacklist, would it be possible to add ptrace, process_vm_readv, process_vm_writev?
That's possible of course.