FrameworksRelease
ActivePublic

Recent Activity

Today

dfaure added a comment to D19170: Fix crash while moving files.

Let's find out :-)

Fri, Feb 22, 10:27 AM · Frameworks
sitter closed D19156: port to findcanberra from ECM.
Fri, Feb 22, 9:55 AM · Frameworks
hallas added a comment to D19170: Fix crash while moving files.

Great analysis, thanks! Now this makes a lot more sense ;-)

The thing that I don't get, is why the subjob would emit anything after result(). I.e. step 7 is not supposed to happen, at all.
cfeck: I think you're referring to warning(), which does pop up a messagebox, but here it's about result() not warning().

Do we really have the *same* job emitting result twice, here?
That would be illegal...

Fri, Feb 22, 9:39 AM · Frameworks
dfaure added a comment to D19170: Fix crash while moving files.

Great analysis, thanks! Now this makes a lot more sense ;-)

Fri, Feb 22, 8:03 AM · Frameworks
cullmann closed D19200: Return sorted definitions for file names and mime types.
Fri, Feb 22, 7:54 AM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann accepted D19200: Return sorted definitions for file names and mime types.

Ok, this seems to work now here, too ;) Will merge it, thanks again.

Fri, Feb 22, 7:53 AM · Frameworks, Framework: Syntax Highlighting, Kate
davschul requested review of D19215: Install DefinitionDownloader header.
Fri, Feb 22, 7:10 AM · Frameworks, Framework: Syntax Highlighting, Kate
davschul updated the diff for D19200: Return sorted definitions for file names and mime types.

Yeah, I just missed to recheck the sorting logic. Before the change we just needed the best match so the partial sort was completely sufficient. Now we need a complete sorted vector, so stable sort is the way to go ;)

Fri, Feb 22, 6:37 AM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann added a comment to D19163: Make it possible to show all spaces in the document.
In D19163#417139, @apol wrote:

I like the feature, but for the implementation: Could we alter the config to itself hold the enum?

We could do that, I just didn't not to break currently existing systems

I think it would be nicer to have it directly as enum in the config, otherwise in one year, we will be all confused how these two bools interact.

Fri, Feb 22, 6:26 AM · Frameworks, Kate
cullmann added a comment to D19200: Return sorted definitions for file names and mime types.

Thanks for taking a look again ;=)

Fri, Feb 22, 6:02 AM · Frameworks, Framework: Syntax Highlighting, Kate
anthonyfieroni abandoned D18249: [datamodel] Rework items insert/remove.
Fri, Feb 22, 5:30 AM · Frameworks

Yesterday

apol updated the diff for D19163: Make it possible to show all spaces in the document.

oops

Thu, Feb 21, 11:35 PM · Frameworks, Kate
apol added a comment to D19163: Make it possible to show all spaces in the document.

I like the feature, but for the implementation: Could we alter the config to itself hold the enum?

We could do that, I just didn't not to break currently existing systems

Thu, Feb 21, 11:34 PM · Frameworks, Kate
dhaumann added inline comments to D19200: Return sorted definitions for file names and mime types.
Thu, Feb 21, 10:32 PM · Frameworks, Framework: Syntax Highlighting, Kate
cfeck added a comment to D19170: Fix crash while moving files.

That a nested event loop of an error dialog caused the crashes makes sense, because they were reported for alien drives (NTFS) or transfers with permission problems. What actual error dialogs did you get and are they reproducible?

Thu, Feb 21, 9:31 PM · Frameworks
dlevin added a comment to D19198: BrightScript: Unary and hex numbers, @attribute.

Thanks for cleaning up the tests after me!

Thu, Feb 21, 8:54 PM · Frameworks, Kate
hallas updated the test plan for D19170: Fix crash while moving files.
Thu, Feb 21, 8:48 PM · Frameworks
hallas updated the diff for D19170: Fix crash while moving files.

Implement a proper fix

Thu, Feb 21, 8:46 PM · Frameworks
hallas added a comment to D19170: Fix crash while moving files.

I think I have finally found the root cause of this. The following events occurs:

Thu, Feb 21, 8:46 PM · Frameworks
ngraham closed D18762: Add support for portals in KRun.
Thu, Feb 21, 8:16 PM · Frameworks
ngraham added a comment to D18762: Add support for portals in KRun.

No problem, I'll take care of this for you!

Thu, Feb 21, 8:14 PM · Frameworks
GeeXT added a comment to D18762: Add support for portals in KRun.

@apol I didn't applied for KDE Developer Account yet (I'm new here) so I can't, sorry.

Thu, Feb 21, 8:12 PM · Frameworks
apol closed D18853: Fix sharing files with spaces or quotes in names via Telegram.
Thu, Feb 21, 8:00 PM · Frameworks
apol added a comment to D18853: Fix sharing files with spaces or quotes in names via Telegram.

Cool! :D welcome to KDE!

Thu, Feb 21, 7:59 PM · Frameworks
apol added a comment to D18762: Add support for portals in KRun.

Thanks!
Can you land the patch or should we do it for you?

Thu, Feb 21, 7:58 PM · Frameworks
bruns added a comment to D18664: Baloo engine: treat every non-success code as a failure.

I think this looks good now, but I would prefer an OK from another developer, as this has become quite large.

Thu, Feb 21, 7:40 PM · Baloo, Frameworks
apol accepted D19156: port to findcanberra from ECM.
Thu, Feb 21, 7:40 PM · Frameworks
bruns added a comment to D19097: Add a test and document PropertyMap/VariantMap conversion.

These two conversion functions should just be deprecated, as they are not expecially useful.

Thu, Feb 21, 7:22 PM · Baloo, Frameworks
bruns added a comment to D19098: Add PropertyMap to QVariantMap conversion function using names.

It already does at two different places, because it fuses different information into a single QMap later on (xattr, file size etc...)
https://phabricator.kde.org/source/baloo-widgets/browse/master/src/extractor.cpp$65
https://phabricator.kde.org/source/baloo-widgets/browse/master/src/filefetchjob.cpp$62

This can be done by using a KFM::PropertyMap directly, and adding property types for the UserMetaData (tags, comment, rating). Note, the strings returned by PropertyInfo::name() are not shared ...

It is not only xattr, also everything from kfileitems{group,size,owner...}. Adding these as property with no users in KFileMetaData does not seem clean.
Also, you would have to construct the properties from the name. Why not use the names directly then? Changing everything to a PropertyMap requires a rewrite of large parts, and I certainly will not rewrite baloo-widgets right now.
This is just for a small cleanup.

Thu, Feb 21, 6:53 PM · Baloo, Frameworks
valeriymalov updated the diff for D18664: Baloo engine: treat every non-success code as a failure.
  • fix MTimeDB::get loop
Thu, Feb 21, 6:16 PM · Baloo, Frameworks
bruns requested changes to D18664: Baloo engine: treat every non-success code as a failure.
Thu, Feb 21, 6:06 PM · Baloo, Frameworks
apol added a comment to D19111: Have ShareFileItemAction provide an output or an error if they are provided.

https://commits.kde.org/purpose/a6d93ff28f090dd0086301884a31e0eea0efd845

Thu, Feb 21, 5:01 PM · Frameworks
apol closed D19111: Have ShareFileItemAction provide an output or an error if they are provided.

Landed, don't know why this didn't update.

Thu, Feb 21, 5:01 PM · Frameworks
nicolasfella accepted D19111: Have ShareFileItemAction provide an output or an error if they are provided.
Thu, Feb 21, 4:55 PM · Frameworks
valeriymalov closed D18873: add baloo engine debugging category.
Thu, Feb 21, 4:48 PM · Baloo, Frameworks
apol updated the diff for D19111: Have ShareFileItemAction provide an output or an error if they are provided.

Remove unrelated debug info

Thu, Feb 21, 4:45 PM · Frameworks
valeriymalov updated the diff for D18664: Baloo engine: treat every non-success code as a failure.
  • review warning fixes
Thu, Feb 21, 4:29 PM · Baloo, Frameworks
valeriymalov updated the summary of D18664: Baloo engine: treat every non-success code as a failure.
Thu, Feb 21, 4:25 PM · Baloo, Frameworks
davschul added a comment to D19200: Return sorted definitions for file names and mime types.

Ah sorry completely missed that part. Unfortunately I'm out of office already, I'll take a look as soon as I'm back tomorrow.

Thu, Feb 21, 4:05 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann added a comment to D19200: Return sorted definitions for file names and mime types.

Actually, do we need a partial sort? Should we not just stable_sort the complete vector by prio? That should keep stuff with same prio untouched, or?

Thu, Feb 21, 2:40 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann added a comment to D19200: Return sorted definitions for file names and mime types.

I think the + 1 is the only real issue, the other issue stems from my local setting that I have no compiled in QRC.

Thu, Feb 21, 2:34 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann requested changes to D19200: Return sorted definitions for file names and mime types.
Thu, Feb 21, 2:28 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann added a comment to D19200: Return sorted definitions for file names and mime types.

I think one error is the sort of the empty vector with the begin() + 1
But even then, make test fails, after fixing this.
Please take a look and run the tests.
Thanks

Thu, Feb 21, 2:28 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann added a comment to D19200: Return sorted definitions for file names and mime types.

The partial sort is bad ;=()

Thu, Feb 21, 2:21 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann reopened D19200: Return sorted definitions for file names and mime types.

Beside that this fails ;=)

Thu, Feb 21, 2:19 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann closed D19200: Return sorted definitions for file names and mime types.
Thu, Feb 21, 2:16 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann accepted D19200: Return sorted definitions for file names and mime types.

Yes, this is nice, nice trick with value(0) to avoid adding an element to the vector but just letting the API default construct it.

Thu, Feb 21, 2:14 PM · Frameworks, Framework: Syntax Highlighting, Kate
cullmann closed D18997: Add functions returning all definitions for a mimetype or file name.

Ok ;=)

Thu, Feb 21, 2:13 PM · Frameworks, Kate, Framework: Syntax Highlighting
davschul added a comment to D18997: Add functions returning all definitions for a mimetype or file name.

Created https://phabricator.kde.org/D19200
That should implement all the latest suggestions/comments

Thu, Feb 21, 1:58 PM · Frameworks, Kate, Framework: Syntax Highlighting
davschul requested review of D19200: Return sorted definitions for file names and mime types.
Thu, Feb 21, 1:56 PM · Frameworks, Framework: Syntax Highlighting, Kate