FrameworksRelease
ActivePublic

Recent Activity

Today

niccolove added a comment to D25340: Added background colors to active and inactive icon view.

@niccolove Do you mind if I commandeer this? I know dealing with these kinds of issues can be super annoying and I'm already used to it.

Sun, Dec 8, 8:26 AM · Frameworks

Yesterday

nicolasfella added a reviewer for D25700: [KHistoryComboBox] Add method to set an icon provider: dfaure.
Sat, Dec 7, 10:54 PM · Frameworks
nicolasfella updated the diff for D25700: [KHistoryComboBox] Add method to set an icon provider.
  • For real
Sat, Dec 7, 10:52 PM · Frameworks
nicolasfella updated the diff for D25700: [KHistoryComboBox] Add method to set an icon provider.
  • Adapt deprecation version
Sat, Dec 7, 10:51 PM · Frameworks
nicolasfella updated the diff for D25700: [KHistoryComboBox] Add method to set an icon provider.
  • Deprecation, fix, and docs
Sat, Dec 7, 10:49 PM · Frameworks
filipf added a comment to D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.

The check for the prefix was added in bf1d1cc6b2ad37cb586f44b56fa2438ed3a5dbfc, while the control.flat one got added much earlier.

The labels are visible again with just the control.flat condition, but the prefix one might be needed as well for non-breeze themes.

There's a part missing though, the triangle (visible on https://openqa.opensuse.org/tests/1105226#step/start_wayland_plasma5/21) is gone. That seems to be a feature lost with PC3 :-(

Sat, Dec 7, 10:33 PM · Frameworks
fvogt added a comment to D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.

The check for the prefix was added in bf1d1cc6b2ad37cb586f44b56fa2438ed3a5dbfc, while the control.flat one got added much earlier.

Sat, Dec 7, 10:13 PM · Frameworks
filipf updated the summary of D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.
Sat, Dec 7, 9:49 PM · Frameworks
dfaure added a comment to D25698: New class KApplicationTrader, to replace KMimeTypeTrader and KServiceTypeTrader.

Assuming we install all parts under plugins/parts instead of just plugins/ like we currently do, the application should be able to do

Sat, Dec 7, 9:10 PM · Frameworks
ndavis added a comment to D25340: Added background colors to active and inactive icon view.

@niccolove Do you mind if I commandeer this? I know dealing with these kinds of issues can be super annoying and I'm already used to it.

Sat, Dec 7, 7:56 PM · Frameworks
astippich added a comment to D25517: Add an option to extract binary data and add front cover property.

ping!

Sat, Dec 7, 6:33 PM · Baloo, Frameworks
ndavis added a comment to D25340: Added background colors to active and inactive icon view.

It's still going to be a PITA with manual editing. Maybe there's a way to automate it with awk, but I don't know that tool well enough. This should at least make the deleting part easier: sed --follow-symlinks -i 's/style="opacity:0.05"//' tasks.svg

Sat, Dec 7, 5:26 PM · Frameworks
ndavis requested changes to D25340: Added background colors to active and inactive icon view.
Sat, Dec 7, 5:20 PM · Frameworks
ndavis added a comment to D25340: Added background colors to active and inactive icon view.

Oh wait, here's the problem

Sat, Dec 7, 5:20 PM · Frameworks
ndavis added a comment to D25340: Added background colors to active and inactive icon view.

Hmm, I'm not seeing any change, and the difference between open and maximized items is still too subtle IMO:

If the background is a different color/opacity, I can't tell.

Sat, Dec 7, 5:14 PM · Frameworks
cullmann closed D25686: Updates from CMake 3.16 final release.
Sat, Dec 7, 4:46 PM · Frameworks, Kate
ngraham added a comment to D25340: Added background colors to active and inactive icon view.

Hmm, I'm not seeing any change, and the difference between open and maximized items is still too subtle IMO:

Sat, Dec 7, 4:40 PM · Frameworks
ahmadsamir updated the diff for D23457: Port regex search to QRegularExpression.

Rebase

Sat, Dec 7, 3:33 PM · Frameworks, Kate
mlaurent added inline comments to D25754: Refactor KHistoryComboBox::insertItems.
Sat, Dec 7, 3:25 PM · Frameworks
nicolasfella closed D25754: Refactor KHistoryComboBox::insertItems.
Sat, Dec 7, 2:41 PM · Frameworks
ndavis accepted D25340: Added background colors to active and inactive icon view.
Sat, Dec 7, 11:40 AM · Frameworks
niccolove updated the diff for D25340: Added background colors to active and inactive icon view.

Reset tabbar to master

Sat, Dec 7, 11:29 AM · Frameworks
niccolove added a comment to D25340: Added background colors to active and inactive icon view.

Wait, is a change to tabbar.svg supposed to be in this diff?

Sat, Dec 7, 11:26 AM · Frameworks
ndavis requested changes to D25340: Added background colors to active and inactive icon view.

Wait, is a change to tabbar.svg supposed to be in this diff?

Sat, Dec 7, 11:25 AM · Frameworks
niccolove added a comment to D25334: Added transparent blue background to tabbars.

Yes that's right, the Kickoff tabs are fine, it's the panel that doesn't look right. It just doesn't look good with that kind of highlight to me. Or maybe the highlight background is too bright.

To me it looks fine with Breeze light IMO. If you think it looks bad with Breeze Dark, that seems like kind of a problem since as far as I was aware, this is the proposed new highlight style that you're working on, right? It definitely needs to look good with Breeze Dark, or at least no worse than the status quo.

Sat, Dec 7, 11:25 AM · Frameworks
ndavis accepted D25340: Added background colors to active and inactive icon view.
Sat, Dec 7, 11:23 AM · Frameworks
niccolove updated the diff for D25340: Added background colors to active and inactive icon view.

Changed inactive to 5%

Sat, Dec 7, 11:21 AM · Frameworks
aacid added a comment to D25698: New class KApplicationTrader, to replace KMimeTypeTrader and KServiceTypeTrader.

How would i load a "KPart that can open PDF files" then?

Sat, Dec 7, 10:06 AM · Frameworks
sars added a comment to D25599: Fix plugin-metadata translations on windows.

Yes it works :)

Sat, Dec 7, 8:55 AM · Windows, Frameworks
ahmadsamir added inline comments to D25767: KAutoSaveFile: add a unit test to check max. filename length.
Sat, Dec 7, 8:36 AM · Frameworks
ahmadsamir updated the diff for D25767: KAutoSaveFile: add a unit test to check max. filename length.

Address comments

Sat, Dec 7, 8:26 AM · Frameworks
chinmoyr updated the diff for D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation.

Rebased, compiled and tested. Changes work as expected.
Double checked file_unix.cpp. Would be a shame if it happens yet again.

Sat, Dec 7, 2:49 AM · Frameworks
bruns added inline comments to D25789: Correctly report if baloo_file is unavailable.
Sat, Dec 7, 2:16 AM · Baloo, Frameworks
dfaure added a comment to D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO.

The opposite extreme is to always pass when X-KDE-Protocols is set and assume that the applications are actually working correctly (e.g. vlc ought to talk to kiod/KPasswdServerClient to get credentials, otherwise its declaration of X-KDE-Protocols is incorrect and you are looking at a bug in vlc. at the very least it should throw up its own auth dialog if it doesn't know what to do).

Sat, Dec 7, 12:47 AM · Frameworks
bcooksley added a comment to D25682: [WIP] add initial wsdiscovery support.

With regards to the Docker/Gitlab CI part, please use the images under kdeorg/ on Dockerhub rather than personally maintained images as the wider community has no access to your namespace on Gitlab.com

Sat, Dec 7, 12:39 AM · Frameworks, Dolphin
dfaure added a comment to D25698: New class KApplicationTrader, to replace KMimeTypeTrader and KServiceTypeTrader.

Feedback on the API question would be welcome.

Sat, Dec 7, 12:37 AM · Frameworks
dfaure requested changes to D25682: [WIP] add initial wsdiscovery support.

I guess you were expecting a higher-level review, but I don't know anything about these protocols.

Sat, Dec 7, 12:27 AM · Frameworks, Dolphin
kossebau added inline comments to D25798: Deprecated allowAsDefault.
Sat, Dec 7, 12:27 AM · Frameworks
ltoscano added a comment to D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts".

Oh sorry, I missed that. It's the kind of information I wouldn't expect in the commit message.

Sat, Dec 7, 12:20 AM · Frameworks
ngraham added a comment to D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts".

Yep, in fact I mentioned this in the description section of the patch:

Sat, Dec 7, 12:13 AM · Frameworks
nicolasfella requested review of D25798: Deprecated allowAsDefault.
Sat, Dec 7, 12:09 AM · Frameworks
ltoscano added a comment to D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts".

Please commit it after the commit for the new Frameworks is made (so probably from Sunday onwards).

Sat, Dec 7, 12:08 AM · Frameworks

Fri, Dec 6

dfaure requested changes to D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation.

I'm concerned that you didn't compile this (because of dependency issues, from what I gather), which means it's not tested either.

Fri, Dec 6, 11:41 PM · Frameworks
ngraham accepted D25340: Added background colors to active and inactive icon view.

I guess I should change my status to accepted given that I think this is good enough and already an improvement. But I think we can do even better, @niccolove. :)

Fri, Dec 6, 11:01 PM · Frameworks
dfaure added a comment to D24489: KAutosaveFile not respecting maximum filename length.

I see. This answers my question about why two merge requests -- no problem, keep them separate, but commit the fix before the unittest
[this is so that bisecting never ends up in the situation where unittests are broken]

Fri, Dec 6, 9:29 PM · Frameworks
filipf added a comment to D25340: Added background colors to active and inactive icon view.

This diff is against commit 467d721cc96258b54048c0dd1508d16e03c0cd55, which isn't in git master. Do I actually need that commit for this patch to work?

Fri, Dec 6, 8:53 PM · Frameworks
ndavis accepted D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts".

Welp, there's nothing objectively wrong with making this patch. LGTM

Fri, Dec 6, 7:43 PM · Frameworks
ngraham added a comment to D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts".

There was a bug report about it that had some people agreeing with it. I think it makes a bit of sense because yes, this dialog is indeed only about keyboard shortcuts, and at least to my ears, the phrase "keyboard shortcuts" instantly connotes what this is about, while "shortcuts" is a more generic term that doesn't have such an instantly recognizable computer-related meaning.

Fri, Dec 6, 7:26 PM · Frameworks
ndavis added a comment to D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts".

This doesn't seem wrong, but why is it needed? Do people get confused about the type of shortcuts? Are there non-keyboard shortcuts? If there are, would we put their configuration menu under a different menu option?

Fri, Dec 6, 7:11 PM · Frameworks
ngraham requested review of D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts".
Fri, Dec 6, 7:06 PM · Frameworks