- For real
- Adapt deprecation version
- Deprecation, fix, and docs
The check for the prefix was added in bf1d1cc6b2ad37cb586f44b56fa2438ed3a5dbfc, while the control.flat one got added much earlier.
Assuming we install all parts under plugins/parts instead of just plugins/ like we currently do, the application should be able to do
@niccolove Do you mind if I commandeer this? I know dealing with these kinds of issues can be super annoying and I'm already used to it.
It's still going to be a PITA with manual editing. Maybe there's a way to automate it with awk, but I don't know that tool well enough. This should at least make the deleting part easier: sed --follow-symlinks -i 's/style="opacity:0.05"//' tasks.svg
Oh wait, here's the problem
Hmm, I'm not seeing any change, and the difference between open and maximized items is still too subtle IMO:
Reset tabbar to master
Wait, is a change to tabbar.svg supposed to be in this diff?
Changed inactive to 5%
How would i load a "KPart that can open PDF files" then?
Yes it works :)
Rebased, compiled and tested. Changes work as expected.
Double checked file_unix.cpp. Would be a shame if it happens yet again.
With regards to the Docker/Gitlab CI part, please use the images under kdeorg/ on Dockerhub rather than personally maintained images as the wider community has no access to your namespace on Gitlab.com
Feedback on the API question would be welcome.
I guess you were expecting a higher-level review, but I don't know anything about these protocols.
Oh sorry, I missed that. It's the kind of information I wouldn't expect in the commit message.
Yep, in fact I mentioned this in the description section of the patch:
Please commit it after the commit for the new Frameworks is made (so probably from Sunday onwards).
Fri, Dec 6
I'm concerned that you didn't compile this (because of dependency issues, from what I gather), which means it's not tested either.
I guess I should change my status to accepted given that I think this is good enough and already an improvement. But I think we can do even better, @niccolove. :)
I see. This answers my question about why two merge requests -- no problem, keep them separate, but commit the fix before the unittest
[this is so that bisecting never ends up in the situation where unittests are broken]
Welp, there's nothing objectively wrong with making this patch. LGTM
There was a bug report about it that had some people agreeing with it. I think it makes a bit of sense because yes, this dialog is indeed only about keyboard shortcuts, and at least to my ears, the phrase "keyboard shortcuts" instantly connotes what this is about, while "shortcuts" is a more generic term that doesn't have such an instantly recognizable computer-related meaning.
This doesn't seem wrong, but why is it needed? Do people get confused about the type of shortcuts? Are there non-keyboard shortcuts? If there are, would we put their configuration menu under a different menu option?