FrameworksRelease
ActivePublic

Recent Activity

Mon, Jul 6

dfaure added a comment to D14631: Adds a new RenameDialog to KIO with more options for batch renaming.

Only if you can find a way to change BatchRenameJob in a binary and behaviour compatible way. And then it will be a dual-headed thing with two modes of operations, awful. All this sounds to me like much more trouble than writing a different job.

Mon, Jul 6, 9:02 AM · Frameworks
luco added a comment to D14631: Adds a new RenameDialog to KIO with more options for batch renaming.

@emateli Thank you, I do understand that BatchMoveJob could be more versatile for a various kind of operations, but couldn't it be easier to just edit the BatchRenameJob's hardcoded logic and make it more parametric?
If I understand correctly you're referring to the fact that the ctor of BatchRenameJob is accepting a QChar and it only substitutes it with numbers, wouldn't be easier to edit that logic instead? I'm asking because I think you already have considered this option and concluded that it was not worth it

Mon, Jul 6, 8:34 AM · Frameworks

Sun, Jul 5

emateli added a comment to D14631: Adds a new RenameDialog to KIO with more options for batch renaming.

You're completely right in the sense that for a batch rename files will be in the same folder. However, rename really is just a move operation. The current BatchRenameJob has a hardcoded logic about placeholders and extensions which make it unusable outside of its current scope.

Sun, Jul 5, 6:27 PM · Frameworks
luco added a comment to D14631: Adds a new RenameDialog to KIO with more options for batch renaming.

@emateli Thank you for your response, I saw that patch and I sincerely don't understand the reason why you're writing a completely different job (BatchMoveJob) when the required operation is exactly a BatchRenameJob.
I'm asking this because I've never used a "batch rename" feature to move files to a different folder, I always used that to rename multiple files with a regex pattern or a numbering sequence instead, but maybe it's just me.

Sun, Jul 5, 6:13 PM · Frameworks
emateli added a comment to D14631: Adds a new RenameDialog to KIO with more options for batch renaming.

I honestly think the GUI is mostly ready, at least what I wanted to achieve with it: Something that is advanced enough but not over the top with options as there's already tools for that. Will check at some point to finish the items left from the review here. What this needs to be fully implemented is support from KIO for a "proper" batch move operation. I've submitted a patch for that at D27760 but am still waiting for a review.

Sun, Jul 5, 6:01 PM · Frameworks
luco added a comment to D14631: Adds a new RenameDialog to KIO with more options for batch renaming.

@emateli Are you still working on this? I'd love to see this feature implemented, I wanted to start by myself then on the Matrix Dolphin channel they suggested seeing this patch and it's awesome! Could you use some help?

Sun, Jul 5, 5:46 PM · Frameworks

Sat, Jul 4

marcingu added a comment to D28745: Skip caching thumbnails on encrypted filesystems.

I made merge request for storageAccessFromPath: https://invent.kde.org/frameworks/solid/-/merge_requests/8

Sat, Jul 4, 12:19 PM · Frameworks, Dolphin

Thu, Jul 2

nicolasfella added a comment to D29020: Add example/test application.

Ping?

Thu, Jul 2, 10:14 PM · Frameworks
nicolasfella updated the diff for D26918: Improve KNotification API docs.
  • Address comments
Thu, Jul 2, 10:00 PM · Frameworks

Wed, Jul 1

marcingu added a comment to D28745: Skip caching thumbnails on encrypted filesystems.

How often do I have to repeat the thumbnailer has to use the canonical path anyway? Please use that.

storageAccessFromPath converts given path into canonical. I figured it should do so anyway, so I'm not doing it again here.

And thats wrong. You need the canonical path in the thumbnailer itself.

Wed, Jul 1, 9:26 AM · Frameworks, Dolphin
ngraham added a comment to D27197: Add symbolic screenshot icons.

Thanks, that's better now. However the camera silhouette still doesn't match that of other monochrome camera images we have. I'd like to stick to standard iconography if possible. Do you think we should switch the other related icons to use your new camera icon, or would you like to use the one from, for example, preferences-system-windows-effect-screenshot?

Wed, Jul 1, 3:38 AM · Frameworks

Tue, Jun 30

bruns added a comment to D28745: Skip caching thumbnails on encrypted filesystems.

How often do I have to repeat the thumbnailer has to use the canonical path anyway? Please use that.

storageAccessFromPath converts given path into canonical. I figured it should do so anyway, so I'm not doing it again here.

Tue, Jun 30, 1:56 PM · Frameworks, Dolphin
mbruchert updated the diff for D27197: Add symbolic screenshot icons.

Fix colors

Tue, Jun 30, 1:11 PM · Frameworks
meven added a comment to D28856: Save disabling of desktop file components in kglobalshortcutsrc.

Would be important to land with https://invent.kde.org/frameworks/kglobalaccel/-/merge_requests/2

Tue, Jun 30, 10:45 AM · Frameworks
arrowd added inline comments to D17816: Support for xattrs on kio copy/move.
Tue, Jun 30, 8:08 AM · Frameworks
arrowd updated the diff for D17816: Support for xattrs on kio copy/move.
  • Remove extraneous debugging output.
Tue, Jun 30, 8:07 AM · Frameworks
marcingu added a comment to D28745: Skip caching thumbnails on encrypted filesystems.

How often do I have to repeat the thumbnailer has to use the canonical path anyway? Please use that.

Tue, Jun 30, 6:41 AM · Frameworks, Dolphin

Mon, Jun 29

bruns added inline comments to D17816: Support for xattrs on kio copy/move.
Mon, Jun 29, 8:15 PM · Frameworks
arrowd updated the diff for D17816: Support for xattrs on kio copy/move.
  • Handle attrs with empty values.
  • Add test for it.
  • Fix syscalls for FreeBSD case.
Mon, Jun 29, 6:09 PM · Frameworks
bruns added a comment to D28745: Skip caching thumbnails on encrypted filesystems.
Solid::Device device = Solid::Device::storageAccessFromPath(filePath);
if (device.is<Solid::StorageVolume>()) {
    allowCache = device.as<Solid::StorageVolume>()->usage() != Solid::StorageVolume::UsageType::Encrypted;
}
Mon, Jun 29, 4:17 PM · Frameworks, Dolphin
thiago added a comment to D28745: Skip caching thumbnails on encrypted filesystems.
for (Device device: list) {
    StorageAccess *storageAccess = device.as<StorageAccess>();
    if (canonPath.startsWith(storageAccess->filePath()) && storageAccess->filePath().size() > match_length) {
        match_length = storageAccess->filePath().size();
        match = device;
    }
Mon, Jun 29, 3:25 PM · Frameworks, Dolphin
marcingu added a comment to D28745: Skip caching thumbnails on encrypted filesystems.

Ok, so far I have implemented Solid::Device::storageAccessFromPath by talking all StorageAccess devices, going though all of them and and returning proper one.
code:

Solid::Device Solid::Device::storageAccessFromPath(const QString &path)
{
    // TODO check if symlinks are in the path
    QFileInfo fileInfo = QFileInfo(path);
    if (!fileInfo.exists()) {
        //TODO error handling
    }
    QSet<QString> checked; //To avoid weird infinete loops
    checked.insert(fileInfo.path());
    while (fileInfo.isSymLink()) {
        fileInfo = QFileInfo(fileInfo.symLinkTarget());
        if (checked.contains(fileInfo.path())) {
            //TODO error handling
        }
        checked.insert(fileInfo.path());
    }
    QDir dir = fileInfo.dir();
    QString canonPath = dir.canonicalPath();
    QList<Device> list = Solid::Device::listFromType(DeviceInterface::Type::StorageAccess);
    Device match;
    int match_length = 0;
    for (Device device: list) {
        StorageAccess *storageAccess = device.as<StorageAccess>();
        if (canonPath.startsWith(storageAccess->filePath()) && storageAccess->filePath().size() > match_length) {
            match_length = storageAccess->filePath().size();
            match = device;
        }
    }
    return match;
}
Mon, Jun 29, 10:31 AM · Frameworks, Dolphin

Sun, Jun 28

cordlandwehr abandoned D28379: KWidgetsAddons: Convert copyright headers to SPDX expressions.

move merge request to Gitlab

Sun, Jun 28, 9:17 AM · Frameworks

Fri, Jun 26

apol abandoned D27338: Provide an initial implementation for input-method-unstable-v1.

https://invent.kde.org/plasma/kwayland-server/-/merge_requests/31

Fri, Jun 26, 6:22 PM · Frameworks
apol abandoned D22362: Port keystates to use QtWayland's generator.

Moved to invent for kwayland-server

Fri, Jun 26, 6:05 PM · Frameworks

Wed, Jun 24

bruns added inline comments to D17816: Support for xattrs on kio copy/move.
Wed, Jun 24, 12:29 PM · Frameworks

Tue, Jun 23

arrowd added inline comments to D17816: Support for xattrs on kio copy/move.
Tue, Jun 23, 5:23 PM · Frameworks
arrowd updated the diff for D17816: Support for xattrs on kio copy/move.
  • Improve comment.
Tue, Jun 23, 4:44 PM · Frameworks
cgiboudeaux added a comment to D28379: KWidgetsAddons: Convert copyright headers to SPDX expressions.

Can you create an invent MR? I'll look later

Tue, Jun 23, 7:23 AM · Frameworks

Mon, Jun 22

bruns added inline comments to D17816: Support for xattrs on kio copy/move.
Mon, Jun 22, 2:51 PM · Frameworks
kossebau closed D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler.
Mon, Jun 22, 2:48 PM · Frameworks
kossebau added a comment to D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler.

Okay :) Hm, need to update 71 to 72 though first, doing now.

Mon, Jun 22, 2:38 PM · Frameworks
vkrause accepted D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler.
Mon, Jun 22, 2:33 PM · Frameworks
kossebau added a comment to D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler.

Ping... :)

Mon, Jun 22, 2:31 PM · Frameworks
ngraham added a comment to D17816: Support for xattrs on kio copy/move.

@bruns?

Mon, Jun 22, 2:12 PM · Frameworks

Sun, Jun 21

elvisangelaccio abandoned D21695: Add FindTaglib.cmake.
Sun, Jun 21, 9:17 PM · Build System, Frameworks
elvisangelaccio commandeered D21695: Add FindTaglib.cmake.
Sun, Jun 21, 9:17 PM · Build System, Frameworks

Sat, Jun 20

arrowd updated the diff for D17816: Support for xattrs on kio copy/move.
  • Rebase on master.
Sat, Jun 20, 4:30 PM · Frameworks
hurikhan77 updated the task description for T11859: Understanding and reducing bad performance impact of running Baloo under certain conditions.
Sat, Jun 20, 1:52 AM · Frameworks, Baloo
hurikhan77 updated the task description for T11859: Understanding and reducing bad performance impact of running Baloo under certain conditions.
Sat, Jun 20, 1:51 AM · Frameworks, Baloo

Fri, Jun 19

kossebau added inline comments to D27396: support icon.width/height.
Fri, Jun 19, 1:44 PM · Frameworks
kossebau added inline comments to D27396: support icon.width/height.
Fri, Jun 19, 1:24 PM · Frameworks

Sun, Jun 14

wojnilowicz closed D29258: Don't use notifybysnore.h on MSYS2.

It probably won't hurt

Sun, Jun 14, 5:25 PM · Frameworks
vonreth accepted D29258: Don't use notifybysnore.h on MSYS2.

It probably won't hurt

Sun, Jun 14, 4:33 PM · Frameworks
wojnilowicz added inline comments to D29258: Don't use notifybysnore.h on MSYS2.
Sun, Jun 14, 3:47 PM · Frameworks
wojnilowicz updated the diff for D29258: Don't use notifybysnore.h on MSYS2.

Qt5Network added as required

Sun, Jun 14, 3:45 PM · Frameworks
cordlandwehr added a comment to D28379: KWidgetsAddons: Convert copyright headers to SPDX expressions.

Another ping... This merge request is lying around already quite some time (sorry for being so big)

Sun, Jun 14, 6:03 AM · Frameworks
sdepiets added a comment to D26342: Allow overriding to disable auto language detection.

Please see below proposal to restore the previous default behavior

Sun, Jun 14, 12:34 AM · Frameworks

Sat, Jun 13

nicolasfella closed D29390: Respect QIcon::fallbackSearchpaths().
Sat, Jun 13, 10:30 PM · Frameworks
dfaure added a comment to D26342: Allow overriding to disable auto language detection.

I don't think that's a regression, in the previous behavior you could try to set any language to proofread, it would always auto-detect "Bonjour" as French, thus the "Tools / Spelling / change language" had not effect if autodetect was enabled at system level (while autodetection should be an application or even case by case decision).

Sat, Jun 13, 5:58 PM · Frameworks