FrameworksRelease
ActivePublic

Recent Activity

Today

aacid requested review of D14983: Set breeze as fallback icon theme.
Tue, Aug 21, 11:10 PM · Frameworks
ngraham added a comment to D14971: Combine display OSD icon files and move to plasma icon theme.

When I apply this patch and compile and deploy plasma-framework to /usr/ and then delete the Breeze icons versions, I still don't see the new icons in the switcher. What am I doing wrong?

Tue, Aug 21, 10:32 PM · Frameworks
aacid added a comment to D14966: Added support for disabling the loading of translations.

I personally don't think this is the way to go and as said many times think that loading a custom translation for tests like ki18n way does is the way to go.

Tue, Aug 21, 10:26 PM · Build System, Frameworks
aacid added a comment to D14967: Disable loading of translations for kformattest, which was not designed with translations.

I personally don't think this is the way to go and as said many times think that loading a custom translation for tests like ki18n way does is the way to go.

Tue, Aug 21, 10:26 PM · Frameworks
aacid requested changes to D14940: kformattest: Use plural suffix (s) consequently.

This is not how plurals for decimals work, they are always in plural.

Tue, Aug 21, 10:00 PM · Frameworks
dhaumann added a comment to D14978: Add unit test that checks Format data.

The problem likely was that Alerts.xml does not have the indentationBasedFolding attribute set. But it's needed in e.g. Python.

Tue, Aug 21, 7:26 PM · Frameworks, Kate
dhaumann updated the diff for D14978: Add unit test that checks Format data.
  • Simplify code
Tue, Aug 21, 7:25 PM · Frameworks, Kate
cullmann added a comment to D14978: Add unit test that checks Format data.

Given that hl definition is "eaten" during the include cycle, I guess one can just delete it and directly include the other one.

Tue, Aug 21, 7:19 PM · Frameworks, Kate
cullmann added a comment to D14978: Add unit test that checks Format data.

I think the issue is, that if you have just include rules and a context with include rules, you will skip that one context completely during including.
Therefore it is missing in the end result, I assume.

Tue, Aug 21, 7:15 PM · Frameworks, Kate
dhaumann added a comment to D14978: Add unit test that checks Format data.

Yes:

  1. Why don't we see Alert_indent.xml
  2. Is Alert_indent.xml still needed with the new KSyntaxHighlighting framework?
Tue, Aug 21, 7:13 PM · Frameworks, Kate
dhaumann added a reviewer for D14978: Add unit test that checks Format data: vkrause.
Tue, Aug 21, 7:12 PM · Frameworks, Kate
cullmann added a comment to D14978: Add unit test that checks Format data.

Still the question is: why is that not seen in includedDefinitions. That hl ist not at all found, thought it is included.

Tue, Aug 21, 7:10 PM · Frameworks, Kate
dhaumann added a comment to D14978: Add unit test that checks Format data.

From kate.git:

Tue, Aug 21, 7:09 PM · Frameworks, Kate
dhaumann added a comment to D14978: Add unit test that checks Format data.

Interesting: alert_indent.xml has no rules except one IncludeRules (And I am supposed to be the author?!):

Tue, Aug 21, 7:06 PM · Frameworks, Kate
cullmann added a comment to D14978: Add unit test that checks Format data.

Btw., the test is a bit easier to read with:

Tue, Aug 21, 7:02 PM · Frameworks, Kate
dhaumann added a comment to D14978: Add unit test that checks Format data.

What fails here is Jira.xml:

Tue, Aug 21, 7:01 PM · Frameworks, Kate
cullmann added a comment to D14978: Add unit test that checks Format data.

contains 363 Normal Text Alerts_indent is missing.

Tue, Aug 21, 7:00 PM · Frameworks, Kate
dhaumann requested review of D14978: Add unit test that checks Format data.
Tue, Aug 21, 6:38 PM · Frameworks, Kate
cullmann closed D14952: Fix includedDefinitions, handle definition change in context switch.
Tue, Aug 21, 2:42 PM · Frameworks, Framework: Syntax Highlighting, Kate
broulik accepted D14971: Combine display OSD icon files and move to plasma icon theme.
Tue, Aug 21, 2:39 PM · Frameworks
pstefan updated the diff for D14971: Combine display OSD icon files and move to plasma icon theme.
  • changed osd-sbs-right to osd-sbs-sright
Tue, Aug 21, 2:32 PM · Frameworks
pstefan updated the diff for D14971: Combine display OSD icon files and move to plasma icon theme.
  • Modes OSD files out of video.svgz into osd.svgz. Removed the 64-64- prefix.
Tue, Aug 21, 2:23 PM · Frameworks
kfunk added a comment to D11193: Sonnet : use current hunspell API.

Please see concerns on https://phabricator.kde.org/R246:0a96acf251baa5c9dd042d093ab2bf8fcee10502

Tue, Aug 21, 2:19 PM · Frameworks
broulik requested changes to D14971: Combine display OSD icon files and move to plasma icon theme.

File looking good, not really a fan of the new thin lined icon style, but the file must be named osd.svgz (Plasma always uses the part before the first hyphen for lookup)

Tue, Aug 21, 2:15 PM · Frameworks
pstefan updated the diff for D14971: Combine display OSD icon files and move to plasma icon theme.
  • Reverse name change
Tue, Aug 21, 1:52 PM · Frameworks
davidedmundson added a comment to D14946: [DialogShadows] Use 0 offset for disabled borders on Wayland.

Yeah, I'm reviewing that now, it just has a lot of maths to get through :)

Tue, Aug 21, 1:12 PM · Frameworks
zzag added a comment to D14946: [DialogShadows] Use 0 offset for disabled borders on Wayland.

This change depends on D14783.

Tue, Aug 21, 1:10 PM · Frameworks
zzag updated the diff for D14946: [DialogShadows] Use 0 offset for disabled borders on Wayland.

"QMarginsF margins = QMarginsF();" => "QMarginsF margins;"

Tue, Aug 21, 1:06 PM · Frameworks
ngraham requested changes to D14971: Combine display OSD icon files and move to plasma icon theme.

If we rename the icons, we will need to correspondingly change the OSD code itself to use the new names: https://cgit.kde.org/kscreen.git/tree/kded/qml/OsdSelector.qml#n51

Tue, Aug 21, 12:37 PM · Frameworks
pstefan updated the diff for D14971: Combine display OSD icon files and move to plasma icon theme.
  • Moved all OSD icons into video.svgz and renamed some of them.
Tue, Aug 21, 12:29 PM · Frameworks
cullmann closed D14956: avoid any heap allocation for default constructed Format() as used as "invalid".
Tue, Aug 21, 11:57 AM · Frameworks, Kate
vkrause accepted D14956: avoid any heap allocation for default constructed Format() as used as "invalid".

Looks good to me, and is indeed a lot less code.

Tue, Aug 21, 11:52 AM · Frameworks, Kate
cullmann reopened D14952: Fix includedDefinitions, handle definition change in context switch.

I got told that I missed some more ContextSwitch variants.

Tue, Aug 21, 10:42 AM · Frameworks, Framework: Syntax Highlighting, Kate
pstefan abandoned D10937: Retouching of Screen Layout Selection OSD Icons.

Moved to D14971

Tue, Aug 21, 10:40 AM · VDG, Frameworks
pstefan retitled D14971: Combine display OSD icon files and move to plasma icon theme from Combine display OSD icon files and mobe to plasma icon theme to Combine display OSD icon files and move to plasma icon theme.
Tue, Aug 21, 10:40 AM · Frameworks
pstefan added reviewers for D14971: Combine display OSD icon files and move to plasma icon theme: ngraham, VDG.
Tue, Aug 21, 10:39 AM · Frameworks
pstefan requested review of D14971: Combine display OSD icon files and move to plasma icon theme.
Tue, Aug 21, 10:39 AM · Frameworks
cullmann updated the diff for D14956: avoid any heap allocation for default constructed Format() as used as "invalid".

Simpler variant with shared default FormatPrivate.

Tue, Aug 21, 10:37 AM · Frameworks, Kate
davidedmundson accepted D14946: [DialogShadows] Use 0 offset for disabled borders on Wayland.
Tue, Aug 21, 10:34 AM · Frameworks
cullmann added a comment to D14956: avoid any heap allocation for default constructed Format() as used as "invalid".

Hmm, if we go that route, what to do in:

Tue, Aug 21, 10:30 AM · Frameworks, Kate
adridg added a comment to D14927: KConfig: handle directory symlinks correctly..

Sorry, this is getting very confusing:

Tue, Aug 21, 10:26 AM · Frameworks
habacker abandoned D14779: Fix 'kformattest fails with installed kcoreaddons language package'.

superseeded by D14967 (tried to updated this review with arc diff, but forgot to add the annoying --verbatim argument to let phabricator know that I have a changed commit message :-/)

Tue, Aug 21, 8:12 AM · Frameworks
habacker requested review of D14967: Disable loading of translations for kformattest, which was not designed with translations.
Tue, Aug 21, 8:07 AM · Frameworks
habacker requested review of D14966: Added support for disabling the loading of translations.
Tue, Aug 21, 8:02 AM · Build System, Frameworks
habacker added a comment to D14779: Fix 'kformattest fails with installed kcoreaddons language package'.

Thanks for this pointer - with this setting the german translation is not fetched anymore.

Tue, Aug 21, 7:51 AM · Frameworks
nibags updated the summary of D13888: JavaScript: add binaries, fix octals, improve escapes & allow Non-ASCII identifiers.
Tue, Aug 21, 7:27 AM · Frameworks, Kate
nibags updated the diff for D13888: JavaScript: add binaries, fix octals, improve escapes & allow Non-ASCII identifiers.
  • Allow identifiers with Non-ASCII characters
Tue, Aug 21, 7:24 AM · Frameworks, Kate
cullmann added a comment to D14956: avoid any heap allocation for default constructed Format() as used as "invalid".

That looks much nicer an avoids the !d checks, which are tedious.

Tue, Aug 21, 7:19 AM · Frameworks, Kate
vkrause added a comment to D14956: avoid any heap allocation for default constructed Format() as used as "invalid".

That should work, yes.

Tue, Aug 21, 6:57 AM · Frameworks, Kate
nibags changed the edit policy for D13888: JavaScript: add binaries, fix octals, improve escapes & allow Non-ASCII identifiers.
Tue, Aug 21, 6:01 AM · Frameworks, Kate