FrameworksRelease
ActivePublic

Recent Activity

Today

poboiko added inline comments to D16266: [Extractor] Make extractor crash resilient.
Sat, Oct 20, 9:16 AM · Baloo, Frameworks

Yesterday

detlefe added a comment to D8532: [WIP] Restrict file extractor with Seccomp.

Dropping one more comment, in case someone wants to give it a try: Apparmor profile transitions don't work if a seccomp filter has been installed before. This makes it probably rather difficult to integrate DrKonqi into an Apparmor policy.

Fri, Oct 19, 10:55 PM · Baloo, Frameworks
detlefe added a comment to D8532: [WIP] Restrict file extractor with Seccomp.
In D8532#336584, @fvogt wrote:

AFAICT this won't actually protect much - the open DBus socket is enough to execute arbitrary programs.

The best design would be (IMO, not sure how well the current architecture fits) to have a fully sandboxed executable which can only communicate with baloo over a single socket.
Over that socket it receives a (read-only) file descriptor for the to be dissected file and then sends the result to baloo.

Fri, Oct 19, 10:37 PM · Baloo, Frameworks
ngraham requested changes to D15999: Add icons with added background to system.svgz.
Fri, Oct 19, 6:59 PM · Frameworks
ngraham added a comment to D15999: Add icons with added background to system.svgz.

So to recap recent discussions, here are the requested changes:

  • (Required) Create a version of the go-previous icon with this same style, and name it go-previous-translucent
  • (Required) Make the background circle more opaque and/or darker
  • (Optional, your call) experiment with making the symbols a bit smaller inside the background circle, per @filipf's suggestion
Fri, Oct 19, 6:56 PM · Frameworks
bcooksley added a comment to D16299: RFC fallback to dnssd service discovery if smb listDir failed on root.

It might be worth getting in touch with the Samba developers, as I believe they've worked with the people at Microsoft who look after the SMB parts of Windows - and they'd know best what is done in regards to discovery of shares these days.
Turning to Google though, it looks like this is simply broken in current versions of Windows 10 (by default at least) - https://answers.microsoft.com/en-us/windows/forum/windows_10-files/homegroup-removed-how-to-get-network-sharing-work/01277332-2916-4a68-853a-116696b20743

Fri, Oct 19, 6:15 PM · Frameworks, Dolphin
kadabash updated the diff for D16137: Add an option to KConfigDialog to fit page contents horizontally.

Fit page content horizontally *and* vertically

Fri, Oct 19, 6:03 PM · Frameworks
shubham added a comment to D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB) .

@bruns Apart from these, does the code seems sane to you?

Fri, Oct 19, 5:14 PM · Frameworks
bruns added inline comments to D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB) .
Fri, Oct 19, 5:11 PM · Frameworks
shubham updated the diff for D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB) .
Fri, Oct 19, 4:35 PM · Frameworks
shubham added a comment to D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB) .

@ngraham No, please recheck, the check is before the first m_totalSize > m_freeSpace check

Fri, Oct 19, 4:15 PM · Frameworks
zzag accepted D16318: [xdgshell] Add positioner constraint adjustment flag operators.
Fri, Oct 19, 3:45 PM · Frameworks
ngraham added a comment to D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB) .

1ul << 32) -1 needs a comment explaining what it means, for people like me with puny brains. :)

Fri, Oct 19, 3:29 PM · Frameworks
shubham added inline comments to D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB) .
Fri, Oct 19, 3:23 PM · Frameworks
shubham updated the diff for D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB) .

File size limit check for a given file system before (m_totalSize > m_freeSpace) check

Fri, Oct 19, 3:23 PM · Frameworks
sitter added a comment to D16299: RFC fallback to dnssd service discovery if smb listDir failed on root.

It's available as an API, but it is not used to publish shares it seems. In fact, if I am reading Microsoft's arcticle on smb1 correctly then ws-discovery is also not enabled by default. Finding other shares in the network seems simply not supported out of the box. I've gotten a device which has an up to date windows 10, albeit installed before the 2017 Fall update, so it has smb1 still enabled. As expected the discovery service also mentioned in the article isn't started by default. Starting it gives me some ws-discovery chatter on the network.

Fri, Oct 19, 2:14 PM · Frameworks, Dolphin
davidedmundson requested review of D16318: [xdgshell] Add positioner constraint adjustment flag operators.
Fri, Oct 19, 2:12 PM · Frameworks
ngraham added reviewers for D15645: Add scheme selection menu with a "System" entry.: broulik, cfeck, elvisangelaccio.
Fri, Oct 19, 1:47 PM · Frameworks
amhndu added a comment to D15645: Add scheme selection menu with a "System" entry..

Ping. Can someone please review ?

Fri, Oct 19, 1:46 PM · Frameworks
ngraham added a comment to D16299: RFC fallback to dnssd service discovery if smb listDir failed on root.

What I'd really like to know is if windows 10 actually has dnssd nowadays, and if it is enabled by default, and whether smb is published if/when dnssd is enabled.

Fri, Oct 19, 12:39 PM · Frameworks, Dolphin
thsurrel closed D16313: Use QMenu::addSeparator.
Fri, Oct 19, 12:04 PM · Frameworks
broulik accepted D16313: Use QMenu::addSeparator.
Fri, Oct 19, 12:02 PM · Frameworks
thsurrel requested review of D16313: Use QMenu::addSeparator.
Fri, Oct 19, 11:41 AM · Frameworks
apol added a comment to D16301: Remove ComponentInstaller.

FWIW my +1 is to removing it. The Appstream assessment is all right but fixing something nobody uses sounds like a waste of time. :P

Fri, Oct 19, 11:36 AM · Frameworks
bruns added a reviewer for D16166: Pass the FileIndexerConfig as const to the individual indexers: dfaure.
Fri, Oct 19, 10:55 AM · Baloo, Frameworks
broulik retitled D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob from [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob to RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob.
Fri, Oct 19, 10:54 AM · Frameworks
broulik requested review of D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob.
Fri, Oct 19, 10:54 AM · Frameworks
bruns closed D16306: [Codecs] Remove unneeded const_cast.
Fri, Oct 19, 10:54 AM · Baloo, Frameworks
sitter added a comment to D16299: RFC fallback to dnssd service discovery if smb listDir failed on root.

Done some research on ws-discovery. gsoap is the only free c implementation I could find. There are some python, js and java implementations but they'll probably not help us nearly as much (unless someone wants to write a daemon or helper binary to bridge the language divide without much hassle). Alternative approach would be writing our own implementation using KDAB's kdsoap library, but then that'd need a maintainer which I am confident we don't have :)

Fri, Oct 19, 9:43 AM · Frameworks, Dolphin
broulik added a comment to D16301: Remove ComponentInstaller.

Method InstallPackages

Fri, Oct 19, 7:26 AM · Frameworks
dfaure accepted D16306: [Codecs] Remove unneeded const_cast.
Fri, Oct 19, 7:25 AM · Baloo, Frameworks
mlaurent added a reviewer for D16306: [Codecs] Remove unneeded const_cast: dfaure.
Fri, Oct 19, 6:06 AM · Baloo, Frameworks
ngraham added a comment to D16299: RFC fallback to dnssd service discovery if smb listDir failed on root.

FWIW, in practice the workgroup is much less prominent to even unnecessary in a macOS or Linux shared file environment. I've only ever seen shares on multiple workgroups used in a Windows environment.

Fri, Oct 19, 4:42 AM · Frameworks, Dolphin
ngraham added a comment to D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB) .

Tested this out and couldn't actually make it work the way I asked--with the FAT32 file size limit checked first. I think I see why: there are two total size > available space? checks that output ERR_DISK_FULL on error, and both of them execute first. The FAT32 file size limit check should be before the first one, probably near // Stat the next src url.

Fri, Oct 19, 3:35 AM · Frameworks

Thu, Oct 18

apol added a comment to D16301: Remove ComponentInstaller.

+1

Thu, Oct 18, 11:40 PM · Frameworks
bruns requested review of D16306: [Codecs] Remove unneeded const_cast.
Thu, Oct 18, 11:20 PM · Baloo, Frameworks
bruns added inline comments to D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB) .
Thu, Oct 18, 9:24 PM · Frameworks
bruns added inline comments to D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB) .
Thu, Oct 18, 9:19 PM · Frameworks
dhaumann added a comment to D16300: Remove double underscore (__) from header include guards.

Qt decided against #pragma once. I wouldn't want to use it in KDE unless it is decided on kde-frameworks-devel.

Thu, Oct 18, 9:07 PM · Frameworks, Kate
cfeck added inline comments to D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB) .
Thu, Oct 18, 9:03 PM · Frameworks
ngraham added inline comments to D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB) .
Thu, Oct 18, 8:58 PM · Frameworks
bruns added inline comments to D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB) .
Thu, Oct 18, 8:47 PM · Frameworks
ngraham added inline comments to D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB) .
Thu, Oct 18, 8:01 PM · Frameworks
ngraham added a comment to D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB) .

Thank you for indulging me 😊

Thu, Oct 18, 7:59 PM · Frameworks
shubham updated the diff for D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB) .
Thu, Oct 18, 7:55 PM · Frameworks
ngraham added a comment to D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB) .

Thanks, this is looking better. I will test it out later.

Thu, Oct 18, 7:35 PM · Frameworks
shubham updated the diff for D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB) .

Cache file system time instead of creating it every time

Thu, Oct 18, 7:05 PM · Frameworks
fvogt requested review of D16305: Add a QIconEnginePlugin to allow QIcon deserialization.
Thu, Oct 18, 6:48 PM · Frameworks
bruns added a comment to D16301: Remove ComponentInstaller.

Method InstallPackages

Thu, Oct 18, 6:47 PM · Frameworks
ngraham added a comment to D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB) .

Maybe we could cache the value of KFileSystemType::fileSystemType() somewhere so we don't need to calculate it again for every file, since it's the same for every one.

Thu, Oct 18, 6:42 PM · Frameworks