FrameworksRelease
ActivePublic

Recent Activity

Yesterday

mschiller added a comment to D20169: Add profile support interface for TerminalInterface.

wrt getProfilePath: what if an application does not store a profile as single filename, for example as directory, or even stored e.g. in a DB? maybe it would be better to have this as property of a profile

Yeah Konsole Profiles seem to already have a path property in the profile implementation. So gonna remove this.

Sun, Apr 21, 9:06 PM · Frameworks
ngraham accepted D20695: Add more icon sizes for audio, configure, distribute.

Looks great, thanks!

Sun, Apr 21, 8:31 PM · Frameworks
pino added a comment to D20169: Add profile support interface for TerminalInterface.

General notes on the API (not a konsole developer though):

  • an abstract virtual destructor is needed
  • in kdelibs/kf5 lingo, the "get" as prefix of API getters is generally not used
  • setCurrentProfile instead of changeCurrentProfile? the latter makes me think it does changes to the current profile, rather than setting another profile as current
  • wrt changeCurrentProfile: what will it do if the specified profile name does not exist? should the API return true/false to indicate the switch actually succeeded?
  • wrt getProfilePath: what if an application does not store a profile as single filename, for example as directory, or even stored e.g. in a DB? maybe it would be better to have this as property of a profile
  • is a setProfileProperty worth having?
  • is an API to list the available properties worth having?
Sun, Apr 21, 7:38 PM · Frameworks
GB_2 closed D20536: Use consistent default Kickoff user icon.
Sun, Apr 21, 7:28 PM · Frameworks
GB_2 updated the diff for D20536: Use consistent default Kickoff user icon.

Fix diff

Sun, Apr 21, 7:26 PM · Frameworks
ngraham added a comment to D20700: Add "edit-remove" icon symlink.

Yeah, I think the current minus icon is similar in that it's only meaningful next to a plus sign. So if we had a user interface with conjoined or adjacent plus and minus buttons, using that icon would make sense. But for removing a specific list item, I think this "X-style" icon is better. The trash can icon has a connotation of "this thing will be destroyed" that only applies to some list item removals.

Sun, Apr 21, 7:19 PM · Frameworks
mschiller updated the diff for D20169: Add profile support interface for TerminalInterface.

Move the profile support to different class

Sun, Apr 21, 6:47 PM · Frameworks
ngraham added a comment to D20708: Change input-* device icon styles, add 16px icons.

Overall very nice.

Sun, Apr 21, 6:42 PM · Frameworks
pino added a comment to D20169: Add profile support interface for TerminalInterface.

Yes, this change breaks the binary compatibility. Please add a TerminalInterfaceV2 that inherits TerminalInterface instead, or add a separate interface for profile handling.

Sun, Apr 21, 6:38 PM · Frameworks
mschiller updated the summary of D20169: Add profile support interface for TerminalInterface.
Sun, Apr 21, 6:35 PM · Frameworks
GB_2 added a comment to D20700: Add "edit-remove" icon symlink.

We have a problem where we don't use consistent iconography for "remove". Sometimes it's a normal minus, sometimes it's a red minus, sometimes it's a red X and sometimes it's a red trash can (the line between "delete" and "remove" can be blurry). I think adding an edit-remove icon would likely cause more confusion, first for developers and then for users. I don't think using a minus without a plus is a problem, but perhaps the minus should be made red?

Sun, Apr 21, 5:30 PM · Frameworks
ndavis added a comment to D20700: Add "edit-remove" icon symlink.
In D20700#453565, @GB_2 wrote:

list-remove is just a minus icon, which has no context and looks weird when used alone, without list-add next to it. An example where the new icon can be used is D20576.

Sun, Apr 21, 4:25 PM · Frameworks
aacid closed D20702: KTar: Protect against negative longlink sizes.
Sun, Apr 21, 4:08 PM · Frameworks
ndavis updated the test plan for D20708: Change input-* device icon styles, add 16px icons.
Sun, Apr 21, 1:17 PM · Frameworks
ndavis requested review of D20708: Change input-* device icon styles, add 16px icons.
Sun, Apr 21, 1:13 PM · Frameworks
GB_2 added a comment to D20700: Add "edit-remove" icon symlink.

Why does list-remove need an alternative?

Sun, Apr 21, 12:35 PM · Frameworks
ndavis added a comment to D20700: Add "edit-remove" icon symlink.

Why does list-remove need an alternative?

Sun, Apr 21, 12:22 PM · Frameworks
apol accepted D20702: KTar: Protect against negative longlink sizes.
Sun, Apr 21, 12:02 PM · Frameworks
GB_2 updated the summary of D20700: Add "edit-remove" icon symlink.
Sun, Apr 21, 10:59 AM · Frameworks
GB_2 retitled D20700: Add "edit-remove" icon symlink from Add "edit-remove" icon to Add "edit-remove" icon symlink.
Sun, Apr 21, 10:56 AM · Frameworks
GB_2 updated the diff for D20700: Add "edit-remove" icon symlink.

Use symlinks: edit-remove -> paint-none

Sun, Apr 21, 10:56 AM · Frameworks
loh.tar added a comment to D20264: Add test for "Auto Reload Document" option.

@dhaumann asked elsewhere

Sun, Apr 21, 9:18 AM · Frameworks, Kate
loh.tar updated the diff for D20697: Review IconBorder.
  • Fix missing printed background in proper theme color
  • Fix scroll past end of document
  • Fix less pushy paint unfolded icon in not dark themes and don't try to use currentLineNumberColor, the folded icon gets also not highligted
  • Some more cosmetic

Sun, Apr 21, 7:00 AM · Frameworks, Kate

Sat, Apr 20

dhaumann accepted D20697: Review IconBorder.

I like the visual change, let's give it a try. Thanks!

Sat, Apr 20, 11:35 PM · Frameworks, Kate
GB_2 added a comment to D20700: Add "edit-remove" icon symlink.

Oops, forgot that paint-none already exists, which looks like this. I will just make a symlink then.

Sat, Apr 20, 9:37 PM · Frameworks
aacid requested review of D20702: KTar: Protect against negative longlink sizes.
Sat, Apr 20, 8:20 PM · Frameworks
GB_2 updated the summary of D20700: Add "edit-remove" icon symlink.
Sat, Apr 20, 6:40 PM · Frameworks
GB_2 requested review of D20700: Add "edit-remove" icon symlink.
Sat, Apr 20, 6:39 PM · Frameworks
yurikoles added a comment to D20691: Fix no member named 'setTime_t' in 'QDateTime' error while building.

How about issuing a minor release?

Sat, Apr 20, 6:00 PM · Frameworks
shubham closed D20691: Fix no member named 'setTime_t' in 'QDateTime' error while building.
Sat, Apr 20, 2:22 PM · Frameworks
elvisangelaccio resigned from D20691: Fix no member named 'setTime_t' in 'QDateTime' error while building.
Sat, Apr 20, 1:57 PM · Frameworks
shubham updated the diff for D20691: Fix no member named 'setTime_t' in 'QDateTime' error while building.

Fix unintentional mode change

Sat, Apr 20, 1:49 PM · Frameworks
loh.tar updated the test plan for D20697: Review IconBorder.
Sat, Apr 20, 12:34 PM · Frameworks, Kate
loh.tar requested review of D20697: Review IconBorder.
Sat, Apr 20, 12:29 PM · Frameworks, Kate
loh.tar abandoned D20565: Ensure not to fold the end marker.

Patch is part of D20606

Sat, Apr 20, 11:31 AM · Frameworks, Kate
loh.tar closed D20606: Add action to toggle folding of child ranges.
Sat, Apr 20, 11:27 AM · Frameworks, Kate
loh.tar closed D20264: Add test for "Auto Reload Document" option.
Sat, Apr 20, 11:27 AM · Frameworks, Kate
ndavis updated the diff for D20695: Add more icon sizes for audio, configure, distribute.

Fix 16-16-audio-volume-muted

Sat, Apr 20, 11:03 AM · Frameworks
ndavis updated the test plan for D20695: Add more icon sizes for audio, configure, distribute.
Sat, Apr 20, 11:02 AM · Frameworks
meven added a comment to D20694: Use regular stat when resolving a symlink.

I fixed them ;-)

Sat, Apr 20, 11:02 AM · Frameworks
ndavis updated the test plan for D20695: Add more icon sizes for audio, configure, distribute.
Sat, Apr 20, 10:57 AM · Frameworks
ndavis updated the diff for D20695: Add more icon sizes for audio, configure, distribute.

Add 16px audio icons

Sat, Apr 20, 10:56 AM · Frameworks
dfaure added a comment to D20694: Use regular stat when resolving a symlink.

I fixed them ;-)

Sat, Apr 20, 10:49 AM · Frameworks
elvisangelaccio requested changes to D20691: Fix no member named 'setTime_t' in 'QDateTime' error while building.

Please revert the mode change to Messages.sh

Sat, Apr 20, 10:46 AM · Frameworks
ndavis planned changes to D20695: Add more icon sizes for audio, configure, distribute.

Oops, looks like I need 16px audio icons as well for the volume/mute icons inside the opened audio widget.

Sat, Apr 20, 10:37 AM · Frameworks
meven added a comment to D20694: Use regular stat when resolving a symlink.

Regressions are fixed :
https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/95/testReport/junit/projectroot/autotests/kiowidgets_kdirmodeltest/history/
https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/87/testReport/junit/projectroot/autotests/kiocore_jobtest/history/

Sat, Apr 20, 10:37 AM · Frameworks
ndavis updated the test plan for D20695: Add more icon sizes for audio, configure, distribute.
Sat, Apr 20, 10:22 AM · Frameworks
ndavis requested review of D20695: Add more icon sizes for audio, configure, distribute.
Sat, Apr 20, 10:19 AM · Frameworks
meven added a comment to D20694: Use regular stat when resolving a symlink.

https://build.kde.org/view/OS - Windows/job/Frameworks/job/kio/job/kf5-qt5 SUSEQt5.10/95 Will confirm if this is fixed.

Sat, Apr 20, 10:19 AM · Frameworks
meven closed D20694: Use regular stat when resolving a symlink.
Sat, Apr 20, 10:17 AM · Frameworks