@kossebau - you have pushed commits depending on this change to several repositories, sometimes without waiting for acceptance, sometimes even bypassing Phabricator review completely.
Keep only matters for further calls to openUrl, not the first one. It's about whether to *add* or *replace* the currently open URL.
KDirModel takes care of that.
Ok, let's land that.
I think this should go in now. I think the usage of the API is correct even for HiDPI.
In KF6, we should just fold that interface into the main class.
Ok, makes sense, will increase version myself.
Thanks for the update!
Nice! Thanks for the improvements ;=)
- Media controller is fine now
- Pin on systray popup is fine
- buttons in NM applet are fine
Much better. Since nobody has input on the deprecations I guess they must be alright. Do have a look into using QDBusError::InvalidArgs before landing though.
Ok, I found one of the "implications". With model->dirLister()->openUrl(m_initURL, KDirLister::Keep); I can list KIO urls like remote:, font:, and applications:, but with model->openUrl(m_initURL, KDirModel::ShowRoot); I cannot, and only seems to display the the local filesystem (specifically it lists "/"). I can probably work around it, but just wanted to pass that info along. I think it would be great if the "root" could be shown for these as well.
Tested on patched KF5 5.64, on Fedora 30 (32bit)... root node shows up! I had to change the call in my code that was originally:
Will do on Sunday (after tagging)
Well, this patch is more or less complete but it doesn't make sense to be deployed without batch operations from KIO as it would spawn a job for each file to be renamed.
@emateli are you going to be able to finish this? Should someone take over? It would be a shame for such great work to get stalled so close to the finish line.
Hum. OK. Weird.
Let's get this in. Can you please give me your full name and email address so I can merge this?
Looks good on khotnewstuff-dialog. Thanks!