FrameworksRelease
ActivePublic

Recent Activity

Today

ngraham added a comment to D13643: Add LabPlot project file icon.

Icon patches always need screenshots! :)

Thu, Jun 21, 1:00 PM · Frameworks, Breeze
anthonyfieroni added inline comments to D13627: [KIconThemes] Isolate private data from race conditions.
Thu, Jun 21, 11:26 AM · Frameworks
anthonyfieroni added inline comments to D13627: [KIconThemes] Isolate private data from race conditions.
Thu, Jun 21, 11:24 AM · Frameworks
dfaure requested changes to D13627: [KIconThemes] Isolate private data from race conditions.

This is the wrong approach for thread safety (wrong level of locking). It should come with a multithreaded unittest so it can be checked for safety (with clang+tsan for instance). And yes the concept overall seems wrong anyway as QIcon isn't threadsafe in the first place, AFAIK.

Thu, Jun 21, 11:01 AM · Frameworks
mmustac added a comment to D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu.

@dfaure Can you commit these changes as I don't have the access to ?

Thu, Jun 21, 9:51 AM · Frameworks
lueck closed D13226: update trash docbook to 5.48.
Thu, Jun 21, 7:24 AM · Documentation, Frameworks
lbeltrame accepted D13641: [KCharSelect] Port generate-datafile.py to Python 3.
Thu, Jun 21, 4:44 AM · Frameworks
mtrescott requested review of D13643: Add LabPlot project file icon.
Thu, Jun 21, 2:02 AM · Frameworks, Breeze
smithjd updated the diff for D11529: Balooctl: Deindex unfound files with check command..

Rebase

Thu, Jun 21, 1:20 AM · Baloo, Frameworks
smithjd edited dependencies for D11529: Balooctl: Deindex unfound files with check command., added: 1; removed: 1.
Thu, Jun 21, 1:20 AM · Baloo, Frameworks
smithjd removed a dependent revision for D13216: Overhaul the file index scheduler.: D11529: Balooctl: Deindex unfound files with check command..
Thu, Jun 21, 1:20 AM · Baloo, Frameworks
smithjd added a dependent revision for D13424: Run a file changed check when the file watches are updated.: D11529: Balooctl: Deindex unfound files with check command..
Thu, Jun 21, 1:20 AM · Baloo, Frameworks
smithjd updated the diff for D13424: Run a file changed check when the file watches are updated..
  • Remove a fixme.
Thu, Jun 21, 1:08 AM · Baloo, Frameworks
smithjd edited dependencies for D13424: Run a file changed check when the file watches are updated., added: 1; removed: 1.
Thu, Jun 21, 1:06 AM · Baloo, Frameworks
smithjd removed a dependent revision for D13216: Overhaul the file index scheduler.: D13424: Run a file changed check when the file watches are updated..
Thu, Jun 21, 1:06 AM · Baloo, Frameworks
smithjd added a dependent revision for D13425: file indexer closing inprovements.: D13424: Run a file changed check when the file watches are updated..
Thu, Jun 21, 1:06 AM · Baloo, Frameworks
smithjd removed a dependent revision for D13424: Run a file changed check when the file watches are updated.: D13425: file indexer closing inprovements..
Thu, Jun 21, 1:05 AM · Baloo, Frameworks
smithjd removed a dependency for D13425: file indexer closing inprovements.: D13424: Run a file changed check when the file watches are updated..
Thu, Jun 21, 1:05 AM · Baloo, Frameworks
smithjd updated the diff for D13216: Overhaul the file index scheduler..
  • Re-write the the file index scheduler.
  • Update the balooctl tool with the changed suspend/resume behaviour.
Thu, Jun 21, 1:05 AM · Baloo, Frameworks
smithjd updated the diff for D13425: file indexer closing inprovements..

Consolidate file indexer close changes into a single review.

Thu, Jun 21, 1:03 AM · Baloo, Frameworks
smithjd updated the summary of D13425: file indexer closing inprovements..
Thu, Jun 21, 1:02 AM · Baloo, Frameworks
smithjd retitled D13424: Run a file changed check when the file watches are updated. from On config change halt the file indexer and run a file changed check when the file watches are updated. to Run a file changed check when the file watches are updated..
Thu, Jun 21, 1:00 AM · Baloo, Frameworks
smithjd updated the diff for D13424: Run a file changed check when the file watches are updated..

Run a full check for unindexed files when the watches are installed.

Thu, Jun 21, 1:00 AM · Baloo, Frameworks

Yesterday

cfeck requested review of D13641: [KCharSelect] Port generate-datafile.py to Python 3.
Wed, Jun 20, 11:03 PM · Frameworks
varlesh closed D13636: add icons for Keyboard Indicator #T9050.
Wed, Jun 20, 8:08 PM · Frameworks
varlesh closed T9050: Icons for Keyboard Indicator as Resolved by committing R114:05b0efa3d97c: New icons for Keyboard Indicator Closes T9050.
Wed, Jun 20, 8:05 PM · VDG, Frameworks
astippich added a comment to D12320: add ability to read embedded cover files.

sorry for the caused inconvenience

Wed, Jun 20, 7:37 PM · Baloo, Frameworks
varlesh added a comment to T9050: Icons for Keyboard Indicator.

Please anybody push this patchs D13636 & D13637 ... i'm lost SSH-key :(

Wed, Jun 20, 7:32 PM · VDG, Frameworks
bcooksley added a comment to D12320: add ability to read embedded cover files.

Thanks for sorting that out.

Wed, Jun 20, 7:11 PM · Baloo, Frameworks
varlesh added a comment to T9050: Icons for Keyboard Indicator.

Ok!

Wed, Jun 20, 7:11 PM · VDG, Frameworks
ngraham added a comment to T9050: Icons for Keyboard Indicator.

Thanks for the patches! You can add Closes T9050 to one of those to make it automatically close this ticket once it's landed.

Wed, Jun 20, 7:09 PM · VDG, Frameworks
varlesh added a comment to T9050: Icons for Keyboard Indicator.

patch icon name https://phabricator.kde.org/D13637

Wed, Jun 20, 7:05 PM · VDG, Frameworks
varlesh added a comment to T9050: Icons for Keyboard Indicator.

patch plasma theme icons: https://phabricator.kde.org/D13636

Wed, Jun 20, 6:59 PM · VDG, Frameworks
varlesh requested review of D13636: add icons for Keyboard Indicator #T9050.
Wed, Jun 20, 6:56 PM · Frameworks
vkrause requested review of D13635: Fixes for Java comments.
Wed, Jun 20, 6:47 PM · Frameworks
varlesh created T9050: Icons for Keyboard Indicator.
Wed, Jun 20, 6:34 PM · VDG, Frameworks
zzag added a comment to D13402: FrameSvg: Simplify updateSizes.

Ping.

Wed, Jun 20, 4:47 PM · Frameworks
zzag added a comment to D13384: FrameSvg: Do not wreck shared mask frames.

Ping.

Wed, Jun 20, 4:46 PM · Frameworks
zzag added a comment to D13496: FrameSvg: Update mask frame if image path has been changed.

Ping.

Wed, Jun 20, 4:46 PM · Frameworks
mgallien closed D13630: automatic tests: do not embed EmbeddedImageData already in the library.
Wed, Jun 20, 2:44 PM · Baloo, Frameworks
dfaure accepted D13630: automatic tests: do not embed EmbeddedImageData already in the library.
Wed, Jun 20, 2:33 PM · Baloo, Frameworks
mgallien added a comment to D12320: add ability to read embedded cover files.

D13630 should fix the Windows build. Sorry for not noticing this before. I was mostly away from keyboard for the last two weeks after having been sick.

Wed, Jun 20, 12:47 PM · Baloo, Frameworks
mgallien requested review of D13630: automatic tests: do not embed EmbeddedImageData already in the library.
Wed, Jun 20, 12:45 PM · Baloo, Frameworks
anthonyfieroni added a comment to D13627: [KIconThemes] Isolate private data from race conditions.

@davidedmundson i don't have much time to test right now, so that's why my reviews looks like *guessing*. I want to know you a sure that loadIcon is called safety, so maybe dbus notifier

connect(s_globalData, &KIconLoaderGlobalData::iconChanged, this, &KIconLoaderPrivate::_k_refreshIcons, Qt::QueuedConnection);
Wed, Jun 20, 11:02 AM · Frameworks
bcooksley updated subscribers of D12320: add ability to read embedded cover files.

This change broke the build on Windows, which due to the CI notification being ignored has now become a maintainability issue.
The failure log can be found at https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20WindowsMSVCQt5.10/33/consoleText

Wed, Jun 20, 10:09 AM · Baloo, Frameworks
davidedmundson added a comment to D13627: [KIconThemes] Isolate private data from race conditions.

It looks like to KIconLoader::loadIcon is called from multiple threads, but i'm not sure

Wed, Jun 20, 8:30 AM · Frameworks
anthonyfieroni requested review of D13627: [KIconThemes] Isolate private data from race conditions.
Wed, Jun 20, 8:18 AM · Frameworks

Tue, Jun 19

apol added a comment to D13043: Properly sanitize input.

Yep, this was from the old and deprecated modeltest.cpp.

Tue, Jun 19, 11:14 PM · Frameworks
ngraham closed D13554: [Properties dialog] Make all field values on general tab selectable.
Tue, Jun 19, 10:29 PM · Frameworks
kossebau added a comment to D13622: Remove unused entry X-KDE-DBus-ModuleName from kded plugins' metadata.

Note: kcoreaddons, baloo, kservice/autotests, and kdelibs4support mention this key too, you can clean it all up ;)

Tue, Jun 19, 10:21 PM · Frameworks