KDE PIMProject
ActivePublic

Details

Description

KDE Personal Information Management

Recent Activity

Yesterday

knauss updated the diff for D20757: Test mails for Decryption Oracle based on replying to PGP or S/MIME..
  • MimeTreeParser returns wrong content for inline mesasges with multiple encrypted blocks.
  • TemplateParser: test htmlReply.
Tue, Apr 23, 10:26 PM · KDE PIM
knauss updated the summary of D20757: Test mails for Decryption Oracle based on replying to PGP or S/MIME..
Tue, Apr 23, 10:20 PM · KDE PIM
knauss updated the summary of D20757: Test mails for Decryption Oracle based on replying to PGP or S/MIME..
Tue, Apr 23, 3:34 PM · KDE PIM
knauss updated the diff for D20757: Test mails for Decryption Oracle based on replying to PGP or S/MIME..
  • Add test for a normal encrypted message, to make sure decryption works.
  • templateparserjobtest: HTML mime parts are handled differently
  • WIP: Decryption Oracle is also possible with PGP inline.
Tue, Apr 23, 3:27 PM · KDE PIM
knauss requested review of D20770: Remove unused ObjectTreeParser::copyContentFrom..
Tue, Apr 23, 3:19 PM · KDE PIM
knauss closed D20755: Refresh TemplateParserJobTest::test_convertedHtml logic.
Tue, Apr 23, 2:12 PM · KDE PIM
knauss closed D20754: Unique names for test rows..
Tue, Apr 23, 2:12 PM · KDE PIM
knauss closed D20753: enable TemplateParserJobTest::test_replyPlain again..
Tue, Apr 23, 2:12 PM · KDE PIM
knauss added a comment to D20757: Test mails for Decryption Oracle based on replying to PGP or S/MIME..

This makes sense I think (and should go in IMHO), but I'm not sure if it is complete to cover all of bug 404698.

  • Do we need to be concerned about forwarding (which does include attachments AFAIK)?

make sense, yes.

Tue, Apr 23, 2:04 PM · KDE PIM
knauss added a comment to D20757: Test mails for Decryption Oracle based on replying to PGP or S/MIME..

Sorry if this is a stupid question :D

But does this test make sense?

I mean how is the test supposed to decrypt the encrypted part of it? How does it know the keys/password/whatever to decrypt it?

Tue, Apr 23, 1:52 PM · KDE PIM
knauss updated the summary of D20750: Move most of UnencryptedMessageTest tests to MimeTreeParser..
Tue, Apr 23, 1:42 PM · KDE PIM
knauss added a comment to D20750: Move most of UnencryptedMessageTest tests to MimeTreeParser..

This is git logic, that it defines this as a copy. And I think git it more or less right, as we can't move every tests because some tests need MessageViewer::BufferedHtmlWriter. Only

Tue, Apr 23, 1:41 PM · KDE PIM
knauss updated the diff for D20750: Move most of UnencryptedMessageTest tests to MimeTreeParser..

update description.

Tue, Apr 23, 1:41 PM · KDE PIM
mlaurent added a comment to D20734: Fix No such slot KPIM::TagSelectionCombo::updateCheckedItems.

Hi,
Did you test on korganizer if it works ?
Here when you try to select a tag it crashs.

Tue, Apr 23, 10:25 AM · KDE PIM
dvratil added inline comments to D20734: Fix No such slot KPIM::TagSelectionCombo::updateCheckedItems.
Tue, Apr 23, 10:14 AM · KDE PIM
vkrause added a comment to D20757: Test mails for Decryption Oracle based on replying to PGP or S/MIME..

This makes sense I think (and should go in IMHO), but I'm not sure if it is complete to cover all of bug 404698.

  • Do we need to be concerned about forwarding (which does include attachments AFAIK)?
  • Do we need to consider inline PGP? That is, have the encrypted part you want to leak in the main body?
Tue, Apr 23, 9:38 AM · KDE PIM
dvratil added inline comments to D20714: akonadi: fix some clazy warnings.
Tue, Apr 23, 9:33 AM · KDE PIM
mlaurent accepted D20755: Refresh TemplateParserJobTest::test_convertedHtml logic.
Tue, Apr 23, 4:58 AM · KDE PIM
mlaurent accepted D20754: Unique names for test rows..
Tue, Apr 23, 4:57 AM · KDE PIM
mlaurent accepted D20753: enable TemplateParserJobTest::test_replyPlain again..
Tue, Apr 23, 4:57 AM · KDE PIM
mlaurent accepted D20751: Add tests for ObjectTreeParser::htmlContent..
Tue, Apr 23, 4:56 AM · KDE PIM
mlaurent requested changes to D20750: Move most of UnencryptedMessageTest tests to MimeTreeParser..

"Move tests from MessageViewer to MimeTreeParser." it's a moving or a copying ?
It seems that it's a copying no ?
Perhaps it's needed to change title

Tue, Apr 23, 4:55 AM · KDE PIM

Mon, Apr 22

aacid added a comment to D20757: Test mails for Decryption Oracle based on replying to PGP or S/MIME..

Sorry if this is a stupid question :D

Mon, Apr 22, 10:23 PM · KDE PIM
knauss added a comment to D20757: Test mails for Decryption Oracle based on replying to PGP or S/MIME..

So these pass? There's no bug?

Mon, Apr 22, 9:24 PM · KDE PIM
knauss added a dependent revision for D20753: enable TemplateParserJobTest::test_replyPlain again.: D20757: Test mails for Decryption Oracle based on replying to PGP or S/MIME..
Mon, Apr 22, 9:22 PM · KDE PIM
knauss added a dependency for D20757: Test mails for Decryption Oracle based on replying to PGP or S/MIME.: D20753: enable TemplateParserJobTest::test_replyPlain again..
Mon, Apr 22, 9:22 PM · KDE PIM
dfaure added a comment to D20757: Test mails for Decryption Oracle based on replying to PGP or S/MIME..

So these pass? There's no bug?

Mon, Apr 22, 9:19 PM · KDE PIM
knauss requested review of D20757: Test mails for Decryption Oracle based on replying to PGP or S/MIME..
Mon, Apr 22, 8:51 PM · KDE PIM
knauss requested review of D20756: Distinguish between mMsg and mOrigMsg..
Mon, Apr 22, 8:49 PM · KDE PIM
knauss requested review of D20755: Refresh TemplateParserJobTest::test_convertedHtml logic.
Mon, Apr 22, 8:49 PM · KDE PIM
knauss requested review of D20754: Unique names for test rows..
Mon, Apr 22, 8:48 PM · KDE PIM
knauss requested review of D20753: enable TemplateParserJobTest::test_replyPlain again..
Mon, Apr 22, 8:48 PM · KDE PIM
knauss requested review of D20751: Add tests for ObjectTreeParser::htmlContent..
Mon, Apr 22, 8:48 PM · KDE PIM
knauss requested review of D20750: Move most of UnencryptedMessageTest tests to MimeTreeParser..
Mon, Apr 22, 8:48 PM · KDE PIM
ognarb added a reviewer for D20734: Fix No such slot KPIM::TagSelectionCombo::updateCheckedItems: KDE PIM.
Mon, Apr 22, 11:52 AM · KDE PIM
ognarb updated the diff for D20734: Fix No such slot KPIM::TagSelectionCombo::updateCheckedItems.

Improve doc

Mon, Apr 22, 11:52 AM · KDE PIM
ognarb requested review of D20734: Fix No such slot KPIM::TagSelectionCombo::updateCheckedItems.
Mon, Apr 22, 11:51 AM · KDE PIM
vkrause requested review of D20728: Adapt to printing model changes.
Mon, Apr 22, 10:15 AM · KDE PIM
vkrause requested review of D20727: Port Grantlee contact printing model to KContacts::Addressee too.
Mon, Apr 22, 10:15 AM · KDE PIM
vkrause closed D20719: Adjust to Grantlee model changes, and extract template i18n messages.
Mon, Apr 22, 9:23 AM · KDE PIM
vkrause closed D20718: Port addressee model for the Grantlee formatter to KContacts::Addressee.
Mon, Apr 22, 9:18 AM · KDE PIM
vkrause closed D20717: Enable KDE localization and icon integration in Grantlee.
Mon, Apr 22, 9:06 AM · KDE PIM
vkrause closed D20711: Port to new KContacts API for accessing common extension values.
Mon, Apr 22, 8:28 AM · KDE PIM
vkrause closed D20710: Use phone number normalization from KContacts.
Mon, Apr 22, 8:27 AM · KDE PIM
vkrause closed D20712: Use new KContacts API for editing URL type and preferrence.
Mon, Apr 22, 8:25 AM · KDE PIM
mlaurent accepted D20706: Make IMPP more compliant with RFC 4770/ RFC 6350.
Mon, Apr 22, 7:31 AM · KDE PIM
mlaurent accepted D20705: Add IM protocol information and protocol listing.
Mon, Apr 22, 7:29 AM · KDE PIM
mlaurent accepted D20710: Use phone number normalization from KContacts.
Mon, Apr 22, 7:28 AM · KDE PIM
mlaurent accepted D20711: Port to new KContacts API for accessing common extension values.
Mon, Apr 22, 7:28 AM · KDE PIM
mlaurent accepted D20712: Use new KContacts API for editing URL type and preferrence.
Mon, Apr 22, 7:28 AM · KDE PIM