KDE PIMProject
ActivePublic

Details

Description

KDE Personal Information Management

Recent Activity

Today

andreylegayev added a comment to D28495: [Kleopatra] Add support of timestamp to logging.

knauss - thanks for hint.
I've tried to set system environment variable in Win10 - as I see it did not affect log message format.
I'll try to debug it.

Thu, Apr 2, 11:13 AM · KDE PIM
knauss added a comment to D28495: [Kleopatra] Add support of timestamp to logging.

Can't https://doc.qt.io/qt-5/qtglobal.html#qSetMessagePattern used? If Kleopatra using "normal" qtlogging you can easily test if you set the environmental variable QT_MESSAGE_PATTERN to print timestamps something like:
QT_MESSAGE_PATTERN="[%{time yyyyMMdd h:mm:ss.zzz t} - %{if-category}%{category}: %{endif} - %{file}:%{line} - %{message}

Thu, Apr 2, 9:43 AM · KDE PIM
mlaurent added a reviewer for D28495: [Kleopatra] Add support of timestamp to logging: aheinecke.
Thu, Apr 2, 4:49 AM · KDE PIM

Yesterday

andreylegayev retitled D28495: [Kleopatra] Add support of timestamp to logging from Add support of timestamp to logging to [Kleopatra] Add support of timestamp to logging.
Wed, Apr 1, 8:41 PM · KDE PIM
andreylegayev requested review of D28495: [Kleopatra] Add support of timestamp to logging.
Wed, Apr 1, 8:23 PM · KDE PIM

Tue, Mar 31

dvratil added a comment to T9416: [KAddressbook] Improve the contacts list.

The underlying data model is Akonadi::ContactsTreeModel which is subclass of Akonadi::EntityTreeModel. Thus, if you have a QModelIndex, you can use the data() function to retrieve data for the Akonadi::EntityTreeModel::ItemRole, which gives you the Akonadi::Item which holds the contact itself: KContacts::Addressee

const auto item = index.data(Akonadi::EntityTreeModel::ItemRole).value<Akonadi::Item>();
if (!item.hasPayload<KContacts::Addressee>()) {
    // error handling
    return
}
const auto contact = item.payload<KContacts::Addressee>();
Tue, Mar 31, 11:58 AM · KDE PIM: Junior Jobs, KDE PIM
marten updated the diff for D28431: Attachment open dialogue: Make the button order more useful.

Group setup for each button together

Tue, Mar 31, 9:02 AM · KDE PIM
mlaurent requested changes to D28448: Implement of "Protected Headers for Cryptographic E-mail". T742.
Tue, Mar 31, 5:16 AM · KDE PIM
usta closed D28453: Add missing include QStandardPaths.
Tue, Mar 31, 5:13 AM · KDE PIM
mlaurent added inline comments to D28449: [messagecomposer]: Implement protected headers for SignJob. T742.
Tue, Mar 31, 5:10 AM · KDE PIM
mlaurent requested changes to D28447: refactor [messagecomposer]: Replace skeletonJobFinished with lambda function..
Tue, Mar 31, 5:06 AM · KDE PIM
mlaurent accepted D28453: Add missing include QStandardPaths.
Tue, Mar 31, 5:03 AM · KDE PIM
usta added reviewers for D28453: Add missing include QStandardPaths: ngraham, knauss, mlaurent.
Tue, Mar 31, 4:04 AM · KDE PIM
usta requested review of D28453: Add missing include QStandardPaths.
Tue, Mar 31, 4:01 AM · KDE PIM
knauss added inline comments to D28431: Attachment open dialogue: Make the button order more useful.
Tue, Mar 31, 1:07 AM · KDE PIM
knauss added a reviewer for D28451: refactor [messagecomposer]: Run QGpgME::EncryptJob in async mode.: KDE PIM.
Tue, Mar 31, 1:02 AM · KDE PIM
knauss added a reviewer for D28449: [messagecomposer]: Implement protected headers for SignJob. T742: KDE PIM.
Tue, Mar 31, 1:02 AM · KDE PIM
knauss added a reviewer for D28448: Implement of "Protected Headers for Cryptographic E-mail". T742: KDE PIM.
Tue, Mar 31, 1:01 AM · KDE PIM
knauss added a task to D28448: Implement of "Protected Headers for Cryptographic E-mail". T742: T742: Add Protected Header support.
Tue, Mar 31, 1:01 AM · KDE PIM
knauss added a revision to T742: Add Protected Header support: D28448: Implement of "Protected Headers for Cryptographic E-mail". T742.
Tue, Mar 31, 1:01 AM · KDE Privacy Goal, KDE PIM
knauss added a revision to T742: Add Protected Header support: D28449: [messagecomposer]: Implement protected headers for SignJob. T742.
Tue, Mar 31, 1:00 AM · KDE Privacy Goal, KDE PIM
knauss added a task to D28449: [messagecomposer]: Implement protected headers for SignJob. T742: T742: Add Protected Header support.
Tue, Mar 31, 1:00 AM · KDE PIM
knauss added a task to D28450: WIP: [messagecomposer]: Implement protected headers for SignEncryptJob.: T742: Add Protected Header support.
Tue, Mar 31, 1:00 AM · KDE PIM
knauss added a revision to T742: Add Protected Header support: D28450: WIP: [messagecomposer]: Implement protected headers for SignEncryptJob..
Tue, Mar 31, 1:00 AM · KDE Privacy Goal, KDE PIM
knauss renamed T742: Add Protected Header support from Add Memory Hole support to Add Protected Header support.
Tue, Mar 31, 1:00 AM · KDE Privacy Goal, KDE PIM
knauss requested review of D28451: refactor [messagecomposer]: Run QGpgME::EncryptJob in async mode..
Tue, Mar 31, 12:58 AM · KDE PIM
knauss requested review of D28450: WIP: [messagecomposer]: Implement protected headers for SignEncryptJob..
Tue, Mar 31, 12:58 AM · KDE PIM
knauss requested review of D28449: [messagecomposer]: Implement protected headers for SignJob. T742.
Tue, Mar 31, 12:57 AM · KDE PIM
knauss requested review of D28448: Implement of "Protected Headers for Cryptographic E-mail". T742.
Tue, Mar 31, 12:57 AM · KDE PIM
knauss requested review of D28447: refactor [messagecomposer]: Replace skeletonJobFinished with lambda function..
Tue, Mar 31, 12:55 AM · KDE PIM

Mon, Mar 30

winterz closed D28361: KCalendarCore: fix fallback to vCalendar loading on iCalendar load failure.
Mon, Mar 30, 9:54 PM · KDE PIM
kondzio added a comment to T9416: [KAddressbook] Improve the contacts list.

Daniel, I want to prepare a solution for this task, but I can't find a way to get an email address in added delegate inside paint event when the email address column is hidden. I tried to get it from the model but it only contains the columns that are visible in the GUI. Can you help me with this?

Mon, Mar 30, 6:50 PM · KDE PIM: Junior Jobs, KDE PIM
poboiko closed D28432: [Akonadi/PasteHelper] Add support for items linking.
Mon, Mar 30, 4:10 PM · KDE PIM
poboiko updated the diff for D28432: [Akonadi/PasteHelper] Add support for items linking.

Rebase on master. ItemModel and CollectionModel were recently removed :(

Mon, Mar 30, 4:09 PM · KDE PIM
poboiko closed D28434: [TodoView] Use parents collection when creating a subtodo.
Mon, Mar 30, 3:48 PM · KDE PIM
poboiko added a comment to D28434: [TodoView] Use parents collection when creating a subtodo.

I think there's a bug for this one.
Maybe https://bugs.kde.org/show_bug.cgi?id=409972 ?

Mon, Mar 30, 3:46 PM · KDE PIM
knauss added a comment to D28399: do not lose address headers when decrypting mail.

Okay it should not be that hard. We have already the mailcommon/src/filter/autotests/filteractiondecrypttest.* that reads mails from mailcommon/src/filter/autotests/gpgdata/. And there are normal mails inside it.

Mon, Mar 30, 3:12 PM · KDE PIM
poboiko requested review of D28436: [IncidenceTreeModel] Update UID if it was changed.
Mon, Mar 30, 1:51 PM · KDE PIM
dvratil accepted D28432: [Akonadi/PasteHelper] Add support for items linking.

Looking good, thanks 👍

Mon, Mar 30, 1:32 PM · KDE PIM
winterz accepted D28434: [TodoView] Use parents collection when creating a subtodo.

I think there's a bug for this one.
Maybe https://bugs.kde.org/show_bug.cgi?id=409972 ?

Mon, Mar 30, 1:20 PM · KDE PIM
poboiko requested review of D28434: [TodoView] Use parents collection when creating a subtodo.
Mon, Mar 30, 1:07 PM · KDE PIM
poboiko requested review of D28432: [Akonadi/PasteHelper] Add support for items linking.
Mon, Mar 30, 12:31 PM · KDE PIM
marten updated the diff for D28431: Attachment open dialogue: Make the button order more useful.

Just noticed that originally the accelerator 'O' was sent for both the "Open With" and "Open with <default application>" buttons. Set to 'W' for "Open With".

Mon, Mar 30, 12:16 PM · KDE PIM
marten requested review of D28431: Attachment open dialogue: Make the button order more useful.
Mon, Mar 30, 12:06 PM · KDE PIM
knauss added a comment to D28399: do not lose address headers when decrypting mail.

I may can help to create a test case.

Mon, Mar 30, 8:25 AM · KDE PIM
dvratil accepted D28361: KCalendarCore: fix fallback to vCalendar loading on iCalendar load failure.
Mon, Mar 30, 8:13 AM · KDE PIM

Sun, Mar 29

mlaurent added a comment to D28399: do not lose address headers when decrypting mail.

"seriously" yep . Creating a testcase avoiding to recreate a bug if a people modifies this code source without knowing why it was changed.

Sun, Mar 29, 5:17 PM · KDE PIM
mkoller added a comment to D28399: do not lose address headers when decrypting mail.

seriously ?
I'm pretty sure that creating a test for this 5 line function would take me more hours than to analyse the initial bug, and the numbers of codelines would pose more risk to introduce a bug in the test than in the function to test.
Instead of investing my time to create such a test, I'd rather try to fix another bug.

Sun, Mar 29, 3:28 PM · KDE PIM
mlaurent added a comment to D28399: do not lose address headers when decrypting mail.

Hi,
is it possible to create an autotest for it ?
Regards

Sun, Mar 29, 12:16 PM · KDE PIM
mkoller updated the summary of D28399: do not lose address headers when decrypting mail.
Sun, Mar 29, 10:39 AM · KDE PIM