Implement reordering of favorite folders using DnD
ClosedPublic

Authored by dfaure on Nov 18 2017, 12:47 PM.

Details

Summary

In order to separate favorites from the "entity order" QSFPM
used by the folder tree widget (it was always weird that filtering or
changing the sort order for the folder tree widget would affect favorites),
we need the favorites to get their own "ordering" proxy (otherwise
ordering is random, based on ETM population order). So while at it,
I implemented manual reordering of favorites.

BUG: 376073
FIXED-IN: 18.04

Test Plan

I can reorder favorites (in listview mode) using DnD
and the order is persisted

Diff Detail

Repository
R92 PIM: Common Mail Support
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure created this revision.Nov 18 2017, 12:47 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptNov 18 2017, 12:47 PM
mlaurent requested changes to this revision.Nov 24 2017, 8:29 AM
mlaurent added inline comments.
autotests/favoritestest.cpp
3

it's copied from christian file ?

src/folder/favoritecollectionorderproxymodel.cpp
25

using namespace MailCommon; no ? avoid to add { and } at the end

This revision now requires changes to proceed.Nov 24 2017, 8:29 AM
dfaure updated this revision to Diff 23200.Dec 1 2017, 8:09 AM

using "using" ;)

dfaure added inline comments.Dec 1 2017, 8:11 AM
autotests/favoritestest.cpp
3

Yes, from akonadi. All the "helper" code in this file is from him.

mlaurent accepted this revision.Dec 1 2017, 12:37 PM

Thanks ;)

This revision is now accepted and ready to land.Dec 1 2017, 12:37 PM
This revision was automatically updated to reflect the committed changes.